[{"id":25213,"web_url":"https://patchwork.libcamera.org/comment/25213/","msgid":"","date":"2022-09-30T23:57:39","subject":"Re: [libcamera-devel] [PATCH v2 4/5] utils: semver: Document\n\tlicence and source","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Sat, Oct 01, 2022 at 12:28:25AM +0100, Kieran Bingham via libcamera-devel wrote:\n> Add the SPDX header, and a reference to the upstream source for\n> this helper script.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> This is kept separate to highlight this is a modification from the original.\n> \n> utils/semver | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/utils/semver b/utils/semver\n> index 5b25f40ba48c..e9d092d94446 100755\n> --- a/utils/semver\n> +++ b/utils/semver\n> @@ -1,5 +1,8 @@\n> #!/usr/bin/env bash\n> \n> +# SPDX-License-Identifier: Apache-2.0\n\nCould you submit this change upstream ?\n\n> +# https://github.com/fsaintjacques/semver-tool\n\nThis part will likely not be accepted upstream, and I think we could\nleave it out from here, as it's available from the git log.\n\nReviewed-by: Laurent Pinchart \n\nOut of curiosity (you know me), I've looked at the Apache 2.0 license.\nIt states the following:\n\n 4. Redistribution. You may reproduce and distribute copies of the\n Work or Derivative Works thereof in any medium, with or without\n modifications, and in Source or Object form, provided that You\n meet the following conditions:\n\n (a) You must give any other recipients of the Work or\n Derivative Works a copy of this License; and\n\n (b) You must cause any modified files to carry prominent notices\n stating that You changed the files; and\n\n (c) You must retain, in the Source form of any Derivative Works\n that You distribute, all copyright, patent, trademark, and\n attribution notices from the Source form of the Work,\n excluding those notices that do not pertain to any part of\n the Derivative Works; and\n\n (d) If the Work includes a \"NOTICE\" text file as part of its\n distribution, then any Derivative Works that You distribute must\n include a readable copy of the attribution notices contained\n within such NOTICE file, excluding those notices that do not\n pertain to any part of the Derivative Works, in at least one\n of the following places: within a NOTICE text file distributed\n as part of the Derivative Works; within the Source form or\n documentation, if provided along with the Derivative Works; or,\n within a display generated by the Derivative Works, if and\n wherever such third-party notices normally appear. The contents\n of the NOTICE file are for informational purposes only and\n do not modify the License. You may add Your own attribution\n notices within Derivative Works that You distribute, alongside\n or as an addendum to the NOTICE text from the Work, provided\n that such additional attribution notices cannot be construed\n as modifying the License.\n\n You may add Your own copyright statement to Your modifications and\n may provide additional or different license terms and conditions\n for use, reproduction, or distribution of Your modifications, or\n for any such Derivative Works as a whole, provided Your use,\n reproduction, and distribution of the Work otherwise complies with\n the conditions stated in this License.\n\n4. (a) should be fine, there's a copy of the license in the LICENSE directory,\nand the SPDX tag specifying the license. 4. (c) should be fine too, as\ninterestingly enough, there's no copyright or attribution notice\nanywhere in the upstream repository. Otherwise it may be a pain, if such\nnotices were present in a COPYRIGHT file in the root directory of the\nproject for instance, copying just the semver script would cause an\nannoying problem. 4. (d) is fine too, there's no NOTICE file.\n\nThis leaves 4. (b), which seems to require a prominent notice that we\nhave added an SPDX tag. The world sounds crazy sometimes.\n\n> +\n> set -o errexit -o nounset -o pipefail\n> \n> NAT='0|[1-9][0-9]*'","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8DC1BD16B\n\tfor ;\n\tFri, 30 Sep 2022 23:57:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E84B62859;\n\tSat, 1 Oct 2022 01:57:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D49C62851\n\tfor ;\n\tSat, 1 Oct 2022 01:57:41 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF8BE59D;\n\tSat, 1 Oct 2022 01:57:40 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664582262;\n\tbh=4H51jMf11ldvRzEgB42TVJG12o3XV5pTqdVZ1RkJBm0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=IHhj9rqS8X6wwUXiBQwLoH4+UBmJZdCAJnfVcWWcSiooVmrpfdKRrYqGqq1ffkhGM\n\ttJb3HGdumgCqYrmxePH3v0QOdImhiZGebIVER4FJxuX53+935D4lP4YtONpn/aEqMV\n\tkU7sVR8i5Oi8I6vWOEBvgT5k1rbGKSdRH7KS+p+qtilkHZ7gVPA8A4n3k6rFehCf0o\n\t/e5T8WWuKXtBhHtJF99ZxcujEXCYSglbkWJNkffWmmb0U382QREXKaOcyY02G0pdnB\n\tZafnDBesdS4GMqFraa/rcjJe5O3/WNrLgHlyFzYOD90JV7AWXPSbPNN/cuXOZLMaDJ\n\t1mCKjXU1hCndQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664582261;\n\tbh=4H51jMf11ldvRzEgB42TVJG12o3XV5pTqdVZ1RkJBm0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IYggz5fdJP1snw6Nva56RzFP+Z4AMEsyKHLtuhvXOz+dkO0Uk4zz0P9bdODPBLWfE\n\tUt8PUt2eqrpSv2e5JrnRDsVt7AegDKZWC789Oqt64fq9vZGYTGIlG2PKkFZqqotE26\n\taazhKJoWzYVvfzCguIS0AOnfzD+x51S7cvI2y71U="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IYggz5fd\"; dkim-atps=neutral","Date":"Sat, 1 Oct 2022 02:57:39 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220930232826.82753-1-kieran.bingham@ideasonboard.com>\n\t<20220930232826.82753-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220930232826.82753-5-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 4/5] utils: semver: Document\n\tlicence and source","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25221,"web_url":"https://patchwork.libcamera.org/comment/25221/","msgid":"<20221003073229.gla7qra34a3gh43j@uno.localdomain>","date":"2022-10-03T07:32:29","subject":"Re: [libcamera-devel] [PATCH v2 4/5] utils: semver: Document\n\tlicence and source","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Sat, Oct 01, 2022 at 12:28:25AM +0100, Kieran Bingham via libcamera-devel wrote:\n> Add the SPDX header, and a reference to the upstream source for\n> this helper script.\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> This is kept separate to highlight this is a modification from the original.\n>\n> utils/semver | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/utils/semver b/utils/semver\n> index 5b25f40ba48c..e9d092d94446 100755\n> --- a/utils/semver\n> +++ b/utils/semver\n> @@ -1,5 +1,8 @@\n> #!/usr/bin/env bash\n>\n> +# SPDX-License-Identifier: Apache-2.0\n> +# https://github.com/fsaintjacques/semver-tool\n> +\n> set -o errexit -o nounset -o pipefail\n>\n> NAT='0|[1-9][0-9]*'\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7B0BC0DA4\n\tfor ;\n\tMon, 3 Oct 2022 07:32:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0FD1C62CCC;\n\tMon, 3 Oct 2022 09:32:34 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C6EE6623B5\n\tfor ;\n\tMon, 3 Oct 2022 09:32:31 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 373B2240009;\n\tMon, 3 Oct 2022 07:32:30 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664782354;\n\tbh=+Yn0DygavKUlrvulhxPnDsGMQb5sHh9f8IoCuKkYrck=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=OuXNrsUAAfgPq2gsuU1q+Ea8HQ6jFmcAKrsagBFgSc+lfPaKSxUsBhqeLqM8x4vkH\n\tfVS24hpyyDLmSDCoGXWBxJ2IyHLX53TwPIf5+VZQShAbH8tPdUHo1+iUW/vaqT0iyT\n\tUrM+iwNUejvlDGkDzNbYhtHj3b/VW8T7KaMvzH9tXm4ABodUNgsvoJ4Qx5oNui0dcz\n\tjbLaw4+x42bbmnIp5TTcudeiHKdWLC/Xvu1ZlOLg+URNM514yVTMKEiD17iLg7UJrY\n\tSp5l+c4vZyQpvz9Aq6dX8vlDpK165h7708Rj0dY5vrMLe8iBOyclBBX0BnPOoyTBN8\n\t90WRzsKDGuCkg==","Date":"Mon, 3 Oct 2022 09:32:29 +0200","To":"Kieran Bingham ","Message-ID":"<20221003073229.gla7qra34a3gh43j@uno.localdomain>","References":"<20220930232826.82753-1-kieran.bingham@ideasonboard.com>\n\t<20220930232826.82753-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220930232826.82753-5-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 4/5] utils: semver: Document\n\tlicence and source","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25377,"web_url":"https://patchwork.libcamera.org/comment/25377/","msgid":"<166541489568.3760285.17149030199217685474@Monstersaurus>","date":"2022-10-10T15:14:55","subject":"Re: [libcamera-devel] [PATCH v2 4/5] utils: semver: Document\n\tlicence and source","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2022-10-01 00:57:39)\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Sat, Oct 01, 2022 at 12:28:25AM +0100, Kieran Bingham via libcamera-devel wrote:\n> > Add the SPDX header, and a reference to the upstream source for\n> > this helper script.\n> > \n> > Signed-off-by: Kieran Bingham \n> > ---\n> > This is kept separate to highlight this is a modification from the original.\n> > \n> > utils/semver | 3 +++\n> > 1 file changed, 3 insertions(+)\n> > \n> > diff --git a/utils/semver b/utils/semver\n> > index 5b25f40ba48c..e9d092d94446 100755\n> > --- a/utils/semver\n> > +++ b/utils/semver\n> > @@ -1,5 +1,8 @@\n> > #!/usr/bin/env bash\n> > \n\nBlank line removed to match upstream proposal too.\n\n> > +# SPDX-License-Identifier: Apache-2.0\n> \n> Could you submit this change upstream ?\n> \n\nSubmitted.\n\nhttps://github.com/fsaintjacques/semver-tool/pull/73\n\n> > +# https://github.com/fsaintjacques/semver-tool\n> \n\nRemoved.\n\n> This part will likely not be accepted upstream, and I think we could\n> leave it out from here, as it's available from the git log.\n> \n> Reviewed-by: Laurent Pinchart \n> \n> Out of curiosity (you know me), I've looked at the Apache 2.0 license.\n> It states the following:\n> \n> 4. Redistribution. You may reproduce and distribute copies of the\n> Work or Derivative Works thereof in any medium, with or without\n> modifications, and in Source or Object form, provided that You\n> meet the following conditions:\n> \n> (a) You must give any other recipients of the Work or\n> Derivative Works a copy of this License; and\n> \n> (b) You must cause any modified files to carry prominent notices\n> stating that You changed the files; and\n> \n> (c) You must retain, in the Source form of any Derivative Works\n> that You distribute, all copyright, patent, trademark, and\n> attribution notices from the Source form of the Work,\n> excluding those notices that do not pertain to any part of\n> the Derivative Works; and\n> \n> (d) If the Work includes a \"NOTICE\" text file as part of its\n> distribution, then any Derivative Works that You distribute must\n> include a readable copy of the attribution notices contained\n> within such NOTICE file, excluding those notices that do not\n> pertain to any part of the Derivative Works, in at least one\n> of the following places: within a NOTICE text file distributed\n> as part of the Derivative Works; within the Source form or\n> documentation, if provided along with the Derivative Works; or,\n> within a display generated by the Derivative Works, if and\n> wherever such third-party notices normally appear. The contents\n> of the NOTICE file are for informational purposes only and\n> do not modify the License. You may add Your own attribution\n> notices within Derivative Works that You distribute, alongside\n> or as an addendum to the NOTICE text from the Work, provided\n> that such additional attribution notices cannot be construed\n> as modifying the License.\n> \n> You may add Your own copyright statement to Your modifications and\n> may provide additional or different license terms and conditions\n> for use, reproduction, or distribution of Your modifications, or\n> for any such Derivative Works as a whole, provided Your use,\n> reproduction, and distribution of the Work otherwise complies with\n> the conditions stated in this License.\n> \n> 4. (a) should be fine, there's a copy of the license in the LICENSE directory,\n> and the SPDX tag specifying the license. 4. (c) should be fine too, as\n> interestingly enough, there's no copyright or attribution notice\n> anywhere in the upstream repository. Otherwise it may be a pain, if such\n> notices were present in a COPYRIGHT file in the root directory of the\n> project for instance, copying just the semver script would cause an\n> annoying problem. 4. (d) is fine too, there's no NOTICE file.\n> \n> This leaves 4. (b), which seems to require a prominent notice that we\n> have added an SPDX tag. The world sounds crazy sometimes.\n> \n> > +\n> > set -o errexit -o nounset -o pipefail\n> > \n> > NAT='0|[1-9][0-9]*'\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E450C0DA4\n\tfor ;\n\tMon, 10 Oct 2022 15:15:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B64B62D68;\n\tMon, 10 Oct 2022 17:15:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E31B062272\n\tfor ;\n\tMon, 10 Oct 2022 17:14:59 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A8EABB0;\n\tMon, 10 Oct 2022 17:14:58 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665414901;\n\tbh=3jhFx8TrWfxZpRUizHqxqWYhtfBKqAc6n2cB64PEFg4=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mGwYIgz4P2rRZBNQlNMTPiNc5pelOczIEhsyJ5DkQ80V1dTSMI7O2eSrxYoAYQrvt\n\t8YxSRBqD0KSV5W6GaZIal6IqJIa5c6YMsGvxEm/ulYxaLiu7cs/DLuDXvBuVwth4J/\n\tfvyk+InvacabC3MHKvdzHQ4iws0OUuaOOtoU0Cf200+FNpsBqO/LCZZUc+nBVBLMHb\n\tqfKBbTwPmOuKqDB2fttFkVaI3F0v6bVb4ChW8WqgufITb6/RsV7sSmLuWXute5vwEn\n\tRKrOZwAEr+Jd1zhNyFZ8ntN0stiHentLVAQpUgdKmTnnvzoyXxGi4yq2DTfs5Fki7k\n\tBRDezLAusoLmQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665414898;\n\tbh=3jhFx8TrWfxZpRUizHqxqWYhtfBKqAc6n2cB64PEFg4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Ea2fv1sgkLqMHPki5oKBAgL7KUQQT7FzM8QxAH1X36PeQE6UW61BI7nI8a7XbXd2q\n\tcPNNg6/LZJ3y3qjA7y8e3vGLhQsZlaU5pmKbY0vFMwyNHgsSsJGiikK7+OTchyEdKv\n\t/CtWvokDqWBG4+MsZri3lgniE7vDkEEKm0fJuevE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ea2fv1sg\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220930232826.82753-1-kieran.bingham@ideasonboard.com>\n\t<20220930232826.82753-5-kieran.bingham@ideasonboard.com>\n\t","To":"Laurent Pinchart ","Date":"Mon, 10 Oct 2022 16:14:55 +0100","Message-ID":"<166541489568.3760285.17149030199217685474@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 4/5] utils: semver: Document\n\tlicence and source","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]