{"id":17472,"url":"https://patchwork.libcamera.org/api/patches/17472/?format=json","web_url":"https://patchwork.libcamera.org/patch/17472/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220930121812.5768-1-david.plowman@raspberrypi.com>","date":"2022-09-30T12:18:12","name":"[libcamera-devel] py: Support controls that are ControlTypeNone","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c70de9b13baa7a7d1e5dabcfd2117d22bc4474ee","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17472/mbox/","series":[{"id":3517,"url":"https://patchwork.libcamera.org/api/series/3517/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3517","date":"2022-09-30T12:18:12","name":"[libcamera-devel] py: Support controls that are ControlTypeNone","version":1,"mbox":"https://patchwork.libcamera.org/series/3517/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17472/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17472/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80385C0DA4\n\tfor ;\n\tFri, 30 Sep 2022 12:18:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D426F623A8;\n\tFri, 30 Sep 2022 14:18:26 +0200 (CEST)","from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2791761F77\n\tfor ;\n\tFri, 30 Sep 2022 14:18:25 +0200 (CEST)","by mail-wr1-x42e.google.com with SMTP id c11so6562276wrp.11\n\tfor ;\n\tFri, 30 Sep 2022 05:18:25 -0700 (PDT)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tu5-20020a7bcb05000000b003a3170a7af9sm1978208wmj.4.2022.09.30.05.18.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Sep 2022 05:18:23 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664540306;\n\tbh=uS4CM4/ULJ4TJV3FvdUNx37VadLNLhTLqdC7+m43g98=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=xjjTiDH5OWbBuDXiS04WWMl9u2hrDCYl2RPn8uk8iXcMqPxoy4GRIsZabyxf5IYRP\n\tiYehuqcoAX59ERKIJZfT7JKjErAbhMmv8R4DWDx3toeoAadWlxxiXTPJnKCyZeWcPe\n\t1ew8yH2JtvY9bE0fWhkFJ3EcTkooxtCSpy3gWYXJKLI2gtVOW3LhgspEiErHomdh9I\n\tZ2UxMOCrDFzx3N/xI1sAlbic06s1FHU/shhG4AjVRjaZMLkoqrSL1wISKs3gf/Dg8s\n\tGcb0ldqvCeZIlIcevZ6UEs1juPvRqH5KIJagRSjerO5WgIzDMiCeJzWVjoNUelMt9N\n\ttanuocl59qDKg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date;\n\tbh=3ru394CvH5Isp/Tf9pxxdeTNiaVNY3DnZ6h1t0zkWXA=;\n\tb=jgVcfckSd1npJOsRrQI+htBwWexXPdvxM1mmIYcLrT5DvoZPM5pKRV37z3NnjsJEID\n\t2wySjt4vV+96xJsKPl26/F0Ute/Ahgmk2vKUJBYHxOGfQqQz0rt3auz18dsp+NgWxASZ\n\tLklOHdLrrmxtDYF3oTxNfkaAUqBYeAfyM481dCWlSggyWex7f7McY4oozHqNzyUY0e0g\n\tG9T8RVnD0cr0mW0FRnY7ZH8n/19j8UGxXiJ4fNxEQTrscWjglewvHMiSxSMJH1GwoH1j\n\tD9sDJKNp6Qznbb/wOgH/OcXafwCdaj7XuURwrn7DQSA6fDLfvfmD6PRBvNgerIQ0+fZU\n\tWtvA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"jgVcfckS\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date;\n\tbh=3ru394CvH5Isp/Tf9pxxdeTNiaVNY3DnZ6h1t0zkWXA=;\n\tb=CinXBBVDAYdQm1xvJ3oDlubuBueZuqgSdlmAmff/FMIcTQdMOPCZRa1mQUcIyhm8hb\n\twtQc2HA4fgo1OtZUlM5No1ZGhRbhHHXSt6/B7PHCUtsTPU2U59qERuH/54Tuat/gpaU/\n\tUo3cqpU3BVKPlp2WXi2grYO3YkYyc1tTmuKl2rAM4+sUSuDZGap+K9orChOADgPpGvv1\n\tqp2ilV53Li2lfny400JEtvM0xJPzmCnHJysofEUASlVSdcIIfrGvj0YZL/kq+9uYSbzK\n\t7HOTsajyUOrZQ9Es5FhUug4SMvWiaxCLLEf9uQRHJf6b8Vcw380/F0Q3azl/LhxTQeTM\n\t0Iaw==","X-Gm-Message-State":"ACrzQf3LQ2kjWrnY75bgqr1RXcUhWpL1MH+nyNoltDJtY/B6K8tXycvz\n\tjFgC69eCB/MnSMxs9AjMZEvLIT3DqiJ2qQ==","X-Google-Smtp-Source":"AMsMyM6oRXXRM0k41x0jdgOvM2lceo5Mu3xaxlYkhpF0RUYoj0kUfoXVm2wOHwKgrbP6K7wfe/YobA==","X-Received":"by 2002:a5d:6245:0:b0:225:3e24:e5b1 with SMTP id\n\tm5-20020a5d6245000000b002253e24e5b1mr5753630wrv.698.1664540304225; \n\tFri, 30 Sep 2022 05:18:24 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Sep 2022 13:18:12 +0100","Message-Id":"<20220930121812.5768-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] py: Support controls that are\n\tControlTypeNone","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Such controls can now be created when a control doesn't have a\nreasonable or obvious default value. We support them using Python's\n\"None\" value, rather than generating a runtime error.\n\nSigned-off-by: David Plowman \n---\n src/py/libcamera/py_helpers.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/py/libcamera/py_helpers.cpp b/src/py/libcamera/py_helpers.cpp\nindex 45aecce9..f685e606 100644\n--- a/src/py/libcamera/py_helpers.cpp\n+++ b/src/py/libcamera/py_helpers.cpp\n@@ -55,6 +55,7 @@ py::object controlValueToPy(const ControlValue &cv)\n \t\treturn py::cast(v);\n \t}\n \tcase ControlTypeNone:\n+\t\treturn py::none();\n \tdefault:\n \t\tthrow std::runtime_error(\"Unsupported ControlValue type\");\n \t}\n@@ -91,6 +92,7 @@ ControlValue pyToControlValue(const py::object &ob, ControlType type)\n \tcase ControlTypeSize:\n \t\treturn ControlValue(ob.cast());\n \tcase ControlTypeNone:\n+\t\treturn ControlValue();\n \tdefault:\n \t\tthrow std::runtime_error(\"Control type not implemented\");\n \t}\n","prefixes":["libcamera-devel"]}