[{"id":25170,"web_url":"https://patchwork.libcamera.org/comment/25170/","msgid":"<20220930090742.jrrmzeyribiue72d@uno.localdomain>","date":"2022-09-30T09:07:42","subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Remove initialized_\n\tflags from algorithms","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Fri, Sep 30, 2022 at 04:55:47AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Multiple algorithms have an initialized_ flag that they set to true at\n> the end of the init() function, and check at the beginning of prepare()\n> to skip preparation. This serves no real purpose, as the flag can only\n> be false if init() fails, in which case the IPA module initialization as\n> a whole will fail.\n>\n> Drop the initialized_ flags.\n>\n> Signed-off-by: Laurent Pinchart \n\nThanks!\nReviewed-by: Jacopo Mondi \n\n\n> ---\n> src/ipa/rkisp1/algorithms/dpcc.cpp | 7 +------\n> src/ipa/rkisp1/algorithms/dpcc.h | 1 -\n> src/ipa/rkisp1/algorithms/dpf.cpp | 7 +------\n> src/ipa/rkisp1/algorithms/dpf.h | 1 -\n> src/ipa/rkisp1/algorithms/gsl.cpp | 5 -----\n> src/ipa/rkisp1/algorithms/gsl.h | 1 -\n> src/ipa/rkisp1/algorithms/lsc.cpp | 8 +-------\n> src/ipa/rkisp1/algorithms/lsc.h | 2 --\n> 8 files changed, 3 insertions(+), 29 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/dpcc.cpp b/src/ipa/rkisp1/algorithms/dpcc.cpp\n> index 53aa1d93e42b..3d6b87e62239 100644\n> --- a/src/ipa/rkisp1/algorithms/dpcc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/dpcc.cpp\n> @@ -189,7 +189,7 @@ bool parseMethod(const YamlObject &yamlMethod, const Method &method,\n> } /* namespace */\n>\n> DefectPixelClusterCorrection::DefectPixelClusterCorrection()\n> -\t: initialized_(false), config_({})\n> +\t: config_({})\n> {\n> }\n>\n> @@ -250,8 +250,6 @@ int DefectPixelClusterCorrection::init([[maybe_unused]] IPAContext &context,\n> \t\t}\n> \t}\n>\n> -\tinitialized_ = true;\n> -\n> \treturn 0;\n> }\n>\n> @@ -266,9 +264,6 @@ void DefectPixelClusterCorrection::prepare([[maybe_unused]] IPAContext &context,\n> \tif (frame > 0)\n> \t\treturn;\n>\n> -\tif (!initialized_)\n> -\t\treturn;\n> -\n> \tparams->others.dpcc_config = config_;\n>\n> \tparams->module_en_update |= RKISP1_CIF_ISP_MODULE_DPCC;\n> diff --git a/src/ipa/rkisp1/algorithms/dpcc.h b/src/ipa/rkisp1/algorithms/dpcc.h\n> index 894c0249f35d..b1fac7d1bb37 100644\n> --- a/src/ipa/rkisp1/algorithms/dpcc.h\n> +++ b/src/ipa/rkisp1/algorithms/dpcc.h\n> @@ -25,7 +25,6 @@ public:\n> \t\t rkisp1_params_cfg *params) override;\n>\n> private:\n> -\tbool initialized_;\n> \trkisp1_cif_isp_dpcc_config config_;\n> };\n>\n> diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\n> index f7bc371da52e..82d4f7fecc67 100644\n> --- a/src/ipa/rkisp1/algorithms/dpf.cpp\n> +++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n> @@ -35,7 +35,7 @@ namespace ipa::rkisp1::algorithms {\n> LOG_DEFINE_CATEGORY(RkISP1Dpf)\n>\n> Dpf::Dpf()\n> -\t: initialized_(false), config_({}), strengthConfig_({})\n> +\t: config_({}), strengthConfig_({})\n> {\n> }\n>\n> @@ -166,8 +166,6 @@ int Dpf::init([[maybe_unused]] IPAContext &context,\n> \tstrengthConfig_.g = fSObject[\"g\"].get(64);\n> \tstrengthConfig_.b = fSObject[\"b\"].get(64);\n>\n> -\tinitialized_ = true;\n> -\n> \treturn 0;\n> }\n>\n> @@ -219,9 +217,6 @@ void Dpf::queueRequest(IPAContext &context,\n> void Dpf::prepare(IPAContext &context, const uint32_t frame,\n> \t\t IPAFrameContext &frameContext, rkisp1_params_cfg *params)\n> {\n> -\tif (!initialized_)\n> -\t\treturn;\n> -\n> \tif (frame == 0) {\n> \t\tparams->others.dpf_config = config_;\n> \t\tparams->others.dpf_strength_config = strengthConfig_;\n> diff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\n> index e232cad4ee87..58f29f74e84b 100644\n> --- a/src/ipa/rkisp1/algorithms/dpf.h\n> +++ b/src/ipa/rkisp1/algorithms/dpf.h\n> @@ -30,7 +30,6 @@ public:\n> \t\t rkisp1_params_cfg *params) override;\n>\n> private:\n> -\tbool initialized_;\n> \tstruct rkisp1_cif_isp_dpf_config config_;\n> \tstruct rkisp1_cif_isp_dpf_strength_config strengthConfig_;\n> };\n> diff --git a/src/ipa/rkisp1/algorithms/gsl.cpp b/src/ipa/rkisp1/algorithms/gsl.cpp\n> index 9cbad02038c4..a80fed589bb2 100644\n> --- a/src/ipa/rkisp1/algorithms/gsl.cpp\n> +++ b/src/ipa/rkisp1/algorithms/gsl.cpp\n> @@ -49,7 +49,6 @@ LOG_DEFINE_CATEGORY(RkISP1Gsl)\n> static constexpr unsigned int kDegammaXIntervals = 16;\n>\n> GammaSensorLinearization::GammaSensorLinearization()\n> -\t: initialized_(false)\n> {\n> }\n>\n> @@ -111,7 +110,6 @@ int GammaSensorLinearization::init([[maybe_unused]] IPAContext &context,\n> \t\treturn -EINVAL;\n> \t}\n>\n> -\tinitialized_ = true;\n> \treturn 0;\n> }\n>\n> @@ -126,9 +124,6 @@ void GammaSensorLinearization::prepare([[maybe_unused]] IPAContext &context,\n> \tif (frame > 0)\n> \t\treturn;\n>\n> -\tif (!initialized_)\n> -\t\treturn;\n> -\n> \tparams->others.sdg_config.xa_pnts.gamma_dx0 = gammaDx_[0];\n> \tparams->others.sdg_config.xa_pnts.gamma_dx1 = gammaDx_[1];\n>\n> diff --git a/src/ipa/rkisp1/algorithms/gsl.h b/src/ipa/rkisp1/algorithms/gsl.h\n> index 5024b6835949..0f1116a7b1f2 100644\n> --- a/src/ipa/rkisp1/algorithms/gsl.h\n> +++ b/src/ipa/rkisp1/algorithms/gsl.h\n> @@ -25,7 +25,6 @@ public:\n> \t\t rkisp1_params_cfg *params) override;\n>\n> private:\n> -\tbool initialized_;\n> \tuint32_t gammaDx_[2];\n> \tstd::vector curveYr_;\n> \tstd::vector curveYg_;\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index 44245caa705e..102535bd11a4 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -89,7 +89,6 @@ static std::vector parseTable(const YamlObject &tuningData,\n> }\n>\n> LensShadingCorrection::LensShadingCorrection()\n> -\t: initialized_(false)\n> {\n> }\n>\n> @@ -114,8 +113,6 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n> \t gbData_.empty() || bData_.empty())\n> \t\treturn -EINVAL;\n>\n> -\tinitialized_ = true;\n> -\n> \treturn 0;\n> }\n>\n> @@ -125,7 +122,7 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n> int LensShadingCorrection::configure(IPAContext &context,\n> \t\t\t\t [[maybe_unused]] const IPACameraSensorInfo &configInfo)\n> {\n> -\tcontext.configuration.lsc.enabled = initialized_;\n> +\tcontext.configuration.lsc.enabled = true;\n> \treturn 0;\n> }\n>\n> @@ -139,9 +136,6 @@ void LensShadingCorrection::prepare(IPAContext &context, const uint32_t frame,\n> \tif (frame > 0)\n> \t\treturn;\n>\n> -\tif (!initialized_)\n> -\t\treturn;\n> -\n> \tstruct rkisp1_cif_isp_lsc_config &config = params->others.lsc_config;\n> \tconst Size &size = context.configuration.sensor.size;\n> \tSize totalSize{};\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n> index da957d3e3103..6c052669d80f 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.h\n> +++ b/src/ipa/rkisp1/algorithms/lsc.h\n> @@ -26,8 +26,6 @@ public:\n> \t\t rkisp1_params_cfg *params) override;\n>\n> private:\n> -\tbool initialized_;\n> -\n> \tstd::vector rData_;\n> \tstd::vector grData_;\n> \tstd::vector gbData_;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A431DBD16B\n\tfor ;\n\tFri, 30 Sep 2022 09:07:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0BDCE62397;\n\tFri, 30 Sep 2022 11:07:47 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15A1D603DC\n\tfor ;\n\tFri, 30 Sep 2022 11:07:45 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 911721C0002;\n\tFri, 30 Sep 2022 09:07:44 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664528867;\n\tbh=zrZjx1sv+hqu1MXLKqBhRixGuM14mHKUIjjf7Rpudew=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=s4/QvrExW9IZX2l+SZxOxH0y9xStHJPuFeOshWLK0/8SQFLzIUsQtOBCbO1lLwoMS\n\tpC1AkFEebj4PbRmbKq7NbGmqCFDeerJJy1DYTa6Wll4qYY26+dCX0r+PmGml1IiqnD\n\tb/0JB6FcmEZonw8GbItStzV4PmlbJNY7E8/zSlrU6Dxghf0uIEPU2ZH7Rudn/Zit/A\n\tufa6wjzfAdgSaEsVr6YPnri/V+SBYZ97eRnMOEN4ZRxIVBK3Lek+LUtjklMaYHBC8V\n\tauzo+tA7F8jvY+m4LLrtr8/YnzLvVhmehPAn/V5UxzFosHXcWNMy/Wsxw826nfEakL\n\tHA3yZQbvKjVEw==","Date":"Fri, 30 Sep 2022 11:07:42 +0200","To":"Laurent Pinchart ","Message-ID":"<20220930090742.jrrmzeyribiue72d@uno.localdomain>","References":"<20220930015547.29911-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220930015547.29911-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Remove initialized_\n\tflags from algorithms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25173,"web_url":"https://patchwork.libcamera.org/comment/25173/","msgid":"<166453266855.56880.11826146284398168940@Monstersaurus>","date":"2022-09-30T10:11:08","subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Remove initialized_\n\tflags from algorithms","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-09-30 02:55:47)\n> Multiple algorithms have an initialized_ flag that they set to true at\n> the end of the init() function, and check at the beginning of prepare()\n> to skip preparation. This serves no real purpose, as the flag can only\n> be false if init() fails, in which case the IPA module initialization as\n> a whole will fail.\n> \n> Drop the initialized_ flags.\n\nGood, I'd spotted this too and it bugged me ;-)\n\n\nReviewed-by: Kieran Bingham \n\n \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/algorithms/dpcc.cpp | 7 +------\n> src/ipa/rkisp1/algorithms/dpcc.h | 1 -\n> src/ipa/rkisp1/algorithms/dpf.cpp | 7 +------\n> src/ipa/rkisp1/algorithms/dpf.h | 1 -\n> src/ipa/rkisp1/algorithms/gsl.cpp | 5 -----\n> src/ipa/rkisp1/algorithms/gsl.h | 1 -\n> src/ipa/rkisp1/algorithms/lsc.cpp | 8 +-------\n> src/ipa/rkisp1/algorithms/lsc.h | 2 --\n> 8 files changed, 3 insertions(+), 29 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/dpcc.cpp b/src/ipa/rkisp1/algorithms/dpcc.cpp\n> index 53aa1d93e42b..3d6b87e62239 100644\n> --- a/src/ipa/rkisp1/algorithms/dpcc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/dpcc.cpp\n> @@ -189,7 +189,7 @@ bool parseMethod(const YamlObject &yamlMethod, const Method &method,\n> } /* namespace */\n> \n> DefectPixelClusterCorrection::DefectPixelClusterCorrection()\n> - : initialized_(false), config_({})\n> + : config_({})\n> {\n> }\n> \n> @@ -250,8 +250,6 @@ int DefectPixelClusterCorrection::init([[maybe_unused]] IPAContext &context,\n> }\n> }\n> \n> - initialized_ = true;\n> -\n> return 0;\n> }\n> \n> @@ -266,9 +264,6 @@ void DefectPixelClusterCorrection::prepare([[maybe_unused]] IPAContext &context,\n> if (frame > 0)\n> return;\n> \n> - if (!initialized_)\n> - return;\n> -\n> params->others.dpcc_config = config_;\n> \n> params->module_en_update |= RKISP1_CIF_ISP_MODULE_DPCC;\n> diff --git a/src/ipa/rkisp1/algorithms/dpcc.h b/src/ipa/rkisp1/algorithms/dpcc.h\n> index 894c0249f35d..b1fac7d1bb37 100644\n> --- a/src/ipa/rkisp1/algorithms/dpcc.h\n> +++ b/src/ipa/rkisp1/algorithms/dpcc.h\n> @@ -25,7 +25,6 @@ public:\n> rkisp1_params_cfg *params) override;\n> \n> private:\n> - bool initialized_;\n> rkisp1_cif_isp_dpcc_config config_;\n> };\n> \n> diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\n> index f7bc371da52e..82d4f7fecc67 100644\n> --- a/src/ipa/rkisp1/algorithms/dpf.cpp\n> +++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n> @@ -35,7 +35,7 @@ namespace ipa::rkisp1::algorithms {\n> LOG_DEFINE_CATEGORY(RkISP1Dpf)\n> \n> Dpf::Dpf()\n> - : initialized_(false), config_({}), strengthConfig_({})\n> + : config_({}), strengthConfig_({})\n> {\n> }\n> \n> @@ -166,8 +166,6 @@ int Dpf::init([[maybe_unused]] IPAContext &context,\n> strengthConfig_.g = fSObject[\"g\"].get(64);\n> strengthConfig_.b = fSObject[\"b\"].get(64);\n> \n> - initialized_ = true;\n> -\n> return 0;\n> }\n> \n> @@ -219,9 +217,6 @@ void Dpf::queueRequest(IPAContext &context,\n> void Dpf::prepare(IPAContext &context, const uint32_t frame,\n> IPAFrameContext &frameContext, rkisp1_params_cfg *params)\n> {\n> - if (!initialized_)\n> - return;\n> -\n> if (frame == 0) {\n> params->others.dpf_config = config_;\n> params->others.dpf_strength_config = strengthConfig_;\n> diff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\n> index e232cad4ee87..58f29f74e84b 100644\n> --- a/src/ipa/rkisp1/algorithms/dpf.h\n> +++ b/src/ipa/rkisp1/algorithms/dpf.h\n> @@ -30,7 +30,6 @@ public:\n> rkisp1_params_cfg *params) override;\n> \n> private:\n> - bool initialized_;\n> struct rkisp1_cif_isp_dpf_config config_;\n> struct rkisp1_cif_isp_dpf_strength_config strengthConfig_;\n> };\n> diff --git a/src/ipa/rkisp1/algorithms/gsl.cpp b/src/ipa/rkisp1/algorithms/gsl.cpp\n> index 9cbad02038c4..a80fed589bb2 100644\n> --- a/src/ipa/rkisp1/algorithms/gsl.cpp\n> +++ b/src/ipa/rkisp1/algorithms/gsl.cpp\n> @@ -49,7 +49,6 @@ LOG_DEFINE_CATEGORY(RkISP1Gsl)\n> static constexpr unsigned int kDegammaXIntervals = 16;\n> \n> GammaSensorLinearization::GammaSensorLinearization()\n> - : initialized_(false)\n> {\n> }\n> \n> @@ -111,7 +110,6 @@ int GammaSensorLinearization::init([[maybe_unused]] IPAContext &context,\n> return -EINVAL;\n> }\n> \n> - initialized_ = true;\n> return 0;\n> }\n> \n> @@ -126,9 +124,6 @@ void GammaSensorLinearization::prepare([[maybe_unused]] IPAContext &context,\n> if (frame > 0)\n> return;\n> \n> - if (!initialized_)\n> - return;\n> -\n> params->others.sdg_config.xa_pnts.gamma_dx0 = gammaDx_[0];\n> params->others.sdg_config.xa_pnts.gamma_dx1 = gammaDx_[1];\n> \n> diff --git a/src/ipa/rkisp1/algorithms/gsl.h b/src/ipa/rkisp1/algorithms/gsl.h\n> index 5024b6835949..0f1116a7b1f2 100644\n> --- a/src/ipa/rkisp1/algorithms/gsl.h\n> +++ b/src/ipa/rkisp1/algorithms/gsl.h\n> @@ -25,7 +25,6 @@ public:\n> rkisp1_params_cfg *params) override;\n> \n> private:\n> - bool initialized_;\n> uint32_t gammaDx_[2];\n> std::vector curveYr_;\n> std::vector curveYg_;\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index 44245caa705e..102535bd11a4 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -89,7 +89,6 @@ static std::vector parseTable(const YamlObject &tuningData,\n> }\n> \n> LensShadingCorrection::LensShadingCorrection()\n> - : initialized_(false)\n> {\n> }\n> \n> @@ -114,8 +113,6 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n> gbData_.empty() || bData_.empty())\n> return -EINVAL;\n> \n> - initialized_ = true;\n> -\n> return 0;\n> }\n> \n> @@ -125,7 +122,7 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n> int LensShadingCorrection::configure(IPAContext &context,\n> [[maybe_unused]] const IPACameraSensorInfo &configInfo)\n> {\n> - context.configuration.lsc.enabled = initialized_;\n> + context.configuration.lsc.enabled = true;\n> return 0;\n> }\n> \n> @@ -139,9 +136,6 @@ void LensShadingCorrection::prepare(IPAContext &context, const uint32_t frame,\n> if (frame > 0)\n> return;\n> \n> - if (!initialized_)\n> - return;\n> -\n> struct rkisp1_cif_isp_lsc_config &config = params->others.lsc_config;\n> const Size &size = context.configuration.sensor.size;\n> Size totalSize{};\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n> index da957d3e3103..6c052669d80f 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.h\n> +++ b/src/ipa/rkisp1/algorithms/lsc.h\n> @@ -26,8 +26,6 @@ public:\n> rkisp1_params_cfg *params) override;\n> \n> private:\n> - bool initialized_;\n> -\n> std::vector rData_;\n> std::vector grData_;\n> std::vector gbData_;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 503AAC0DA4\n\tfor ;\n\tFri, 30 Sep 2022 10:11:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7698E62399;\n\tFri, 30 Sep 2022 12:11:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B7EA61F77\n\tfor ;\n\tFri, 30 Sep 2022 12:11:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 095734D5;\n\tFri, 30 Sep 2022 12:11:11 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664532673;\n\tbh=Q11fSnrPVPBLxa7S4W3QM3WtDy3z6bY15qNK2sMfwEs=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=2imSVQJCG7cRDVxO8wkaMqjWIyUg4s2ld0vuGLahkVxkHHK74kwDZgIEh0fVnKFtj\n\tE60Pn+8kLnRa8HijD+ieYuDZMBWOk94g+X1Yr+LfviyQHvSgFDN3ezDc4O3RzIyZ0w\n\t1fFYTGRe1QWuDBHpmbbjgzUHrJfVqoMhtJyqgwSEPypDJjdM1dKrj6z5luUgSC0ahZ\n\tfbY6JyLM5qF3KsVwI3TVLDmdGMvaG+96nV1N7wrBK9X5S5tX91x2sBQdi+L9Mr6smn\n\tLmuSHrsOqFAO1hWigN5UG76se1Rp0YZ4W7kRNPeqq2nOstprgCkadZ5hlKKgge46oC\n\t8nCeEYUf1B1Vw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664532671;\n\tbh=Q11fSnrPVPBLxa7S4W3QM3WtDy3z6bY15qNK2sMfwEs=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=v+NOaUczvZ/Rq0KHsMdCdskaV4iAgIFN35I5BkpalP1v3xfZJJDGsusbp71WKhlRr\n\t6+tbUmdf7/qCTR4NCiJ0xJDMAEPectqmaknhSgIEPFIUnY0wfrYrpdUGGBCq2MlzA+\n\tNKtj8a9H1OIAUWJQmUPfnQzqXEqFGqm0VtV4trv8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"v+NOaUcz\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220930015547.29911-1-laurent.pinchart@ideasonboard.com>","References":"<20220930015547.29911-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 30 Sep 2022 11:11:08 +0100","Message-ID":"<166453266855.56880.11826146284398168940@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Remove initialized_\n\tflags from algorithms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]