[{"id":25167,"web_url":"https://patchwork.libcamera.org/comment/25167/","msgid":"<20220929073549.rey6n7tefs2b72gu@uno.localdomain>","date":"2022-09-29T07:35:49","subject":"Re: [libcamera-devel] [PATCH v2 4/4] ipa: raspberrypi: Fix the\n\timx296 mono tuning black level","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Naush,\n\nOn Thu, Sep 29, 2022 at 08:23:23AM +0100, Naushir Patuck via libcamera-devel wrote:\n> The sensor black level is 60 (in 10-bits), fix this in the mono variant tuning\n> file.\n>\n> Signed-off-by: Naushir Patuck \n\nThanks for clarifying the unit in your previous reply\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/raspberrypi/data/imx296_mono.json | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json\n> index 490c0fda0cca..b68b11dbd609 100644\n> --- a/src/ipa/raspberrypi/data/imx296_mono.json\n> +++ b/src/ipa/raspberrypi/data/imx296_mono.json\n> @@ -5,7 +5,7 @@\n> {\n> \"rpi.black_level\":\n> {\n> - \"black_level\": 4096\n> + \"black_level\": 3840\n> }\n> },\n> {\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4951CC0DA4\n\tfor ;\n\tThu, 29 Sep 2022 07:35:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0632F62384;\n\tThu, 29 Sep 2022 09:35:54 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A47DB6237B\n\tfor ;\n\tThu, 29 Sep 2022 09:35:51 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 43849200003;\n\tThu, 29 Sep 2022 07:35:51 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664436954;\n\tbh=ItsuxUTyr6t1b3AJPDRGSsKFN2T8gk/BYOW3CuIz0co=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=hYQlt6wmbaNjMftNJqsUDAh4MEHEYWLe2wSvQZjlCXwxh1O4yG4fj9/ZWwgRnr2YO\n\tqV10EsjgL6GvvL8B0CvipKKwTQmwHpGdBb7Ha7ZvqonhDHDZYkXE6G6/+GalcBC/Q8\n\tzKuIxRCO0gcPO2hK2zz/F3KaaKmY4mTAyHVcGKZSYYOiF7G2xpYb8r7PJHGU7Nrufm\n\tQI7AcloxOkGVjSe1iH8YsRC6qwOY/wOE2W3i7kgNUjntG3Jc0WjltFNYlO4mDLkq1x\n\tK11HTDSAXxIGGOKD6PlYo+6pqNtdSaVT3RyUimlIWZVpuyXEluwdchBEo0WWD7sOSi\n\tLIGUUVo+jb6mA==","Date":"Thu, 29 Sep 2022 09:35:49 +0200","To":"Naushir Patuck ","Message-ID":"<20220929073549.rey6n7tefs2b72gu@uno.localdomain>","References":"<20220929072323.7400-1-naush@raspberrypi.com>\n\t<20220929072323.7400-5-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220929072323.7400-5-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 4/4] ipa: raspberrypi: Fix the\n\timx296 mono tuning black level","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25233,"web_url":"https://patchwork.libcamera.org/comment/25233/","msgid":"","date":"2022-10-03T09:43:57","subject":"Re: [libcamera-devel] [PATCH v2 4/4] ipa: raspberrypi: Fix the\n\timx296 mono tuning black level","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the patch!\n\nOn Thu, 29 Sept 2022 at 08:35, Jacopo Mondi via libcamera-devel\n wrote:\n>\n> Hi Naush,\n>\n> On Thu, Sep 29, 2022 at 08:23:23AM +0100, Naushir Patuck via libcamera-devel wrote:\n> > The sensor black level is 60 (in 10-bits), fix this in the mono variant tuning\n> > file.\n> >\n> > Signed-off-by: Naushir Patuck \n>\n> Thanks for clarifying the unit in your previous reply\n>\n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: David Plowman \n\nThanks\nDavid\n\n>\n> Thanks\n> j\n>\n> > ---\n> > src/ipa/raspberrypi/data/imx296_mono.json | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json\n> > index 490c0fda0cca..b68b11dbd609 100644\n> > --- a/src/ipa/raspberrypi/data/imx296_mono.json\n> > +++ b/src/ipa/raspberrypi/data/imx296_mono.json\n> > @@ -5,7 +5,7 @@\n> > {\n> > \"rpi.black_level\":\n> > {\n> > - \"black_level\": 4096\n> > + \"black_level\": 3840\n> > }\n> > },\n> > {\n> > --\n> > 2.25.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DB45C0DA4\n\tfor ;\n\tMon, 3 Oct 2022 09:44:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8610461F74;\n\tMon, 3 Oct 2022 11:44:11 +0200 (CEST)","from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com\n\t[IPv6:2607:f8b0:4864:20::102c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF7A861F74\n\tfor ;\n\tMon, 3 Oct 2022 11:44:09 +0200 (CEST)","by mail-pj1-x102c.google.com with SMTP id fw14so2391425pjb.3\n\tfor ;\n\tMon, 03 Oct 2022 02:44:09 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664790251;\n\tbh=cYl9d754cIfoQRG/BV2hBmOMp68zJx/S6O3L89QEyiY=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=lAcizPDm65yom5dXzvWAbQkTEX1AEzUzOvKtdT77aa8mNsRkbAQtd/dcoEivH3onV\n\tpxteir0jy19HX6Ox840W9Sd+Qv8opRFqJZizwFpTaHzwPaQ+nK1t/7Mx17YirS0T/D\n\tJCiq3ARlwcufLE3/Fo/JmZnRUTybCuaXxoecXr+q+PUo6gVHPY+9byH6TwM2+M3N3y\n\ts/WtmnN1xDze9d5wPk6qtzBO2IROCjlCfXtHEkfSYhqiQdGsU2A7YGxFIPW+aS+KCg\n\teT7BfPEJ6tOz55XCDwGr2LcdKABiiB4qpFlizvgZwBjzoLK79c5JNDfBeqFtdz2s9f\n\tMF5h/L828hXHw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date;\n\tbh=6s/weg+FmtUhHnd1TDe53hu3NB6qffBzKvrLARUAhvo=;\n\tb=Bq4pTNCE4zzVyo+gX3HdawmGtdh1tV4Id9+BeWEAfn697Gk4bdWBRnorJCI3gnsIhZ\n\t6K3fQAGx+wg9SD+vOo5NJZSDR8U5luGRDvXgtOSE/ZnjGwXGqZFgLlnuqDDt93vW+NHY\n\turvYle4MlCPUGnUFKadPkKUXxe4SF7gCZYTE2TcmmLJokUwF8tcBo0as5hhD5U2xoSqP\n\tAP6HD9B5pnDCtpD1snAnhmZM+a5/vVRNX04MgmYLT3jqJZJ7aC3tE3KvnZ8Wu4il/iwe\n\tGq/Bb41j4lYt5n06NURqq64FlWkVmexp4jsrPhSHPjmgLcy9vcSE1skHKAkbe+eQcaHw\n\tLYEA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Bq4pTNCE\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date;\n\tbh=6s/weg+FmtUhHnd1TDe53hu3NB6qffBzKvrLARUAhvo=;\n\tb=yxPxo1P0IYoLHQCrM5Eopdo3mZCMGct36NyxRM8v2i1IS4UlwLBwzMjTWfenmUaTqD\n\t6CqhZhfR1KAUXMgVwJNUa/UXXcfvV90kv0BjKcjXN3e9BW3wlyFIGkvYmyKEpLwAUBnR\n\tRQep5c1ovYm8T0QmsVdZImRgPwF1KIVpBguMsLAEXnG8Xj5gb9iIIiFMFqBB/9hhn91J\n\tmyszyVz/pS1jpuaeUPTQxENuykhCXsWW3mwpDCMS2pskiY0dn8OqskYLEf0LY7D9RuJv\n\tYbQaxOyFcAP8IZObNjnuj7tx14wr8VOv2xtFe2jgNxAUMxtOpEZpqcTt/chdHrCf/+kt\n\tZTnQ==","X-Gm-Message-State":"ACrzQf0O5IFaOJ/Fl9It/F+NthRMketQXioGnUPQgjn2o2ufQZyHU4hv\n\t1d1NpgoKeBV9rUAb6onr70fuTPtazOXiM00pW+UHUw==","X-Google-Smtp-Source":"AMsMyM7BQnSH00OPL54SkgcUy7Ri7pOrTyGkH5hR92ZqxpHBJNhaGc8ECGJs0iJ7D9D060FNV7bY9sFJ5C7Ks9Q4HV8=","X-Received":"by 2002:a17:90a:6405:b0:203:6eaa:4999 with SMTP id\n\tg5-20020a17090a640500b002036eaa4999mr11332734pjj.8.1664790248468;\n\tMon, 03 Oct 2022 02:44:08 -0700 (PDT)","MIME-Version":"1.0","References":"<20220929072323.7400-1-naush@raspberrypi.com>\n\t<20220929072323.7400-5-naush@raspberrypi.com>\n\t<20220929073549.rey6n7tefs2b72gu@uno.localdomain>","In-Reply-To":"<20220929073549.rey6n7tefs2b72gu@uno.localdomain>","Date":"Mon, 3 Oct 2022 10:43:57 +0100","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 4/4] ipa: raspberrypi: Fix the\n\timx296 mono tuning black level","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]