{"id":17440,"url":"https://patchwork.libcamera.org/api/patches/17440/?format=json","web_url":"https://patchwork.libcamera.org/patch/17440/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220927023642.12341-30-laurent.pinchart@ideasonboard.com>","date":"2022-09-27T02:36:38","name":"[libcamera-devel,v5,29/33] ipa: rkisp1: awb: Log means, gains and temperature in debug message","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e44874a3e7dc73c74bfcd7b12f0c9ae5994de899","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17440/mbox/","series":[{"id":3506,"url":"https://patchwork.libcamera.org/api/series/3506/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3506","date":"2022-09-27T02:36:09","name":"ipa: Frame context queue, IPU3 & RkISP consolidation, and RkISP1 improvements","version":5,"mbox":"https://patchwork.libcamera.org/series/3506/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17440/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17440/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 480E1C327E\n\tfor ;\n\tTue, 27 Sep 2022 02:37:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1089B6236A;\n\tTue, 27 Sep 2022 04:37:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FD94622F1\n\tfor ;\n\tTue, 27 Sep 2022 04:37:45 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 89759E5\n\tfor ;\n\tTue, 27 Sep 2022 04:37:44 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664246267;\n\tbh=lBdRG10Dae6rR63qGMuMOGUHyO2yRK3Bsr7qu44b0aY=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=p0u+T8ikBfL8STqY1kjfwkw7EZAbgbX+iRtavMQARZ6I5S8Kt4DPhHqTzJMy+bfB4\n\t4VMQ4lKdTpC8b9b5+svkh9QEBAmY+i37vqEkMqipR4KZbzt9aYG2xL3nryYPkmZUee\n\tdpeKcJbGrL73okXWSolQmi8IGWt7UXDIclAxxmkJhOub/y5kmPxkurvLcSpUfYvOFa\n\tyo7NvT5HwxQYr0VCMjCyyTj+CJpRjV5vyLeqjCzawiuSOIgC9umK9Wu3D8fnUrpa9I\n\tB6KG4EvfwxroSAWeqkXVBJ3FtcOeD/pnr0wQxUNdsM/672dn05i0b2wOrpfMV2XQL7\n\tfmeeQ4wpci5Sg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664246264;\n\tbh=lBdRG10Dae6rR63qGMuMOGUHyO2yRK3Bsr7qu44b0aY=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=FRVTpTdKUsxdjz1gNDvM2k0wyuHAA/B4y5b9ElIPY8Bj+Ltyn4u8wHQdzKItBuMt/\n\tLYt17LbcMruXZGOiLtxEUioqzuSlaXJ9Su/g5xnS4th2C5h4bh39l49qJJZZ7Id1Qv\n\tcuB0OAg+AbfPf1lLpFFs8WCFH6Udu83GEYKBZM4g="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"FRVTpTdK\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 27 Sep 2022 05:36:38 +0300","Message-Id":"<20220927023642.12341-30-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220927023642.12341-1-laurent.pinchart@ideasonboard.com>","References":"<20220927023642.12341-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 29/33] ipa: rkisp1: awb: Log means,\n\tgains and temperature in debug message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Extend the debug message in Awb::process() to log the means and color\ntemperature in addition to the gains. This is useful for debugging the\nalgorithm behaviour. While at it, set the showpoint flag to print a\nfixed number of digits after the decimal point, making logs more\nreadable.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \nReviewed-by: Jacopo Mondi \n---\n src/ipa/rkisp1/algorithms/awb.cpp | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex cde5b981df61..139c8239504f 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -9,6 +9,7 @@\n \n #include \n #include \n+#include \n \n #include \n \n@@ -271,8 +272,12 @@ void Awb::process(IPAContext &context,\n \tactiveState.awb.gains.automatic.blue = std::clamp(blueGain, 0.0, 1023.0 / 256);\n \tactiveState.awb.gains.automatic.green = 1.0;\n \n-\tLOG(RkISP1Awb, Debug) << \"Gain found for red: \" << activeState.awb.gains.automatic.red\n-\t\t\t << \" and for blue: \" << activeState.awb.gains.automatic.blue;\n+\tLOG(RkISP1Awb, Debug) << std::showpoint\n+\t\t<< \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n+\t\t<< \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\n+\t\t<< activeState.awb.gains.automatic.green << \", \"\n+\t\t<< activeState.awb.gains.automatic.blue << \"], temp \"\n+\t\t<< frameContext.awb.temperatureK << \"K\";\n }\n \n REGISTER_IPA_ALGORITHM(Awb, \"Awb\")\n","prefixes":["libcamera-devel","v5","29/33"]}