[{"id":25128,"web_url":"https://patchwork.libcamera.org/comment/25128/","msgid":"<166426651526.570727.9025743004505506957@Monstersaurus>","date":"2022-09-27T08:15:15","subject":"Re: [libcamera-devel] [PATCH v5 18/33] ipa: Disable\n\tcopy-construction of IPAContext","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-09-27 03:36:27)\n> The IPAContext is not meant to be copied. Prevent unintentional\n> pass-by-value by disabling its copy constructor.\n> \n> Signed-off-by: Laurent Pinchart \n\nI wonder if IPAContext should derive from an (empty) base struct which\nhas copy disabled... (would that actually work?)\n\nBut I doubt that's much better. This is fine I think.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/ipu3/ipa_context.h | 4 ++++\n> src/ipa/rkisp1/ipa_context.h | 4 ++++\n> 2 files changed, 8 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\n> index bdba3d07d13a..9766330f2f39 100644\n> --- a/src/ipa/ipu3/ipa_context.h\n> +++ b/src/ipa/ipu3/ipa_context.h\n> @@ -10,6 +10,7 @@\n> \n> #include \n> \n> +#include \n> #include \n> \n> #include \n> @@ -87,6 +88,9 @@ struct IPAContext {\n> IPAActiveState activeState;\n> \n> FCQueue frameContexts;\n> +\n> +private:\n> + LIBCAMERA_DISABLE_COPY(IPAContext)\n> };\n> \n> } /* namespace ipa::ipu3 */\n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index 4481bd2acde6..9a84b7adda45 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -10,6 +10,7 @@\n> \n> #include \n> \n> +#include \n> #include \n> \n> #include \n> @@ -101,6 +102,9 @@ struct IPAContext {\n> IPAActiveState activeState;\n> \n> FCQueue frameContexts;\n> +\n> +private:\n> + LIBCAMERA_DISABLE_COPY(IPAContext)\n> };\n> \n> } /* namespace ipa::rkisp1 */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3791BD16B\n\tfor ;\n\tTue, 27 Sep 2022 08:15:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0E9E062264;\n\tTue, 27 Sep 2022 10:15:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A140B61F7B\n\tfor ;\n\tTue, 27 Sep 2022 10:15:18 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E94EAE5;\n\tTue, 27 Sep 2022 10:15:17 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664266520;\n\tbh=SaBKX1CJ0zIuSumULhL0k42ClwgVLKeFzn1t54QhhFM=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=BvYLe1sO9ZMb69Nhm6HouynAZiNQGXSTDqc/UUNClodY0T3qKYgfd7bRy+7/45AnZ\n\tYe/ISviVLLxudLf7pcVbuIDNq7uJssu5to4QfNKyt7p/StOV80sNCA5K67G7GWYcH1\n\tjO8ep/qooohn6RHDuZ1GrREE3XvjrwJCHUvtfTvdHMGuJubfpNt8syzveZI5tra5ad\n\tCGrO70vFEVVLFAZchOG3b9wtc6QekL8bfsiu3EYNb53cVcYol1dQXJFWUS0n9bHz69\n\tzJX1aeheV7oBlefdWCFwX846ygaW2LzBfDfMyzdvXcPLfILJqQq0P+unMnRug3vND9\n\tYFV20mZk1k2YA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664266518;\n\tbh=SaBKX1CJ0zIuSumULhL0k42ClwgVLKeFzn1t54QhhFM=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=G8i0xzPOL0N+I/E2i2hE0DwhaAYH8YcoLuknazNjrynPPO+cF7dGwChSnzRS53Jqb\n\tkX6VmoTiaUg6VLEhV7jo99xSyUVnvyz8abiOOXMct0X22Wi217J/reuvkamB327rVX\n\tAfwKdu8bXa1tDfIry6Yv2HxUzHKNXLp0hAZXzVJ0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"G8i0xzPO\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220927023642.12341-19-laurent.pinchart@ideasonboard.com>","References":"<20220927023642.12341-1-laurent.pinchart@ideasonboard.com>\n\t<20220927023642.12341-19-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 27 Sep 2022 09:15:15 +0100","Message-ID":"<166426651526.570727.9025743004505506957@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v5 18/33] ipa: Disable\n\tcopy-construction of IPAContext","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25129,"web_url":"https://patchwork.libcamera.org/comment/25129/","msgid":"<20220927081919.ojb746zo4tfzvvdi@uno.localdomain>","date":"2022-09-27T08:19:19","subject":"Re: [libcamera-devel] [PATCH v5 18/33] ipa: Disable\n\tcopy-construction of IPAContext","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Tue, Sep 27, 2022 at 09:15:15AM +0100, Kieran Bingham via libcamera-devel wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-09-27 03:36:27)\n> > The IPAContext is not meant to be copied. Prevent unintentional\n> > pass-by-value by disabling its copy constructor.\n> >\n> > Signed-off-by: Laurent Pinchart \n>\n> I wonder if IPAContext should derive from an (empty) base struct which\n> has copy disabled... (would that actually work?)\n>\n> But I doubt that's much better. This is fine I think.\n>\n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> > ---\n> > src/ipa/ipu3/ipa_context.h | 4 ++++\n> > src/ipa/rkisp1/ipa_context.h | 4 ++++\n> > 2 files changed, 8 insertions(+)\n> >\n> > diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\n> > index bdba3d07d13a..9766330f2f39 100644\n> > --- a/src/ipa/ipu3/ipa_context.h\n> > +++ b/src/ipa/ipu3/ipa_context.h\n> > @@ -10,6 +10,7 @@\n> >\n> > #include \n> >\n> > +#include \n> > #include \n> >\n> > #include \n> > @@ -87,6 +88,9 @@ struct IPAContext {\n> > IPAActiveState activeState;\n> >\n> > FCQueue frameContexts;\n> > +\n> > +private:\n> > + LIBCAMERA_DISABLE_COPY(IPAContext)\n> > };\n> >\n> > } /* namespace ipa::ipu3 */\n> > diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> > index 4481bd2acde6..9a84b7adda45 100644\n> > --- a/src/ipa/rkisp1/ipa_context.h\n> > +++ b/src/ipa/rkisp1/ipa_context.h\n> > @@ -10,6 +10,7 @@\n> >\n> > #include \n> >\n> > +#include \n> > #include \n> >\n> > #include \n> > @@ -101,6 +102,9 @@ struct IPAContext {\n> > IPAActiveState activeState;\n> >\n> > FCQueue frameContexts;\n> > +\n> > +private:\n> > + LIBCAMERA_DISABLE_COPY(IPAContext)\n> > };\n> >\n> > } /* namespace ipa::rkisp1 */\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52CC0BD16B\n\tfor ;\n\tTue, 27 Sep 2022 08:19:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B757E62264;\n\tTue, 27 Sep 2022 10:19:22 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1A1B61F7B\n\tfor ;\n\tTue, 27 Sep 2022 10:19:21 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 2236C20000B;\n\tTue, 27 Sep 2022 08:19:20 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664266762;\n\tbh=fxba321VxDBC8q4HeWX8u7NVF6NJZky4vunMq4QLaWA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=NByYYK3CVeMBbTaByG8q1A80Gr993ZtvddUwvJXDKGx3EYfxvOegy1nerAKZf+Zkt\n\tfvyHxhr3wjhhf3g5GaS6OAhk1AGAaNNAxj7oJMhwFvPKJ2Uktrtpr7vYLiRP9KBXnR\n\tbWBqFQjHHGa9Gk/wyV0GFDoD1hWnGITBHAvCFlQ78j7DZmhfhFNhEFjalVDaqaZbub\n\tdNjnFKBBH114Sym5wwNSxG21zBNG1dodsWD45RrJeU3YRxQ7GxRzI7+Uj4GmXfnP2J\n\t57gAZzXrgQvnK13ieSSUXSEwI9DCoGOKdAsQUceOEBgKWLTSM6H1753ZdQcZsBGqPD\n\taPWZLWAFQ31Lg==","Date":"Tue, 27 Sep 2022 10:19:19 +0200","To":"Kieran Bingham ","Message-ID":"<20220927081919.ojb746zo4tfzvvdi@uno.localdomain>","References":"<20220927023642.12341-1-laurent.pinchart@ideasonboard.com>\n\t<20220927023642.12341-19-laurent.pinchart@ideasonboard.com>\n\t<166426651526.570727.9025743004505506957@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166426651526.570727.9025743004505506957@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v5 18/33] ipa: Disable\n\tcopy-construction of IPAContext","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25136,"web_url":"https://patchwork.libcamera.org/comment/25136/","msgid":"","date":"2022-09-27T10:10:12","subject":"Re: [libcamera-devel] [PATCH v5 18/33] ipa: Disable\n\tcopy-construction of IPAContext","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Sep 27, 2022 at 09:15:15AM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-09-27 03:36:27)\n> > The IPAContext is not meant to be copied. Prevent unintentional\n> > pass-by-value by disabling its copy constructor.\n> > \n> > Signed-off-by: Laurent Pinchart \n> \n> I wonder if IPAContext should derive from an (empty) base struct which\n> has copy disabled... (would that actually work?)\n\nThat would work. We may also want to disable copying of the active\nstate. I'll have a look on top of this.\n\n> But I doubt that's much better. This is fine I think.\n> \n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > src/ipa/ipu3/ipa_context.h | 4 ++++\n> > src/ipa/rkisp1/ipa_context.h | 4 ++++\n> > 2 files changed, 8 insertions(+)\n> > \n> > diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\n> > index bdba3d07d13a..9766330f2f39 100644\n> > --- a/src/ipa/ipu3/ipa_context.h\n> > +++ b/src/ipa/ipu3/ipa_context.h\n> > @@ -10,6 +10,7 @@\n> > \n> > #include \n> > \n> > +#include \n> > #include \n> > \n> > #include \n> > @@ -87,6 +88,9 @@ struct IPAContext {\n> > IPAActiveState activeState;\n> > \n> > FCQueue frameContexts;\n> > +\n> > +private:\n> > + LIBCAMERA_DISABLE_COPY(IPAContext)\n> > };\n> > \n> > } /* namespace ipa::ipu3 */\n> > diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> > index 4481bd2acde6..9a84b7adda45 100644\n> > --- a/src/ipa/rkisp1/ipa_context.h\n> > +++ b/src/ipa/rkisp1/ipa_context.h\n> > @@ -10,6 +10,7 @@\n> > \n> > #include \n> > \n> > +#include \n> > #include \n> > \n> > #include \n> > @@ -101,6 +102,9 @@ struct IPAContext {\n> > IPAActiveState activeState;\n> > \n> > FCQueue frameContexts;\n> > +\n> > +private:\n> > + LIBCAMERA_DISABLE_COPY(IPAContext)\n> > };\n> > \n> > } /* namespace ipa::rkisp1 */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21602C0DA4\n\tfor ;\n\tTue, 27 Sep 2022 10:10:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7DFA462274;\n\tTue, 27 Sep 2022 12:10:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F2D3461F7D\n\tfor ;\n\tTue, 27 Sep 2022 12:10:29 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D576E5;\n\tTue, 27 Sep 2022 12:10:29 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664273430;\n\tbh=S9nEC7EQv9ZdvA7ys13vlCmiroKHopPkKOKQLq8wzE8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=3HH1/kN2SC7sqeRnhw7AbjE1H05uKcPr0VD8h0q190jZVRO712BNF1M+q1AqG87eH\n\tPraW9deVunR9FSjet6wT+1ZHFIsW7h78iyTMI/q/n7J4fxmFlzwNfUJH6g4oTIuN9d\n\t/mrIjYidRul5N27KmKSF/IEqfzpyLC/phBpdzTAjs88BBENjXuLzLv3oRCkv0pPUEA\n\tXE+r9phLP0Sfyd3e+qsP8MKcVwOW+H1PGwV5ep1tQhvvvkirFJj6/OcFUEcnjnzLEh\n\tDemvZMfewxg9aQ2iCo8nY9fMY5jMJiFCQiE0CLUmAGT0LqjehfkkcJdx46kMVxRI9L\n\t4X41h8IBe4Zcg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664273429;\n\tbh=S9nEC7EQv9ZdvA7ys13vlCmiroKHopPkKOKQLq8wzE8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iBzIs8FhbaIzoE9R2sQ0CEVOHF7NIxP+HjC5gV00Qeo3H1n3u7JDWz3iw8gUtom4D\n\tzpdHdBT9C8/sysfwxD/2uNoufuTKZ3hNcZ48qo3JzNsqRF5yC6lKhSRYRPX5Odl9TG\n\tSzhV4WTG940zyiWWbW6ooqn8uQt0IJcQY29BcOeM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"iBzIs8Fh\"; dkim-atps=neutral","Date":"Tue, 27 Sep 2022 13:10:12 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220927023642.12341-1-laurent.pinchart@ideasonboard.com>\n\t<20220927023642.12341-19-laurent.pinchart@ideasonboard.com>\n\t<166426651526.570727.9025743004505506957@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166426651526.570727.9025743004505506957@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v5 18/33] ipa: Disable\n\tcopy-construction of IPAContext","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]