[{"id":25130,"web_url":"https://patchwork.libcamera.org/comment/25130/","msgid":"<20220927091356.n3zvpzy326546nv2@uno.localdomain>","date":"2022-09-27T09:13:56","subject":"Re: [libcamera-devel] [PATCH v5 11/33] ipa: ipu3: Pass controls to\n\talgorithm's queueRequest() handler","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Tue, Sep 27, 2022 at 05:36:20AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Call the Algorithm::queueRequest() function of all algorithms when a\n> request is queued, to pass the request controls to the algorithms. We\n> can now drop the copy of the control list stored in IPAFrameContext as\n> it isn't used anymore.\n>\n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> Changes since v4:\n>\n> - Drop todo comment\n> ---\n> src/ipa/ipu3/ipa_context.cpp | 3 ---\n> src/ipa/ipu3/ipa_context.h | 3 ---\n> src/ipa/ipu3/ipu3.cpp | 5 ++---\n> 3 files changed, 2 insertions(+), 9 deletions(-)\n>\n> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> index 6904ccbbdf8b..bd71b615365d 100644\n> --- a/src/ipa/ipu3/ipa_context.cpp\n> +++ b/src/ipa/ipu3/ipa_context.cpp\n> @@ -168,9 +168,6 @@ namespace libcamera::ipa::ipu3 {\n> * \\struct IPAFrameContext\n> * \\brief IPU3-specific FrameContext\n> *\n> - * \\var IPAFrameContext::frameControls\n> - * \\brief Controls sent in by the application while queuing the request\n> - *\n> * \\var IPAFrameContext::sensor\n> * \\brief Effective sensor values that were applied for the frame\n> *\n> diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\n> index bfc0196e098a..36099353e9f2 100644\n> --- a/src/ipa/ipu3/ipa_context.h\n> +++ b/src/ipa/ipu3/ipa_context.h\n> @@ -12,7 +12,6 @@\n>\n> #include \n>\n> -#include \n> #include \n>\n> #include \n> @@ -78,8 +77,6 @@ struct IPAFrameContext : public FrameContext {\n> \t\tuint32_t exposure;\n> \t\tdouble gain;\n> \t} sensor;\n> -\n> -\tControlList frameControls;\n> };\n>\n> struct IPAContext {\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 96dc2af2cb73..d1ea081d595d 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -663,11 +663,10 @@ void IPAIPU3::processStatsBuffer(const uint32_t frame,\n> */\n> void IPAIPU3::queueRequest(const uint32_t frame, const ControlList &controls)\n> {\n> -\t/* \\todo Start processing for 'frame' based on 'controls'. */\n> \tIPAFrameContext &frameContext = context_.frameContexts.alloc(frame);\n>\n> -\t/* \\todo Implement queueRequest to each algorithm. */\n> -\tframeContext.frameControls = controls;\n> +\tfor (auto const &algo : algorithms())\n> +\t\talgo->queueRequest(context_, frame, frameContext, controls);\n> }\n>\n> /**\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE74DC0DA4\n\tfor ;\n\tTue, 27 Sep 2022 09:14:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1CB1F62269;\n\tTue, 27 Sep 2022 11:14:01 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 270C961F7B\n\tfor ;\n\tTue, 27 Sep 2022 11:13:59 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 95A5E4000C;\n\tTue, 27 Sep 2022 09:13:58 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664270041;\n\tbh=/vdlkHPGIQFZxXmCXLsMsHB7hcqdixGD6W/jvuxU2Dw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ExUkT7jbFzz7N21d/QrO3t9M8YFjWugmFU9UBe0rix4RMPT8mrnMwag971L4pzqli\n\t/1CkTmMJplmkVqEPhxtTlCalkqXqzuobu7SBJcixBE6F2Tu56LSlu61ECVHYsU3IPY\n\te/SnfXd1c48TJz/9qubRh0FqMPt3vU3wA9+5zGRmYx17sSzIKA2YaRsgsmi3xcOgsZ\n\tfTP0CcBUBgWQw6gZzpEFW5Vra5HZBcA0DOZ8BETo2HV16U0Ey8hnwwYShidpHqvkxp\n\tje3y+BVVHBLHru0XKfXaIGHQNURvd+27Di4qdP2vI8mrhfx93laLBw2FB2AbMJArhF\n\tymymh3BxUVepg==","Date":"Tue, 27 Sep 2022 11:13:56 +0200","To":"Laurent Pinchart ","Message-ID":"<20220927091356.n3zvpzy326546nv2@uno.localdomain>","References":"<20220927023642.12341-1-laurent.pinchart@ideasonboard.com>\n\t<20220927023642.12341-12-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220927023642.12341-12-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v5 11/33] ipa: ipu3: Pass controls to\n\talgorithm's queueRequest() handler","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]