[{"id":2335,"web_url":"https://patchwork.libcamera.org/comment/2335/","msgid":"<20190807211815.GB20497@pendragon.ideasonboard.com>","date":"2019-08-07T21:18:15","subject":"Re: [libcamera-devel] [PATCH v2 4/4] tests: camera-sensor: Test\n\tusing invalid media bus format","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Wed, Aug 07, 2019 at 10:49:15PM +0200, Niklas Söderlund wrote:\n> Linux commit b6c61a6c37317efd (\"media: vimc: propagate pixel format in\n> the stream\") changes the sensor in the vimc media graph to accept all\n> media bus format currently described in Linux. This prevents the\n> camera-sensor test case to verify that a supported media bus format is\n> selected from a list of defined formats, fix this my using an invalid\n\ns/my using/by using/\n\n> media bus format in the test case.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> test/camera-sensor.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/test/camera-sensor.cpp b/test/camera-sensor.cpp\n> index 092cbdd8111ce70d..9fe59cc98d79ccab 100644\n> --- a/test/camera-sensor.cpp\n> +++ b/test/camera-sensor.cpp\n> @@ -83,7 +83,8 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> -\t\tV4L2SubdeviceFormat format = sensor_->getFormat({ MEDIA_BUS_FMT_UYVY8_2X8,\n> +\t\t/* Use an invalid format and make sure it's not selected. */\n> +\t\tV4L2SubdeviceFormat format = sensor_->getFormat({ 0xdeadbeef,\n> \t\t\t\t\t\t\t\t MEDIA_BUS_FMT_SBGGR10_1X10,\n> \t\t\t\t\t\t\t\t MEDIA_BUS_FMT_BGR888_1X24 },\n> \t\t\t\t\t\t\t\tSize(1024, 768));","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 617AA6161A\n\tfor ;\n\tWed, 7 Aug 2019 23:18:18 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C71F967;\n\tWed, 7 Aug 2019 23:18:17 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565212698;\n\tbh=kQy99x8hb6pLxe4eTXstCLOM9MNRs99tvCvEYsrrBtc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UVylTEi1n508gPFAUD6l46NIPb8BPBla0wUvJuTXu2w0sp1aWp3jxLML866XlomQh\n\tOghD2cGwS6MsqkrUofFxlIfja/HQlwLKE+V9TSZxp2pOgkDBA4gMGICc3uNO5O8FTd\n\to1I1DkvEmJP4AkUxwL/dEVs/ngfFLQE7ln/JlKBs=","Date":"Thu, 8 Aug 2019 00:18:15 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190807211815.GB20497@pendragon.ideasonboard.com>","References":"<20190807204915.23942-1-niklas.soderlund@ragnatech.se>\n\t<20190807204915.23942-5-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190807204915.23942-5-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 4/4] tests: camera-sensor: Test\n\tusing invalid media bus format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 07 Aug 2019 21:18:18 -0000"}},{"id":2336,"web_url":"https://patchwork.libcamera.org/comment/2336/","msgid":"<20190807211835.GC20497@pendragon.ideasonboard.com>","date":"2019-08-07T21:18:35","subject":"Re: [libcamera-devel] [PATCH v2 4/4] tests: camera-sensor: Test\n\tusing invalid media bus format","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Aug 08, 2019 at 12:18:15AM +0300, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Wed, Aug 07, 2019 at 10:49:15PM +0200, Niklas Söderlund wrote:\n> > Linux commit b6c61a6c37317efd (\"media: vimc: propagate pixel format in\n> > the stream\") changes the sensor in the vimc media graph to accept all\n> > media bus format currently described in Linux. This prevents the\n> > camera-sensor test case to verify that a supported media bus format is\n> > selected from a list of defined formats, fix this my using an invalid\n> \n> s/my using/by using/\n\nand\n\nReviewed-by: Laurent Pinchart \n\n> > media bus format in the test case.\n> > \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > test/camera-sensor.cpp | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/test/camera-sensor.cpp b/test/camera-sensor.cpp\n> > index 092cbdd8111ce70d..9fe59cc98d79ccab 100644\n> > --- a/test/camera-sensor.cpp\n> > +++ b/test/camera-sensor.cpp\n> > @@ -83,7 +83,8 @@ protected:\n> > \t\t\treturn TestFail;\n> > \t\t}\n> > \n> > -\t\tV4L2SubdeviceFormat format = sensor_->getFormat({ MEDIA_BUS_FMT_UYVY8_2X8,\n> > +\t\t/* Use an invalid format and make sure it's not selected. */\n> > +\t\tV4L2SubdeviceFormat format = sensor_->getFormat({ 0xdeadbeef,\n> > \t\t\t\t\t\t\t\t MEDIA_BUS_FMT_SBGGR10_1X10,\n> > \t\t\t\t\t\t\t\t MEDIA_BUS_FMT_BGR888_1X24 },\n> > \t\t\t\t\t\t\t\tSize(1024, 768));","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78DB36161A\n\tfor ;\n\tWed, 7 Aug 2019 23:18:38 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E872D67;\n\tWed, 7 Aug 2019 23:18:37 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565212718;\n\tbh=vEQ6Q0qW9ygCFvgAzxk3S3+MN+d+D41sEXu8Xw41sIo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=u6f3rVytOKJaBstmVqg3zPIbvHBm+ODkWQJwJ66yxqAFqNwFp7BvUycYuPTYAMEH4\n\t4a1JztrVxPAywXqIxT6yVJRbM9op8Ogw2hB7OPPWeF32UMqePzHIdVokcEcePX4SIt\n\t1UkXLxOhlFtrSkXiFQ/qUdyV9QewOHlVyv8DfVP4=","Date":"Thu, 8 Aug 2019 00:18:35 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190807211835.GC20497@pendragon.ideasonboard.com>","References":"<20190807204915.23942-1-niklas.soderlund@ragnatech.se>\n\t<20190807204915.23942-5-niklas.soderlund@ragnatech.se>\n\t<20190807211815.GB20497@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190807211815.GB20497@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 4/4] tests: camera-sensor: Test\n\tusing invalid media bus format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 07 Aug 2019 21:18:38 -0000"}}]