[{"id":25152,"web_url":"https://patchwork.libcamera.org/comment/25152/","msgid":"<20220928073336.t4safyzytth56sva@uno.localdomain>","date":"2022-09-28T07:33:36","subject":"Re: [libcamera-devel] [PATCH v1 4/4] ipa: raspberrypi: Fix the\n\timx296 mono tuning black level","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Naush\n\nOn Mon, Sep 26, 2022 at 01:29:11PM +0100, Naushir Patuck via libcamera-devel wrote:\n> The sensor black level is 60 (in 10-bits), fix this in the mono variant tuning\n> file.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/raspberrypi/data/imx296_mono.json | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/raspberrypi/data/imx296_mono.json b/src/ipa/raspberrypi/data/imx296_mono.json\n> index 490c0fda0cca..b68b11dbd609 100644\n> --- a/src/ipa/raspberrypi/data/imx296_mono.json\n> +++ b/src/ipa/raspberrypi/data/imx296_mono.json\n> @@ -5,7 +5,7 @@\n> {\n> \"rpi.black_level\":\n> {\n> - \"black_level\": 4096\n> + \"black_level\": 3840\n\nOut of curiosity, what encoding is this one ? You mentioned 10-bits\nbut this doesn't look like Q10, or is it ?\n\n> }\n> },\n> {\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D54E3BD16B\n\tfor ;\n\tWed, 28 Sep 2022 07:33:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D7BF62299;\n\tWed, 28 Sep 2022 09:33:39 +0200 (CEST)","from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 354E461F7A\n\tfor ;\n\tWed, 28 Sep 2022 09:33:38 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 9B727FF809;\n\tWed, 28 Sep 2022 07:33:37 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664350419;\n\tbh=/A9ZVThggqp3J+qcvGKv5kP6wPY94o31dRGFhS7SyWY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=RObHR6gS5oqxpp1J8977U44XBOLuetimUL+W7iV2Hl5XUlGV1A4Yr5/q75IPj2Ozw\n\tE/ckhQhJruifhrWk6M51gxI9Ghd1mSBqHhNFNGqguVa+MBum17PbnSKuBm5oNTqAkK\n\tjJX5YZDNy0QShfGoeGejl7MKTJ37vQq5ZGqMpxMSyNF0zspvU3FOPTx6vVnKA21Xhn\n\trNb0Ieww49OVPhUQbQfI0mTbomStrJSfldldMphOfHK8Q7/Ejfeatj/uWB5rCxxE+k\n\t4NkCmwCkiCoT8RacwMVm5VNAfYHWHkRBLJ2+IbqtOhSQ2ITyK1iRyxdbHLuQHG6k8g\n\tVwJGGbE7NZ3Pw==","Date":"Wed, 28 Sep 2022 09:33:36 +0200","To":"Naushir Patuck ","Message-ID":"<20220928073336.t4safyzytth56sva@uno.localdomain>","References":"<20220926122911.13412-1-naush@raspberrypi.com>\n\t<20220926122911.13412-5-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220926122911.13412-5-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v1 4/4] ipa: raspberrypi: Fix the\n\timx296 mono tuning black level","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25153,"web_url":"https://patchwork.libcamera.org/comment/25153/","msgid":"","date":"2022-09-28T07:50:46","subject":"Re: [libcamera-devel] [PATCH v1 4/4] ipa: raspberrypi: Fix the\n\timx296 mono tuning black level","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Jacopo,\n\nThank you for the feedback.\n\nOn Wed, 28 Sept 2022 at 08:33, Jacopo Mondi wrote:\n\n> Hi Naush\n>\n> On Mon, Sep 26, 2022 at 01:29:11PM +0100, Naushir Patuck via\n> libcamera-devel wrote:\n> > The sensor black level is 60 (in 10-bits), fix this in the mono variant\n> tuning\n> > file.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/ipa/raspberrypi/data/imx296_mono.json | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/data/imx296_mono.json\n> b/src/ipa/raspberrypi/data/imx296_mono.json\n> > index 490c0fda0cca..b68b11dbd609 100644\n> > --- a/src/ipa/raspberrypi/data/imx296_mono.json\n> > +++ b/src/ipa/raspberrypi/data/imx296_mono.json\n> > @@ -5,7 +5,7 @@\n> > {\n> > \"rpi.black_level\":\n> > {\n> > - \"black_level\": 4096\n> > + \"black_level\": 3840\n>\n> Out of curiosity, what encoding is this one ? You mentioned 10-bits\n> but this doesn't look like Q10, or is it ?\n>\n\nAll our tuning parameters are specified in 16-bits, i.e. a white-point of\n65535.\nSo the black level above is computed as 60 << (16bits - 10bits) == 3840.\n\nRegards,\nNaush\n\n\n>\n> > }\n> > },\n> > {\n> > --\n> > 2.25.1\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB4C4C0DA4\n\tfor ;\n\tWed, 28 Sep 2022 07:51:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9F746229B;\n\tWed, 28 Sep 2022 09:51:03 +0200 (CEST)","from mail-lf1-x134.google.com (mail-lf1-x134.google.com\n\t[IPv6:2a00:1450:4864:20::134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7F4A61F7A\n\tfor ;\n\tWed, 28 Sep 2022 09:51:02 +0200 (CEST)","by mail-lf1-x134.google.com with SMTP id g1so1513588lfu.12\n\tfor ;\n\tWed, 28 Sep 2022 00:51:02 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664351463;\n\tbh=BwzS+ykEthzXO8Sce4PBTHqzCcU7Yhr4MrH02RJLVjo=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rZXVlYhRA13BI9enwd80CAEO/7NMql90hJXnOicSPkQXEqomiMZfrL+Hsw8y+Htly\n\tTYg8o/VMXRIUhIQ3CZ37g5rbXIibq75fYh2BdQNPnT3bIqt+HKC+fkmaKrYyZzJuFV\n\t//7518DdF9sRaLWHayrh2bBOoOkP4fj9U62Bkl9Suuh1FghR4GzUTZzWzmMzhxBJwt\n\tDoRXOdBViI7gUIqX5fFVo49xPhxx6WM121e4s9YVVytyCqn/NpkBwm0VUwhbmhmts4\n\tj1p7gev8NeYlQ1/a0hlFypGTMbisa4dKjQg97kQjOPgdPxUtFayvJE1hJKQen1dS4a\n\tYoPWAVHYk/L1w==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date;\n\tbh=UV0BhgwzJoFuP4wLFgm6jqO66/teqOVVw9k0LBU71ig=;\n\tb=AneWCgyjhCcSty4KTxpi48l+rz0SL9Q6aBf/io8flZ9a8iKEp65poWxcBFgCdX9vi0\n\tgP1my/ktgcKOrGp7UszAvKpAbWkyJ31QusipbwPTywSImRbVGwK0ShShUOExiNCUdato\n\tA+Bn5AyGeJwvr8dtU3rtJCnbYmeE5ZGKeDrW+I7DMWJYMkK8ApQmAfMwVypkfAu5QPIh\n\tRwLcaKUW5L2j+TwIdMlYH1MATWTCe4tVJU+jnYephA38KrfVokEg3llsUuuDCM+ev7cJ\n\tQcBhfZTAxE/AqCCELRas7ZPmUwToO15eH8HR61af0ABcWwt7V2VOAvk9KZb+4Yz/Xb24\n\tA5PQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"AneWCgyj\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date;\n\tbh=UV0BhgwzJoFuP4wLFgm6jqO66/teqOVVw9k0LBU71ig=;\n\tb=0XyQtqop+XHc9BtppcYDXsyO5TChKl2fcUpPaQK7Tc6XNjiqLW/VHSaQbhmbRuwxQf\n\tWEVdgCbRfZm1nyxZgDi01nf0FH2rjjqdvWp/ttPNSmgY+AWLNcaDTFf5Ms+55ZG4sj08\n\tIQF9pW4S3cGJqiowucv3GhYfV93jMw/AsO2dQYuXUck2qOEAJGgFjdW6bcmRMxR7SVL9\n\t3cf3Vt47Bi6IT/djo7sWeTWxACbMqhwL2W+JCDl/oW8Pxx2Dpngw681MCbE8ee+5QyPo\n\t6BTQfhUXJZwAW+FiFsIDF2jxSJrIjP0re0rskVYyycPTa2r+OW34U36Z0foSpXzs9Znk\n\tDKpQ==","X-Gm-Message-State":"ACrzQf342HRksM5siDaItcc13bnVywI6xG5+aRQ0r+mYbMgYkQ4sQEz9\n\tpOHXsMqaS1bpE1M+gXUdc38+XE+R13tmJ1UOt7UpvQ==","X-Google-Smtp-Source":"AMsMyM5ndy5aRggnx2/40xtb+MsylNCcv9yTZ1Y6wXaoyL9Hux73HfgBMXEsY49g9xo3u6VjDjcbbcaxm2USIvpsyXI=","X-Received":"by 2002:a05:6512:234a:b0:49d:3155:45a7 with SMTP id\n\tp10-20020a056512234a00b0049d315545a7mr11756358lfu.245.1664351461723;\n\tWed, 28 Sep 2022 00:51:01 -0700 (PDT)","MIME-Version":"1.0","References":"<20220926122911.13412-1-naush@raspberrypi.com>\n\t<20220926122911.13412-5-naush@raspberrypi.com>\n\t<20220928073336.t4safyzytth56sva@uno.localdomain>","In-Reply-To":"<20220928073336.t4safyzytth56sva@uno.localdomain>","Date":"Wed, 28 Sep 2022 08:50:46 +0100","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"multipart/alternative; boundary=\"000000000000a8644305e9b80594\"","Subject":"Re: [libcamera-devel] [PATCH v1 4/4] ipa: raspberrypi: Fix the\n\timx296 mono tuning black level","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]