[{"id":25147,"web_url":"https://patchwork.libcamera.org/comment/25147/","msgid":"<20220928070753.byauyuq4mzkf6u2z@uno.localdomain>","date":"2022-09-28T07:07:53","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix sensor delays\n\tfor the IMX296","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Naush\n\nOn Mon, Sep 26, 2022 at 10:36:13AM +0100, Naushir Patuck via libcamera-devel wrote:\n> The IMX296 implements a 2 frame delay for exposure, gain and vertical blanking\n> changes. Report this in the camera helper.\n>\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> ---\n> src/ipa/raspberrypi/cam_helper_imx296.cpp | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n>\n> diff --git a/src/ipa/raspberrypi/cam_helper_imx296.cpp b/src/ipa/raspberrypi/cam_helper_imx296.cpp\n> index ab1d157aaf45..09f828ea6249 100644\n> --- a/src/ipa/raspberrypi/cam_helper_imx296.cpp\n> +++ b/src/ipa/raspberrypi/cam_helper_imx296.cpp\n> @@ -23,6 +23,7 @@ public:\n> \tdouble gain(uint32_t gainCode) const override;\n> \tuint32_t exposureLines(Duration exposure) const override;\n> \tDuration exposure(uint32_t exposureLines) const override;\n> +\tvoid getDelays(int &exposureDelay, int &gainDelay, int &vblankDelay) const override;\n>\n> private:\n> \tstatic constexpr uint32_t maxGainCode = 239;\n> @@ -61,6 +62,14 @@ Duration CamHelperImx296::exposure(uint32_t exposureLines) const\n> \treturn exposureLines * timePerLine + 14.26us;\n> }\n>\n> +void CamHelperImx296::getDelays(int &exposureDelay, int &gainDelay,\n> +\t\t\t\tint &vblankDelay) const\n> +{\n> +\texposureDelay = 2;\n> +\tgainDelay = 2;\n> +\tvblankDelay = 2;\n> +}\n> +\n> static CamHelper *create()\n> {\n> \treturn new CamHelperImx296();\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7766BD16B\n\tfor ;\n\tWed, 28 Sep 2022 07:07:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7A68D62293;\n\tWed, 28 Sep 2022 09:07:57 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0649161F7A\n\tfor ;\n\tWed, 28 Sep 2022 09:07:56 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 912351C000A;\n\tWed, 28 Sep 2022 07:07:55 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664348877;\n\tbh=m/8MapjFxLqZ+zCUMc5Elf9n7gDJAZ9Ws/LX0X43yx4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SqvF+z/BINw7Qdlh3T6GXnVfKqFdIWgZ0HskV7BTBUUwSsqPWaEkbgCKMZKFq/KMZ\n\tlkYLZGOfXbBgE8ud8mLBurNFZcG4JenQCcx07PfmzpgOGFpP5SfHr2b4BRH2tMcXYn\n\tRQs1HsISYqy88wNDZI9Og+gpM7U/KXw2/MvxbheDu1/kePQng5+0D0M9ztkaxyqkGN\n\ttlE8erTCxbRxM8A+3pij/LeVyg6suFLYMqVBwJA6ljAYX0vexc8v4K+7GhjymZXigs\n\t4iFaCDUfRE2/YkZrxJ4pl9yYzMICrkDhVbsObrkr4SMtUh3JFP4Spsp2ciD6NNEm9x\n\tRtLi6tww/tnNg==","Date":"Wed, 28 Sep 2022 09:07:53 +0200","To":"Naushir Patuck ","Message-ID":"<20220928070753.byauyuq4mzkf6u2z@uno.localdomain>","References":"<20220926093613.29828-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220926093613.29828-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix sensor delays\n\tfor the IMX296","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25228,"web_url":"https://patchwork.libcamera.org/comment/25228/","msgid":"","date":"2022-10-03T09:27:04","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix sensor delays\n\tfor the IMX296","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the patch!\n\nOn Wed, 28 Sept 2022 at 08:07, Jacopo Mondi via libcamera-devel\n wrote:\n>\n> Hi Naush\n>\n> On Mon, Sep 26, 2022 at 10:36:13AM +0100, Naushir Patuck via libcamera-devel wrote:\n> > The IMX296 implements a 2 frame delay for exposure, gain and vertical blanking\n> > changes. Report this in the camera helper.\n> >\n> > Signed-off-by: Naushir Patuck \n>\n> Reviewed-by: Jacopo Mondi \n>\n\nReviewed-by: David Plowman \n\nThanks\nDavid\n\n> Thanks\n> j\n> > ---\n> > src/ipa/raspberrypi/cam_helper_imx296.cpp | 9 +++++++++\n> > 1 file changed, 9 insertions(+)\n> >\n> > diff --git a/src/ipa/raspberrypi/cam_helper_imx296.cpp b/src/ipa/raspberrypi/cam_helper_imx296.cpp\n> > index ab1d157aaf45..09f828ea6249 100644\n> > --- a/src/ipa/raspberrypi/cam_helper_imx296.cpp\n> > +++ b/src/ipa/raspberrypi/cam_helper_imx296.cpp\n> > @@ -23,6 +23,7 @@ public:\n> > double gain(uint32_t gainCode) const override;\n> > uint32_t exposureLines(Duration exposure) const override;\n> > Duration exposure(uint32_t exposureLines) const override;\n> > + void getDelays(int &exposureDelay, int &gainDelay, int &vblankDelay) const override;\n> >\n> > private:\n> > static constexpr uint32_t maxGainCode = 239;\n> > @@ -61,6 +62,14 @@ Duration CamHelperImx296::exposure(uint32_t exposureLines) const\n> > return exposureLines * timePerLine + 14.26us;\n> > }\n> >\n> > +void CamHelperImx296::getDelays(int &exposureDelay, int &gainDelay,\n> > + int &vblankDelay) const\n> > +{\n> > + exposureDelay = 2;\n> > + gainDelay = 2;\n> > + vblankDelay = 2;\n> > +}\n> > +\n> > static CamHelper *create()\n> > {\n> > return new CamHelperImx296();\n> > --\n> > 2.25.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F07FC0DA4\n\tfor ;\n\tMon, 3 Oct 2022 09:27:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9AC8F62CDA;\n\tMon, 3 Oct 2022 11:27:18 +0200 (CEST)","from mail-pl1-x631.google.com (mail-pl1-x631.google.com\n\t[IPv6:2607:f8b0:4864:20::631])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F8FF61F74\n\tfor ;\n\tMon, 3 Oct 2022 11:27:17 +0200 (CEST)","by mail-pl1-x631.google.com with SMTP id 10so5568923pli.0\n\tfor ;\n\tMon, 03 Oct 2022 02:27:16 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664789238;\n\tbh=+fnUxB3vM1IWe5dYPAyCeOI7fHJopP3vArijKeVQv4U=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=iwuwJakLuwRjw8nt6K17mixI0SyeJud2t40BkJUwrwEMwwF8p2rSM9o21QD5GaUPk\n\tm+oexznzgxgXF4pJTt2uW9BwqjX7FItEul9mTjSUqLs5rqByBzzUwistaM/sceHsf9\n\t9hceyyhPDjNrm1b8WUqapBAZIVD3prDDnbnx9qSEDCcvnLScakTc/K/H5C2CYqNgGY\n\tKLHnOtNmY5UqBHDvAUWz6WogQViH68kSD4awAkA3n5UBrbOQ1n6MMHv3eGn8Gp4UJt\n\tccolrmAkgFlpz/i0QbIU8eyzBzTGpRodgy/SIhGTIf06mSODIkFae5Pc64oRFC7NU4\n\tW/MgzHB0VHitw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date;\n\tbh=Hdl0XtV7NnzrqY46HaHLisSBQa3TABU0MZfZWxT833c=;\n\tb=Y9Ox0Y+mksNmjuOO08ut6S1IU8iXbHRCaYzKYGciKAnPnCsmdjQvZUVFfqxjUfU4ts\n\tWODAsnn3FsOA20h0UDKUExOz2kYiPKTA9aOF1MPWRnlbXSvH/5S9R19hvFpUh73FTYev\n\tRg5ZTd7nFSsRq6sgWw6Oc00iQjd5PytTh8tQESYMsG0Hgo7hkvirgsifaFCYjr8230jF\n\tGw9eypONLd1yzEaJxDEhW9p3VjMz5VtnjVuuaN3RoctPC2xZeXfd15JnsKthD+8pQpRI\n\t8VhuU85LL23oTwjCLoLodff06RyM8KrLAikIJe+CdC1P9VrXzMTxp8MpdxyzU5PQ6tGM\n\tef0w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Y9Ox0Y+m\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date;\n\tbh=Hdl0XtV7NnzrqY46HaHLisSBQa3TABU0MZfZWxT833c=;\n\tb=MmyRQxRYHDm5SQlJh3IKtrP+KjvZVz6HRXS2ipHx5E+xU5hP/zEjDrtexFOzY6z6qR\n\tMF5Pgsj072KIK7odFejMt6YQIQU3pcOHUa+x7S8srPmgIuhghPHbVo6QvS5C8NCN/bg0\n\tbKwhq1+jj/m9zx6u5eZtgmN/yq9P4gMRZcaWkPYf99OlJ3IZ15mSJFbf9idM3lNLb/Vw\n\tKfmsWmnsBVmRDdK8riLcEY5ZiTkaOHYJyzoauvsdh/XxxvcuPq9VOlaKdhp0mGCpViaq\n\tStxgH+ZfdVKtTjx2toZt2d6TtoB5KaYyeQTdotisNBZPQG9XZLTxi5p4RvXdg3A5kIxJ\n\t6fJA==","X-Gm-Message-State":"ACrzQf1cVg5eAhHmotmjMhHivF6iQDobeGlVBN6JO10WFXGt1PwpeOXw\n\tRG2pAsS7wpU0PLvaXErGQoyzHtoilQXrcVW4o2LfZw==","X-Google-Smtp-Source":"AMsMyM6IXChmWv6W+pJRnj+Z/ypVd7m7gGbLrEIQRdBr3OcezLmhVbJChDlZryQREdgG0Yz1z8qyeZ2C05l4ennz9Zo=","X-Received":"by 2002:a17:902:ce81:b0:178:8e0a:5615 with SMTP id\n\tf1-20020a170902ce8100b001788e0a5615mr21687429plg.109.1664789235309;\n\tMon, 03 Oct 2022 02:27:15 -0700 (PDT)","MIME-Version":"1.0","References":"<20220926093613.29828-1-naush@raspberrypi.com>\n\t<20220928070753.byauyuq4mzkf6u2z@uno.localdomain>","In-Reply-To":"<20220928070753.byauyuq4mzkf6u2z@uno.localdomain>","Date":"Mon, 3 Oct 2022 10:27:04 +0100","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix sensor delays\n\tfor the IMX296","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]