{"id":17395,"url":"https://patchwork.libcamera.org/api/patches/17395/?format=json","web_url":"https://patchwork.libcamera.org/patch/17395/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220926093613.29828-1-naush@raspberrypi.com>","date":"2022-09-26T09:36:13","name":"[libcamera-devel] ipa: raspberrypi: Fix sensor delays for the IMX296","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5f0daef0b750d4b8340e5cf36964bf2977c77563","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17395/mbox/","series":[{"id":3501,"url":"https://patchwork.libcamera.org/api/series/3501/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3501","date":"2022-09-26T09:36:13","name":"[libcamera-devel] ipa: raspberrypi: Fix sensor delays for the IMX296","version":1,"mbox":"https://patchwork.libcamera.org/series/3501/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17395/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17395/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5EB4C0DA4\n\tfor ;\n\tMon, 26 Sep 2022 09:36:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2596E6224D;\n\tMon, 26 Sep 2022 11:36:18 +0200 (CEST)","from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DE5861F7C\n\tfor ;\n\tMon, 26 Sep 2022 11:36:16 +0200 (CEST)","by mail-wm1-x333.google.com with SMTP id l8so4070399wmi.2\n\tfor ;\n\tMon, 26 Sep 2022 02:36:16 -0700 (PDT)","from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tn5-20020a05600c3b8500b003b5054c6f87sm10649956wms.21.2022.09.26.02.36.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 26 Sep 2022 02:36:15 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664184978;\n\tbh=Bgczjz6S9dTZu0HHZ4ylLyIBCMOXWqxMfm9a2RGVu1E=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=q7UBq1DIgrXC+8FbOc7NM8U4qXniz1htMxJZheD7NfGq3QYKwRHdQHco2ji5oVpzg\n\ti/MlL+r/K0vVcKg35g5obo/+7+9fTi1nmjkg/amS+tN4KivcYWJezu0eQbmOBF+JLb\n\trAXdMq3hhGzr6MnFTkF2TGWyUpXYTtaSiUpoT/+ZD9aXNL1JkrMK8DDgIv4naDWlTk\n\tmIlMwzfDLQ4o5oRUL9Ae4VHO9oIuzuTwn+Wqazja7PikbMUfcAC2JZe6lUMgznX5My\n\tby6jKdJSTfO3/9KAhicnXdq1WbwutEPhYzHNYR99Eyo8RhUNCRh4XX9OguVbICh76e\n\tqdUhRuYKPVH1g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date;\n\tbh=vvTvS6K/KgANWo0Eoe1G5amqDl4mlX3OozLvj9NfGtw=;\n\tb=j8TE2ZqeKk7EiLUgfwdtbKCbLrvMud+nbGYS95n4zEjYTHVzRpLHDth/5YQufPHNH/\n\tYzxvqpkKbvH6/a3J+bKenKryeLJy6f954wOJRkjq3RTbfPZHVIac6hOhy1Vvnm6WbHUU\n\tIdtjn8abS+eFltzaEJrK6kxeZBKi3q64AfQjWUfnc4iKhZt6ElYW88WaClY4BVzTwr8n\n\tzn2+SHrDBxMbvXbLvenpw4JrM3JDuluhog58Em22kMMcQJ1hUvtkuaCTYghCAwoYEa4l\n\ttXeCV2QmIgxmRw79dagzKXSybF2sWpO4cjuUI06EHh4ViDVMqsqbDSGEwS5dnoPGgkUe\n\tsS8g=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"j8TE2Zqe\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date;\n\tbh=vvTvS6K/KgANWo0Eoe1G5amqDl4mlX3OozLvj9NfGtw=;\n\tb=k6qkjlqQSXGNy7HE8leYRu1tacqATthwMchV+Ta8gNkwmFpGjv7qnL/yOw5xacAbeo\n\tTWN5qZ3vROkJheLedd6hhNrNTWhkvWN0/lnghPNxytbOT6t5W0ziywxh8fg7AGfG/m7w\n\tDIopeDheGNiMNTjfh96hmyH1DKCrhzcojtub2U17uPomjRKAjXnRmnJiRk/bO4nrm88F\n\tj1cOe1tuJUn8rV3NNK27LwDp5g3mTHNQU41J1f/urcRkIrix9Bl1vMLfiHkV2Zx7GKgM\n\tuo3dC7+oNqYHNjdDdxXL6HnS6z+UTXsCvaItI6eUqWYTDANqpP2+mEW+shC6CHVHhJyx\n\tqaLA==","X-Gm-Message-State":"ACrzQf33CWxgp4O6sWhgPxBT1tYQY8j8NQpapPRekDFkdW5yxnP8B52f\n\t6PRmKw8hmf+JlP4AaY3MHC79hpTSqcWRfCfN","X-Google-Smtp-Source":"AMsMyM5hq2N+WET6pBQFXIF3itCKERUWwig/EMsx/jLILXPrpp0QnboqCHB615Q3rNleuuEdcgexqw==","X-Received":"by 2002:a1c:7315:0:b0:3b4:e1b8:47b2 with SMTP id\n\td21-20020a1c7315000000b003b4e1b847b2mr14155725wmb.165.1664184975603; \n\tMon, 26 Sep 2022 02:36:15 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 26 Sep 2022 10:36:13 +0100","Message-Id":"<20220926093613.29828-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: raspberrypi: Fix sensor delays for\n\tthe IMX296","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IMX296 implements a 2 frame delay for exposure, gain and vertical blanking\nchanges. Report this in the camera helper.\n\nSigned-off-by: Naushir Patuck \n---\n src/ipa/raspberrypi/cam_helper_imx296.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/src/ipa/raspberrypi/cam_helper_imx296.cpp b/src/ipa/raspberrypi/cam_helper_imx296.cpp\nindex ab1d157aaf45..09f828ea6249 100644\n--- a/src/ipa/raspberrypi/cam_helper_imx296.cpp\n+++ b/src/ipa/raspberrypi/cam_helper_imx296.cpp\n@@ -23,6 +23,7 @@ public:\n \tdouble gain(uint32_t gainCode) const override;\n \tuint32_t exposureLines(Duration exposure) const override;\n \tDuration exposure(uint32_t exposureLines) const override;\n+\tvoid getDelays(int &exposureDelay, int &gainDelay, int &vblankDelay) const override;\n \n private:\n \tstatic constexpr uint32_t maxGainCode = 239;\n@@ -61,6 +62,14 @@ Duration CamHelperImx296::exposure(uint32_t exposureLines) const\n \treturn exposureLines * timePerLine + 14.26us;\n }\n \n+void CamHelperImx296::getDelays(int &exposureDelay, int &gainDelay,\n+\t\t\t\tint &vblankDelay) const\n+{\n+\texposureDelay = 2;\n+\tgainDelay = 2;\n+\tvblankDelay = 2;\n+}\n+\n static CamHelper *create()\n {\n \treturn new CamHelperImx296();\n","prefixes":["libcamera-devel"]}