[{"id":25000,"web_url":"https://patchwork.libcamera.org/comment/25000/","msgid":"","date":"2022-09-19T17:01:31","subject":"Re: [libcamera-devel] [PATCH] ipa: meson: Fix identation","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the fix.\n\nOn 9/19/22 10:30 PM, Laurent Pinchart wrote:\n> meson.build files are indented with 4 spaces, not 2.\n\nops :-S\n\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n> ---\n> src/ipa/meson.build | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index e972bbe896b0..76ad5b445601 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -31,8 +31,8 @@ ipa_modules = get_option('ipas')\n> # Tests require the vimc IPA, similar to vimc pipline-handler for their\n> # execution. Include it automatically when tests are enabled.\n> if get_option('test') and 'vimc' not in ipa_modules\n> - message('Enabling vimc IPA to support tests')\n> - ipa_modules += ['vimc']\n> + message('Enabling vimc IPA to support tests')\n> + ipa_modules += ['vimc']\n> endif\n> \n> enabled_ipa_modules = []\n>\n> base-commit: 74ab3f778c848b20cbf8fe299170756ff6ebab1a","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D644EC0DA4\n\tfor ;\n\tMon, 19 Sep 2022 17:01:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 882FA62194;\n\tMon, 19 Sep 2022 19:01:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D534361F85\n\tfor ;\n\tMon, 19 Sep 2022 19:01:39 +0200 (CEST)","from [IPV6:2409:4052:61f:3157:5bc5:64a0:9696:6774] (unknown\n\t[IPv6:2409:4052:61f:3157:5bc5:64a0:9696:6774])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A7B3D02;\n\tMon, 19 Sep 2022 19:01:37 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663606901;\n\tbh=9Wh6gVOhou0HsoeIuMlL9knF3Epss3Su0mgS8ZfcIH8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=npkPNX64wFKnInaF65U8aWfJbjd5sEa3zd5i7M6+sbCVuODXfPTkVSTWg/RojBeAE\n\tKFLLKmmZPo07kXj0hmjyo+KlfErwcRqeY5bqAoSv3W8e1ZxzlMCu18YY/+evTPWISd\n\tU9vlt3t+xLjRmTBlgiuhJSjXfSl9paepaABSJcUZEESYBhvOHw2FuHEFF33av5S3Sm\n\tOP3mC1oHzs24NLOwfj9UxnO9UUQfRHs8M1PZ8U7jJ/bRbrpp/Gd+Pl0rubbiLS4hOU\n\trck1I0UugKQrmeb3jAXCdC+DClXx7hPSlA++eWv1c5gVfplGWHpMmArPc3uM9AY14P\n\tbotp1q/EFFHoQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663606899;\n\tbh=9Wh6gVOhou0HsoeIuMlL9knF3Epss3Su0mgS8ZfcIH8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Vdvzr86eS8Pg0VNRHzSs7DRIzkZ1DSocbcXOGjwd64/jc+XztBISwzsJYDzxJC4M+\n\tBUs95zjPjZKC5iNTepZC3GdYee+KS/PjXsbX1c/vlVXZdZpyXnNve9AGH+sTMopHfe\n\tU4RwUUoBSUQ9Yx44FwQ7RFKatQLGgv2M4LY/gwh8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Vdvzr86e\"; dkim-atps=neutral","Message-ID":"","Date":"Mon, 19 Sep 2022 22:31:31 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.2.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220919170000.12878-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220919170000.12878-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] ipa: meson: Fix identation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25005,"web_url":"https://patchwork.libcamera.org/comment/25005/","msgid":"<166362686517.3399646.985611881249230212@Monstersaurus>","date":"2022-09-19T22:34:25","subject":"Re: [libcamera-devel] [PATCH] ipa: meson: Fix identation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-09-19 18:00:00)\n> meson.build files are indented with 4 spaces, not 2.\n> \n\nHrm ... I thought we had a checkstyle rule to catch this ?\n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/meson.build | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index e972bbe896b0..76ad5b445601 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -31,8 +31,8 @@ ipa_modules = get_option('ipas')\n> # Tests require the vimc IPA, similar to vimc pipline-handler for their\n> # execution. Include it automatically when tests are enabled.\n> if get_option('test') and 'vimc' not in ipa_modules\n> - message('Enabling vimc IPA to support tests')\n> - ipa_modules += ['vimc']\n> + message('Enabling vimc IPA to support tests')\n> + ipa_modules += ['vimc']\n> endif\n> \n> enabled_ipa_modules = []\n> \n> base-commit: 74ab3f778c848b20cbf8fe299170756ff6ebab1a\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5349C0DA4\n\tfor ;\n\tMon, 19 Sep 2022 22:34:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42CF762199;\n\tTue, 20 Sep 2022 00:34:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 964D461FAC\n\tfor ;\n\tTue, 20 Sep 2022 00:34:28 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E0986DB;\n\tTue, 20 Sep 2022 00:34:28 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663626870;\n\tbh=nyzufHZPgoPTeVcvq/1hnco6BTZzU88apHPbysFDDuw=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=aExTWqJ4UFfTaypxmNTU3kSuJUQaiI4LbKZFOf5ti/oV5oLDQ1AsO+s5fbSvmLENc\n\toawgaFFJgnOCO+0tQXPl5poxD1kEKlc/tyx6AilXLiipKOfCdRTX1u6hzf/aDptpcT\n\tAuPYhbc2UGcZlZCXZThnhVXzvJPxa45OoeiI9PUx5/G+wduYZkF5F8Fe2kDBQ6spgF\n\tJ7H0X3jkDI70vfgZdakpGBA/Tbc6QVxuI45jZV3F/4hWbveui36BJ6pvHbq2/cT8oS\n\tP98yvmRe52cSbavIUPdgsitY8DJQjl4JdEey/nOc4pFhEgaiQfYakA2jQWvG6TIOoa\n\tNqspgWqqR5Yhg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663626868;\n\tbh=nyzufHZPgoPTeVcvq/1hnco6BTZzU88apHPbysFDDuw=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=TzXyQPNXi/syFT1ruX1b3sAOwoP/gO25cYRsvI5ycOTP6VSWja+rSMilM8iHWcHhA\n\tkJ2WM0etLqGbSPXE/zzWBj2B7tPIzcqsnScnfHP/28otzFZHkOhNDBBs83GKkU1t2j\n\tP5/vFH7ySAq2lu66Qa7LAHHMMT31Lx8QA9WYGYBY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"TzXyQPNX\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220919170000.12878-1-laurent.pinchart@ideasonboard.com>","References":"<20220919170000.12878-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 19 Sep 2022 23:34:25 +0100","Message-ID":"<166362686517.3399646.985611881249230212@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] ipa: meson: Fix identation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25006,"web_url":"https://patchwork.libcamera.org/comment/25006/","msgid":"","date":"2022-09-19T22:40:05","subject":"Re: [libcamera-devel] [PATCH] ipa: meson: Fix identation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Sep 19, 2022 at 11:34:25PM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-09-19 18:00:00)\n> > meson.build files are indented with 4 spaces, not 2.\n> \n> Hrm ... I thought we had a checkstyle rule to catch this ?\n\nWe only check that spaces are used for indentation, not tabs. Patches\nare welcome :-) It would not be trivial though.\n\n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/ipa/meson.build | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> > index e972bbe896b0..76ad5b445601 100644\n> > --- a/src/ipa/meson.build\n> > +++ b/src/ipa/meson.build\n> > @@ -31,8 +31,8 @@ ipa_modules = get_option('ipas')\n> > # Tests require the vimc IPA, similar to vimc pipline-handler for their\n> > # execution. Include it automatically when tests are enabled.\n> > if get_option('test') and 'vimc' not in ipa_modules\n> > - message('Enabling vimc IPA to support tests')\n> > - ipa_modules += ['vimc']\n> > + message('Enabling vimc IPA to support tests')\n> > + ipa_modules += ['vimc']\n> > endif\n> > \n> > enabled_ipa_modules = []\n> > \n> > base-commit: 74ab3f778c848b20cbf8fe299170756ff6ebab1a","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E56EDC3272\n\tfor ;\n\tMon, 19 Sep 2022 22:40:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 33EFC6219A;\n\tTue, 20 Sep 2022 00:40:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 920AE61F7E\n\tfor ;\n\tTue, 20 Sep 2022 00:40:19 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9FEC6DB;\n\tTue, 20 Sep 2022 00:40:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663627220;\n\tbh=F2vQmF2l8yONYyqNWorzPpAOdJnaDOMByYBNovUPH0M=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=YQssMx3/Q+OZZSKYPzEQwEwVISvN4V4bMG6bbgnHTEEF/5PtGBw46eqSQ6g8f+XkO\n\tgv7N5b4Sz8rnuP9IGI+X8uTAln9VAxVSwb4ZspyROmQQT0M5U2n9NVsgXjSSPGWgKV\n\tfbtqoP6S2vP9vAp+16nVab+bc/JiUK4S0TXuTYB4rlHTqyV1Ayw5YyHgUeGRnfAWQi\n\txU1VoNo+zXRmK7DtWzcDjuoD/mXtSqxNrq/8VlJJs0hDCuxixU9gBD+ISurto2MGhK\n\tCJ3cXu90qJH9xVU/nHo/nzVGlm0aZyD1MGuHE8GVHyAtmsLz/b+eY2vw51glpe8r4k\n\tE6E1PMHcA4XHw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663627219;\n\tbh=F2vQmF2l8yONYyqNWorzPpAOdJnaDOMByYBNovUPH0M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=n3DcsJ+BfYAKWf5f8UkzwodTv1c4kA58oQCfi3bsir/3c1gbbDDl7Ikv7+CvkeV8r\n\tV/5v72XfVz4e4BiuYa92VTQ5DIDSItEVlKibwRsOk4ibDFOOcBCoZp9oAODHA80Hef\n\trfZ72nlVoFYJftJswWk79QEbKI4lMHer1FXIMQBY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"n3DcsJ+B\"; dkim-atps=neutral","Date":"Tue, 20 Sep 2022 01:40:05 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220919170000.12878-1-laurent.pinchart@ideasonboard.com>\n\t<166362686517.3399646.985611881249230212@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166362686517.3399646.985611881249230212@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] ipa: meson: Fix identation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]