[{"id":2327,"web_url":"https://patchwork.libcamera.org/comment/2327/","msgid":"<20190807090515.GC5048@pendragon.ideasonboard.com>","date":"2019-08-07T09:05:15","subject":"Re: [libcamera-devel] [PATCH v2 2/6] include: android: Add Android\n\theaders from Cros","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Aug 06, 2019 at 09:55:14PM +0200, Jacopo Mondi wrote:\n> Copy the Android Camera3 HAL headers from the ChromiumOS build system\n> and define a new inclusion directive in the meson build system for them.\n> \n> The header files have been copied from:\n> https://chromium.googlesource.com/chromiumos/platform2\n> at revision 9e65ddd2c496e712f005ada9715decd2ff8e4a03\n> and provide:\n> \n> 1) Android CameraHAL3 HAL headers in include/android/hardware/\n> 2) The Android system headers in include/android/system/\n> 3) The Android camera metadata headers in include/android/metadata/\n> \n> The original path in the Cros platform2/ repository is, respectively:\n> camera/android/header_files/include/hardware\n> camera/android/header_files/include/system\n> camera/android/libcamera_metadata/include/\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> .../libhardware/include/hardware/camera3.h | 3093 +++++++++++++++++\n> .../include/hardware/camera_common.h | 916 +++++\n> .../libhardware/include/hardware/fb.h | 173 +\n> .../libhardware/include/hardware/gralloc.h | 384 ++\n> .../libhardware/include/hardware/hardware.h | 238 ++\n> include/android/meson.build | 5 +\n> .../android/metadata/camera_metadata_hidden.h | 100 +\n> .../android/metadata/system/camera_metadata.h | 580 ++++\n> .../metadata/system/camera_metadata_tags.h | 1005 ++++++\n> .../metadata/system/camera_vendor_tags.h | 158 +\n> .../android/system/core/include/android/log.h | 144 +\n> .../system/core/include/cutils/compiler.h | 44 +\n> .../core/include/cutils/native_handle.h | 69 +\n> .../system/core/include/system/camera.h | 298 ++\n> .../system/core/include/system/graphics.h | 763 ++++\n> .../system/core/include/system/window.h | 954 +++++\n> include/meson.build | 1 +\n> 17 files changed, 8925 insertions(+)\n> create mode 100644 include/android/hardware/libhardware/include/hardware/camera3.h\n> create mode 100644 include/android/hardware/libhardware/include/hardware/camera_common.h\n> create mode 100644 include/android/hardware/libhardware/include/hardware/fb.h\n> create mode 100644 include/android/hardware/libhardware/include/hardware/gralloc.h\n> create mode 100644 include/android/hardware/libhardware/include/hardware/hardware.h\n> create mode 100644 include/android/meson.build\n> create mode 100644 include/android/metadata/camera_metadata_hidden.h\n> create mode 100644 include/android/metadata/system/camera_metadata.h\n> create mode 100644 include/android/metadata/system/camera_metadata_tags.h\n> create mode 100644 include/android/metadata/system/camera_vendor_tags.h\n> create mode 100644 include/android/system/core/include/android/log.h\n\nI think this file can be dropped.\n\n> create mode 100644 include/android/system/core/include/cutils/compiler.h\n> create mode 100644 include/android/system/core/include/cutils/native_handle.h\n> create mode 100644 include/android/system/core/include/system/camera.h\n> create mode 100644 include/android/system/core/include/system/graphics.h\n> create mode 100644 include/android/system/core/include/system/window.h\n\n[snip]\n\n> diff --git a/include/android/meson.build b/include/android/meson.build\n> new file mode 100644\n> index 000000000000..0fe40dabe1d5\n> --- /dev/null\n> +++ b/include/android/meson.build\n> @@ -0,0 +1,5 @@\n> +android_includes = ([\n> + include_directories('hardware/libhardware/include/'),\n> + include_directories('system/core/include'),\n> + include_directories('metadata/'),\n\nMaybe sort them alphabetically ?\n\nReviewed-by: Laurent Pinchart \n\n> +])\n\n[snip]","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ECAB0615FF\n\tfor ;\n\tWed, 7 Aug 2019 11:05:19 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 27D0D814;\n\tWed, 7 Aug 2019 11:05:19 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565168719;\n\tbh=tfLO7Yy/PD+mIvhX+W/44/3ArI4+QseQ5uDLVr5bfGc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cLdBV1ZmwkacotR6ynS9CpDtdRZ1G6zdwpTu++6xh09ipAHIgjdFZJeN/I5Dd8uRt\n\tGjnE130fT8GkZYGHvOZGjhIJnZAs6+HWafFRVnk2ZA4DekbKgIqwdMDW8BBrJQppc7\n\t9Mpr8FSNgh8ppjP4IxoN79Kgr+Wt73dJkGqr9hPg=","Date":"Wed, 7 Aug 2019 12:05:15 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190807090515.GC5048@pendragon.ideasonboard.com>","References":"<20190806195518.16739-1-jacopo@jmondi.org>\n\t<20190806195518.16739-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190806195518.16739-3-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 2/6] include: android: Add Android\n\theaders from Cros","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 07 Aug 2019 09:05:20 -0000"}}]