[{"id":25144,"web_url":"https://patchwork.libcamera.org/comment/25144/","msgid":"<20220928063412.qy6op2n3nryxanrp@uno.localdomain>","date":"2022-09-28T06:34:12","subject":"Re: [libcamera-devel] [PATCH 2/3] ipa: ipu3: Drive requestQueue\n\twhen controls are accepted","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kate,\n\nOn Fri, Sep 16, 2022 at 06:37:12PM +0800, Kate Hsuan via libcamera-devel wrote:\n> Drive and dispatch the controls to the algorithms when the controls\n> are received.\n>\n> Signed-off-by: Kate Hsuan \n> ---\n> src/ipa/ipu3/ipu3.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index ac0c42a7..4f64a546 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -657,6 +657,9 @@ void IPAIPU3::queueRequest(const uint32_t frame, const ControlList &controls)\n> {\n> \t/* \\todo Start processing for 'frame' based on 'controls'. */\n> \tcontext_.frameContexts[frame % kMaxFrameContexts] = { frame, controls };\n> +\n> +\tfor (auto const &algo : algorithms())\n> +\t\talgo->queueRequest(context_, frame, controls);\n\nCould you rebase on master now that\nhttps://patchwork.libcamera.org/project/libcamera/list/?series=3506\n\nhas been merged and this part has been implemented already.\n\nAlso a nudge to Daniel (in cc) that was waiting for that series to get\nin to progress with RkISP1 AF implementation.\n\nThanks\n j\n\n> }\n>\n> /**\n> --\n> 2.37.3\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 570D5BD16B\n\tfor ;\n\tWed, 28 Sep 2022 06:34:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78CD56228E;\n\tWed, 28 Sep 2022 08:34:16 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9911561F78\n\tfor ;\n\tWed, 28 Sep 2022 08:34:14 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id B018340002;\n\tWed, 28 Sep 2022 06:34:13 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664346856;\n\tbh=SNtOPd5oi7MKrjzViDed6noVR9Ow5S8QHKkelJuXMus=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=c6Ux6eAb6dAnfKbwaV0se5vdbXmxVh62dSScj22Hvuh1PAX1VFalV4xraNKv6dBF0\n\tvqQVT0zbN+HLFth7+cbWyWpHe6M34bStAbkZpaWqiUPF7rO5ENhNWG8oNTgtJidzpC\n\tmfRE5bH5us05Actrc6CLQP68O6iYhtJZYQMWuZ5v0UFLbLLxwz5RCXsh59SJGq3ejT\n\tXxlxLH2S8cjz4xkITElf3LnOqEDxxwITG2xc4+69N4tJHajIaE4HwE9j7gHmw8QnUn\n\tP3HID8nieeu0hJmVausZgMQjzIEIHWsKJgVE9ZLOBvZmCuYH4ywHA02iT/auO04LUK\n\tXhbw0hdhOZpbw==","Date":"Wed, 28 Sep 2022 08:34:12 +0200","To":"Kate Hsuan ","Message-ID":"<20220928063412.qy6op2n3nryxanrp@uno.localdomain>","References":"<20220916103713.21132-1-hpa@redhat.com>\n\t<20220916103713.21132-3-hpa@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220916103713.21132-3-hpa@redhat.com>","Subject":"Re: [libcamera-devel] [PATCH 2/3] ipa: ipu3: Drive requestQueue\n\twhen controls are accepted","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]