[{"id":24987,"web_url":"https://patchwork.libcamera.org/comment/24987/","msgid":"<20220915005925.GA1055504@pyrite.rasen.tech>","date":"2022-09-15T00:59:25","subject":"Re: [libcamera-devel] [PATCH] meson: Enable vimc IPA for tests","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Wed, Sep 14, 2022 at 04:28:59PM +0530, Umang Jain via libcamera-devel wrote:\n> Vimc pipeline handler is enabled unconditionally if the meson config\n> option '-Dtest' is true. However, this is not true for the vimc IPA.\n> Hence, a meson configuration such as:\n> \n> -Dpipelines=raspberrypi -Dipas=raspberrypi -Dtest=true\n> \n> will include the vimc pipeline handler (in addition to raspberrypi)\n> but will skip the vimc IPA which can lead to failure of unit tests\n> that depends on vimc to execute.\n> \n> One such unit test was identified as a result of this issue on\n> RaspberryPi:\n> \n> ERROR IPAModule ipa_module.cpp:278 ipa_vimc.so: Failed to open IPA library: No such file or directory\n> test IPA module src/ipa/vimc/ipa_vimc.so is invalid\n> \n> due to the non-existent ipa_vimc.so.\n> \n> Fix this by including the vimc IPA unconditionally when the tests are\n> enabled, similar to how the vim pipeline-handler is included.\n> \n> Fixes: 6e65d4225736 (\"libcamera: Enable vimc pipeline handler when tests are enabled\")\n> Signed-off-by: Umang Jain \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/meson.build | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index 849bb372..e972bbe8 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -27,6 +27,14 @@ ipa_sign = files('ipa-sign.sh')\n> ipa_names = []\n> \n> ipa_modules = get_option('ipas')\n> +\n> +# Tests require the vimc IPA, similar to vimc pipline-handler for their\n> +# execution. Include it automatically when tests are enabled.\n> +if get_option('test') and 'vimc' not in ipa_modules\n> + message('Enabling vimc IPA to support tests')\n> + ipa_modules += ['vimc']\n> +endif\n> +\n> enabled_ipa_modules = []\n> \n> # The ipa-sign-install.sh script which uses the ipa_names variable will itself\n> -- \n> 2.37.3\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1869DC3272\n\tfor ;\n\tThu, 15 Sep 2022 00:59:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5950661FA9;\n\tThu, 15 Sep 2022 02:59:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8597461F83\n\tfor ;\n\tThu, 15 Sep 2022 02:59:33 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E1972DD;\n\tThu, 15 Sep 2022 02:59:31 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663203575;\n\tbh=C++icKe0Vs0n0NpFDiwOQLPpBV4BvhfVe7ZLErFkUAk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=YmaV50/FveQq4Rp9fOWmr+3GguMfillA0lmH9Mrrgo9yIrTCaHviTFq4PVDpVdS2n\n\t4s6P23DPaWnwyipVTa8OIYD9D0u3Xvip5AVjwzShKfG+T0lyXgLcu7Iti/sXkN9wTK\n\tCql79XTTHuyf/N8KXRB+H4gvxK8qHu5oNg4UU+AGwBWcHBtobVoCciFkmEvHBSi5hJ\n\tqk/wOSruwxYLl9QqncpJeG1jEm7YzLgEK1s8+5VqjRSNNnoXF4MFZBDG1M34BIGbl2\n\tb39ngQ1aVHFsXpjWBHf+oKxzLgp5VGGFDANTEPBun4CPL/4ivOihZUkPI9nbP2xILv\n\txcM2PHU0uJqOg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663203573;\n\tbh=C++icKe0Vs0n0NpFDiwOQLPpBV4BvhfVe7ZLErFkUAk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mnF7tfoVI3CrrjiZgkz2xCCXwSrG399YLp9IngixmuJs4UI23Uk7jbVZr/0TDILgN\n\ttigHAuDljxWYetsFTuD/rI3/2HroiunLVvDlY1vawT+DtDeQLBexn/DL29RR90cZ3j\n\tQOLCWYwfHCdGZU4XDeDIVn4n+Ed5uAuZJ4A8a3/I="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"mnF7tfoV\"; dkim-atps=neutral","Date":"Thu, 15 Sep 2022 09:59:25 +0900","To":"Umang Jain ","Message-ID":"<20220915005925.GA1055504@pyrite.rasen.tech>","References":"<20220914105859.124524-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220914105859.124524-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] meson: Enable vimc IPA for tests","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24988,"web_url":"https://patchwork.libcamera.org/comment/24988/","msgid":"<166323176421.4088395.641972707781086087@Monstersaurus>","date":"2022-09-15T08:49:24","subject":"Re: [libcamera-devel] [PATCH] meson: Enable vimc IPA for tests","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder via libcamera-devel (2022-09-15 01:59:25)\n> On Wed, Sep 14, 2022 at 04:28:59PM +0530, Umang Jain via libcamera-devel wrote:\n> > Vimc pipeline handler is enabled unconditionally if the meson config\n> > option '-Dtest' is true. However, this is not true for the vimc IPA.\n> > Hence, a meson configuration such as:\n> > \n> > -Dpipelines=raspberrypi -Dipas=raspberrypi -Dtest=true\n> > \n> > will include the vimc pipeline handler (in addition to raspberrypi)\n> > but will skip the vimc IPA which can lead to failure of unit tests\n> > that depends on vimc to execute.\n> > \n> > One such unit test was identified as a result of this issue on\n> > RaspberryPi:\n> > \n> > ERROR IPAModule ipa_module.cpp:278 ipa_vimc.so: Failed to open IPA library: No such file or directory\n> > test IPA module src/ipa/vimc/ipa_vimc.so is invalid\n> > \n> > due to the non-existent ipa_vimc.so.\n> > \n> > Fix this by including the vimc IPA unconditionally when the tests are\n> > enabled, similar to how the vim pipeline-handler is included.\n> > \n> > Fixes: 6e65d4225736 (\"libcamera: Enable vimc pipeline handler when tests are enabled\")\n> > Signed-off-by: Umang Jain \n> \n> Reviewed-by: Paul Elder \n> \n\nOhh good fix.\n\nReviewed-by: Kieran Bingham \n\n> > ---\n> > src/ipa/meson.build | 8 ++++++++\n> > 1 file changed, 8 insertions(+)\n> > \n> > diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> > index 849bb372..e972bbe8 100644\n> > --- a/src/ipa/meson.build\n> > +++ b/src/ipa/meson.build\n> > @@ -27,6 +27,14 @@ ipa_sign = files('ipa-sign.sh')\n> > ipa_names = []\n> > \n> > ipa_modules = get_option('ipas')\n> > +\n> > +# Tests require the vimc IPA, similar to vimc pipline-handler for their\n> > +# execution. Include it automatically when tests are enabled.\n> > +if get_option('test') and 'vimc' not in ipa_modules\n> > + message('Enabling vimc IPA to support tests')\n> > + ipa_modules += ['vimc']\n> > +endif\n> > +\n> > enabled_ipa_modules = []\n> > \n> > # The ipa-sign-install.sh script which uses the ipa_names variable will itself\n> > -- \n> > 2.37.3\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 84B44C0DA4\n\tfor ;\n\tThu, 15 Sep 2022 08:49:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 99E1861FAA;\n\tThu, 15 Sep 2022 10:49:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 06ABD600AA\n\tfor ;\n\tThu, 15 Sep 2022 10:49:26 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 58E37305;\n\tThu, 15 Sep 2022 10:49:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663231768;\n\tbh=Fy9QgjQEqz3dAySPVJ/hUQ4RPC3tFnar64eZKzW4PEk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=l6CEXiK8DtbKDVQBP9oqlMrcpA0m1pCIeaHqE1xbKnLXwc9VZ0OVfKcB36S9aGrjJ\n\tOqx+ai44Iqnf8Swx7RfRQsFdnRFq1uF3sX43gn7Uo44RZxrCjFQuf/g1hs0JDz7SU/\n\tZjtBQAKBUEXVhIGdmfYQIFK/vFPZLQT/UJf2dE4bE7eaiqgChV8nhOSRsJVL4thxXP\n\t0wNGNeGp4HxW0RiXAc49gd+GBEtzxcjvzT7nKA7/vD1odxJ2PVAGLKARy1dQo0xRTL\n\tk9SGVqWpZeTRQUffg/0D4AKtvM4Iif/scRu54PX0rvxQEqXgazWtIMLaeiRMFUyxes\n\tI+c3xHTEshCiQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663231766;\n\tbh=Fy9QgjQEqz3dAySPVJ/hUQ4RPC3tFnar64eZKzW4PEk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=OLQAci8NjWxGftQh+FiGnTSOjAP5oAyD3BuzoP+3StWV/kf10hJwnSkk+vuYXGgNA\n\t6tO6xj5CYzyEd+Fd+GP4Df+F61BpsVW0mKBCYOGfQbDrKlriWNHijHT/BUVDAFcIV/\n\tMhAaCn0OdttTGpNubwAC3pua+3RbGxvkAjkGELYU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OLQAci8N\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220915005925.GA1055504@pyrite.rasen.tech>","References":"<20220914105859.124524-1-umang.jain@ideasonboard.com>\n\t<20220915005925.GA1055504@pyrite.rasen.tech>","To":"Paul Elder via libcamera-devel ,\n\tUmang Jain , paul.elder@ideasonboard.com","Date":"Thu, 15 Sep 2022 09:49:24 +0100","Message-ID":"<166323176421.4088395.641972707781086087@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] meson: Enable vimc IPA for tests","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]