{"id":17367,"url":"https://patchwork.libcamera.org/api/patches/17367/?format=json","web_url":"https://patchwork.libcamera.org/patch/17367/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220914105859.124524-1-umang.jain@ideasonboard.com>","date":"2022-09-14T10:58:59","name":"[libcamera-devel] meson: Enable vimc IPA for tests","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8e84aa3fffc895d5f336902ea31192e1f26afc9b","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17367/mbox/","series":[{"id":3486,"url":"https://patchwork.libcamera.org/api/series/3486/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3486","date":"2022-09-14T10:58:59","name":"[libcamera-devel] meson: Enable vimc IPA for tests","version":1,"mbox":"https://patchwork.libcamera.org/series/3486/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17367/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17367/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65519C0DA4\n\tfor ;\n\tWed, 14 Sep 2022 10:59:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC47761FA8;\n\tWed, 14 Sep 2022 12:59:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F6546099F\n\tfor ;\n\tWed, 14 Sep 2022 12:59:07 +0200 (CEST)","from umang.jainideasonboard.com (unknown [103.251.226.115])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C3CC8305;\n\tWed, 14 Sep 2022 12:59:05 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663153148;\n\tbh=1XbmHz3RYSr2zdnaHZ4YKl0EuHIWqeSNAlCpqqd05RA=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=ovWlLESnr8dbeweuHahYYQoDTjnXbMKMixrKCdarKhrZ18twVQDcKVHVbEkt0QKjG\n\tv3vP0YYDuLoLFFtXrvSIfIWycfzDMTWAltv0YE0UGRgOLB29BpxFLcTvvdPZQCVsrm\n\tTN4Vx3zzqauH7FwiyMCMr8Kgd9uaU4h81VD4on3epMAsN3pnX2KK2BP81PHNsz2Puq\n\t6DVTiTz4/aSRBPzlmWjrWMvK3NOgWiDW7DCp7NzLSTKU5OKirzrhFk/5ObeboIn9R2\n\t2LeY8HTznYjWzG4gstZ1A/LE3B5P2eo8kOuWIllsNFkrbQ5WjJbPTDYfB/wnk57ZVV\n\tiWE6vWMNiokjg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663153147;\n\tbh=1XbmHz3RYSr2zdnaHZ4YKl0EuHIWqeSNAlCpqqd05RA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ryGZWH6xbhXvtromG0nAcyHa+e7IzFbMdKdPfVytWUBU7/Qb1trgbpM1DlsPiW1Pb\n\t1hghIRNJMlIxOwnUgwvRQgkDHaUR2/PEGJoTI5yM677yo1+Sh5O1G3AuKTbngk2XnI\n\tWCoH3RiHi/sh//la26twNO0xpU6fjKX7xB7YhYjc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ryGZWH6x\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 14 Sep 2022 16:28:59 +0530","Message-Id":"<20220914105859.124524-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.37.3","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] meson: Enable vimc IPA for tests","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Vimc pipeline handler is enabled unconditionally if the meson config\noption '-Dtest' is true. However, this is not true for the vimc IPA.\nHence, a meson configuration such as:\n\n -Dpipelines=raspberrypi -Dipas=raspberrypi -Dtest=true\n\nwill include the vimc pipeline handler (in addition to raspberrypi)\nbut will skip the vimc IPA which can lead to failure of unit tests\nthat depends on vimc to execute.\n\nOne such unit test was identified as a result of this issue on\nRaspberryPi:\n\nERROR IPAModule ipa_module.cpp:278 ipa_vimc.so: Failed to open IPA library: No such file or directory\ntest IPA module src/ipa/vimc/ipa_vimc.so is invalid\n\ndue to the non-existent ipa_vimc.so.\n\nFix this by including the vimc IPA unconditionally when the tests are\nenabled, similar to how the vim pipeline-handler is included.\n\nFixes: 6e65d4225736 (\"libcamera: Enable vimc pipeline handler when tests are enabled\")\nSigned-off-by: Umang Jain \n---\n src/ipa/meson.build | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/src/ipa/meson.build b/src/ipa/meson.build\nindex 849bb372..e972bbe8 100644\n--- a/src/ipa/meson.build\n+++ b/src/ipa/meson.build\n@@ -27,6 +27,14 @@ ipa_sign = files('ipa-sign.sh')\n ipa_names = []\n \n ipa_modules = get_option('ipas')\n+\n+# Tests require the vimc IPA, similar to vimc pipline-handler for their\n+# execution. Include it automatically when tests are enabled.\n+if get_option('test') and 'vimc' not in ipa_modules\n+ message('Enabling vimc IPA to support tests')\n+ ipa_modules += ['vimc']\n+endif\n+\n enabled_ipa_modules = []\n \n # The ipa-sign-install.sh script which uses the ipa_names variable will itself\n","prefixes":["libcamera-devel"]}