[{"id":24974,"web_url":"https://patchwork.libcamera.org/comment/24974/","msgid":"","date":"2022-09-12T12:45:19","subject":"Re: [libcamera-devel] [PATCH] test: gstreamer: Fix redundant word\n\tin error message.","submitter":{"id":85,"url":"https://patchwork.libcamera.org/api/people/85/","name":"Vedant Paranjape","email":"vedantparanjape160201@gmail.com"},"content":"Hello Rishikesh,\n\nThanks for the patch.\n\n\nOn Sun, Sep 11, 2022 at 11:39 PM Rishikesh Donadkar\n wrote:\n>\n> Fix redundant \"create\" in the error message.\n>\n> Signed-off-by: Rishikesh Donadkar \nReviewed-by: Vedant Paranjape \n> ---\n> test/gstreamer/gstreamer_test.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/test/gstreamer/gstreamer_test.cpp b/test/gstreamer/gstreamer_test.cpp\n> index 4947b7bb..66cc2166 100644\n> --- a/test/gstreamer/gstreamer_test.cpp\n> +++ b/test/gstreamer/gstreamer_test.cpp\n> @@ -115,7 +115,7 @@ int GstreamerTest::createPipeline()\n> pipeline_ = gst_pipeline_new(\"test-pipeline\");\n>\n> if (!libcameraSrc_ || !pipeline_) {\n> - g_printerr(\"Unable to create create pipeline %p.%p\\n\",\n> + g_printerr(\"Unable to create pipeline %p.%p\\n\",\n> libcameraSrc_, pipeline_);\n>\n> return TestFail;\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88A69C0DA4\n\tfor ;\n\tMon, 12 Sep 2022 12:45:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6DD361F93;\n\tMon, 12 Sep 2022 14:45:37 +0200 (CEST)","from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com\n\t[IPv6:2a00:1450:4864:20::22c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D492609A6\n\tfor ;\n\tMon, 12 Sep 2022 14:45:36 +0200 (CEST)","by mail-lj1-x22c.google.com with SMTP id z20so10423522ljq.3\n\tfor ;\n\tMon, 12 Sep 2022 05:45:36 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662986737;\n\tbh=U6ySDj1rzUmMLMDdZgQudLEJ7FtYT/ujya2i81z7TCU=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=U/Bx9LqpmkunmjcTdwHbDvp/eqcyMr2C1BJV0d2nPx7yl+nKbHp+KZdPWPckuIkto\n\tLNf9Wk957GWqQI9ygKBoomohARvvDv8JpqGc5u04mIu80bgwUJ+IGb7DRJRq9aIDyV\n\tQBl9nItG5PrWP0C8oeOz719k4SAVykEjTTLu5CsjPbgmew4NmkG6k5b6n0Lt4l7jyD\n\tHLey1aJleQJhgBJmjk5+/oNZdq0Gm1qcFcAOOw9PQjdzjS7Y9AMe6XElSUFROu4HnY\n\tv0EtEc50RDLjUOMfaXUMzXUiGmbS6aEAZT28ZVaHXAE0WagyVDfiJY5IFWt5ylvNmb\n\ttYbdtJAk5rdaA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date;\n\tbh=ekpG1OEmK8Ihy/tMpEglPtTH8IRRh1IjxRgBV35PI9I=;\n\tb=kYjcOH3t6tNyzOZzhHdEobajAMiEFkmsbrwtoqE7LCuQDT+1JTWqqruFv3xHthADIx\n\tGgbnFYciEt2TkbDhh5OfetsfTHeKGOCzxpGEsCHeAeSdyhMu6N6uNsf3v8BwCZNSZqj8\n\tE88llqyYSC5B74mYAc7kLU1TdEJCvHaBCjEAUhdTEdOEoeKpfb69BDBkooHHixPuZV+w\n\tPj0KF7VjXir+qf7Swx5ZWS6S1JCVsiTS3szOv3eityMnpCSyzktva+ureLRZ2HdCN8Nc\n\tlMOzgQj0W32R6yba6ARHGAZwrmYHVR48KPCsIaTGFz5IPyfW9JsfHJknXsEnpCcAcTrf\n\tQ+MA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"kYjcOH3t\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date;\n\tbh=ekpG1OEmK8Ihy/tMpEglPtTH8IRRh1IjxRgBV35PI9I=;\n\tb=NCPgCNfW8q5JKnjc/Af19ff+i1M3lbwqPRSxQIgJoanABzdwp5oO2oAkdQpszo1MCp\n\tqnYGDwrIzD4v1GkqTZN88l0nmAf7onv+pCq71qPhl1bOF/LFke2BoirlP/jZwmIfO93L\n\tDHN2ymMLFq6tJZnSliHVFZAKDHCbRQiTpvU8NwJ3UeKXACne4Ps3e1+qhlIfmhIhugZn\n\tfUF/LENUNri2madlxEk3QWWykSGLPMVOSbJ9tobmj5oHuw8omHfCuidKjUiWg9SAM5sE\n\t3k7JdedggFq+Qov4w/zl7DWEu4Rtb0s5KjIJDLdit+VHuVHZcUmkydn/xwD3cy1rwh2F\n\td4IQ==","X-Gm-Message-State":"ACgBeo1FIS9kB3BiZYH/o4j4c/Vv7Pumb4a87Hd7UTglher1zhJQPj3z\n\t/6v5MZ8nqkhLk/qSxCoNZsiEFnt/9w20ZWOU+YVqxe/NzrEe0A==","X-Google-Smtp-Source":"AA6agR7ompHWT9+gM2mSRguLhq7c8Jjm5vvkA1jGGnJzMXivIaFmi3l17nz7D0lVsG0TBcJT6MxVOo2jb4VJ9sxL+o8=","X-Received":"by 2002:a2e:a54a:0:b0:261:caa2:8d74 with SMTP id\n\te10-20020a2ea54a000000b00261caa28d74mr7444573ljn.11.1662986735192;\n\tMon, 12 Sep 2022 05:45:35 -0700 (PDT)","MIME-Version":"1.0","References":"<20220911180918.95019-1-rishikeshdonadkar@gmail.com>","In-Reply-To":"<20220911180918.95019-1-rishikeshdonadkar@gmail.com>","Date":"Mon, 12 Sep 2022 18:15:19 +0530","Message-ID":"","To":"Rishikesh Donadkar ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] test: gstreamer: Fix redundant word\n\tin error message.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Vedant Paranjape via libcamera-devel\n\t","Reply-To":"Vedant Paranjape ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24979,"web_url":"https://patchwork.libcamera.org/comment/24979/","msgid":"<5c93801c-c80f-33f8-d3f4-a00330c040fb@ideasonboard.com>","date":"2022-09-12T16:04:52","subject":"Re: [libcamera-devel] [PATCH] test: gstreamer: Fix redundant word\n\tin error message.","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Rishi\n\nThank you for the patch\n\nOn 9/12/22 6:15 PM, Vedant Paranjape wrote:\n> Hello Rishikesh,\n>\n> Thanks for the patch.\n>\n>\n> On Sun, Sep 11, 2022 at 11:39 PM Rishikesh Donadkar\n> wrote:\n>> Fix redundant \"create\" in the error message.\n>>\n>> Signed-off-by: Rishikesh Donadkar \n> Reviewed-by: Vedant Paranjape \n\nReviewed-by: Umang Jain \n>> ---\n>> test/gstreamer/gstreamer_test.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/test/gstreamer/gstreamer_test.cpp b/test/gstreamer/gstreamer_test.cpp\n>> index 4947b7bb..66cc2166 100644\n>> --- a/test/gstreamer/gstreamer_test.cpp\n>> +++ b/test/gstreamer/gstreamer_test.cpp\n>> @@ -115,7 +115,7 @@ int GstreamerTest::createPipeline()\n>> pipeline_ = gst_pipeline_new(\"test-pipeline\");\n>>\n>> if (!libcameraSrc_ || !pipeline_) {\n>> - g_printerr(\"Unable to create create pipeline %p.%p\\n\",\n>> + g_printerr(\"Unable to create pipeline %p.%p\\n\",\n>> libcameraSrc_, pipeline_);\n>>\n>> return TestFail;\n>> --\n>> 2.25.1\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 514A7C0DA4\n\tfor ;\n\tMon, 12 Sep 2022 16:04:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8CDCB61F9F;\n\tMon, 12 Sep 2022 18:04:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B73FB609A6\n\tfor ;\n\tMon, 12 Sep 2022 18:04:57 +0200 (CEST)","from [IPV6:2401:4900:1f3e:10f4:5f12:86fe:4e4:3b81] (unknown\n\t[IPv6:2401:4900:1f3e:10f4:5f12:86fe:4e4:3b81])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A673415;\n\tMon, 12 Sep 2022 18:04:56 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662998698;\n\tbh=aY9GpkvrcJwlrGHzNcu0L1BeHGbymiJh7lUj5i91QFM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=qTVNYvYO+RmEXplUIT5HJqDGWLa1qwHYmfyJiF9r8Lp4vToxMF7gGXEc62siO/KFB\n\twmqi/JezsfObvLursaJ+hhughflM3u4AP4qPxfT8t2k6ZDr+SPoKV/GQ/IcGZgTXRV\n\t8a5P0xCWtGl2w5tTyQbD5MyrdV9HokSw+XH+5K7FtGbrMoh98EoqMHjfCRTsN/y4ls\n\tSMSaC8g6Lq1aZbiZtaWnSmOj0EXX3/hh4H9/k9cAMo8FhleSSFMudl22SXCJC4U2cr\n\tL0fS8BC93PRmuxfTOzK9pWGfPpH1v5KyKvoLGYJ8hCvgfeIpK0uuAUXea8NAF8nYgO\n\tl9vfi0gqmgiRw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662998697;\n\tbh=aY9GpkvrcJwlrGHzNcu0L1BeHGbymiJh7lUj5i91QFM=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=lYy+5DWTuz0utekx+COgjZ/zA+VrPLpEYMdBJ8ckCVaVIfX14M7fB1qpPNX+SbwCj\n\tAZgjM3DAfHEl7NJNMb40jxlo3apaWAoEHgLW88FItzLSoX4IgJ+6EDJPXQLhsaWItL\n\twZYbaJjYUD2mgowto1bFFJJQN42N/6BP8fCFCa6M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lYy+5DWT\"; dkim-atps=neutral","Message-ID":"<5c93801c-c80f-33f8-d3f4-a00330c040fb@ideasonboard.com>","Date":"Mon, 12 Sep 2022 21:34:52 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.12.0","Content-Language":"en-US","To":"Vedant Paranjape ,\n\tRishikesh Donadkar ","References":"<20220911180918.95019-1-rishikeshdonadkar@gmail.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] test: gstreamer: Fix redundant word\n\tin error message.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]