[{"id":25249,"web_url":"https://patchwork.libcamera.org/comment/25249/","msgid":"","date":"2022-10-03T23:06:05","subject":"Re: [libcamera-devel] [PATCH 12/14] libcamera: pipeline: simple:\n\tLoad a converter configuration file (if any)","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Xavier,\n\nThank you for the patch.\n\nOn Thu, Sep 08, 2022 at 08:48:48PM +0200, Xavier Roumegue via libcamera-devel wrote:\n\nAs for the error patches, a commit message is needed.\n\n> Signed-off-by: Xavier Roumegue \n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index a5970234..31d10c56 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -498,6 +498,14 @@ int SimpleCameraData::init()\n> \t\t\t\t<< \"Failed to create converter, disabling format conversion\";\n> \t\t\tconverter_.reset();\n> \t\t} else {\n> +\t\t\tchar const *configFromEnv = utils::secure_getenv(\"LIBCAMERA_SIMPLE_CONVERTER_FILE\");\n> +\n> +\t\t\tif (configFromEnv && *configFromEnv != '\\0') {\n> +\t\t\t\tLOG(SimplePipeline, Debug)\n> +\t\t\t\t\t<< \"Getting simple converter filename as \" << std::string(configFromEnv);\n\nThis duplicates the debug message in\nV4L2M2MConverter::loadConfiguration().\n\n> +\t\t\t\tconverter_->loadConfiguration(std::string(configFromEnv));\n> +\t\t\t}\n\nThis is quite a hack. It may be OK for initial tests, but we need a\nbetter mechanism to pick a proper configuration file. This also applies\nto the rkisp1 pipeline handler.\n\n> +\n> \t\t\tconverter_->inputBufferReady.connect(this, &SimpleCameraData::converterInputDone);\n> \t\t\tconverter_->outputBufferReady.connect(this, &SimpleCameraData::converterOutputDone);\n> \t\t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64567BD16B\n\tfor ;\n\tMon, 3 Oct 2022 23:06:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0470603F6;\n\tTue, 4 Oct 2022 01:06:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C76DB601C7\n\tfor ;\n\tTue, 4 Oct 2022 01:06:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F4189DE;\n\tTue, 4 Oct 2022 01:06:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664838369;\n\tbh=/86xWJqqv2k2Niutpfxv3GaVtMI/akQsicEkIjxQctU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2u9eCdC4EdaJLiLc2SPLqSo6MW7XE2Wi28vvr1oCVRITrJzcPc9YmNtfp5XjnVukU\n\tmNrctOGLq0+OHy8hq2C19zdcyFWMFdgpvsjjJfpWDWnVwyt1cbdLvUIdBp4uNdF8N1\n\tShoLUgRa2mMlGSIxlVJySS3E4F2jYn92IM4uBD5fYpsHuJZbnJXBqozO9Itcdt+mM5\n\t5qFFQABrSZj1EOtj3XKoAfgnALqOY/G6zbpVwrOexc3/r0CSo974tsVyI9ROOz7qKy\n\tqDuUSsRp3bz0NP00xCQ2HW/HoTGbt2Ce6m5FyJs3ob66el9rUPuXQ3pE0LtDNfsz3W\n\tJy4C962uq7xag==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664838368;\n\tbh=/86xWJqqv2k2Niutpfxv3GaVtMI/akQsicEkIjxQctU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EVEKmBnaXFRiZrPpWc56+YFR2xmikKD2nfSN9PENVJWtlxIg92BnFlRespdF2ZXHO\n\tvLNpJ9R4UqjYO4QLgEAROwbTwWipOwriqhWkZjuM38rid64MqvzcDRWa5fw7B6ABjW\n\tQZF3SdrPMDr03pYXX2Ajpm7IjHqqdTzZaATS9RjQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EVEKmBna\"; dkim-atps=neutral","Date":"Tue, 4 Oct 2022 02:06:05 +0300","To":"Xavier Roumegue ","Message-ID":"","References":"<20220908184850.1874303-1-xavier.roumegue@oss.nxp.com>\n\t<20220908184850.1874303-13-xavier.roumegue@oss.nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220908184850.1874303-13-xavier.roumegue@oss.nxp.com>","Subject":"Re: [libcamera-devel] [PATCH 12/14] libcamera: pipeline: simple:\n\tLoad a converter configuration file (if any)","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]