[{"id":25246,"web_url":"https://patchwork.libcamera.org/comment/25246/","msgid":"","date":"2022-10-03T22:16:10","subject":"Re: [libcamera-devel] [PATCH 08/14] libcamera: yaml_parser:\n\tIncrease sentinel to 100k","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Xavier,\n\nThank you for the patch.\n\nOn Thu, Sep 08, 2022 at 08:48:44PM +0200, Xavier Roumegue via libcamera-devel wrote:\n\nThis is missing a commit message.\n\n> Signed-off-by: Xavier Roumegue \n> ---\n> src/libcamera/yaml_parser.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\n> index d8a7c2f9..abca6903 100644\n> --- a/src/libcamera/yaml_parser.cpp\n> +++ b/src/libcamera/yaml_parser.cpp\n> @@ -676,7 +676,7 @@ int YamlParserContext::parseDictionaryOrList(YamlObject::Type type,\n> \t * Add a safety counter to make sure we don't loop indefinitely in case\n> \t * the YAML file is malformed.\n> \t */\n> -\tfor (unsigned int sentinel = 1000; sentinel; sentinel--) {\n> +\tfor (unsigned int sentinel = 100000; sentinel; sentinel--) {\n> \t\tauto evt = nextEvent();\n> \t\tif (!evt)\n> \t\t\treturn -EINVAL;\n> @@ -690,7 +690,7 @@ int YamlParserContext::parseDictionaryOrList(YamlObject::Type type,\n> \t}\n> \n> \tLOG(YamlParser, Error) << \"The YAML file contains a List or Dictionary\"\n> -\t\t\t\t \" whose size exceeds the parser's limit (1000)\";\n> +\t\t\t\t \" whose size exceeds the parser's limit (100000)\";\n\nCould you define a constant (constexpr) and use it above and here ?\n\n> \n> \treturn -EINVAL;\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F03CABD16B\n\tfor ;\n\tMon, 3 Oct 2022 22:16:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AC5CF601D0;\n\tTue, 4 Oct 2022 00:16:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95A8A601C7\n\tfor ;\n\tTue, 4 Oct 2022 00:16:12 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2452F9DE;\n\tTue, 4 Oct 2022 00:16:12 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664835374;\n\tbh=o7Uex4anB9Kh++1YdY/7T6qj3gdk8mi7RisRwTUh8gU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=4Jmr6mqEMS7Ks1JTJ0m0ipDUsudt8jBUIw9o9e8AEl6wzDaCtPg8oED6t+78azh0I\n\tNMOzAtjy0Y9ujdqifdgvT1SNa/k0dlCOOFQLKacNUQytqSGUUCpZ4sON1L5ztBI6N4\n\tZrHHnyFmba1OiGgC40yd/PwmDlaBM7v+OX6EnLr1vHLH6mn7yiVoD8bqr7GgOCGIDU\n\t8Xnl/pQlyedzVfySWt8HfjvvAeEOiMWIOqxVztjS1UHRvBKL7LKA9r++O9hcXDnekS\n\td1fxGggt8lHcq/WnWCCa7qaZstdxvPEF0Jey3QihtBOfFqIMB83rUiREiVytLNO6iA\n\tOSHqNwsu8UmkA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664835372;\n\tbh=o7Uex4anB9Kh++1YdY/7T6qj3gdk8mi7RisRwTUh8gU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AlVroEX5vmBoEAepfEgkzsLPNqGQaCLW/mZ597I9kJqCl7dXxzQNWchkYypZ0G9rh\n\t5Mr/ldmvx7cS9ww+4x0lmskGpTj/ithB0PqUbVH5I4j5vatA2HfQ+m2Q9HPZpAQOfH\n\tWu7yOn3eARbSqbP4mLgD7e9XSugwKwT2J4aJwpoI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AlVroEX5\"; dkim-atps=neutral","Date":"Tue, 4 Oct 2022 01:16:10 +0300","To":"Xavier Roumegue ","Message-ID":"","References":"<20220908184850.1874303-1-xavier.roumegue@oss.nxp.com>\n\t<20220908184850.1874303-9-xavier.roumegue@oss.nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220908184850.1874303-9-xavier.roumegue@oss.nxp.com>","Subject":"Re: [libcamera-devel] [PATCH 08/14] libcamera: yaml_parser:\n\tIncrease sentinel to 100k","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]