[{"id":2329,"web_url":"https://patchwork.libcamera.org/comment/2329/","msgid":"<20190807091228.GE5048@pendragon.ideasonboard.com>","date":"2019-08-07T09:12:28","subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: Add camera metadata\n\tlibrary","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Aug 06, 2019 at 09:55:16PM +0200, Jacopo Mondi wrote:\n> Import the Android camera metadata library from the ChromiumOS build\n> system.\n> \n> The camera metadata library has been copied from\n> https://chromium.googlesource.com/chromiumos/platform2\n> at revision 9e65ddd2c496e712f005ada9715decd2ff8e4a03\n> \n> The original path in the Cros platform2/ repository is:\n> camera/android/libcamera_metadata/src\n> \n> Create a new build target for the camera metadata library to\n> create a static library to link against libcamera.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/android/meson.build                       |    7 +\n>  src/android/metadata/camera_metadata.c        | 1204 +++++++\n>  .../metadata/camera_metadata_tag_info.c       | 2811 +++++++++++++++++\n>  src/meson.build                               |    1 +\n>  4 files changed, 4023 insertions(+)\n>  create mode 100644 src/android/meson.build\n>  create mode 100644 src/android/metadata/camera_metadata.c\n>  create mode 100644 src/android/metadata/camera_metadata_tag_info.c","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 332C4615FF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  7 Aug 2019 11:12:31 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 918FE814;\n\tWed,  7 Aug 2019 11:12:30 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565169150;\n\tbh=dQ5qrbVI2d+mg7hZdvre6unUd7yP/c4QypWuhAZ/tIc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SUHiZvxjWNb3GbrsbdC6gWMSV/JaXjtZzlnounNGFZAehhs01gx3LfW8x1UzC5IR/\n\tmNe5i87ItMx/PGIQ4qVptOxr1VB95tc3LGTCgHHnNWlVZ1monRwKugfjvlyazO1XUc\n\tGTR6A/KvrLzLp9QbKJVY2vlw2evYEbvLctlbpYNU=","Date":"Wed, 7 Aug 2019 12:12:28 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190807091228.GE5048@pendragon.ideasonboard.com>","References":"<20190806195518.16739-1-jacopo@jmondi.org>\n\t<20190806195518.16739-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190806195518.16739-5-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: Add camera metadata\n\tlibrary","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 07 Aug 2019 09:12:31 -0000"}}]