[{"id":25245,"web_url":"https://patchwork.libcamera.org/comment/25245/","msgid":"","date":"2022-10-03T22:15:13","subject":"Re: [libcamera-devel] [PATCH 07/14] include: linux: Update headers\n\tfor dw100/dynamic array support","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Xavier,\n\nThank you for the patch.\n\nOn Thu, Sep 08, 2022 at 08:48:43PM +0200, Xavier Roumegue via libcamera-devel wrote:\n> This is merged in media_tree/master linux kernel:\n> - 9d5c3c069805 - media: uapi: Add a control for DW100 driver\n> - a41c4088cf43 - media: v4l: uapi: Add user control base for DW100 controls\n> - 43cc0ec38131 - media: v4l2-ctrls: add change flag for when dimensions change\n> \n> Signed-off-by: Xavier Roumegue \n> ---\n> include/linux/dw100.h | 14 ++++++++++++++\n> include/linux/v4l2-controls.h | 6 ++++++\n> include/linux/videodev2.h | 2 ++\n> 3 files changed, 22 insertions(+)\n> create mode 100644 include/linux/dw100.h\n> \n> diff --git a/include/linux/dw100.h b/include/linux/dw100.h\n> new file mode 100644\n> index 00000000..3356496e\n> --- /dev/null\n> +++ b/include/linux/dw100.h\n> @@ -0,0 +1,14 @@\n> +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */\n> +/* Copyright 2022 NXP */\n> +\n> +#ifndef __UAPI_DW100_H__\n> +#define __UAPI_DW100_H__\n> +\n> +#include \n> +\n> +/*\n> + * Check Documentation/userspace-api/media/drivers/dw100.rst for control details.\n> + */\n> +#define V4L2_CID_DW100_DEWARPING_16x16_VERTEX_MAP (V4L2_CID_USER_DW100_BASE + 1)\n> +\n> +#endif\n> diff --git a/include/linux/v4l2-controls.h b/include/linux/v4l2-controls.h\n> index 9d2a8237..047f8965 100644\n> --- a/include/linux/v4l2-controls.h\n> +++ b/include/linux/v4l2-controls.h\n> @@ -229,6 +229,12 @@ enum v4l2_colorfx {\n> */\n> #define V4L2_CID_USER_ISL7998X_BASE\t\t(V4L2_CID_USER_BASE + 0x1180)\n> \n> +/*\n> + * The base for DW100 driver controls.\n> + * We reserve 16 controls for this driver.\n> + */\n> +#define V4L2_CID_USER_DW100_BASE\t\t(V4L2_CID_USER_BASE + 0x1190)\n> +\n> /* MPEG-class control IDs */\n> /* The MPEG controls are applicable to all codec controls\n> * and the 'MPEG' part of the define is historical */\n> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\n> index bfb315d6..f502114f 100644\n> --- a/include/linux/videodev2.h\n> +++ b/include/linux/videodev2.h\n> @@ -1860,6 +1860,7 @@ struct v4l2_querymenu {\n> #define V4L2_CTRL_FLAG_HAS_PAYLOAD\t0x0100\n> #define V4L2_CTRL_FLAG_EXECUTE_ON_WRITE\t0x0200\n> #define V4L2_CTRL_FLAG_MODIFY_LAYOUT\t0x0400\n> +#define V4L2_CTRL_FLAG_DYNAMIC_ARRAY\t0x0800\n\nThis isn't part of any of the commits listed in the commit message, but\nhas been introduced in commit 64fe675e999c (\"media: videodev2.h: add\nV4L2_CTRL_FLAG_DYNAMIC_ARRAY\"). As it isn't used in this series, I would\ndrop it.\n\n> \n> /* Query flags, to be ORed with the control ID */\n> #define V4L2_CTRL_FLAG_NEXT_CTRL\t0x80000000\n> @@ -2367,6 +2368,7 @@ struct v4l2_event_vsync {\n> #define V4L2_EVENT_CTRL_CH_VALUE\t\t(1 << 0)\n> #define V4L2_EVENT_CTRL_CH_FLAGS\t\t(1 << 1)\n> #define V4L2_EVENT_CTRL_CH_RANGE\t\t(1 << 2)\n> +#define V4L2_EVENT_CTRL_CH_DIMENSIONS\t\t(1 << 3)\n\nThis isn't used in this series either, you can drop it.\n\nWith these two changes dropped, and the commit message updates\n(including the subject line),\n\nReviewed-by: Laurent Pinchart \n\n> \n> struct v4l2_event_ctrl {\n> \t__u32 changes;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E976ABD16B\n\tfor ;\n\tMon, 3 Oct 2022 22:15:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D482C601D0;\n\tTue, 4 Oct 2022 00:15:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 503C6601C7\n\tfor ;\n\tTue, 4 Oct 2022 00:15:16 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A793D9DE;\n\tTue, 4 Oct 2022 00:15:15 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664835317;\n\tbh=07sRQyHslMv0ncUtLYDDdoSpAdptK+7AEM1aKTMkUxk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ckLshF4IYZgodVi17godv21Axw93CbYfAf3HCXn0J/m2fnSR1izwab8ZWPZQ1PnBi\n\tmIwWL+QHmr/8GQawS86Ek6lyMTxtKSUK7Pp1qXk6hdf7nhP/w9CXPflZCHiiGmZ+Yv\n\t9brZJUSLgd4MB/sFlc29UM7e7+oUN5lhioVRqbYzqBGlwNpxtlwyNdK0nnZCxLarEy\n\tH96HS7lSNCIJjXpko+JXGLE34Bsudi2F8kTtu4yShaBEtFN5WP4k+9r9KRmUqkw4oX\n\tltiDOg9qDl2LJ4wG3ntZg5cfetOHpLUnptLsvUbH87hVGyNicUO8YWtRoimM1/L2gG\n\t+aBL5gLR2O80w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664835315;\n\tbh=07sRQyHslMv0ncUtLYDDdoSpAdptK+7AEM1aKTMkUxk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ck67ySm9Ayf33bSI4shJU0EO2I7ppMs3wmbovzbgSZxIrAFK1vAPjqqNvsYJXIyhH\n\tp8vvkNLKScJgRNUQKBAkfwRZWFzJrcQT9ur/NYM/Muw7bXQ+cyW/okYAUU/4JqekS0\n\twJe6LjkyccRgICddq0iNTuIeOwMVcenuJzONnZCY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ck67ySm9\"; dkim-atps=neutral","Date":"Tue, 4 Oct 2022 01:15:13 +0300","To":"Xavier Roumegue ","Message-ID":"","References":"<20220908184850.1874303-1-xavier.roumegue@oss.nxp.com>\n\t<20220908184850.1874303-8-xavier.roumegue@oss.nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220908184850.1874303-8-xavier.roumegue@oss.nxp.com>","Subject":"Re: [libcamera-devel] [PATCH 07/14] include: linux: Update headers\n\tfor dw100/dynamic array support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]