[{"id":24986,"web_url":"https://patchwork.libcamera.org/comment/24986/","msgid":"<20220914105207.4inj24zb6fid5s3b@uno.localdomain>","date":"2022-09-14T10:52:07","subject":"Re: [libcamera-devel] [PATCH 05/14] libcamera: converter: Add\n\tqueueBuffer() helper","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"We usually don't allow commits without a message, even more in this\ncase where it would be good explain why the helper is, well, helpful\n:)\n\nOn Thu, Sep 08, 2022 at 08:48:41PM +0200, Xavier Roumegue via libcamera-devel wrote:\n> Signed-off-by: Xavier Roumegue \n> ---\n> include/libcamera/internal/converter.h | 6 ++++++\n> 1 file changed, 6 insertions(+)\n>\n> diff --git a/include/libcamera/internal/converter.h b/include/libcamera/internal/converter.h\n> index e2237c57..ea1deab0 100644\n> --- a/include/libcamera/internal/converter.h\n> +++ b/include/libcamera/internal/converter.h\n> @@ -55,6 +55,12 @@ public:\n> \tvirtual int queueBuffers(FrameBuffer *input,\n> \t\t\t\t const std::map &outputs) = 0;\n>\n> +\tint queueBuffer(FrameBuffer *input, FrameBuffer *output)\n\nDoes it need documentation ?\n\n> +\t{\n> +\t\tstd::map _output = { { 0, output } };\n> +\t\treturn queueBuffers(input, _output);\n> +\t}\n> +\n> \tstd::string deviceNode_;\n> \tSignal inputBufferReady;\n> \tSignal outputBufferReady;\n> --\n> 2.37.3\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D989C3272\n\tfor ;\n\tWed, 14 Sep 2022 10:52:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC43C61FA6;\n\tWed, 14 Sep 2022 12:52:10 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 00FEC6099F\n\tfor ;\n\tWed, 14 Sep 2022 12:52:09 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 769A0C0004;\n\tWed, 14 Sep 2022 10:52:09 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663152730;\n\tbh=5MS8k7xvsMCT9RqDI5HkoMt/wwkEo5yovpnE/hKwcMo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=4hlIk5hCTMYWD8J/P1oqrg5ukpq+GupYDpjH5+VlTIjmKa9HbNke2ozQp67AxxSrM\n\tLntMatCPlJpjdqYD+DNcr0aKAMRDedSgAyMRV84ZbYCaf9lq1tJPU/l3dxxDcykFg8\n\tF616KTepgo8hJG0AmN0pdj0YF2z88yJno99f+rxG3EHGubdm4IBsN29pxXv7QZpikg\n\tfyI3X4j/E6yQN655K01mrjRWA+mcK91ngj2qHu2DmoMHapBoceIAD8DQMXLwq/dVTx\n\ta7KYn3xY1mq76T08oxALuxDniS1axwqm5YuotDiHAf1y9BuRFadfBitSPlYjRKKt+x\n\tSyP1TeuOkhDfQ==","Date":"Wed, 14 Sep 2022 12:52:07 +0200","To":"Xavier Roumegue ","Message-ID":"<20220914105207.4inj24zb6fid5s3b@uno.localdomain>","References":"<20220908184850.1874303-1-xavier.roumegue@oss.nxp.com>\n\t<20220908184850.1874303-6-xavier.roumegue@oss.nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220908184850.1874303-6-xavier.roumegue@oss.nxp.com>","Subject":"Re: [libcamera-devel] [PATCH 05/14] libcamera: converter: Add\n\tqueueBuffer() helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25244,"web_url":"https://patchwork.libcamera.org/comment/25244/","msgid":"","date":"2022-10-03T22:10:37","subject":"Re: [libcamera-devel] [PATCH 05/14] libcamera: converter: Add\n\tqueueBuffer() helper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Sep 14, 2022 at 12:52:07PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> We usually don't allow commits without a message, even more in this\n> case where it would be good explain why the helper is, well, helpful\n> :)\n\nI can't disagree :-)\n\n> On Thu, Sep 08, 2022 at 08:48:41PM +0200, Xavier Roumegue via libcamera-devel wrote:\n> > Signed-off-by: Xavier Roumegue \n> > ---\n> > include/libcamera/internal/converter.h | 6 ++++++\n> > 1 file changed, 6 insertions(+)\n> >\n> > diff --git a/include/libcamera/internal/converter.h b/include/libcamera/internal/converter.h\n> > index e2237c57..ea1deab0 100644\n> > --- a/include/libcamera/internal/converter.h\n> > +++ b/include/libcamera/internal/converter.h\n> > @@ -55,6 +55,12 @@ public:\n> > \tvirtual int queueBuffers(FrameBuffer *input,\n> > \t\t\t\t const std::map &outputs) = 0;\n> >\n> > +\tint queueBuffer(FrameBuffer *input, FrameBuffer *output)\n> \n> Does it need documentation ?\n\nPatch 04/14 also requires documentation, I think Xavier wanted a first\nreview of the overall API in order to avoid spending time writing\ndocumentation that would then need to be rewritten. I assume\ndocumentation will come in v2 or v3.\n\n> > +\t{\n> > +\t\tstd::map _output = { { 0, output } };\n> > +\t\treturn queueBuffers(input, _output);\n> > +\t}\n> > +\n> > \tstd::string deviceNode_;\n> > \tSignal inputBufferReady;\n> > \tSignal outputBufferReady;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96543C0DA4\n\tfor ;\n\tMon, 3 Oct 2022 22:10:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08BB4601CF;\n\tTue, 4 Oct 2022 00:10:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C729601C7\n\tfor ;\n\tTue, 4 Oct 2022 00:10:40 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6F6F89DE;\n\tTue, 4 Oct 2022 00:10:39 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664835042;\n\tbh=Tmge+AE3owbrMZGjPoiK+eqJwP6B4WzGLum84MkCmJw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SbniPAdol1kK3JcLQwYAehKBwBQZxCoqubp1GDQS4JnAF+K82tEuU8N4NWap6huhN\n\tXzZ0FYsx+yQ9CZoY+7PhogYqGOhJmn/LobbxevjkpPZIy6SH0x//4iEC39nrpjkm9W\n\tAJsn3gMP0QGUFwTyRMFKVzWr+dcSzFrs+rKSZjnithj44CyM2V/uqlX31fSGQaWouf\n\t3hrkSjCJpcQy+lJk+UULJ+ru33uiB2Ap1lyH4hUC/VGRMj6JvuzcWTF6uIy5qgCm1F\n\tfzDPfh/yK0UHyCXPIFGUJxBaGPaI+hWUd5lBwSWHdufL8/MDQcYYHfw/sxF+Yt7iLd\n\tm9vu0+SjwkUnQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664835039;\n\tbh=Tmge+AE3owbrMZGjPoiK+eqJwP6B4WzGLum84MkCmJw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pFdND4nO7uTypp0M81JY0nSQbhqzPH8NzXyHwVZwvaHyAT7GEgkx7PqcsXkS+re2q\n\ttIveNquhKclfKIjx51QHTKYLRxpNhMxvYP9ff9eqGDdiKSFb4doBc2cN+XK8i4GF77\n\tt6vbHaxZTHICcXcvSnL2RwVrGl208D4KPNd0MdrY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pFdND4nO\"; dkim-atps=neutral","Date":"Tue, 4 Oct 2022 01:10:37 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220908184850.1874303-1-xavier.roumegue@oss.nxp.com>\n\t<20220908184850.1874303-6-xavier.roumegue@oss.nxp.com>\n\t<20220914105207.4inj24zb6fid5s3b@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220914105207.4inj24zb6fid5s3b@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 05/14] libcamera: converter: Add\n\tqueueBuffer() helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]