[{"id":25238,"web_url":"https://patchwork.libcamera.org/comment/25238/","msgid":"","date":"2022-10-03T13:39:24","subject":"Re: [libcamera-devel] [PATCH 01/14] libcamera: v4l2_device: Add\n\tsupport for V4L2_CTRL_TYPE_U32","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Xavier,\n\nThank you for the patch.\n\nOn Thu, Sep 08, 2022 at 08:48:37PM +0200, Xavier Roumegue via libcamera-devel wrote:\n\nA commit message would be nice. For instance,\n\nSupport for the U16 and U32 compound control types is missing. U16 will\nrequire a new libcamera control type, but U32 maps to the existing\nControlTypeInteger32 and can be added easily.\n\n> Signed-off-by: Xavier Roumegue \n> ---\n> src/libcamera/v4l2_device.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 83901763..756188ea 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -488,6 +488,7 @@ ControlType V4L2Device::v4l2CtrlType(uint32_t ctrlType)\n> \t\treturn ControlTypeBool;\n> \n> \tcase V4L2_CTRL_TYPE_INTEGER:\n> +\tcase V4L2_CTRL_TYPE_U32:\n> \t\treturn ControlTypeInteger32;\n> \n> \tcase V4L2_CTRL_TYPE_INTEGER64:\n> @@ -613,6 +614,7 @@ void V4L2Device::listControls()\n> \t\tcase V4L2_CTRL_TYPE_BITMASK:\n> \t\tcase V4L2_CTRL_TYPE_INTEGER_MENU:\n> \t\tcase V4L2_CTRL_TYPE_U8:\n> +\t\tcase V4L2_CTRL_TYPE_U32:\n> \t\t\tbreak;\n> \t\t/* \\todo Support other control types. */\n> \t\tdefault:\n\nShouldn't you also update V4L2Device::v4l2ControlInfo() and\nV4L2Device::getControls() ?","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C388FC0DA4\n\tfor ;\n\tMon, 3 Oct 2022 13:39:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 29903601BC;\n\tMon, 3 Oct 2022 15:39:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DDE9A600E9\n\tfor ;\n\tMon, 3 Oct 2022 15:39:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43F5D440;\n\tMon, 3 Oct 2022 15:39:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664804368;\n\tbh=/oLRNiA2qoDVwEkiM/94pZBHGxbN/eaTYIvjyGaWmus=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=g4jM7DI+0kI4jZmzUyeqypSrAkf60U0b/yyAZ0j6TunzEjtSgUWsVovLDamfMH5/C\n\tXTF2hRtw+jVCPcKGe+u9jcK1GH3QXhsl0mWYgFyQjr1W07grZVu2pKsjfTOLm/urDc\n\tWXrg67E8S43vrEKrcQh/kWQgNijwk2dBlc7tEg+dvCL565ef5oM/KO7iVDCnBT/1Tf\n\tsSlF9frgEbhicKsfMcZ2c8kHKYwOA/FRrASjvK5vmDfRz6jpUJSEAS1J8fWy0JXfh2\n\txGi6UC0mBl8YCCEbP7o5X+H52Vcq9d+B6O4YHtRBXBvDD3oVs6b4+zxCEx5jji3ZEO\n\tQbw1oAPfSnaoQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664804366;\n\tbh=/oLRNiA2qoDVwEkiM/94pZBHGxbN/eaTYIvjyGaWmus=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=V0CiLQaQrmphYSXEZRkFiAdrZ7GeQIjsb6Nj0KMBZYi8mwFzcN76nTIvBF2Ffgog0\n\tX316lJi9ixO1usMCDrurxWXO5pumM4vLBVT7dhKjX/DU3MWlKSPKEQW3AE3o5hoTbq\n\tW5nBf+UI2pKfJEfwTeVGcl2OPUWB2pBJa0tRSU4g="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"V0CiLQaQ\"; dkim-atps=neutral","Date":"Mon, 3 Oct 2022 16:39:24 +0300","To":"Xavier Roumegue ","Message-ID":"","References":"<20220908184850.1874303-1-xavier.roumegue@oss.nxp.com>\n\t<20220908184850.1874303-2-xavier.roumegue@oss.nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220908184850.1874303-2-xavier.roumegue@oss.nxp.com>","Subject":"Re: [libcamera-devel] [PATCH 01/14] libcamera: v4l2_device: Add\n\tsupport for V4L2_CTRL_TYPE_U32","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]