{"id":17340,"url":"https://patchwork.libcamera.org/api/patches/17340/?format=json","web_url":"https://patchwork.libcamera.org/patch/17340/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220908014200.28728-32-laurent.pinchart@ideasonboard.com>","date":"2022-09-08T01:41:59","name":"[libcamera-devel,v4,31/32] ipa: rkisp1: awb: Freeze AWB when means are too small","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b7112db064dc1058970c55a5a04f8a678787e579","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17340/mbox/","series":[{"id":3476,"url":"https://patchwork.libcamera.org/api/series/3476/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3476","date":"2022-09-08T01:41:28","name":"ipa: Frame context queue, IPU3 & RkISP consolidation, and RkISP1 improvements","version":4,"mbox":"https://patchwork.libcamera.org/series/3476/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17340/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17340/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA956C3272\n\tfor ;\n\tThu, 8 Sep 2022 01:43:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A3D4362113;\n\tThu, 8 Sep 2022 03:43:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E85562101\n\tfor ;\n\tThu, 8 Sep 2022 03:43:01 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB2A76CC\n\tfor ;\n\tThu, 8 Sep 2022 03:43:00 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662601383;\n\tbh=FPQ0oy+GR46vpCePLbhpjzaqSYBF4YKVAzLdR6O5vcA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=rctIiXFSwaOrFbOSjblLonQvvj4xw8pkqsJkSVJYLg7GOBB6+vo5DdCAApyAED+F7\n\tCP8A6nE/Yd+U+UrfIvDNLaYShLJN0A95Ng/npkkg3ipvHz9SJAZUkG1R0nc9mcKKGx\n\t3FPqcBlYWcroQpnNsy83sRSSNSIs+9axZtuebOKmFgEltRVyUJbYe5Maxe9Zfv11xK\n\tM20YIHqjf7SYJJN68WnvmqVY3CoN9YPZ8nJ5e2QtuIdTQDdo2qm3DfV+eVw7zvR7ze\n\tqYwrTPXMnod7HXPYNzbHddwhH8KVUzQfx+GDp/8SuLRuOM49ai0FK7k/htyVOhEAVU\n\t81H22TeltA1uQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662601381;\n\tbh=FPQ0oy+GR46vpCePLbhpjzaqSYBF4YKVAzLdR6O5vcA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=CU0RXV67jyAwHZBzCrBB+/K/rECokn55n0uqW/7cVtwwH28lwyGzuRmV9Lz6lQC4P\n\t26SuzaAW8Ggu5QowqQ1PsVyV1cpDGr8n0vne92bnogmUgV/ziM87C9SFQ9gsxoyx3d\n\t5rW/0vyHGNfadAcnAQix8rrZTOt61KjVwrD4qaMA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CU0RXV67\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 8 Sep 2022 04:41:59 +0300","Message-Id":"<20220908014200.28728-32-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 31/32] ipa: rkisp1: awb: Freeze AWB\n\twhen means are too small","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the RGB means are too small, gains and color temperature can't be\nmeaningfully calculated. Freeze the AWB in that case, using the\npreviously calculated values.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/rkisp1/algorithms/awb.cpp | 17 ++++++++++++++++-\n src/ipa/rkisp1/ipa_context.cpp | 3 +++\n src/ipa/rkisp1/ipa_context.h | 1 +\n 3 files changed, 20 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 5f2535688c93..404ad66e6953 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -31,6 +31,9 @@ namespace ipa::rkisp1::algorithms {\n \n LOG_DEFINE_CATEGORY(RkISP1Awb)\n \n+/* Minimum mean value below which AWB can't operate. */\n+constexpr double kMeanMinThreshold = 2.0;\n+\n Awb::Awb()\n \t: rgbMode_(false)\n {\n@@ -263,7 +266,17 @@ void Awb::process(IPAContext &context,\n \tgreenMean /= frameContext.awb.gains.green;\n \tblueMean /= frameContext.awb.gains.blue;\n \n-\tframeContext.awb.temperatureK = estimateCCT(redMean, greenMean, blueMean);\n+\t/*\n+\t * If the means are too small we don't have enough information to\n+\t * meaningfully calculate gains. Freeze the algorithm in that case.\n+\t */\n+\tif (redMean < kMeanMinThreshold && greenMean < kMeanMinThreshold &&\n+\t blueMean < kMeanMinThreshold) {\n+\t\tframeContext.awb.temperatureK = activeState.awb.temperatureK;\n+\t\treturn;\n+\t}\n+\n+\tactiveState.awb.temperatureK = estimateCCT(redMean, greenMean, blueMean);\n \n \t/*\n \t * Estimate the red and blue gains to apply in a grey world. The green\n@@ -290,6 +303,8 @@ void Awb::process(IPAContext &context,\n \tactiveState.awb.gains.automatic.blue = blueGain;\n \tactiveState.awb.gains.automatic.green = 1.0;\n \n+\tframeContext.awb.temperatureK = activeState.awb.temperatureK;\n+\n \tLOG(RkISP1Awb, Debug) << std::showpoint\n \t\t<< \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n \t\t<< \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\ndiff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\nindex 335cb32c538d..9cac05bec79b 100644\n--- a/src/ipa/rkisp1/ipa_context.cpp\n+++ b/src/ipa/rkisp1/ipa_context.cpp\n@@ -156,6 +156,9 @@ namespace libcamera::ipa::rkisp1 {\n * \\var IPAActiveState::awb.gains.automatic.blue\n * \\brief Automatic white balance gain for B channel\n *\n+ * \\var IPAActiveState::awb.temperatureK\n+ * \\brief Estimated color temperature\n+ *\n * \\var IPAActiveState::awb.autoEnabled\n * \\brief Whether the Auto White Balance algorithm is enabled\n */\ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 53787320e565..d0bc9090a8f1 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -68,6 +68,7 @@ struct IPAActiveState {\n \t\t\t} automatic;\n \t\t} gains;\n \n+\t\tunsigned int temperatureK;\n \t\tbool autoEnabled;\n \t} awb;\n \n","prefixes":["libcamera-devel","v4","31/32"]}