[{"id":25041,"web_url":"https://patchwork.libcamera.org/comment/25041/","msgid":"<166371687119.18961.13470050380425839928@Monstersaurus>","date":"2022-09-20T23:34:31","subject":"Re: [libcamera-devel] [PATCH v4 28/32] ipa: rkisp1: awb: Log means, \n\tgains and temperature in debug message","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-09-08 02:41:56)\n> Extend the debug message in Awb::process() to log the means and color\n> temperature in addition to the gains. This is useful for debugging the\n> algorithm behaviour. While at it, set the showpoint flag to print a\n> fixed number of digits after the decimal point, making logs more\n> readable.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 9 +++++++--\n> 1 file changed, 7 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index 2ff67ed98221..ed91e9277a16 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -9,6 +9,7 @@\n> \n> #include \n> #include \n> +#include \n> \n> #include \n> \n> @@ -271,8 +272,12 @@ void Awb::process(IPAContext &context,\n> activeState.awb.gains.automatic.blue = std::clamp(blueGain, 0.0, 1023.0 / 256);\n> activeState.awb.gains.automatic.green = 1.0;\n> \n> - LOG(RkISP1Awb, Debug) << \"Gain found for red: \" << activeState.awb.gains.automatic.red\n> - << \" and for blue: \" << activeState.awb.gains.automatic.blue;\n> + LOG(RkISP1Awb, Debug) << std::showpoint\n> + << \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n> + << \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\n> + << activeState.awb.gains.automatic.green << \", \"\n> + << activeState.awb.gains.automatic.blue << \"], temp \"\n> + << frameContext.awb.temperatureK << \"K\";\n\nThat's ok I think - but 'metadata, metadata, metadata' ... although -\nmetadata should only report what the /actual/ frame uses - while we\nmight really want the algorithms to report what they calculate even when\nwe're in manual mode....\n\nSo I think this is good ...\n\nReviewed-by: Kieran Bingham \n\n\n> }\n> \n> REGISTER_IPA_ALGORITHM(Awb, \"Awb\")\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69B44C3272\n\tfor ;\n\tTue, 20 Sep 2022 23:34:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B60BC621D6;\n\tWed, 21 Sep 2022 01:34:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04A2061F7D\n\tfor ;\n\tWed, 21 Sep 2022 01:34:34 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 76646415;\n\tWed, 21 Sep 2022 01:34:33 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663716875;\n\tbh=xUj6n4d4kX/maxphuP02Xdioml4haF6niGTtIlQwXR0=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=nE2cWUKmlESjssFUeY9LWLKNRRQPYQsb4EKcpwpAXrjaQn3PWO6LgQQs77PzIgZvE\n\tFZgzw09LQCdUIMvPRMLcWrzz0EUDiNhJg8qU1H0epIO2eJtv9imYcFZD95aXuOw6u/\n\ta3mz9RJQRUpabq/e/ZIHLB1NbTLKwDQFHyOyhOU7wvziEJNYvtlAuZeNb00j51fwDK\n\tb3O+sw66q+c4Tp6+/y530BoHoOAbz7bdmKaa5sS5tPL8FpTCfEwFSfmqGeKuTQNVY9\n\tIYmGtxt9WweFhoL4g9krywbumD3o7rXs2d1rPflX6YoJED7P0+yGY+TfFJtYCbs2Z6\n\tb8F6Hu4yUJ92g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663716873;\n\tbh=xUj6n4d4kX/maxphuP02Xdioml4haF6niGTtIlQwXR0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=IaS2eQ+G/BewFl+hHC78H1Qhq6fmSLgVUnrhwcf2MmgG4N4iRZF6qgbdptKqCjFWn\n\txh6ZlN3hyjUYWjfLoK2eQFQkeCqwrkeNPPpxx+lvlRt4HCQUf94KWfMYr+zOhw+Xnl\n\t1NOlhlHfNOMNhlBweOsgwfdGKz+hpNd9/iL8PIoQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IaS2eQ+G\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220908014200.28728-29-laurent.pinchart@ideasonboard.com>","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>\n\t<20220908014200.28728-29-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 21 Sep 2022 00:34:31 +0100","Message-ID":"<166371687119.18961.13470050380425839928@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v4 28/32] ipa: rkisp1: awb: Log means, \n\tgains and temperature in debug message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25078,"web_url":"https://patchwork.libcamera.org/comment/25078/","msgid":"<20220922103618.rzhytt4wy2f7vay7@uno.localdomain>","date":"2022-09-22T10:36:18","subject":"Re: [libcamera-devel] [PATCH v4 28/32] ipa: rkisp1: awb: Log means, \n\tgains and temperature in debug message","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Thu, Sep 08, 2022 at 04:41:56AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Extend the debug message in Awb::process() to log the means and color\n> temperature in addition to the gains. This is useful for debugging the\n> algorithm behaviour. While at it, set the showpoint flag to print a\n\n\"The character to use as decimal point character is determined by the\nnumpunct facet of the locale imbued in the stream at the time of\noutput, as described in std::num_put::put\"\n\nHow not to love C++\n\n\n> fixed number of digits after the decimal point, making logs more\n> readable.\n\nI still don't get how many characters are expected to be printed, but\nthat's ok\n\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 9 +++++++--\n> 1 file changed, 7 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index 2ff67ed98221..ed91e9277a16 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -9,6 +9,7 @@\n>\n> #include \n> #include \n> +#include \n>\n> #include \n>\n> @@ -271,8 +272,12 @@ void Awb::process(IPAContext &context,\n> \tactiveState.awb.gains.automatic.blue = std::clamp(blueGain, 0.0, 1023.0 / 256);\n> \tactiveState.awb.gains.automatic.green = 1.0;\n>\n> -\tLOG(RkISP1Awb, Debug) << \"Gain found for red: \" << activeState.awb.gains.automatic.red\n> -\t\t\t << \" and for blue: \" << activeState.awb.gains.automatic.blue;\n> +\tLOG(RkISP1Awb, Debug) << std::showpoint\n> +\t\t<< \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n> +\t\t<< \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\n> +\t\t<< activeState.awb.gains.automatic.green << \", \"\n> +\t\t<< activeState.awb.gains.automatic.blue << \"], temp \"\n> +\t\t<< frameContext.awb.temperatureK << \"K\";\n> }\n>\n> REGISTER_IPA_ALGORITHM(Awb, \"Awb\")\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77F87C0DA4\n\tfor ;\n\tThu, 22 Sep 2022 10:36:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CAEBB62203;\n\tThu, 22 Sep 2022 12:36:21 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::221])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40D856219A\n\tfor ;\n\tThu, 22 Sep 2022 12:36:20 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 76753240012;\n\tThu, 22 Sep 2022 10:36:19 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663842981;\n\tbh=25tWXvx8BNQxQZZXdKqPBjiZGU4WSfaz7gBcfn8Z+8I=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Xz0bl/8mzcFIZPmIv1WS0gfaIzUpnmGPzae0L6GJ4n2i7T9J1bXHUrvKuNA1iWpW5\n\tBi1F4Pcikj0qFWNXjIIXRl4KPchCmZ7ef3kr4+Z9UMpzzKF2Hx9EeRy09oTC1biLBV\n\td4DFSBCUsxYC66RAKgpLC6MGEKgxtUDYL4jqYnXyXatGpEyD7RadlBWG3rEGfcn1ff\n\tMDnGuNlKP5gjxFU/Be9Ef2NiqIkouDoqNPfsOPvzhEdYlLUcfuEZ6X5c4Xq1ySMgWZ\n\tR+jCfl56Jn6Lb/nvNgJdctfG3Bf/UpTPDQdpE9cDTvHhD2ITbvrPoUWpRWNK65v8nM\n\tkZ5JlDR0QxxAQ==","Date":"Thu, 22 Sep 2022 12:36:18 +0200","To":"Laurent Pinchart ","Message-ID":"<20220922103618.rzhytt4wy2f7vay7@uno.localdomain>","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>\n\t<20220908014200.28728-29-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220908014200.28728-29-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 28/32] ipa: rkisp1: awb: Log means, \n\tgains and temperature in debug message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25101,"web_url":"https://patchwork.libcamera.org/comment/25101/","msgid":"","date":"2022-09-22T22:31:06","subject":"Re: [libcamera-devel] [PATCH v4 28/32] ipa: rkisp1: awb: Log means, \n\tgains and temperature in debug message","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Sep 21, 2022 at 12:34:31AM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-09-08 02:41:56)\n> > Extend the debug message in Awb::process() to log the means and color\n> > temperature in addition to the gains. This is useful for debugging the\n> > algorithm behaviour. While at it, set the showpoint flag to print a\n> > fixed number of digits after the decimal point, making logs more\n> > readable.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/ipa/rkisp1/algorithms/awb.cpp | 9 +++++++--\n> > 1 file changed, 7 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> > index 2ff67ed98221..ed91e9277a16 100644\n> > --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> > +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> > @@ -9,6 +9,7 @@\n> > \n> > #include \n> > #include \n> > +#include \n> > \n> > #include \n> > \n> > @@ -271,8 +272,12 @@ void Awb::process(IPAContext &context,\n> > activeState.awb.gains.automatic.blue = std::clamp(blueGain, 0.0, 1023.0 / 256);\n> > activeState.awb.gains.automatic.green = 1.0;\n> > \n> > - LOG(RkISP1Awb, Debug) << \"Gain found for red: \" << activeState.awb.gains.automatic.red\n> > - << \" and for blue: \" << activeState.awb.gains.automatic.blue;\n> > + LOG(RkISP1Awb, Debug) << std::showpoint\n> > + << \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n> > + << \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\n> > + << activeState.awb.gains.automatic.green << \", \"\n> > + << activeState.awb.gains.automatic.blue << \"], temp \"\n> > + << frameContext.awb.temperatureK << \"K\";\n> \n> That's ok I think - but 'metadata, metadata, metadata' ... although -\n> metadata should only report what the /actual/ frame uses - while we\n> might really want the algorithms to report what they calculate even when\n> we're in manual mode....\n\nYes, that was the idea. We don't skip the calculation even in manual\nmode in order to always have a colour temperature estimate, so I thought\nwe could as well always log the computed gains.\n\n> So I think this is good ...\n> \n> Reviewed-by: Kieran Bingham \n> \n> > }\n> > \n> > REGISTER_IPA_ALGORITHM(Awb, \"Awb\")","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D37E9BD16B\n\tfor ;\n\tThu, 22 Sep 2022 22:31:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3111F62223;\n\tFri, 23 Sep 2022 00:31:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 26EF0621F8\n\tfor ;\n\tFri, 23 Sep 2022 00:31:22 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6FD2D4F7;\n\tFri, 23 Sep 2022 00:31:21 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663885884;\n\tbh=eqGK+Kx3iv7b6OI2XQq5oP3Xe9bcHfgpQx2heTDlgEk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=QoyH2qOSfnTJrDkVRQqN61W6hpRciI+Z0WBfvg4PGGJtSOevEizEdpBstQCyYYKVO\n\tJtXf+9VcNnojdSqJWAmpjMn/UJ87wGLd22UenySYS/uHE8Y6E176X+xf2NwwC9H3im\n\tc7hHTSIUYLa4cIn8mfGgOUq4R9ahGDIGfoACPQ8VacDTsOmMKn14v1uRqpSVeamTx8\n\tJZaLRHiZEZ4FBVJeBMiwRetns9BaVUJUdk3fmn80g1N32pHBB1wIoQ0KWXgs8XuWmG\n\tIbq86s1SYlqS6l5kxWYu+KrU7kQYNHERsOcsYGUuITSaGqpOQrrYbvErKM2xSMWqIo\n\tnyaUFaod47Ndw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663885881;\n\tbh=eqGK+Kx3iv7b6OI2XQq5oP3Xe9bcHfgpQx2heTDlgEk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=M3s3YpXALNwVVg4qvWffdiEqGdFRuFWVdAMWWTKI5A6tNkiGE1KRDtTsZLyQi2i2K\n\tXNVWzL5fmSbeubXlnkufqJPIKJpWJeRiqJOgUeXTYlwMG9PIOGPU0YHuESfCxWQAvs\n\tO6sYP5lJCeEQlySc5+GdqiPSPsJcEzRY2VHPlmLM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"M3s3YpXA\"; dkim-atps=neutral","Date":"Fri, 23 Sep 2022 01:31:06 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>\n\t<20220908014200.28728-29-laurent.pinchart@ideasonboard.com>\n\t<166371687119.18961.13470050380425839928@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166371687119.18961.13470050380425839928@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v4 28/32] ipa: rkisp1: awb: Log means, \n\tgains and temperature in debug message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]