[{"id":25039,"web_url":"https://patchwork.libcamera.org/comment/25039/","msgid":"<166371602163.18961.795627642037733565@Monstersaurus>","date":"2022-09-20T23:20:21","subject":"Re: [libcamera-devel] [PATCH v4 26/32] ipa: rkisp1: awb: Store\n\tcolor temperature as an integer","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-09-08 02:41:54)\n> The color temperature doesn't need floating point precision, and is\n> calculated by Awb::estimateCCT() as an unsigned integer. Store it with\n> the same data type in the frame context.\n> \n\nExcepting that I suspect we don't need to store the colour temperature\nin the FrameContext, but it could go directly to metadata ... this is\nfine if we don't want to get there yet.\n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/ipa_context.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index c15b908afcc8..53787320e565 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -100,7 +100,7 @@ struct RkISP1FrameContext : public FrameContext {\n> double blue;\n> } gains;\n> \n> - double temperatureK;\n> + unsigned int temperatureK;\n> bool autoEnabled;\n> } awb;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C9FDC3272\n\tfor ;\n\tTue, 20 Sep 2022 23:20:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF2F9621D2;\n\tWed, 21 Sep 2022 01:20:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A868661F7D\n\tfor ;\n\tWed, 21 Sep 2022 01:20:24 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4DD6C415;\n\tWed, 21 Sep 2022 01:20:24 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663716025;\n\tbh=DSDl2EYGBwmVgzqWa+yoNhhdQGVhHz4+4z4pNPimSjo=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=FlCkZsMbA5kWdPbl1j3xGh1YRW8uK0wn6LwASzKRsq+uYTYsYjZOZ3i0l8KSTuCx+\n\tYAFrkd92UCh0fR8ZgDOoQKPlsrCsZsVfd89bMZOswpBIPYnXv1I2zm6BJYUf9m8LZs\n\tzhCTedUo3f9QBJxl9l5PPr9DsWQimAxlY4Kf6Oxap2DqvDjuovCDoDdYLqLllAZiCj\n\tei2Cv2QvOUUb6kJyk+z/KzZubsM96Xz3OLn0uo2NTjbCE41/+R1fUKQ7n9QzDmEKKo\n\tU/aXE90/vKKKPBZ5NRHuYEYw2XjdbQy6we0hR0S9bTWXLms2eeZlo608fL9+rT2/qm\n\t2T5iwk7W796Mg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663716024;\n\tbh=DSDl2EYGBwmVgzqWa+yoNhhdQGVhHz4+4z4pNPimSjo=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=i8wHkhXVWwjskR/rrwrkSwR9HFoN/uZGfW3BEuV2tSeY2JQ0IVwghKOI7RbxFk+nc\n\tf/M3zm5eTwwR03NySC1RAXGFpbyrIExqqjFtxdiNsN6UEUjreP0AExOHMrHw7AIZI0\n\t6242GHURwXDVBcLlA9h6J11tHZKwSDEX0AcxVaEc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"i8wHkhXV\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220908014200.28728-27-laurent.pinchart@ideasonboard.com>","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>\n\t<20220908014200.28728-27-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 21 Sep 2022 00:20:21 +0100","Message-ID":"<166371602163.18961.795627642037733565@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v4 26/32] ipa: rkisp1: awb: Store\n\tcolor temperature as an integer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25076,"web_url":"https://patchwork.libcamera.org/comment/25076/","msgid":"<20220922102610.wryng7wi5f3y4r37@uno.localdomain>","date":"2022-09-22T10:26:10","subject":"Re: [libcamera-devel] [PATCH v4 26/32] ipa: rkisp1: awb: Store\n\tcolor temperature as an integer","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Thu, Sep 08, 2022 at 04:41:54AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The color temperature doesn't need floating point precision, and is\n> calculated by Awb::estimateCCT() as an unsigned integer. Store it with\n> the same data type in the frame context.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/rkisp1/ipa_context.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index c15b908afcc8..53787320e565 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -100,7 +100,7 @@ struct RkISP1FrameContext : public FrameContext {\n> \t\t\tdouble blue;\n> \t\t} gains;\n>\n> -\t\tdouble temperatureK;\n> +\t\tunsigned int temperatureK;\n> \t\tbool autoEnabled;\n> \t} awb;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 607E2C0DA4\n\tfor ;\n\tThu, 22 Sep 2022 10:26:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1842162202;\n\tThu, 22 Sep 2022 12:26:15 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E75046219A\n\tfor ;\n\tThu, 22 Sep 2022 12:26:12 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 384BD60008;\n\tThu, 22 Sep 2022 10:26:11 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663842375;\n\tbh=BkUHLAYpE1GzzfLTyxTPMSuBTGbQZ8aezKTsTq6Xcfs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Onj3jc9CNqqIR7GEou1VcLptuQYyQR3mz9nQ0noZVgCCnJG93oDpVvuy0tHAw8DLm\n\tfK0A9/6E/LrP7C4Eawp+04dL1Y8bLWqBK6frlpBfAR11b4moI0UGT/t8z2Jx5nzkc7\n\tz2JDXacHuBZmQyCG2+mrj+FDnUHPsxfDNWqvXYb8cR/Usyqd8rsCslsv6XYmW2XUhV\n\tumgSyT4HQ/Jhw6FGH8wVOOYMGjQdWINHJB1OZnSHXIOrflkG/xZta+lUYmyOvuy0aV\n\t8eu4T7ssZ1froo4gDl3AuLKU+qLLCEaWuVIAcMzSD+LeW//ucFiWyMIB6LhydsXJtN\n\t+F9Ll1ByKWp0w==","Date":"Thu, 22 Sep 2022 12:26:10 +0200","To":"Laurent Pinchart ","Message-ID":"<20220922102610.wryng7wi5f3y4r37@uno.localdomain>","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>\n\t<20220908014200.28728-27-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220908014200.28728-27-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 26/32] ipa: rkisp1: awb: Store\n\tcolor temperature as an integer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]