[{"id":25021,"web_url":"https://patchwork.libcamera.org/comment/25021/","msgid":"<166368518816.3912877.9141551336398785333@Monstersaurus>","date":"2022-09-20T14:46:28","subject":"Re: [libcamera-devel] [PATCH v4 15/32] ipa: rkisp1: Use base\n\tFrameContext class","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-09-08 02:41:43)\n> Inherit from the base FrameContext class in the RkISP1 IPAFrameContext.\n> As the IPAFrameContext is currently unused, this change is a no-op, but\n> it prepares the RkISP1 IPA module for frame context queue support.\n> \n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/rkisp1/ipa_context.h | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index 5590482c6a8c..f6b3e6eb951c 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -14,6 +14,8 @@\n> \n> #include \n> \n> +#include \n> +\n> namespace libcamera {\n> \n> namespace ipa::rkisp1 {\n> @@ -89,7 +91,7 @@ struct IPAActiveState {\n> unsigned int frameCount;\n> };\n> \n> -struct IPAFrameContext {\n> +struct IPAFrameContext : public FrameContext {\n> };\n> \n> struct IPAContext {\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A30EC3272\n\tfor ;\n\tTue, 20 Sep 2022 14:46:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D2916621B9;\n\tTue, 20 Sep 2022 16:46:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C1266218B\n\tfor ;\n\tTue, 20 Sep 2022 16:46:31 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BB6176BE;\n\tTue, 20 Sep 2022 16:46:30 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663685191;\n\tbh=BxWTluysttg/aRYUhWoIAT4F2RVYBt7WRw+EBeCGCV4=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=WlOUGtGNgKJFvdgRlrm7hJp/281r24/YW1SrGU4tmls6AaHSXJmFGG7wOQER1WMuY\n\tOTVCv95eP4QS9meXqjQnM0riwX1C645/JEtGB02GlwOQA0aLTEiqg+AaAPywDHdwLf\n\t2zTcjj/LUMTJGxx8XJSR3Z2J44Icqwfeb57Nqe6kKr39AhzAHflZnhX4KvRzAmfbKa\n\tLvHDdhGeIg9nvkNqJzd1dMWJwqmKiO9Z1sVqQX8rmPxmgld7CO/ZJFOFxmOx0iUrRh\n\tYjnf7cOj8EgKFMaAlx7zN13q4xJUZMz7armQj6s0BO3dRaUdnF8Uub+Jd1bw5Cwtt2\n\tf9poyfCsLgjng==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663685190;\n\tbh=BxWTluysttg/aRYUhWoIAT4F2RVYBt7WRw+EBeCGCV4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=MDoJ4ZAslkvZrOxnLvNIPEaNvWR6c6xCxWhz4rECo1+DYm3MN76C89Q/SOW9Uypp2\n\tYwwD3KFspQ26OtnfKP/ONr0Namr/NRogMDWxhGCDylWEHEElpnUBZqHevv41cw1w3t\n\tQhQc7ILsC3ZlRgLsGKVeFvMlnJmpUBRni5KD1CvA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MDoJ4ZAs\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220908014200.28728-16-laurent.pinchart@ideasonboard.com>","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>\n\t<20220908014200.28728-16-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 20 Sep 2022 15:46:28 +0100","Message-ID":"<166368518816.3912877.9141551336398785333@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v4 15/32] ipa: rkisp1: Use base\n\tFrameContext class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25061,"web_url":"https://patchwork.libcamera.org/comment/25061/","msgid":"<20220921183522.ovorvavn7beuzcq3@uno.localdomain>","date":"2022-09-21T18:35:22","subject":"Re: [libcamera-devel] [PATCH v4 15/32] ipa: rkisp1: Use base\n\tFrameContext class","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Can't argue :)\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\nOn Thu, Sep 08, 2022 at 04:41:43AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Inherit from the base FrameContext class in the RkISP1 IPAFrameContext.\n> As the IPAFrameContext is currently unused, this change is a no-op, but\n> it prepares the RkISP1 IPA module for frame context queue support.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/ipa_context.h | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index 5590482c6a8c..f6b3e6eb951c 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -14,6 +14,8 @@\n>\n> #include \n>\n> +#include \n> +\n> namespace libcamera {\n>\n> namespace ipa::rkisp1 {\n> @@ -89,7 +91,7 @@ struct IPAActiveState {\n> \tunsigned int frameCount;\n> };\n>\n> -struct IPAFrameContext {\n> +struct IPAFrameContext : public FrameContext {\n> };\n>\n> struct IPAContext {\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7432C0DA4\n\tfor ;\n\tWed, 21 Sep 2022 18:35:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3F1D621F4;\n\tWed, 21 Sep 2022 20:35:25 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::224])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0EB4600AA\n\tfor ;\n\tWed, 21 Sep 2022 20:35:24 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 39390E0005;\n\tWed, 21 Sep 2022 18:35:23 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663785326;\n\tbh=HDTY4KFowTdjC/CG6xytZsYL/cWWN9k9C4NwR577AYI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ixndhxXvkBJhorhOxzd3wtcWVezpmjCBV1jQ0svkKKsmt0aX5wVjG1QaATHBMR4+v\n\tdNciC8k7jR2r58SOE163A3Wgl7aG0KYCPSVuj1pbDxXUQySdeP4Jg2y7iyaxlvCkMA\n\tV6618HWVrCkz5J49qrHk4vaseXfE5eGtEmPBBHxL+wjH14jpbQP0+jSl9o+hKQov5D\n\tJmRCy7tstuYg4dWmENS7GoXMhIAvDEt9bj0Ne9Pgrsr2Sns7fSn3+d75FgnT5vXpcd\n\tsawbgEj2PdMlaVPjwuDIfY2Zaj7/kw4hG5w+J9S9ObGO1EQLzgf8ZAKI3Chc4qPwTU\n\t0cqMwim/QqbFg==","Date":"Wed, 21 Sep 2022 20:35:22 +0200","To":"Laurent Pinchart ","Message-ID":"<20220921183522.ovorvavn7beuzcq3@uno.localdomain>","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>\n\t<20220908014200.28728-16-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220908014200.28728-16-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 15/32] ipa: rkisp1: Use base\n\tFrameContext class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]