[{"id":25019,"web_url":"https://patchwork.libcamera.org/comment/25019/","msgid":"<166368437787.3912877.17979179531123599498@Monstersaurus>","date":"2022-09-20T14:32:57","subject":"Re: [libcamera-devel] [PATCH v4 13/32] ipa: rkisp1: Sort\n\tdocumentation of the IPA context","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-09-08 02:41:41)\n> The documentation of the IPA context structures is separate from the\n> documentation of the structure members. Sort the documentation block to\n> group members with their structure.\n> \n\nSimple move is fine with me. I can see the text itself is unchanged.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/ipa_context.cpp | 62 +++++++++++++++++-----------------\n> 1 file changed, 31 insertions(+), 31 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\n> index f64af732260c..cc66bc70ac44 100644\n> --- a/src/ipa/rkisp1/ipa_context.cpp\n> +++ b/src/ipa/rkisp1/ipa_context.cpp\n> @@ -24,37 +24,6 @@ namespace libcamera::ipa::rkisp1 {\n> * may also be updated in the start() operation.\n> */\n> \n> -/**\n> - * \\struct IPAFrameContext\n> - * \\brief Per-frame context for algorithms\n> - *\n> - * The frame context stores data specific to a single frame processed by the\n> - * IPA. Each frame processed by the IPA has a context associated with it,\n> - * accessible through the IPAContext structure.\n> - *\n> - * \\todo Detail how to access contexts for a particular frame\n> - *\n> - * Each of the fields in the frame context belongs to either a specific\n> - * algorithm, or to the top-level IPA module. A field may be read by any\n> - * algorithm, but should only be written by its owner.\n> - */\n> -\n> -/**\n> - * \\struct IPAContext\n> - * \\brief Global IPA context data shared between all algorithms\n> - *\n> - * \\var IPAContext::configuration\n> - * \\brief The IPA session configuration, immutable during the session\n> - *\n> - * \\var IPAContext::frameContext\n> - * \\brief The frame context for the frame being processed\n> - *\n> - * \\todo While the frame context is supposed to be per-frame, this\n> - * single frame context stores data related to both the current frame\n> - * and the previous frames, with fields being updated as the algorithms\n> - * are run. This needs to be turned into real per-frame data storage.\n> - */\n> -\n> /**\n> * \\var IPASessionConfiguration::agc\n> * \\brief AGC parameters configuration of the IPA\n> @@ -115,6 +84,21 @@ namespace libcamera::ipa::rkisp1 {\n> * \\brief Sensor output resolution\n> */\n> \n> +/**\n> + * \\struct IPAFrameContext\n> + * \\brief Per-frame context for algorithms\n> + *\n> + * The frame context stores data specific to a single frame processed by the\n> + * IPA. Each frame processed by the IPA has a context associated with it,\n> + * accessible through the IPAContext structure.\n> + *\n> + * \\todo Detail how to access contexts for a particular frame\n> + *\n> + * Each of the fields in the frame context belongs to either a specific\n> + * algorithm, or to the top-level IPA module. A field may be read by any\n> + * algorithm, but should only be written by its owner.\n> + */\n> +\n> /**\n> * \\var IPAFrameContext::agc\n> * \\brief Context for the Automatic Gain Control algorithm\n> @@ -216,4 +200,20 @@ namespace libcamera::ipa::rkisp1 {\n> * Algorithm::prepare() function of all algorithms.\n> */\n> \n> +/**\n> + * \\struct IPAContext\n> + * \\brief Global IPA context data shared between all algorithms\n> + *\n> + * \\var IPAContext::configuration\n> + * \\brief The IPA session configuration, immutable during the session\n> + *\n> + * \\var IPAContext::frameContext\n> + * \\brief The frame context for the frame being processed\n> + *\n> + * \\todo While the frame context is supposed to be per-frame, this\n> + * single frame context stores data related to both the current frame\n> + * and the previous frames, with fields being updated as the algorithms\n> + * are run. This needs to be turned into real per-frame data storage.\n> + */\n> +\n> } /* namespace libcamera::ipa::rkisp1 */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4661EC0DA4\n\tfor ;\n\tTue, 20 Sep 2022 14:33:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E933E621B8;\n\tTue, 20 Sep 2022 16:33:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E63766218B\n\tfor ;\n\tTue, 20 Sep 2022 16:33:00 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 925316BE;\n\tTue, 20 Sep 2022 16:33:00 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663684381;\n\tbh=mFvvFAC35b4fC6cqo2Zt4A7cwzuhUxFHsJW7tJcsHaI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=VReMj1OiQ2pg6hEZyn7apFgjzXwsMQ60gODZms3B2jXI7GosMS2UYYmD/b/fk5o91\n\tZgAxjdUUThUwEeYB5C8z7NkUSINfxYxr6qP86Kl3U5q9JCSJX7NYVPKst/JpK0PG3B\n\tEPOaoZywThOfazG7tRiA910vTPZbL9BRLqgkb07/S828LsvCbA9CiZ5UJX8DlbwuGD\n\tjpX2gPRqbYoQF2RPFc1WCvMIAi8tlfAQV8NdFruVu5nKU2Z9IKUeXoMrKcG2AFi/7g\n\t095bocLwmhrXneia25log3sHUEUpwgRpNlQoL34sDEBnaPoZDYfGSdnDFTOW5z5p7L\n\tvV7D216d2GG0Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663684380;\n\tbh=mFvvFAC35b4fC6cqo2Zt4A7cwzuhUxFHsJW7tJcsHaI=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Kg+OLmvpgPrrGQFijJnGtoiiUQBzOenGXN4dGFG8bOGexHysB1tlPp4xDW5Wz+WaH\n\tLtU5qR1+nx+MxvU5kN38WRRLGJPUN7e1pevdzTeNCKOvtAicKxdWK8eg9RVzEYXRXV\n\tTHBH7Fr9PEC4goB80ZWnZ22jwJrSKwzosu8ZavTA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Kg+OLmvp\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220908014200.28728-14-laurent.pinchart@ideasonboard.com>","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>\n\t<20220908014200.28728-14-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 20 Sep 2022 15:32:57 +0100","Message-ID":"<166368437787.3912877.17979179531123599498@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v4 13/32] ipa: rkisp1: Sort\n\tdocumentation of the IPA context","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25058,"web_url":"https://patchwork.libcamera.org/comment/25058/","msgid":"<20220921182040.qownyiq75b5raxv7@uno.localdomain>","date":"2022-09-21T18:20:40","subject":"Re: [libcamera-devel] [PATCH v4 13/32] ipa: rkisp1: Sort\n\tdocumentation of the IPA context","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Thu, Sep 08, 2022 at 04:41:41AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The documentation of the IPA context structures is separate from the\n> documentation of the structure members. Sort the documentation block to\n> group members with their structure.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\n\n> ---\n> src/ipa/rkisp1/ipa_context.cpp | 62 +++++++++++++++++-----------------\n> 1 file changed, 31 insertions(+), 31 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\n> index f64af732260c..cc66bc70ac44 100644\n> --- a/src/ipa/rkisp1/ipa_context.cpp\n> +++ b/src/ipa/rkisp1/ipa_context.cpp\n> @@ -24,37 +24,6 @@ namespace libcamera::ipa::rkisp1 {\n> * may also be updated in the start() operation.\n> */\n>\n> -/**\n> - * \\struct IPAFrameContext\n> - * \\brief Per-frame context for algorithms\n> - *\n> - * The frame context stores data specific to a single frame processed by the\n> - * IPA. Each frame processed by the IPA has a context associated with it,\n> - * accessible through the IPAContext structure.\n> - *\n> - * \\todo Detail how to access contexts for a particular frame\n> - *\n> - * Each of the fields in the frame context belongs to either a specific\n> - * algorithm, or to the top-level IPA module. A field may be read by any\n> - * algorithm, but should only be written by its owner.\n> - */\n> -\n> -/**\n> - * \\struct IPAContext\n> - * \\brief Global IPA context data shared between all algorithms\n> - *\n> - * \\var IPAContext::configuration\n> - * \\brief The IPA session configuration, immutable during the session\n> - *\n> - * \\var IPAContext::frameContext\n> - * \\brief The frame context for the frame being processed\n> - *\n> - * \\todo While the frame context is supposed to be per-frame, this\n> - * single frame context stores data related to both the current frame\n> - * and the previous frames, with fields being updated as the algorithms\n> - * are run. This needs to be turned into real per-frame data storage.\n> - */\n> -\n> /**\n> * \\var IPASessionConfiguration::agc\n> * \\brief AGC parameters configuration of the IPA\n> @@ -115,6 +84,21 @@ namespace libcamera::ipa::rkisp1 {\n> * \\brief Sensor output resolution\n> */\n>\n> +/**\n> + * \\struct IPAFrameContext\n> + * \\brief Per-frame context for algorithms\n> + *\n> + * The frame context stores data specific to a single frame processed by the\n> + * IPA. Each frame processed by the IPA has a context associated with it,\n> + * accessible through the IPAContext structure.\n> + *\n> + * \\todo Detail how to access contexts for a particular frame\n> + *\n> + * Each of the fields in the frame context belongs to either a specific\n> + * algorithm, or to the top-level IPA module. A field may be read by any\n> + * algorithm, but should only be written by its owner.\n> + */\n> +\n> /**\n> * \\var IPAFrameContext::agc\n> * \\brief Context for the Automatic Gain Control algorithm\n> @@ -216,4 +200,20 @@ namespace libcamera::ipa::rkisp1 {\n> * Algorithm::prepare() function of all algorithms.\n> */\n>\n> +/**\n> + * \\struct IPAContext\n> + * \\brief Global IPA context data shared between all algorithms\n> + *\n> + * \\var IPAContext::configuration\n> + * \\brief The IPA session configuration, immutable during the session\n> + *\n> + * \\var IPAContext::frameContext\n> + * \\brief The frame context for the frame being processed\n> + *\n> + * \\todo While the frame context is supposed to be per-frame, this\n> + * single frame context stores data related to both the current frame\n> + * and the previous frames, with fields being updated as the algorithms\n> + * are run. This needs to be turned into real per-frame data storage.\n> + */\n> +\n> } /* namespace libcamera::ipa::rkisp1 */\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5199C0DA4\n\tfor ;\n\tWed, 21 Sep 2022 18:20:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D5EB621EF;\n\tWed, 21 Sep 2022 20:20:43 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45C63600AA\n\tfor ;\n\tWed, 21 Sep 2022 20:20:42 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id A4577200003;\n\tWed, 21 Sep 2022 18:20:41 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663784443;\n\tbh=JMRFo/bKtQyn/95OqkGu8DL5jxsPgMTDydc/lPn1jMY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=b5CUEr2WxhY7O232rkrbsixkkqbaKiuKctLKqkMxR4DizGCZN4lrBearwRDlMLmn8\n\tKf/FV4DzzXsFIQu9oW8k6OJ2tUMmz9yETlOipiUJZ9a6yP8Oz6y/5eWMqwl0FxVTSu\n\tYOd6tk2ElM7QadUBUS2hGZK21ekl7mDD5usoyfNsjbxJwQ6eG2eBKZWVH9WzhWD8U8\n\t0ijzLD355wYMH+ThruZCWGhzt518hKOYo0hLFaUUK3k2IMcbY6+rcUbPLkInmLX2Iq\n\tzOzPmif9TIJQEHBuFUXN5/8BW9lwtxC72mmjWnsweYCrDuIBqmwLfoxIOHDADA87kH\n\tw1hi8uBh9X+Pw==","Date":"Wed, 21 Sep 2022 20:20:40 +0200","To":"Laurent Pinchart ","Message-ID":"<20220921182040.qownyiq75b5raxv7@uno.localdomain>","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>\n\t<20220908014200.28728-14-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220908014200.28728-14-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 13/32] ipa: rkisp1: Sort\n\tdocumentation of the IPA context","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]