[{"id":25018,"web_url":"https://patchwork.libcamera.org/comment/25018/","msgid":"<166368428655.3912877.13668419355106673097@Monstersaurus>","date":"2022-09-20T14:31:26","subject":"Re: [libcamera-devel] [PATCH v4 12/32] ipa: rkisp1: Remove unused\n\tclass member","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-09-08 02:41:40)\n> From: Jacopo Mondi \n> \n> The \"autoExposure\" class member is not used.\n> \n> Remove it.\n\nWell that's easy.\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 5 -----\n> 1 file changed, 5 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 07210d16b5b5..f7a17459b6c3 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -71,9 +71,6 @@ private:\n> \n> ControlInfoMap ctrls_;\n> \n> - /* Camera sensor controls. */\n> - bool autoExposure_;\n> -\n> /* revision-specific data */\n> rkisp1_cif_isp_version hwRevision_;\n> unsigned int hwHistBinNMax_;\n> @@ -216,8 +213,6 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n> return -EINVAL;\n> }\n> \n> - autoExposure_ = true;\n> -\n> int32_t minExposure = itExp->second.min().get();\n> int32_t maxExposure = itExp->second.max().get();\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F4FDC3272\n\tfor ;\n\tTue, 20 Sep 2022 14:31:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C420621B7;\n\tTue, 20 Sep 2022 16:31:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED0F16218B\n\tfor ;\n\tTue, 20 Sep 2022 16:31:28 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99EC56BE;\n\tTue, 20 Sep 2022 16:31:28 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663684291;\n\tbh=nf/HpVc7vkuWVFcIKKApiNfgjOik2tSgPv41Nd75r5U=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=O2A/5A3w9PCUUHTlii5HVsGyHYZ4ysrhx1jP7KJ+LlZPJ0dNBG5aoODTEkgW1ByAd\n\tLZUcC89L3UMLMDg5+1R/qdz/iYcI913IDzlBsxMaPtby757I6ccKAUPoODD0rdPvyQ\n\tR5B/qQUEV4B6AVxJB9wTfEupoLK0fERgq4sLd8GRH/RVcrfAWGT03nlhVFNSCW9Jxd\n\tHhAPHo5iBnTct4PRzgN1HIm6V/2sUe4APmaF6zu5lHlo8qIGXwpD0VBKMPhXTOjXLp\n\tkunG4cfr6Sn1MfFvoC/8882UHk697uhUPIcDzeBQGOMR+ti7rUq59DHsidMui2h+Al\n\tj459co3hp8ZBg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663684288;\n\tbh=nf/HpVc7vkuWVFcIKKApiNfgjOik2tSgPv41Nd75r5U=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=VNGgtNaNJFEe8Sob5Zq38PSQfPDgdWGM8PzvRw6BY6Gbq8dA72iomWGw8OoMoINWY\n\t6rggDScHm1AKmDY9Fm4uGg44pTK7hrAjICIssvRJWMw/dc+dI2mxIY60KRV3acTmrL\n\tha1c+5lNcNsEkOvncClRx3vLslSPswI83lv6zo+Y="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VNGgtNaN\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220908014200.28728-13-laurent.pinchart@ideasonboard.com>","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>\n\t<20220908014200.28728-13-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 20 Sep 2022 15:31:26 +0100","Message-ID":"<166368428655.3912877.13668419355106673097@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v4 12/32] ipa: rkisp1: Remove unused\n\tclass member","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]