[{"id":25008,"web_url":"https://patchwork.libcamera.org/comment/25008/","msgid":"<166368010639.3912877.1197019741967535600@Monstersaurus>","date":"2022-09-20T13:21:46","subject":"Re: [libcamera-devel] [PATCH v4 02/32] ipa: ipu3: af: Pass context\n\treference to afIsOutOfFocus()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-09-08 02:41:30)\n> Avoid copying the whole IPA context by passing a reference to the\n> Af::afIsOutOfFocus() function.\n\nWe need to disable/delete the implicit copy constructor of the IPA\ncontext...\n\nIs that something you have already?\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/ipu3/algorithms/af.cpp | 2 +-\n> src/ipa/ipu3/algorithms/af.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\n> index 106a7614e2c7..9127c24f1287 100644\n> --- a/src/ipa/ipu3/algorithms/af.cpp\n> +++ b/src/ipa/ipu3/algorithms/af.cpp\n> @@ -383,7 +383,7 @@ double Af::afEstimateVariance(Span y_items, bool isY1)\n> * \\return True if the variance threshold is crossed indicating lost focus,\n> * false otherwise\n> */\n> -bool Af::afIsOutOfFocus(IPAContext context)\n> +bool Af::afIsOutOfFocus(IPAContext &context)\n> {\n> const uint32_t diff_var = std::abs(currentVariance_ -\n> context.activeState.af.maxVariance);\n> diff --git a/src/ipa/ipu3/algorithms/af.h b/src/ipa/ipu3/algorithms/af.h\n> index ccf015f3f8f5..9b93594898bb 100644\n> --- a/src/ipa/ipu3/algorithms/af.h\n> +++ b/src/ipa/ipu3/algorithms/af.h\n> @@ -44,7 +44,7 @@ private:\n> void afIgnoreFrameReset();\n> double afEstimateVariance(Span y_items, bool isY1);\n> \n> - bool afIsOutOfFocus(IPAContext context);\n> + bool afIsOutOfFocus(IPAContext &context);\n> \n> /* VCM step configuration. It is the current setting of the VCM step. */\n> uint32_t focus_;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13005C3272\n\tfor ;\n\tTue, 20 Sep 2022 13:21:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8171621AB;\n\tTue, 20 Sep 2022 15:21:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30D4D6218B\n\tfor ;\n\tTue, 20 Sep 2022 15:21:49 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D8596BE;\n\tTue, 20 Sep 2022 15:21:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663680110;\n\tbh=e52oNXwc4Iaff+ftd2IJdhi+JK7PECZdM539vwYYqYo=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Tn6rDt4nRHU6qR+VJmRFjrpBOykzgiLfMYr659lTRVgpxCNmXZAWeaTE442MXS6O8\n\tTziaX2HGSTMNf9a5zUlr8TgdzBXsWI7K0mO2XPsmaXnXHNMF6pJnVMCUj8o9uAv2fV\n\tABto4rgvvts4zfCTOc+tC1+oXiMt+fW/OKj3/6nLEWIR0A8HdgrZMWCEylZgYySFWY\n\tydQZ99WGA1Da1ylN/HnXOV3wBS4h1Dc9v7XfHxwuaqEZBAXigRT/rMZtph68RCgeuk\n\t/ag5CXz52OBV1LSyFyuRuqucqkvhw3zBTDb/b5cqKLka76+IaE3YHEIqtTsGqacaoZ\n\tvx8t96D9XPWpQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663680108;\n\tbh=e52oNXwc4Iaff+ftd2IJdhi+JK7PECZdM539vwYYqYo=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Ka6g46D8IhqW43SL1ttXByX+JYH7E6th1ckp/fwT6nXiJiedw0EffN282hO++wEEf\n\tEnJlU4kpngnRrN912MuMn55rgBeLKlWt3CH6nF4tUaoOl03EUYnFksGiE+GSj5uMTj\n\tBBVU3FaRfOoUgRGZpUEDRbwNWBvDkv6XB9UQ2eCk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ka6g46D8\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220908014200.28728-3-laurent.pinchart@ideasonboard.com>","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>\n\t<20220908014200.28728-3-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 20 Sep 2022 14:21:46 +0100","Message-ID":"<166368010639.3912877.1197019741967535600@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v4 02/32] ipa: ipu3: af: Pass context\n\treference to afIsOutOfFocus()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25024,"web_url":"https://patchwork.libcamera.org/comment/25024/","msgid":"","date":"2022-09-20T18:56:37","subject":"Re: [libcamera-devel] [PATCH v4 02/32] ipa: ipu3: af: Pass context\n\treference to afIsOutOfFocus()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, Sep 20, 2022 at 02:21:46PM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-09-08 02:41:30)\n> > Avoid copying the whole IPA context by passing a reference to the\n> > Af::afIsOutOfFocus() function.\n> \n> We need to disable/delete the implicit copy constructor of the IPA\n> context...\n> \n> Is that something you have already?\n\nNo I don't. It would indeed be useful. That will need to be done\nindividually in IPA modules though, as there's no base class for the\ncontext, but I don't think that's a problem. I'll add a patch on top.\n\n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/ipa/ipu3/algorithms/af.cpp | 2 +-\n> > src/ipa/ipu3/algorithms/af.h | 2 +-\n> > 2 files changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\n> > index 106a7614e2c7..9127c24f1287 100644\n> > --- a/src/ipa/ipu3/algorithms/af.cpp\n> > +++ b/src/ipa/ipu3/algorithms/af.cpp\n> > @@ -383,7 +383,7 @@ double Af::afEstimateVariance(Span y_items, bool isY1)\n> > * \\return True if the variance threshold is crossed indicating lost focus,\n> > * false otherwise\n> > */\n> > -bool Af::afIsOutOfFocus(IPAContext context)\n> > +bool Af::afIsOutOfFocus(IPAContext &context)\n> > {\n> > const uint32_t diff_var = std::abs(currentVariance_ -\n> > context.activeState.af.maxVariance);\n> > diff --git a/src/ipa/ipu3/algorithms/af.h b/src/ipa/ipu3/algorithms/af.h\n> > index ccf015f3f8f5..9b93594898bb 100644\n> > --- a/src/ipa/ipu3/algorithms/af.h\n> > +++ b/src/ipa/ipu3/algorithms/af.h\n> > @@ -44,7 +44,7 @@ private:\n> > void afIgnoreFrameReset();\n> > double afEstimateVariance(Span y_items, bool isY1);\n> > \n> > - bool afIsOutOfFocus(IPAContext context);\n> > + bool afIsOutOfFocus(IPAContext &context);\n> > \n> > /* VCM step configuration. It is the current setting of the VCM step. */\n> > uint32_t focus_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7D56C0DA4\n\tfor ;\n\tTue, 20 Sep 2022 18:56:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41AC9621C3;\n\tTue, 20 Sep 2022 20:56:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 83D5B6218B\n\tfor ;\n\tTue, 20 Sep 2022 20:56:52 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9EB56BE;\n\tTue, 20 Sep 2022 20:56:51 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663700213;\n\tbh=axb5gutv1eSKG9Qmc9TH/KxfsuacT3v7ZFeVCuqYkLY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=CNtbLeFTJ0C805jiDWT907LlIc5Rbjz7BqV3DyFejB/Q1V7iXQnHdIoZLDWDmVDbq\n\ttfttNF4sWAlT5D8WZI9LvN4QC9yMT4R5qVbmpVRIE9ppqIR5GyZfBrVu9/Q0oTBDWt\n\tXKUmi6MR1QITeRKNqLe/RQ0HAyZqOPwY3RTGDG17PYtugDeigvXUxkTH0OIquoW2au\n\t6teA0NaQgMllYniu9SLz1QXsxJ6yD7xJcQ3KAgTuYFEB21HmX+9NEWY5fyWCT4qkSx\n\tpjLmqDsyQ9B8OyoLTj292tj6tUyoHZz+YiRhiK3I0ZdasNhrzkk6fTvcF4PZ01C/uX\n\tbkFLaU9lZnzZg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1663700212;\n\tbh=axb5gutv1eSKG9Qmc9TH/KxfsuacT3v7ZFeVCuqYkLY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IwM3Sx78BL+Cz2ZKWsbP9rtcXslFywug+0q2GKdOuJzHNSS23KbTHxcxRnsg5kgtg\n\tmeTp3PGQabibzU43JaMH17O4dHuryAxwsb7GjNRO/rjJz19PBNKT257+rAwzgUMCTL\n\t2CxcYoeBofX8LVM+FlLgYKktzE0Xu23tAfxDhyl0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IwM3Sx78\"; dkim-atps=neutral","Date":"Tue, 20 Sep 2022 21:56:37 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>\n\t<20220908014200.28728-3-laurent.pinchart@ideasonboard.com>\n\t<166368010639.3912877.1197019741967535600@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166368010639.3912877.1197019741967535600@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v4 02/32] ipa: ipu3: af: Pass context\n\treference to afIsOutOfFocus()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25049,"web_url":"https://patchwork.libcamera.org/comment/25049/","msgid":"<20220921100140.3bj2jgdjkihgv77n@lati>","date":"2022-09-21T10:01:40","subject":"Re: [libcamera-devel] [PATCH v4 02/32] ipa: ipu3: af: Pass context\n\treference to afIsOutOfFocus()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Thu, Sep 08, 2022 at 04:41:30AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Avoid copying the whole IPA context by passing a reference to the\n> Af::afIsOutOfFocus() function.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/ipu3/algorithms/af.cpp | 2 +-\n> src/ipa/ipu3/algorithms/af.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\n> index 106a7614e2c7..9127c24f1287 100644\n> --- a/src/ipa/ipu3/algorithms/af.cpp\n> +++ b/src/ipa/ipu3/algorithms/af.cpp\n> @@ -383,7 +383,7 @@ double Af::afEstimateVariance(Span y_items, bool isY1)\n> * \\return True if the variance threshold is crossed indicating lost focus,\n> * false otherwise\n> */\n> -bool Af::afIsOutOfFocus(IPAContext context)\n> +bool Af::afIsOutOfFocus(IPAContext &context)\n> {\n> \tconst uint32_t diff_var = std::abs(currentVariance_ -\n> \t\t\t\t\t context.activeState.af.maxVariance);\n> diff --git a/src/ipa/ipu3/algorithms/af.h b/src/ipa/ipu3/algorithms/af.h\n> index ccf015f3f8f5..9b93594898bb 100644\n> --- a/src/ipa/ipu3/algorithms/af.h\n> +++ b/src/ipa/ipu3/algorithms/af.h\n> @@ -44,7 +44,7 @@ private:\n> \tvoid afIgnoreFrameReset();\n> \tdouble afEstimateVariance(Span y_items, bool isY1);\n>\n> -\tbool afIsOutOfFocus(IPAContext context);\n> +\tbool afIsOutOfFocus(IPAContext &context);\n>\n> \t/* VCM step configuration. It is the current setting of the VCM step. */\n> \tuint32_t focus_;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E97EBC0DA4\n\tfor ;\n\tWed, 21 Sep 2022 10:01:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C6C0621E0;\n\tWed, 21 Sep 2022 12:01:43 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::226])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A55BF600AA\n\tfor ;\n\tWed, 21 Sep 2022 12:01:42 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 3B144C000E;\n\tWed, 21 Sep 2022 10:01:41 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663754503;\n\tbh=4mmGm/MSC3I7LWKumPXXngIuh33wojoVkQeYurqL388=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=IkSDeCWP3OF7/EWYydAMJmta0eg4NMt+FOzvz7UJniW4kg2tpUaRJWc3lFyuqo2ns\n\tEihT66XxfnqLNjgVeR9qrAwQ8Vatkhoo1hlI1Eud3t8M8UMRb/DsHj80Jh0OI1kfU9\n\t0xJ4F9x5AZl6Y2mgvfz0gW8IHKUl8s6b004dHGBeHb3XkVmlP57awSjMggmRIRng0q\n\tMKhGtIwgnazy++ez4fZN7PP1pfaNNOtzXcltcAvK4jwponfTKIuinPLsa2uMFr+Rtz\n\txeR7NuaibiSybvm6WdzRTbWM9TNKfbIrSRkratphliMANyO1z9hUJalPwLdD3WZh8O\n\txgVCU5BFfQomg==","Date":"Wed, 21 Sep 2022 12:01:40 +0200","To":"Laurent Pinchart ","Message-ID":"<20220921100140.3bj2jgdjkihgv77n@lati>","References":"<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>\n\t<20220908014200.28728-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220908014200.28728-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 02/32] ipa: ipu3: af: Pass context\n\treference to afIsOutOfFocus()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]