[{"id":25114,"web_url":"https://patchwork.libcamera.org/comment/25114/","msgid":"","date":"2022-09-23T09:59:05","subject":"Re: [libcamera-devel] [PATCH v2 3/7] tests: delayed_controls: Add\n\tcookie value test","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the patch.\n\nOn Mon, 5 Sept 2022 at 08:40, Naushir Patuck via libcamera-devel\n wrote:\n>\n> Add a test for passing and returning cookie values in DelayedControls.\n>\n> Signed-off-by: Naushir Patuck \n\nNot a lot to add here... LGTM.\n\nReviewed-by: David Plowman \n\nThanks!\nDavid\n\n> ---\n> test/delayed_controls.cpp | 44 +++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 44 insertions(+)\n>\n> diff --git a/test/delayed_controls.cpp b/test/delayed_controls.cpp\n> index 322c545998b2..5cc7d3aed4fd 100644\n> --- a/test/delayed_controls.cpp\n> +++ b/test/delayed_controls.cpp\n> @@ -267,6 +267,45 @@ protected:\n> return TestPass;\n> }\n>\n> + int cookieValue()\n> + {\n> + std::unordered_map delays = {\n> + { V4L2_CID_BRIGHTNESS, { 1, false } },\n> + };\n> + std::unique_ptr delayed =\n> + std::make_unique(dev_.get(), delays);\n> + ControlList ctrls;\n> +\n> + /* Set a cookie to the reset value. */\n> + const unsigned int startCookie = 0x1234;\n> + ctrls.set(V4L2_CID_BRIGHTNESS, 1);\n> + dev_->setControls(&ctrls);\n> + delayed->reset(startCookie);\n> +\n> + /* Trigger the first frame start event */\n> + delayed->applyControls(0);\n> +\n> + for (unsigned int i = 1; i < 100; i++) {\n> + ctrls.set(V4L2_CID_BRIGHTNESS, 1);\n> + delayed->push(ctrls, startCookie + i);\n> +\n> + delayed->applyControls(i);\n> +\n> + auto [result, cookie] = delayed->get(i);\n> + unsigned int expected = startCookie + i - 1;\n> + if (cookie != expected) {\n> + cerr << \"Failed cookie value\"\n> + << \" frame \" << i\n> + << \" expected cookie \" << expected\n> + << \" got cookie \" << cookie\n> + << endl;\n> + return TestFail;\n> + }\n> + }\n> +\n> + return TestPass;\n> + }\n> +\n> int run() override\n> {\n> int ret;\n> @@ -291,6 +330,11 @@ protected:\n> if (ret)\n> return ret;\n>\n> + /* Test cookie values. */\n> + ret = cookieValue();\n> + if (ret)\n> + return ret;\n> +\n> return TestPass;\n> }\n>\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72808C0DA4\n\tfor ;\n\tFri, 23 Sep 2022 09:59:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8125B62235;\n\tFri, 23 Sep 2022 11:59:18 +0200 (CEST)","from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com\n\t[IPv6:2a00:1450:4864:20::12f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE675621BC\n\tfor ;\n\tFri, 23 Sep 2022 11:59:16 +0200 (CEST)","by mail-lf1-x12f.google.com with SMTP id u18so18956725lfo.8\n\tfor ;\n\tFri, 23 Sep 2022 02:59:16 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1663927158;\n\tbh=FP+WBsU4wcP0cSuuDHp73Y1z5H6GbWAIwxO2dndFgIE=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=BNY73b8XnQ3RuHXMo8+2o2zLNEuDuE3s4iJsS9tnSC2DCCu5cY5E3IB0F2lFf3Zmh\n\tTENc0lZgt38Vcr8I2fIgv1SLP310GoHU2PF1mDbFIGyx4pacHIvAl91eLSv035hL8I\n\tlYfA7sDGndmBoqCAqAZdwQ2/9HHu6ufGBGdUzA2slp0QrEOP4IV6YfnYQajyoQkrmY\n\tsz1tFnK1mCxv3KX4kQ/lQUMxVUbu9PAZcNHzhvVjAt8fVPu06SjBdU1Hsy4FKYOcuG\n\tE9H695gc1kKKHsx5dj+gCQ5n++ZTpNM7WQYyDgl5C0UQdSorxhI2QtWOEzAL2yQl7g\n\tGPstHM1yc/zEQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date;\n\tbh=nFdiDpr1DzpqYHajOXV2EE/aoB6S74sySEtbgNTavfI=;\n\tb=NYI8ICPpgeELsgnne/OXY/UESl72Yw1hfPNa4XP+m+38QAjlgDsfweTs0bUDo/8HRB\n\tihb119Pr9xHxRVXqRQ2neZW9hXrh+VN/qqbwKOaAH+GcyL/N30Vc5ydttvSG6Vu9RIbN\n\tbmooNBOe+bpsP+4KQHTDYTlYJc1wQ3V3T9TXJcPq0PxRoNg9H4LHcISE9Bk6CDA/vb2w\n\t6L17GVyTZ8Fq0DGclFg67d0ynyucTE7wz4Le33wBtE/09WB8F+DO1jNEADsSlwxTR7H4\n\t/ffvrJFQabf5jX9NJ/c2XwQTGKxR9gHNu+7FF3g43WWhbjvgXLYYYvWo9yabY87G1epb\n\tib3g=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"NYI8ICPp\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date;\n\tbh=nFdiDpr1DzpqYHajOXV2EE/aoB6S74sySEtbgNTavfI=;\n\tb=HaIEISrzGNuyNje2zB+cpImaPzPMnEXlAmbc35zfpxJ8MgpFxNESV7p/RUpglYKeb/\n\tT0Ry5831yAjBz2gIxy07oschS0fyEbSdwx5E0GsO4n3bqci6uFiLAzjRUQJyh10//AVH\n\tYkdg5QLfVdxx/eCBSalR6OXxy02eLdKWBzeqYhbAwMN6fndT2Ik5R5yOcHPMRmxqqXcD\n\tWZJqpfkNPN7UACIGIlZU4tEDYW/Mv9OO4ClM5FRBpkkFvKah0Zl/0ebB+dnpB9z5ydFn\n\tU0yOHxGviUKPLLmtlTjru3ZqG5Clpot/rADDf6jn5/d/GNILeWVEKwvCz12VMg4bds0B\n\tq/HQ==","X-Gm-Message-State":"ACrzQf2LgzBnlELExRDoHw7/MP7q33FR1zZToCSPt9n0PSgGQ3tUAdkC\n\t05LVxPWMmCmuRUPe2vc3t8h20dVrtGE60ElUtKdOokikQiU=","X-Google-Smtp-Source":"AMsMyM5Ftv1kLabbAMmNvgEpcY1vMsXi06NdOmMGqMvU6qI/Rj+gFwUcfX9ciZSRL8jn8AVLygcvZC/J3M/+C+Mzbqo=","X-Received":"by 2002:a19:6446:0:b0:49a:9b06:f4be with SMTP id\n\tb6-20020a196446000000b0049a9b06f4bemr3016814lfj.157.1663927155930;\n\tFri, 23 Sep 2022 02:59:15 -0700 (PDT)","MIME-Version":"1.0","References":"<20220905073956.7342-1-naush@raspberrypi.com>\n\t<20220905073956.7342-4-naush@raspberrypi.com>","In-Reply-To":"<20220905073956.7342-4-naush@raspberrypi.com>","Date":"Fri, 23 Sep 2022 10:59:05 +0100","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 3/7] tests: delayed_controls: Add\n\tcookie value test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]