[{"id":24920,"web_url":"https://patchwork.libcamera.org/comment/24920/","msgid":"","date":"2022-09-04T21:59:52","subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Christian,\n\nThank you for the patch.\n\nOn Sun, Sep 04, 2022 at 06:27:15PM +0200, Christian Rauch via libcamera-devel wrote:\n> Compiling with tests adds a significant amount of build targets to the\n> meson build. However, tests are only of interest when a feature has been\n> implemented or for continuous integration.\n> Disable tests by default to reduce the computational resource requirements\n> and the duration of a complete libcamera built.\n> \n> Signed-off-by: Christian Rauch \n\nAs most people building libcamera won't run tests, this seems reasonable\nto me. I'm however a bit worried that it would lead to lower\ncompilation-test coverage, as people may send patches without realizing\nthey break compilation of tests. We already have that problem for\nruntime breakages of tests, and it's most likely be addressed by test\nautomation on patches submitted upstream, so I think I'm fine with the\nchange.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> meson_options.txt | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index 7a9aecfc..f1d67808 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -47,6 +47,7 @@ option('qcam',\n> \n> option('test',\n> type : 'boolean',\n> + value : false,\n> description: 'Compile and include the tests')\n> \n> option('tracing',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01C8FC3272\n\tfor ;\n\tSun, 4 Sep 2022 22:00:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2529D62048;\n\tMon, 5 Sep 2022 00:00:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A5E262037\n\tfor ;\n\tMon, 5 Sep 2022 00:00:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6DEBE6BC;\n\tMon, 5 Sep 2022 00:00:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662328810;\n\tbh=m1bFr7fHlszByRclqt6jaPizW58lGgza7vbDixK6W80=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=N+FitDBqonhUmY3A8wzCZ02Fy2+fEMz3iFqENBEdcE0/fpdTRnbOE8U+tHRx7nM3t\n\tfkfbSb+78jI5mDzIGedwFmrGm/v946tKZH7x1ERwPxANFTblzIrtzOYBYhSRxrBlg0\n\tiyp6Ih/f0IhvpElm7IH1Ps3tvgCq+RwnW0kD9u41BEACBVOKJWcyrgC3FTAWKgXpfK\n\tNACq7a2fsga96pBDGSysIL2e/+HMl0Ermzz51VbjH4rT9pK+xhn8fOgyMz/GACpDAI\n\t5uEdGHuzqEASxH6L5T6KsEAZU/KKTOxyss/PcJIm406wgccD9k/UPMizkL6PQGqIFN\n\tKpPXMbn1I2/5g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662328807;\n\tbh=m1bFr7fHlszByRclqt6jaPizW58lGgza7vbDixK6W80=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AQiQUNVciWHkw1qol6m0E3lLUNntMYUyClUj+FatLvehh5H8IZnJTxOlOMFeqN5hV\n\tLRFTlj5sjDmH7nbytFTO+TFMX0Vr7xk394WbRJrw4VEmdyG969Tlzw1qkyfCLRUgbt\n\t+ZsTPxhu6f0XAY/xoeXUVaRf42aRZGnsAwBB6eAY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AQiQUNVc\"; dkim-atps=neutral","Date":"Mon, 5 Sep 2022 00:59:52 +0300","To":"Christian Rauch ","Message-ID":"","References":"<20220904162715.286574-1-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220904162715.286574-1-Rauch.Christian@gmx.de>","Subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24930,"web_url":"https://patchwork.libcamera.org/comment/24930/","msgid":"<4056f8eb-d9c1-b098-419e-22829e07ffda@ideasonboard.com>","date":"2022-09-05T06:41:50","subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Christian,\n\nThank you for the patch.\n\nOn 9/5/22 3:29 AM, Laurent Pinchart via libcamera-devel wrote:\n> Hi Christian,\n>\n> Thank you for the patch.\n>\n> On Sun, Sep 04, 2022 at 06:27:15PM +0200, Christian Rauch via libcamera-devel wrote:\n>> Compiling with tests adds a significant amount of build targets to the\n>> meson build. However, tests are only of interest when a feature has been\n>> implemented or for continuous integration.\n>> Disable tests by default to reduce the computational resource requirements\n>> and the duration of a complete libcamera built.\n>>\n>> Signed-off-by: Christian Rauch \n> As most people building libcamera won't run tests, this seems reasonable\n> to me. I'm however a bit worried that it would lead to lower\n> compilation-test coverage, as people may send patches without realizing\n> they break compilation of tests. We already have that problem for\n\nI'm concerned about this as well.\n> runtime breakages of tests, and it's most likely be addressed by test\n> automation on patches submitted upstream, so I think I'm fine with the\n> change.\n>\n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n>\n>> ---\n>> meson_options.txt | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/meson_options.txt b/meson_options.txt\n>> index 7a9aecfc..f1d67808 100644\n>> --- a/meson_options.txt\n>> +++ b/meson_options.txt\n>> @@ -47,6 +47,7 @@ option('qcam',\n>>\n>> option('test',\n>> type : 'boolean',\n>> + value : false,\n>> description: 'Compile and include the tests')\n>>\n>> option('tracing',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C7DADC3272\n\tfor ;\n\tMon, 5 Sep 2022 06:41:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4500962052;\n\tMon, 5 Sep 2022 08:41:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D7966041F\n\tfor ;\n\tMon, 5 Sep 2022 08:41:55 +0200 (CEST)","from [IPV6:2401:4900:1f3f:3b55:213a:3c32:c7d0:be1e] (unknown\n\t[IPv6:2401:4900:1f3f:3b55:213a:3c32:c7d0:be1e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E58204A8;\n\tMon, 5 Sep 2022 08:41:53 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662360117;\n\tbh=gI37BTbX/IdEDjKvc6QRt5YUb1g/2mOh4xJJiFIBVh4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JPKmqmY9dDCOF3D6/I7PEeRAhUDSzRlv7Lj4cEcUAHeFneFVleMmP7WZeffi4kqe/\n\trlNxveQeA8jJ2G0ZkpPSCAlzx49U2sFIZQyiMp+C3k01C3IHh1z87o7vK9B1KO85Tt\n\tfnHJMTDIyO6knB4vrcltCKWq90ikdCm25dWhQQvak/MmQwdviI0ZCX/uTDlUrlY8+L\n\tq6vRWHU0e/1dDfmIifLmvH+AsbFA1yZ9UhFTmejSiiK/W7ZAVX3Byl8aro7ke0KQMn\n\tBPkh/QWRQyZmnfwqaoWTkOb3TiAzZbYLrIVXeEQxWhl5klfV5QTVEWAeNbECV5DF0S\n\tvbrZ2m4OrA7bg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662360114;\n\tbh=gI37BTbX/IdEDjKvc6QRt5YUb1g/2mOh4xJJiFIBVh4=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=X2VQx/HVVdBxHquBji/AywFAMfZr8cvotdJ3f8Onii0ZZV9QNSrA9T7JAz2MpZbMc\n\tBB7Y7+0PUncp4RFMsVKERS9F4j5lTO1Cs5h1BUsq9vu7w+KjZFj7Z86EVwJelKxqBP\n\twzF8he0MliFQXgdSweBsYG43vcn04PLCZwL6Gyc0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"X2VQx/HV\"; dkim-atps=neutral","Message-ID":"<4056f8eb-d9c1-b098-419e-22829e07ffda@ideasonboard.com>","Date":"Mon, 5 Sep 2022 12:11:50 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.12.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tChristian Rauch ","References":"<20220904162715.286574-1-Rauch.Christian@gmx.de>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24936,"web_url":"https://patchwork.libcamera.org/comment/24936/","msgid":"<166237150069.2444436.17964164995530545653@Monstersaurus>","date":"2022-09-05T09:51:40","subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi All,\n\nQuoting Umang Jain via libcamera-devel (2022-09-05 07:41:50)\n> Hi Christian,\n> \n> Thank you for the patch.\n> \n> On 9/5/22 3:29 AM, Laurent Pinchart via libcamera-devel wrote:\n> > Hi Christian,\n> >\n> > Thank you for the patch.\n> >\n> > On Sun, Sep 04, 2022 at 06:27:15PM +0200, Christian Rauch via libcamera-devel wrote:\n> >> Compiling with tests adds a significant amount of build targets to the\n> >> meson build. However, tests are only of interest when a feature has been\n> >> implemented or for continuous integration.\n> >> Disable tests by default to reduce the computational resource requirements\n> >> and the duration of a complete libcamera built.\n> >>\n> >> Signed-off-by: Christian Rauch \n> > As most people building libcamera won't run tests, this seems reasonable\n> > to me. I'm however a bit worried that it would lead to lower\n> > compilation-test coverage, as people may send patches without realizing\n> > they break compilation of tests. We already have that problem for\n> \n> I'm concerned about this as well.\n\nWhen I first saw this patch over the weekend, indeed my reaction was\n\"Ahhh\" ... but I also agree this is a better default to have off right\nnow.\n\nWe would like patches to be submitted after having all tests run, but\nthe majority of people who compile libcamera (currently) may not be\ndevelopers. We have lots of people compiling on RPi / IPU3 and low power\ndevices directly, and they certainly don't care for running tests.\n\nSo to improve user experience, I do think this should be off by default\n(at least now) and that stance may change depending on our upcoming\nrelease strategies ... but developers should be able to enable tests\nanyway.\n\nIdeally of course these tests will then be enabled and run on any branch\npush to the common public hosting services, so I think we should\nintegrate a gitlab and github CI script that could build and run the\nunit tests. (These could skip the kernel related tests initially).\n\nAnyway,\n\nYes - \n\nReviewed-by: Kieran Bingham \n\n> > runtime breakages of tests, and it's most likely be addressed by test\n> > automation on patches submitted upstream, so I think I'm fine with the\n> > change.\n> >\n> > Reviewed-by: Laurent Pinchart \n> \n> Reviewed-by: Umang Jain \n> \n> >\n> >> ---\n> >> meson_options.txt | 1 +\n> >> 1 file changed, 1 insertion(+)\n> >>\n> >> diff --git a/meson_options.txt b/meson_options.txt\n> >> index 7a9aecfc..f1d67808 100644\n> >> --- a/meson_options.txt\n> >> +++ b/meson_options.txt\n> >> @@ -47,6 +47,7 @@ option('qcam',\n> >>\n> >> option('test',\n> >> type : 'boolean',\n> >> + value : false,\n> >> description: 'Compile and include the tests')\n> >>\n> >> option('tracing',\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5AAEC0DA4\n\tfor ;\n\tMon, 5 Sep 2022 09:51:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0AFA562062;\n\tMon, 5 Sep 2022 11:51:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45E5D62054\n\tfor ;\n\tMon, 5 Sep 2022 11:51:43 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9544F4A8;\n\tMon, 5 Sep 2022 11:51:42 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662371505;\n\tbh=KnhtJMPGYgcrZIigPVTPbLKNN6FDMnn675qLGnErawQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=h3rZ4HfbIuIbHR9xs520WpTpzeAPZAtjO+oY5EwkeD97r89epm2UnXkbPReP+l7Td\n\tL0u7plYupsJrj94JAQ/JBdWFl5P0TJT8Ct0bEDZfxsniSGddhr5l7ykz24kHhxSnP/\n\tBSHhIf9ykqXJlcxz0kvozbkcH48lK2N7oXn6r2PLKysgjGPg1wyhhrAMGeBClxQAl4\n\tGWJy8QTdsDiT4p+5R2V0grNTT6tgECwN21l4f0ofNL9yvpPLXsO+wz+HRVB20iR1AU\n\tXSqjiwEw0E3tWdlEloBNOYhUi8wswJf/tRbaPRLtiwaTIk64pqU7J9ucOd1wq9MTDo\n\txZsm8b4kGzjIA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662371502;\n\tbh=KnhtJMPGYgcrZIigPVTPbLKNN6FDMnn675qLGnErawQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=isqn3YUam/TYjAg+Bu8Chnz+3ulRcp+lm/ZnOqc1H9DhnCO8TEK4gR8qmaRPzS4Jd\n\tw4P950WCR+qnJ5WOmcYLD7OMeHb5k7MnINxU1kske7y1RvJ0tEks1uwk2uAdKNUJWq\n\tHoN4vSdiD62H8PAsLIbQbm7eOxRez/wIKnjQ4Bvo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"isqn3YUa\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<4056f8eb-d9c1-b098-419e-22829e07ffda@ideasonboard.com>","References":"<20220904162715.286574-1-Rauch.Christian@gmx.de>\n\t\n\t<4056f8eb-d9c1-b098-419e-22829e07ffda@ideasonboard.com>","To":"Christian Rauch ,\n\tLaurent Pinchart ,\n\tUmang Jain ,\n\tUmang Jain via libcamera-devel ","Date":"Mon, 05 Sep 2022 10:51:40 +0100","Message-ID":"<166237150069.2444436.17964164995530545653@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24937,"web_url":"https://patchwork.libcamera.org/comment/24937/","msgid":"","date":"2022-09-05T10:35:12","subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Sep 05, 2022 at 10:51:40AM +0100, Kieran Bingham wrote:\n> Quoting Umang Jain via libcamera-devel (2022-09-05 07:41:50)\n> > On 9/5/22 3:29 AM, Laurent Pinchart via libcamera-devel wrote:\n> > > On Sun, Sep 04, 2022 at 06:27:15PM +0200, Christian Rauch via libcamera-devel wrote:\n> > >> Compiling with tests adds a significant amount of build targets to the\n> > >> meson build. However, tests are only of interest when a feature has been\n> > >> implemented or for continuous integration.\n> > >> Disable tests by default to reduce the computational resource requirements\n> > >> and the duration of a complete libcamera built.\n> > >>\n> > >> Signed-off-by: Christian Rauch \n> > > As most people building libcamera won't run tests, this seems reasonable\n> > > to me. I'm however a bit worried that it would lead to lower\n> > > compilation-test coverage, as people may send patches without realizing\n> > > they break compilation of tests. We already have that problem for\n> > \n> > I'm concerned about this as well.\n> \n> When I first saw this patch over the weekend, indeed my reaction was\n> \"Ahhh\" ... but I also agree this is a better default to have off right\n> now.\n> \n> We would like patches to be submitted after having all tests run, but\n> the majority of people who compile libcamera (currently) may not be\n> developers. We have lots of people compiling on RPi / IPU3 and low power\n> devices directly, and they certainly don't care for running tests.\n> \n> So to improve user experience, I do think this should be off by default\n> (at least now) and that stance may change depending on our upcoming\n> release strategies ... but developers should be able to enable tests\n> anyway.\n> \n> Ideally of course these tests will then be enabled and run on any branch\n> push to the common public hosting services, so I think we should\n> integrate a gitlab and github CI script that could build and run the\n> unit tests. (These could skip the kernel related tests initially).\n\nMany of our tests indeed depend on vimc, vivid and vim2m, so that's a\nblocker for git..b. I'd be happy if we started with test runners that\nperformed compile testing only, with all options enabled.\n\n> Anyway,\n> \n> Yes - \n> \n> Reviewed-by: Kieran Bingham \n> \n> > > runtime breakages of tests, and it's most likely be addressed by test\n> > > automation on patches submitted upstream, so I think I'm fine with the\n> > > change.\n> > >\n> > > Reviewed-by: Laurent Pinchart \n> > \n> > Reviewed-by: Umang Jain \n> > \n> > >> ---\n> > >> meson_options.txt | 1 +\n> > >> 1 file changed, 1 insertion(+)\n> > >>\n> > >> diff --git a/meson_options.txt b/meson_options.txt\n> > >> index 7a9aecfc..f1d67808 100644\n> > >> --- a/meson_options.txt\n> > >> +++ b/meson_options.txt\n> > >> @@ -47,6 +47,7 @@ option('qcam',\n> > >>\n> > >> option('test',\n> > >> type : 'boolean',\n> > >> + value : false,\n> > >> description: 'Compile and include the tests')\n> > >>\n> > >> option('tracing',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E0288C0DA4\n\tfor ;\n\tMon, 5 Sep 2022 10:35:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E73762062;\n\tMon, 5 Sep 2022 12:35:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56BE062022\n\tfor ;\n\tMon, 5 Sep 2022 12:35:28 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7DE824A8;\n\tMon, 5 Sep 2022 12:35:27 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662374130;\n\tbh=DqY/8MyvTT5aCkiWlHcHkeTKhoCukxfkSzeBcyaobEM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=jiqinDbmRc09oFpIgMBURS5fAuTlHxe0zjmbS2kaji3CT+lU3TovSZlbvy3HEu0NE\n\tC+6hNO5PEOdEu17in2TcrEbzlZ2AWmmt7pPZoEvwrA203RGuSF19pAU4GwE0isYMQd\n\tkftFoFQfhEfQZuNWcqP2mdRmgUq2ak5YUK+eSDyG3oilmIlJh17lMep7tCZDQo3Ilk\n\tthNECXNmtZcMF767vXHuZNHftVPaT1tn83DDjHzOCkzScjNuhbdRwfiWQwcWrLK+FZ\n\tlrsZ1w2s+/oLun0CWC/fV8cVLTHGuH6d0HR/HZGxzqoRYMZ+iuNZJgJf668FpX5WtJ\n\tytC7foZEFpr/Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662374127;\n\tbh=DqY/8MyvTT5aCkiWlHcHkeTKhoCukxfkSzeBcyaobEM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=c2tl1hWmMmDaPeN3MbKF9g7Wk3JmIECQdGITry9YZFP3cOoNx31IsTJvLagzUWRb+\n\tjFw9/45szFxLCvH0rboxtNZu/Zw4ANIQmuvDH7vLEdbQJtZm7etZgqQVqjPd7WKuHY\n\tNFqA8XJX0OqeeUOCL84TFJz5iIe0T4IQfWjiJU6A="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"c2tl1hWm\"; dkim-atps=neutral","Date":"Mon, 5 Sep 2022 13:35:12 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220904162715.286574-1-Rauch.Christian@gmx.de>\n\t\n\t<4056f8eb-d9c1-b098-419e-22829e07ffda@ideasonboard.com>\n\t<166237150069.2444436.17964164995530545653@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166237150069.2444436.17964164995530545653@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Umang Jain via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24938,"web_url":"https://patchwork.libcamera.org/comment/24938/","msgid":"<166238337661.956466.16360484051312789581@Monstersaurus>","date":"2022-09-05T13:09:36","subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2022-09-05 11:35:12)\n> On Mon, Sep 05, 2022 at 10:51:40AM +0100, Kieran Bingham wrote:\n> > Quoting Umang Jain via libcamera-devel (2022-09-05 07:41:50)\n> > > On 9/5/22 3:29 AM, Laurent Pinchart via libcamera-devel wrote:\n> > > > On Sun, Sep 04, 2022 at 06:27:15PM +0200, Christian Rauch via libcamera-devel wrote:\n> > > >> Compiling with tests adds a significant amount of build targets to the\n> > > >> meson build. However, tests are only of interest when a feature has been\n> > > >> implemented or for continuous integration.\n> > > >> Disable tests by default to reduce the computational resource requirements\n> > > >> and the duration of a complete libcamera built.\n> > > >>\n> > > >> Signed-off-by: Christian Rauch \n> > > > As most people building libcamera won't run tests, this seems reasonable\n> > > > to me. I'm however a bit worried that it would lead to lower\n> > > > compilation-test coverage, as people may send patches without realizing\n> > > > they break compilation of tests. We already have that problem for\n> > > \n> > > I'm concerned about this as well.\n> > \n> > When I first saw this patch over the weekend, indeed my reaction was\n> > \"Ahhh\" ... but I also agree this is a better default to have off right\n> > now.\n> > \n> > We would like patches to be submitted after having all tests run, but\n> > the majority of people who compile libcamera (currently) may not be\n> > developers. We have lots of people compiling on RPi / IPU3 and low power\n> > devices directly, and they certainly don't care for running tests.\n> > \n> > So to improve user experience, I do think this should be off by default\n> > (at least now) and that stance may change depending on our upcoming\n> > release strategies ... but developers should be able to enable tests\n> > anyway.\n> > \n> > Ideally of course these tests will then be enabled and run on any branch\n> > push to the common public hosting services, so I think we should\n> > integrate a gitlab and github CI script that could build and run the\n> > unit tests. (These could skip the kernel related tests initially).\n> \n> Many of our tests indeed depend on vimc, vivid and vim2m, so that's a\n> blocker for git..b. I'd be happy if we started with test runners that\n> performed compile testing only, with all options enabled.\n\nFor that I'd really like to continue to investigate (or for anyone else\nto continue to investigate) running the tests under a compiled kernel in\neither UML (which seemed to be a deadend for linux-media driver support\ndue to large rabbit holes) - or as a microvm, with a custom minimal\nkernel that contains VIMC/VIVID/VIM2M.\n\nIt's something I started to research, but haven't been able to complete,\nbut I beleive would be a way of fully automating the tests with the\nvirtual drivers. If anyone wants to explore this, I'm happy to share\nwhere I got to on it.\n\n--\nKieran\n\n\n> \n> > Anyway,\n> > \n> > Yes - \n> > \n> > Reviewed-by: Kieran Bingham \n> > \n> > > > runtime breakages of tests, and it's most likely be addressed by test\n> > > > automation on patches submitted upstream, so I think I'm fine with the\n> > > > change.\n> > > >\n> > > > Reviewed-by: Laurent Pinchart \n> > > \n> > > Reviewed-by: Umang Jain \n> > > \n> > > >> ---\n> > > >> meson_options.txt | 1 +\n> > > >> 1 file changed, 1 insertion(+)\n> > > >>\n> > > >> diff --git a/meson_options.txt b/meson_options.txt\n> > > >> index 7a9aecfc..f1d67808 100644\n> > > >> --- a/meson_options.txt\n> > > >> +++ b/meson_options.txt\n> > > >> @@ -47,6 +47,7 @@ option('qcam',\n> > > >>\n> > > >> option('test',\n> > > >> type : 'boolean',\n> > > >> + value : false,\n> > > >> description: 'Compile and include the tests')\n> > > >>\n> > > >> option('tracing',\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1309BC0DA4\n\tfor ;\n\tMon, 5 Sep 2022 13:09:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3E3762063;\n\tMon, 5 Sep 2022 15:09:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91D5C62022\n\tfor ;\n\tMon, 5 Sep 2022 15:09:39 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E003625B;\n\tMon, 5 Sep 2022 15:09:38 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662383380;\n\tbh=3bxUV93AdJCCbEO/E086bOCVPR9Q3UJqM6sRii9/WlE=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zW1DTN6+Gg1gFmtyk2bqxrfpM8jP7+dS56TrMXCQGjMnGOuQOpm4XDqjPeC88efOc\n\t+yVurXn2zLiu5zzfNkHHSDfqhHP2bVWV2kCON3IZC/hDNxRbMXnEZkxReoVgLC2okz\n\tyMRDcrv3avRgSW5o3Q7TVRZGT491NdWqBunJry//O7c4DDbbaxjT4yyII0B6hPYnh8\n\tLuW0cy/oariyWwyxTkHpkc1IPJQ1poRTGiJmwByf/wJ6K/d3/+bdEd9r1Y2BK5d42h\n\tBIikiuVSiJky/TXgfnJ9guJ0Tkcx045D1ExMTzrEPrHFFN8FnN7+xEseZY6SDtByAt\n\ti7XR7Hcon3mzA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662383379;\n\tbh=3bxUV93AdJCCbEO/E086bOCVPR9Q3UJqM6sRii9/WlE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=kDGSiE7Cn3nnjnb3U8Rk2ZiMgoL/exzPrWoKxFdE5X/2Hdp22JwGM9XA3X639BIRY\n\tlACN2T/pS2yItfJjlp0VBdGGYjqDkTdAGVR2byVpJ7AnPO1AGaevYcg4fW9UF1ncKc\n\tj4KlNwnJUqn5AWBQC6r6wlxmusOprl+qc4hAMBzE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kDGSiE7C\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220904162715.286574-1-Rauch.Christian@gmx.de>\n\t\n\t<4056f8eb-d9c1-b098-419e-22829e07ffda@ideasonboard.com>\n\t<166237150069.2444436.17964164995530545653@Monstersaurus>\n\t","To":"Laurent Pinchart ","Date":"Mon, 05 Sep 2022 14:09:36 +0100","Message-ID":"<166238337661.956466.16360484051312789581@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Umang Jain via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24939,"web_url":"https://patchwork.libcamera.org/comment/24939/","msgid":"<00be429e-13a9-aabd-3b68-7ec682b446ea@gmx.de>","date":"2022-09-05T19:26:19","subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"Hi Kieran,\n\nAm 05.09.22 um 11:51 schrieb Kieran Bingham:\n> Hi All,\n>\n> Quoting Umang Jain via libcamera-devel (2022-09-05 07:41:50)\n>> Hi Christian,\n>>\n>> Thank you for the patch.\n>>\n>> On 9/5/22 3:29 AM, Laurent Pinchart via libcamera-devel wrote:\n>>> Hi Christian,\n>>>\n>>> Thank you for the patch.\n>>>\n>>> On Sun, Sep 04, 2022 at 06:27:15PM +0200, Christian Rauch via libcamera-devel wrote:\n>>>> Compiling with tests adds a significant amount of build targets to the\n>>>> meson build. However, tests are only of interest when a feature has been\n>>>> implemented or for continuous integration.\n>>>> Disable tests by default to reduce the computational resource requirements\n>>>> and the duration of a complete libcamera built.\n>>>>\n>>>> Signed-off-by: Christian Rauch \n>>> As most people building libcamera won't run tests, this seems reasonable\n>>> to me. I'm however a bit worried that it would lead to lower\n>>> compilation-test coverage, as people may send patches without realizing\n>>> they break compilation of tests. We already have that problem for\n>>\n>> I'm concerned about this as well.\n>\n> When I first saw this patch over the weekend, indeed my reaction was\n> \"Ahhh\" ... but I also agree this is a better default to have off right\n> now.\n>\n> We would like patches to be submitted after having all tests run, but\n> the majority of people who compile libcamera (currently) may not be\n> developers. We have lots of people compiling on RPi / IPU3 and low power\n> devices directly, and they certainly don't care for running tests.\n\nI compile libcamera more often than I submit patches. I also compile on\na Raspberry Pi Zero 2. So compiling the tests is a huge waste of\nresources for me.\n\n> So to improve user experience, I do think this should be off by default\n> (at least now) and that stance may change depending on our upcoming\n> release strategies ... but developers should be able to enable tests\n> anyway.\n\nI would argue that tests should only be enabled when it is intended to\nrun them.\n\n> Ideally of course these tests will then be enabled and run on any branch\n> push to the common public hosting services, so I think we should\n> integrate a gitlab and github CI script that could build and run the\n> unit tests. (These could skip the kernel related tests initially).\n\nI am also used to have tests run automatically on a CI server when I\nsend PRs to other projects. Having some public libcamera CI instance\nthat compiles and tests sent patches would be very helpful.\nIf you intend to use GitHub actions, I can contribute the scripts that I\nalready use for my own purpose.\n\n>\n> Anyway,\n>\n> Yes -\n>\n> Reviewed-by: Kieran Bingham \n>\n>>> runtime breakages of tests, and it's most likely be addressed by test\n>>> automation on patches submitted upstream, so I think I'm fine with the\n>>> change.\n>>>\n>>> Reviewed-by: Laurent Pinchart \n>>\n>> Reviewed-by: Umang Jain \n>>\n>>>\n>>>> ---\n>>>> meson_options.txt | 1 +\n>>>> 1 file changed, 1 insertion(+)\n>>>>\n>>>> diff --git a/meson_options.txt b/meson_options.txt\n>>>> index 7a9aecfc..f1d67808 100644\n>>>> --- a/meson_options.txt\n>>>> +++ b/meson_options.txt\n>>>> @@ -47,6 +47,7 @@ option('qcam',\n>>>>\n>>>> option('test',\n>>>> type : 'boolean',\n>>>> + value : false,\n>>>> description: 'Compile and include the tests')\n>>>>\n>>>> option('tracing',\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F96CC3272\n\tfor ;\n\tMon, 5 Sep 2022 19:26:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9EBF262072;\n\tMon, 5 Sep 2022 21:26:22 +0200 (CEST)","from mout.gmx.net (mout.gmx.net [212.227.17.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2184361F9B\n\tfor ;\n\tMon, 5 Sep 2022 21:26:21 +0200 (CEST)","from [192.168.0.158] ([88.152.184.103]) by mail.gmx.net (mrgmx104\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id\n\t1M6DWi-1oT5s41UuO-006feH; Mon, 05 Sep 2022 21:26:20 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662405982;\n\tbh=jgec0g2pbGqPNCl01CbBhm0CUZYkzKxu60y1f/9eBIU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=yZZf8GUfEVQl1BI8i0Vp6fQs8/I1oq2bupaphHN8a+kn8ZFPnKy12GcyAafnX3Q6X\n\tkKiHadB24wI8oHinCf4lduW7Jyc6pJAnK2pdOw/K7MKIj5Quy7BOkd4Y7RMmKkmu+r\n\tCQh69E5sj5IFqS5e3iiOY2m14kptCZGv7DfOnfUVjuUlzC9VE2O7rJRNhqOAJbwd2y\n\t/Wba3WbHH6RYsfRiSXDWPzzlD3fiBh4oeGnREo8kvpkBQ7cVqboYJh6duSuRDwyCGC\n\tZK7LUyhzErVfVAzlhZWlC7c3w7l5AjIFmcpZARMuVj5tmWNFiUq6Pjga+n84KzA4nY\n\t5qQWvq9hj2iBA==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1662405980;\n\tbh=jgec0g2pbGqPNCl01CbBhm0CUZYkzKxu60y1f/9eBIU=;\n\th=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To;\n\tb=Wf2nu2SrIC5jsQXZ4LNRCmbtDsMp/I6OG//nGCT2Ih3gH28VSGPOTzvRWD127RGB4\n\tgnCiOWqWpgh6PUHOuE2gSJIWXI4FXwF5lYucpdG5IKaqmOHxTxPgGM9X06ei/uwLsK\n\tJ2roBZ6Ays1l2AlrVQRz89L2ygmwYE6khaLmBwYU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"Wf2nu2Sr\"; dkim-atps=neutral","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","Message-ID":"<00be429e-13a9-aabd-3b68-7ec682b446ea@gmx.de>","Date":"Mon, 5 Sep 2022 21:26:19 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.11.0","Content-Language":"en-GB","To":"Kieran Bingham ,\n\tLaurent Pinchart ,\n\tUmang Jain ,\n\tUmang Jain via libcamera-devel ","References":"<20220904162715.286574-1-Rauch.Christian@gmx.de>\n\t\n\t<4056f8eb-d9c1-b098-419e-22829e07ffda@ideasonboard.com>\n\t<166237150069.2444436.17964164995530545653@Monstersaurus>","In-Reply-To":"<166237150069.2444436.17964164995530545653@Monstersaurus>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:W7jmDOVDwamwRoaMFl2NTYZZubY1Ug1fhlN6PK23KnozAVTqySF\n\ttmTbNPk3glm3s1PGGDWdla8Hbyv5Tu1biS4UGQ2be3rKCYWnTT52mfHjz1F6omned0LQlpa\n\toRrg178ZqyH2MDZcAktaO4UVcCACa1m/lsr7mcWoaEpFfS0a5NjYQfMi2DEAua0ghC5m7MM\n\t4NMDVehuPr09YK9gkmXZw==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:361Mc2NuWjc=:wYFdarh1C7wmifp01Q/eJT\n\tejq5dChGzXfkfIXtlCsyVFznS7YVzahAnfKkXowm+tV4HbUSofMr7lOTG4KikdBZiB/9KYl3i\n\tGwYqoRKXAFAfKRZgRglI82J8yB96Lnf+3ZctHM+Aku9g6Z4/2jxG/7UD9484lCp1c81iQbhHR\n\t0hIfdKAWrcUrD7JtcopF6q2YLMobz3l0QpSwvcwmGh3Xhp9wRu5ufFsx124kJWgrSUn7tWUMK\n\tr8qMlcWZTjOQaMRicMISdHGFeXzNrRFlwc/ulqYkSYbxjfvFfRosn7nkhNu4dcK1A3A5V094I\n\tATI3LQa0aHcQfeFlud4Q+gSnlMa9o5gTGFKICoBn7t6Tq0bHsEt63t3IHlNoT6wTopi3EEKZM\n\tPis15Qhq1yGM75/z3YqUqLhP5Zm8GbtWGGlL64ZETHG7qLGEJzOU8jNavIfyo4bdyNLCb3oJn\n\t4W4U9dOPo+T/qt/cSY/rdfJmpfdx5J1wzHRDF8IrCxDk7PW+hAYwdzr0Paf5i4XuY4hFwg4j6\n\tdWf1k06gYBDmueEfTYGOamGOQ4BWQmhO55+bN08+LQ541RGDeCwmEjfC14R9aAISg6EbAXwrA\n\tZVRytUmorovssOZu5mlQSVkBs0CTIxdRfcME/+C/nR9DsuVQeoyO5gEF7F4v/vauGLkAxChxB\n\t1eSmc/1uM3bn/SL3KoSYw2sK9hYSHvqNKgXMJ7AJx+BcRmiO/gSv/9KUL16HbEc1wsLBq2u12\n\tLQbl/sbFl5F0IJBAPQkFuZD2hRLKuFqIVzCCcoXzlpWVhggpGUnebeOgO/OD2WasTRmBPpbaW\n\t+aJerK8AMbImLMSWJpywlK7EOvH3z2+/dswjetU24MHxSaQIWYV8/NNmn0IJ7NhAYqLAkZVYn\n\t3pwKBMIvP7zvT3c6IhPiVne6C5uwr9qhmuHPA9j+tncRBBrksX/8N4OdasviX6uqL1kj0M2qX\n\tOKWUqogDn3F5fWwW5xHFlhZFvgicO06iI8BuajMQnLA1DJ636XzlP6AGWsPSLOtmTbGm2plnV\n\tNlRYGCP0pwASSXHHNudiLqq4OU8AB4cA9tI7OMg2DzFdyJsjcIBM51hYGrcIT0/Sg2DHC13t+\n\tkkqjtPyKIjhVH13cvTTvL5KKciDf7EMtfYJl5E+hs3WnyMLiMvmIkOhGPD+gH2oK/X7OWcV3n\n\trAmaC0Az/Qz13ClYar1Aua+Vbj","Subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24940,"web_url":"https://patchwork.libcamera.org/comment/24940/","msgid":"<166240682666.56880.7619863806175978081@Monstersaurus>","date":"2022-09-05T19:40:26","subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Christian Rauch (2022-09-05 20:26:19)\n> Hi Kieran,\n> \n> Am 05.09.22 um 11:51 schrieb Kieran Bingham:\n> > Hi All,\n> >\n> > Quoting Umang Jain via libcamera-devel (2022-09-05 07:41:50)\n> >> Hi Christian,\n> >>\n> >> Thank you for the patch.\n> >>\n> >> On 9/5/22 3:29 AM, Laurent Pinchart via libcamera-devel wrote:\n> >>> Hi Christian,\n> >>>\n> >>> Thank you for the patch.\n> >>>\n> >>> On Sun, Sep 04, 2022 at 06:27:15PM +0200, Christian Rauch via libcamera-devel wrote:\n> >>>> Compiling with tests adds a significant amount of build targets to the\n> >>>> meson build. However, tests are only of interest when a feature has been\n> >>>> implemented or for continuous integration.\n> >>>> Disable tests by default to reduce the computational resource requirements\n> >>>> and the duration of a complete libcamera built.\n> >>>>\n> >>>> Signed-off-by: Christian Rauch \n> >>> As most people building libcamera won't run tests, this seems reasonable\n> >>> to me. I'm however a bit worried that it would lead to lower\n> >>> compilation-test coverage, as people may send patches without realizing\n> >>> they break compilation of tests. We already have that problem for\n> >>\n> >> I'm concerned about this as well.\n> >\n> > When I first saw this patch over the weekend, indeed my reaction was\n> > \"Ahhh\" ... but I also agree this is a better default to have off right\n> > now.\n> >\n> > We would like patches to be submitted after having all tests run, but\n> > the majority of people who compile libcamera (currently) may not be\n> > developers. We have lots of people compiling on RPi / IPU3 and low power\n> > devices directly, and they certainly don't care for running tests.\n> \n> I compile libcamera more often than I submit patches. I also compile on\n> a Raspberry Pi Zero 2. So compiling the tests is a huge waste of\n> resources for me.\n\nYes, I understand that. If libcamera were 'well packaged, stable, and\nfinished' ... there would be less users having to compile it though.\n\nSo some time in the future... libcamera should become\nrarely built, and tests won't be such a burden.\n\nAlso - compiling on an RPi02 is certainly a pain. Did I share the RPi\ncross compile environment with you already ?\n\n\n\n> > So to improve user experience, I do think this should be off by default\n> > (at least now) and that stance may change depending on our upcoming\n> > release strategies ... but developers should be able to enable tests\n> > anyway.\n> \n> I would argue that tests should only be enabled when it is intended to\n> run them.\n> \n> > Ideally of course these tests will then be enabled and run on any branch\n> > push to the common public hosting services, so I think we should\n> > integrate a gitlab and github CI script that could build and run the\n> > unit tests. (These could skip the kernel related tests initially).\n> \n> I am also used to have tests run automatically on a CI server when I\n> send PRs to other projects. Having some public libcamera CI instance\n> that compiles and tests sent patches would be very helpful.\n> If you intend to use GitHub actions, I can contribute the scripts that I\n> already use for my own purpose.\n\nAs mentioned in the thread with Laurent - this is more complex because\nwe need a custom kernel with virtual drivers (as you've experienced).\n\nI think this can be solved, but that requires some investigations that I\nhaven't had time for.\n\n'We' won't use github actions, but I think integrating a github actions\nscript to the repository is certainly reasonable, if it helps anyone who\npushes a branch to their repository compile test in a consistent manner.\n\nIf you have something usable for that, please do post it to the list.\n\n--\nKieran\n\n\n> \n> >\n> > Anyway,\n> >\n> > Yes -\n> >\n> > Reviewed-by: Kieran Bingham \n> >\n> >>> runtime breakages of tests, and it's most likely be addressed by test\n> >>> automation on patches submitted upstream, so I think I'm fine with the\n> >>> change.\n> >>>\n> >>> Reviewed-by: Laurent Pinchart \n> >>\n> >> Reviewed-by: Umang Jain \n> >>\n> >>>\n> >>>> ---\n> >>>> meson_options.txt | 1 +\n> >>>> 1 file changed, 1 insertion(+)\n> >>>>\n> >>>> diff --git a/meson_options.txt b/meson_options.txt\n> >>>> index 7a9aecfc..f1d67808 100644\n> >>>> --- a/meson_options.txt\n> >>>> +++ b/meson_options.txt\n> >>>> @@ -47,6 +47,7 @@ option('qcam',\n> >>>>\n> >>>> option('test',\n> >>>> type : 'boolean',\n> >>>> + value : false,\n> >>>> description: 'Compile and include the tests')\n> >>>>\n> >>>> option('tracing',\n> >>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE0FEC0DA4\n\tfor ;\n\tMon, 5 Sep 2022 19:40:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1CE0A62072;\n\tMon, 5 Sep 2022 21:40:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 342E661F9B\n\tfor ;\n\tMon, 5 Sep 2022 21:40:30 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8622B6D5;\n\tMon, 5 Sep 2022 21:40:29 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662406832;\n\tbh=tp4T8BddezGwTULy1iBaj2eo1jkrgkWpMgimhuOrh+s=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=augyy2yE72qL1dyiXs9QpG2eFnxcUDItWk+XiK8MjhnOtg6b/V6MnF9e/JGmO350S\n\t0DNCdVgZrcVxfeVMzGr2LSXXc3f+yHpEX9OLrJpiu4jKy9YsYBy7DhfB7tpZ6x04LJ\n\t18+7fB7+VUFcTzTzdF5cSq/y6yk0iN6mNE14/majuMrd5JPdNmI+l3RBECeerptpnw\n\tqi+MyYejqpBg89DvsvY6OsyM1XjW+DG7LFRcuLTIRDA/FBRI6LFfTNqkkiBU4aXAZE\n\tqixZTW6k0T1B9WFyF99gBYjmALtCLGFiMe8cyVEcR8sGf00++ViXd4eRBKn+PHOm3B\n\tMm4K7T2d+QTXA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662406829;\n\tbh=tp4T8BddezGwTULy1iBaj2eo1jkrgkWpMgimhuOrh+s=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=lSgVjhF6/Gj9ULx3k6nveO+0G4v3WTMgdchBtGDZgmOMRaXHciQdioGjWl5LibDih\n\tKQKLlgK0V1BlrIGF1lue1W8GzcjuEHcpw3qu5ryvQHKZiZVhzgJk8Pg9afkwzSqkcw\n\t5WUlX7teZOYWTBwbXfSvaa8mjtYWSq8tmvL/XL9s="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lSgVjhF6\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<00be429e-13a9-aabd-3b68-7ec682b446ea@gmx.de>","References":"<20220904162715.286574-1-Rauch.Christian@gmx.de>\n\t\n\t<4056f8eb-d9c1-b098-419e-22829e07ffda@ideasonboard.com>\n\t<166237150069.2444436.17964164995530545653@Monstersaurus>\n\t<00be429e-13a9-aabd-3b68-7ec682b446ea@gmx.de>","To":"Christian Rauch ,\n\tLaurent Pinchart ,\n\tUmang Jain ,\n\tUmang Jain via libcamera-devel ","Date":"Mon, 05 Sep 2022 20:40:26 +0100","Message-ID":"<166240682666.56880.7619863806175978081@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24944,"web_url":"https://patchwork.libcamera.org/comment/24944/","msgid":"","date":"2022-09-05T22:08:46","subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"Hi Kieran,\n\nAm 05.09.22 um 21:40 schrieb Kieran Bingham:\n> Quoting Christian Rauch (2022-09-05 20:26:19)\n>> Hi Kieran,\n>>\n>> Am 05.09.22 um 11:51 schrieb Kieran Bingham:\n>>> Hi All,\n>>>\n>>> Quoting Umang Jain via libcamera-devel (2022-09-05 07:41:50)\n>>>> Hi Christian,\n>>>>\n>>>> Thank you for the patch.\n>>>>\n>>>> On 9/5/22 3:29 AM, Laurent Pinchart via libcamera-devel wrote:\n>>>>> Hi Christian,\n>>>>>\n>>>>> Thank you for the patch.\n>>>>>\n>>>>> On Sun, Sep 04, 2022 at 06:27:15PM +0200, Christian Rauch via libcamera-devel wrote:\n>>>>>> Compiling with tests adds a significant amount of build targets to the\n>>>>>> meson build. However, tests are only of interest when a feature has been\n>>>>>> implemented or for continuous integration.\n>>>>>> Disable tests by default to reduce the computational resource requirements\n>>>>>> and the duration of a complete libcamera built.\n>>>>>>\n>>>>>> Signed-off-by: Christian Rauch \n>>>>> As most people building libcamera won't run tests, this seems reasonable\n>>>>> to me. I'm however a bit worried that it would lead to lower\n>>>>> compilation-test coverage, as people may send patches without realizing\n>>>>> they break compilation of tests. We already have that problem for\n>>>>\n>>>> I'm concerned about this as well.\n>>>\n>>> When I first saw this patch over the weekend, indeed my reaction was\n>>> \"Ahhh\" ... but I also agree this is a better default to have off right\n>>> now.\n>>>\n>>> We would like patches to be submitted after having all tests run, but\n>>> the majority of people who compile libcamera (currently) may not be\n>>> developers. We have lots of people compiling on RPi / IPU3 and low power\n>>> devices directly, and they certainly don't care for running tests.\n>>\n>> I compile libcamera more often than I submit patches. I also compile on\n>> a Raspberry Pi Zero 2. So compiling the tests is a huge waste of\n>> resources for me.\n>\n> Yes, I understand that. If libcamera were 'well packaged, stable, and\n> finished' ... there would be less users having to compile it though.\n>\n> So some time in the future... libcamera should become\n> rarely built, and tests won't be such a burden.\n>\n> Also - compiling on an RPi02 is certainly a pain. Did I share the RPi\n> cross compile environment with you already ?\n>\n>\n>\n>>> So to improve user experience, I do think this should be off by default\n>>> (at least now) and that stance may change depending on our upcoming\n>>> release strategies ... but developers should be able to enable tests\n>>> anyway.\n>>\n>> I would argue that tests should only be enabled when it is intended to\n>> run them.\n>>\n>>> Ideally of course these tests will then be enabled and run on any branch\n>>> push to the common public hosting services, so I think we should\n>>> integrate a gitlab and github CI script that could build and run the\n>>> unit tests. (These could skip the kernel related tests initially).\n>>\n>> I am also used to have tests run automatically on a CI server when I\n>> send PRs to other projects. Having some public libcamera CI instance\n>> that compiles and tests sent patches would be very helpful.\n>> If you intend to use GitHub actions, I can contribute the scripts that I\n>> already use for my own purpose.\n>\n> As mentioned in the thread with Laurent - this is more complex because\n> we need a custom kernel with virtual drivers (as you've experienced).\n>\n> I think this can be solved, but that requires some investigations that I\n> haven't had time for.\n>\n> 'We' won't use github actions, but I think integrating a github actions\n> script to the repository is certainly reasonable, if it helps anyone who\n> pushes a branch to their repository compile test in a consistent manner.\n>\n> If you have something usable for that, please do post it to the list.\n\nI gave this a shot with the kernel modules on a GitHub runner:\nhttps://github.com/christianrauch/libcamera-ci/blob/ci/.github/workflows/main_runner.yml\n\nAfter installing the kernel modules vimc, vim2m and vivid on Ubuntu\n22.04, I was able to run some of the tests that require a virtual camera\ndevice. But some other tests fail because of timeouts in\n\"ipc_pipe_unixsocket.cpp:134\".\nI think there are still some peculiarities of running in some kind of\nVM, but testing with a virtual camera in a CI is certainly possible.\n\n>\n> --\n> Kieran\n>\n>\n>>\n>>>\n>>> Anyway,\n>>>\n>>> Yes -\n>>>\n>>> Reviewed-by: Kieran Bingham \n>>>\n>>>>> runtime breakages of tests, and it's most likely be addressed by test\n>>>>> automation on patches submitted upstream, so I think I'm fine with the\n>>>>> change.\n>>>>>\n>>>>> Reviewed-by: Laurent Pinchart \n>>>>\n>>>> Reviewed-by: Umang Jain \n>>>>\n>>>>>\n>>>>>> ---\n>>>>>> meson_options.txt | 1 +\n>>>>>> 1 file changed, 1 insertion(+)\n>>>>>>\n>>>>>> diff --git a/meson_options.txt b/meson_options.txt\n>>>>>> index 7a9aecfc..f1d67808 100644\n>>>>>> --- a/meson_options.txt\n>>>>>> +++ b/meson_options.txt\n>>>>>> @@ -47,6 +47,7 @@ option('qcam',\n>>>>>>\n>>>>>> option('test',\n>>>>>> type : 'boolean',\n>>>>>> + value : false,\n>>>>>> description: 'Compile and include the tests')\n>>>>>>\n>>>>>> option('tracing',\n>>>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A3940C3272\n\tfor ;\n\tMon, 5 Sep 2022 22:08:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A66A62079;\n\tTue, 6 Sep 2022 00:08:51 +0200 (CEST)","from mout.gmx.net (mout.gmx.net [212.227.15.19])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5AA262072\n\tfor ;\n\tTue, 6 Sep 2022 00:08:47 +0200 (CEST)","from [192.168.0.158] ([88.152.184.103]) by mail.gmx.net (mrgmx005\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id\n\t1M3lY1-1oV31Q0sXj-000q6j for\n\t; Tue, 06 Sep 2022 00:08:47 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662415731;\n\tbh=dHdBGHiM2H79k0NObb72YNwdAf2rI43iMWu7Jtk3pZA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=CywbpqgjuOt5s5rXrWMCXakYkUQCY1U3CyVHKOQByvgdDym1IDBEmooxwG4+TgZDw\n\te94SkiPMozrNaH0uSXshHhm4YhBfXEzN8YlzvGm0ULnw6S/ulYyEeUu/7LQdrQFmrv\n\tBxFHMBz5aK2Zej3mQ8DnJVR/s7/ML05ScRxI/BjDDlNTtJMple104tzNrBSjaLXSYS\n\tPjpU7huvCJEx6G7lhQ/JhTd9kHniCF+agws5VMD/q85ehfR7dTe0L+6KN4/FU816o6\n\tRT9rqJFi70bgf+Fo5UeTwZjjW4LdDGxpZs3WbiZ+22X7RSjEcLjOozE/LpaKzfKPxP\n\tdoQV0MctTAM0w==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1662415727;\n\tbh=dHdBGHiM2H79k0NObb72YNwdAf2rI43iMWu7Jtk3pZA=;\n\th=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To;\n\tb=ePjd/9Z9uYDUpcg2mpRgtAvuzG73XkYuiQqGFA8vR5O8lvqVuGtuMs0lQ+PGPpp63\n\tSn0Pvg7EM0xaua4zElHtuUpluIOqMqgbZum/FEPh8zVhuSBWwjqKq0ij/dV0EQ9WM9\n\tbRbOBYaXwniXQcsPs05m3y8LFhowRhWujhf5X2Bk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"ePjd/9Z9\"; dkim-atps=neutral","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","Message-ID":"","Date":"Tue, 6 Sep 2022 00:08:46 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.11.0","Content-Language":"en-GB","To":"libcamera-devel@lists.libcamera.org","References":"<20220904162715.286574-1-Rauch.Christian@gmx.de>\n\t\n\t<4056f8eb-d9c1-b098-419e-22829e07ffda@ideasonboard.com>\n\t<166237150069.2444436.17964164995530545653@Monstersaurus>\n\t<00be429e-13a9-aabd-3b68-7ec682b446ea@gmx.de>\n\t<166240682666.56880.7619863806175978081@Monstersaurus>","In-Reply-To":"<166240682666.56880.7619863806175978081@Monstersaurus>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:jRzxyCYzox3hE5YhLv3YVmJFGDGqmRpelTcCZzLB7PXNrWKSTaY\n\t7Fiz7I/1k7BWa9qbVTFJXnChPrr98kFxkjWUjbgoGyExpi7jJgfZB65+2T2ihX+/3i29QOe\n\t06G0GZXWgURPfEZBFAscSFBnWp1WisrKToD0C7obHsYbGCzt38YEoEQprhOSgr9q5dmPFKs\n\tiwR5/abJBcNHPyjZK4k2Q==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:2b0SOjNrG7w=:maXIHi3TjkXoNs7WjiuL3Y\n\thQN4ogeONhZ6+akrk5cOAiV/vTYOjuherImiciD8XYQWMjrrrp9GJXn99QPObaykCApI9+9zw\n\tUzvCDyFuDer3TwcSzFnsNxmOqvbok78E5gS80eopjWFLszmcs0lAmnOvCOs2sEL8uVtoGS7n5\n\t1P4CxGpoba5q7ruxM86XZue7ZSjpNNsoZS3i3Vg6r3l3sQ84v0DUviBQ1JLxqi8qr2hcfz8g3\n\tuWDHOCmbtFu9J6EjE03RA2pAKtxSz/bZxBZXepp05Dbk8qg4UEJW1imupHt47/PLJvOaM1++r\n\tQhgyy/o2dE9zYkBFAq+D/jmNiNCy+xUsXN2KZ56E4GfGxmKn1dtP+1tPTUGPLvEYXR86BVF0x\n\taOjaYbp0mXJ/x7zTh27olUUZ8osZX0L+u0Ru64n6282k/z0OQDE4OJqSgvzpssrTwN5KfDCb8\n\t7e5dEG1Pj33MbKMCAgEcV/GFKmmYlcH9h1i0M212vO3/4tcN8Wkq3fQlDntQ1evRFZnTCat8l\n\tWCt8WI4zlvYG7XomScd4X9WCcZ9VbUEwAKXJL054fF9nwBKNSXPV+knqUuo/mCPsacvv7X/i4\n\tJwNFPwHo6IMlP8MZGWp9w9+GT9czlqPq6K7BzcMUSgAslFEopPI8iCSNuxWF4ZGIkhqdu98kQ\n\tSyHs7lmu1saSc0Hh+wXzR3z7MJJAMWyBCIchmOgzlz1PHQi8YwKdH4XwtuDm9EWGazSHI83eQ\n\thalfeLicvOLzH2OGbbSvhhf5geuQ3f6DIJAOxOeQBK7Jnbf3r3GHF929XX7orKGxPw1NPw3s8\n\t8Ij7/qnyIKqTcGSZS4oB9VhJ669Kd36jo/Qiziti/Z6WTQBW67WzLCtcIsF/rcJFIURYj8iPm\n\tCAhhSfYtAhoovlz66e9P7abh1h1JH0/pJHq9oqqh3MdjI5li8Zv59SNGXjfgKcP9CZYscMssO\n\tAAaxxM1NUMa3tXQ/LjjS7CRU2Ug3ZyCm5/+u2EXNFT2zYZqXAzvhxc0iDVAl8VUJr8aN61pOm\n\tl58pGkX07fulBYlHvziYYPPNDV+tJmFvLC6t0s2LGdxfuqVFmdZ7VnvK/S2WHLf3pWWm7q6iI\n\t+EBkgSMF03nTcpdUpG3yOM5ss/YPHsWhTdy7a4RqdK3CwEK3Kf14QQitp0QmSdRZQh0d14e99\n\tTaoZZ/TfgYTo1WHXPQ9G0/Ek+D","Subject":"Re: [libcamera-devel] [PATCH] meson: disable tests by default","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]