{"id":17283,"url":"https://patchwork.libcamera.org/api/patches/17283/?format=json","web_url":"https://patchwork.libcamera.org/patch/17283/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220902224939.111640-2-Rauch.Christian@gmx.de>","date":"2022-09-02T22:49:39","name":"[libcamera-devel,v3,2/2] libcamera: control: initialise control info to ControlTypeNone by default","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8eb49c6c8c989398aa4c3ab0fce7924786c14348","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/?format=json","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17283/mbox/","series":[{"id":3462,"url":"https://patchwork.libcamera.org/api/series/3462/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3462","date":"2022-09-02T22:49:38","name":"[libcamera-devel,v3,1/2] libcamera: serialiser: store/load all ControlValue types","version":3,"mbox":"https://patchwork.libcamera.org/series/3462/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17283/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17283/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7886C327D\n\tfor ;\n\tFri, 2 Sep 2022 22:49:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A29762003;\n\tSat, 3 Sep 2022 00:49:45 +0200 (CEST)","from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C32B161F98\n\tfor ;\n\tSat, 3 Sep 2022 00:49:42 +0200 (CEST)","from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx105\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id 1MWASY-1os0mC1PwI-00Xeyb;\n\tSat, 03 Sep 2022 00:49:42 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662158985;\n\tbh=43Wc/2BpudvfrX/o3utclvPD0GpzMKvzRuoMqKNZyAc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=aQuJPRWiXa3tyYwXG5gxwfYBBEl9/InlRX/4ARbP6qZEpgia9NziFuvYBd5tbOG8M\n\t30HGrsTXl7VYBxslH8j98xn4cdnhbPrmh18HYano9eTdlxBVeQssViu0Y40pH64vzT\n\tp0SDr5+TBXN+4wDaRTPrxze46j45/0t8eP9dfPxTmAen9POVw1Xx8mpCEvNEVk4IAP\n\tc/FXV+uXh46NgLmRDt+ZaPAHOyjIsJ21gv2JaEx++POTXxkDqYoHwJVDfLNYcceaYz\n\tGLenlN8UTozjxtBvkAz9h3WpUzk9EvVPunyuuirfLrrekh5zlY5Xv0YXuoIB6gtAyO\n\tXBYlIcxvsFMUw==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1662158982;\n\tbh=43Wc/2BpudvfrX/o3utclvPD0GpzMKvzRuoMqKNZyAc=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=IA35MEPnHro8EySkf/GvRkBwE1ViYjQnP9SKMeG2tzGjEhkDmzMhRNRmzqxIXIGgQ\n\t0tcgwp81spMPwlmBNcn5MRaNjXQlAHZmQvEu5Rnkb4+irnKWxW+QKXXPX/WsL20Uh/\n\t19glWxpZ7JOu19ISmOWtYsIV7z8nhon+tWnOV5AI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"IA35MEPn\"; dkim-atps=neutral","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 3 Sep 2022 00:49:39 +0200","Message-Id":"<20220902224939.111640-2-Rauch.Christian@gmx.de>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220902224939.111640-1-Rauch.Christian@gmx.de>","References":"<20220902224939.111640-1-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:+U2dkuPU9DeXru8ShUM4nvi5GxyK1y2QAPuaJ7fqhAgu6GtELSK\n\tjjTyl709jJGl7PVSRSLp7Go1V2iT2nYivJAvhZvZQoAs5z8W6LgjlU9M7W/Xz2FpImeYXeZ\n\t3Kcf5ugKJU238b9f3M581wOc3K546A9viBY1hvkKW6/biYSYzEtK1ZUvLbhhLPVGT4hi4OV\n\tzbzP3v7HdpOdO5KEkWM9g==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:+3mYHzLqsa4=:UCsUUrJ0l5GyIqZmc8dFO9\n\tU/YRifkBDGfGf2ViDzqmNBzbH72BShAA+zscJc3YOayvds7qCvic4QB6rhX+2k7/0wtjME1u/\n\tJGzm7l/kbYGnWlbOC580jJX+vFJeuXyBNA4DepiC2ddd98A2smKmf6V5PsP8RQTbBmyJ69Srx\n\tLPagpAIx+Lyvx1ssMvKyg98pjCh11E7DVfBfQxKbRH08Jo9cnz/A2DMvopRniSTTZomuq/mCr\n\tRzp3mO/mf5uGF81wJe3NCbeF8sSzpgCUVTObc2BA6+s66an6yR7/x9DwCRuXr7bCaTCtucpm2\n\tHAWls7b9Usmm3N4K/MDFbVoPV0EVY972M140HULsxTRGJwhyu3oc4DLwr15dZ0iQNmgQyjX0W\n\tCLf9l0nDt3BaEfXjSRsIHzAtLH94fQvusxKD9cQ7+ScP/1+3UHVCXwQgd+zrd392qLlcG+hYc\n\tKyoljf/dUI44DnfDcUEhkcEfSYsSvVvEE4ZZntH1N5RCK55k7KTC1Xlt0yR/hrtmZm3a5GY1O\n\te0VsGk0UdQUGQCKm+gBkoWuhYwN2hU1Lm7Nqhl+RvO2O8QyNG15MtfOMjuqPqPUqnAs9VGR+9\n\tO6MswCT0tgjS7/kOdAjfjXUyAOgsHuNQ/LuRdHx2TiLnIuip6O/423fDp410ILY1Zji/NyWrx\n\tjeH2yXDH2Xj5VD5wdTubWKLT70hA4LjC04H+FyMLG2m5638sS8mAERfg+zXKf8RDbF61wkJUN\n\tkUl6JkXafDSXrY9hyI8ttDko4a4VRlriNi2LpTzwmwNjqgkKyY7OV2RjRq0ARrLeGSE5GqFDg\n\t6bQKSj/aBXlF5d8FK6WG4L+nVK8188qGcir2+05adbEmNpPWIrJ5Pgp6PpxZ0Fzq4ZjbJSCJz\n\txLAzetuvhjAQNU/oDpNDTYARY8R4YMOhu/EPHjhVGY/80j0novfOshDewQUBFURg6YwJZtBOE\n\tc7x4fSK5xwV4dkhnG8eaHG9bUelT23IjWDSBRWXADJr2PPp2/j9/XyjvlH1Yhj88dRsZxCAuI\n\tm6yc2oYxDiG0GRKhuBFh9QFE2Pl7zbVFNxSU4+iQUIMOWQZ+NBTN/uz+oJ9nNGKk7YUUWW56b\n\tFDVqohG8XJ4d1OImN0aqweZJBMlRi70DSXhdZnUp85cE2QSG/iDL7IUB0LMcYyV/plUmjKIa0\n\tguzt3aLH06LVcnUvfdA58dwpHm","Subject":"[libcamera-devel] [PATCH v3 2/2] libcamera: control: initialise\n\tcontrol info to ControlTypeNone by default","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The default ControlInfo constructor allows to partially initialised the\nmin/max/def values. Uninitialised values are assigned to 0 by default. This\nimplicit initialisation makes it impossible to distinguish between and\nuninitialised and an explicitly 0-initialised ControlValue.\n\nDefault construct the ControlValue in the ControlInfo default contructor to\nexplicitly represent uninitialised values by the ControlTypeNone type.\n\nSigned-off-by: Christian Rauch \n---\n include/libcamera/controls.h | 6 +++---\n test/controls/control_info.cpp | 4 ++--\n 2 files changed, 5 insertions(+), 5 deletions(-)\n\n--\n2.34.1","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex ebc168fc..38d0a3e8 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -268,9 +268,9 @@ private:\n class ControlInfo\n {\n public:\n-\texplicit ControlInfo(const ControlValue &min = 0,\n-\t\t\t const ControlValue &max = 0,\n-\t\t\t const ControlValue &def = 0);\n+\texplicit ControlInfo(const ControlValue &min = {},\n+\t\t\t const ControlValue &max = {},\n+\t\t\t const ControlValue &def = {});\n \texplicit ControlInfo(Span values,\n \t\t\t const ControlValue &def = {});\n \texplicit ControlInfo(std::set values, bool def);\ndiff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp\nindex 2827473b..56b4101f 100644\n--- a/test/controls/control_info.cpp\n+++ b/test/controls/control_info.cpp\n@@ -26,8 +26,8 @@ protected:\n \t\t */\n \t\tControlInfo brightness;\n\n-\t\tif (brightness.min().get() != 0 ||\n-\t\t brightness.max().get() != 0) {\n+\t\tif (brightness.min().type() != ControlType::ControlTypeNone ||\n+\t\t brightness.max().type() != ControlType::ControlTypeNone) {\n \t\t\tcout << \"Invalid control range for Brightness\" << endl;\n \t\t\treturn TestFail;\n \t\t}\n","prefixes":["libcamera-devel","v3","2/2"]}