{"id":17263,"url":"https://patchwork.libcamera.org/api/patches/17263/?format=json","web_url":"https://patchwork.libcamera.org/patch/17263/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220830202124.457253-2-Rauch.Christian@gmx.de>","date":"2022-08-30T20:21:24","name":"[libcamera-devel,v2,2/2] test: represent uninitialised values via ControlTypeNone","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e59719b83ab6d88bfbcbe61e803e1592d216b6d8","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/?format=json","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17263/mbox/","series":[{"id":3456,"url":"https://patchwork.libcamera.org/api/series/3456/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3456","date":"2022-08-30T20:21:23","name":"[libcamera-devel,v2,1/2] libcamera: control: initialise control info to ControlTypeNone by default","version":2,"mbox":"https://patchwork.libcamera.org/series/3456/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17263/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17263/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BBB27C3272\n\tfor ;\n\tTue, 30 Aug 2022 20:21:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8CDF461FC4;\n\tTue, 30 Aug 2022 22:21:29 +0200 (CEST)","from mout.gmx.net (mout.gmx.net [212.227.15.15])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59AD461F9E\n\tfor ;\n\tTue, 30 Aug 2022 22:21:27 +0200 (CEST)","from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx005\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 1MnakR-1pAP353uzN-00jZTE;\n\tTue, 30 Aug 2022 22:21:27 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661890889;\n\tbh=wOJwDrNf0xdBeE0FltnByPOrSE8MMXUO8R+6Wl9E6fI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=0cteoDbl0WKRQSmAiRraHeSwUQxZfm/TnxWrViiDlEFIFj2U5DsTbnNumE4qdGlDc\n\tY5X1C52XgGfuidr4/A0Q3PaOvlJBWtsWNyiG1nZGCrgxhrQ9ydKlUDxBcymYELuJZH\n\trpzFWICcHjqkmu4wLjy1/Qt2gNiWNJHhyYINAz1R0V1sHppu+IFIQ1oG4ChSxEOQoj\n\tlftKC5FzF7HUoAbeTgmYn62wHL/JTq9pN6Igml14Nqew2Usr/PubGYPeI2bGaP/VnT\n\tIyLV+ux5mJw+SQ9D3bBriP7n5IxWjq/NBrrKZAEave7tz2REMjAyaIU+gq6eYjmLUG\n\tq8YdwEjJkcIMQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1661890887;\n\tbh=wOJwDrNf0xdBeE0FltnByPOrSE8MMXUO8R+6Wl9E6fI=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=kCfuDAPNAwk9hiYMWGAj2DcCz1bFtVyJSLct6JED3AYDxES6NGOeAM2qqNjn6iPB5\n\t94PrKMr4+vdAiSNzc+f10dpNSQANKfbl+t4RZxFpT7nHro2YVIORln9PEGmRhcIKaC\n\t+bXTjKdltJzDIs+66t9PhLw3a3zfiL59zr/Lgv2E="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"kCfuDAPN\"; dkim-atps=neutral","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 30 Aug 2022 22:21:24 +0200","Message-Id":"<20220830202124.457253-2-Rauch.Christian@gmx.de>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220830202124.457253-1-Rauch.Christian@gmx.de>","References":"<20220830202124.457253-1-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:YLfPpHiEBGYWMZ28F4JCtdPlfWSV6GTqGpW4k2PIxc8vIjovsZ5\n\t/0Hlksk3X0B1SkO5XoW7iwmcNM+KbJBUFNe47u4VPzG0gdn1OEucFR0TfJxdrqxsL4JK628\n\ta26YV9nb+nGqBuslHLGs/ziZ4mhop0TnySDsyf+ahcHvHhPxb2U4mCkMpQOa3UdExgUlBqB\n\tWwvitfVkTlHnJ2ehC9nGw==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:awd+5/3pgic=:wN8ON1Wms3YXwdQcpq58o1\n\tGbJzJA1i53iRQ0yXtHn3mtIG+2d83HQgPPDx9XmOiBCd79kP7UOxG0H8OPt25xhhGugK4Jj7Q\n\tZ5aU0ZWSeyE0q1ApAV9Yx69et6WHvGXzG6jMrEcX/hIUUFIkipa63lENJE+LjdgJ88CtttL6h\n\tJcioreo9QEVBvpiJf+VecwHtxUvvzSrUljh0js6AuEJANH+u2Nl1k/2WCYkDDi/Xs/2D27kZc\n\tUO/0R5NMYTZdVXZWnN2oDgfCish47cQEeRbTUwXhKe0XOlcBQoh1cNocLyZ7F3JOtSzSJ2Rhh\n\tmLYgUkDJ5LDSjMjFpCOesO8XTbR9AAjoQ7PRsNKzJNVZrrvgH7yAEdPFaHqaNu3miuMDyThlE\n\tgbH/ZbpPUDpMXQpgHN5aDFo9MbjidT43gWPnL5j/6gQ1AA+yC608wQHLR9tA2zvEf4/O37piK\n\tqr1ASa3pmXIQ5WqX8rUVjFJ+ABtheFSHSioonhVKd7RyNddxKc8shdgztGPfunZT36MDd0w1k\n\tzDQAsc77vefR4BM4XD0hqzqvcHuCG9vIk7ckzAPVQidvFf/u/I3uMFrnhIgk2+VXGo05dA3wE\n\tQYoAjZMNO/VeWIoqOeVCKmmz37vbIyQx/3MNV3SkW4NTqyVm387jMk4Cxi6wdaOQ12nRg07fs\n\t0SOggYQxJ6DiKRq0ytYgqLdLIkGJiNjM+lIWEVXc/BA7CqNGLjVEblhzCUFHlB6AGoTSFf4ao\n\tU7cowfEuWpnG5Rn2TrYRUOGDYYBuM09NMCUsQLnU9TWBerKXtO9Edx8mgyZd6EiJLJDioyY5Z\n\tpZI/V74gYpmzWL/94W+xdk/BdxR86MUOtU3kuf6YYy0JIu/CL1fI1lZc62ls20zsL9gOShKv+\n\t4+OYF4As2bi+cQzZ27Pc1lAObqvQ+tGOcbe3DTmQSRU7ByFzI+7i2yePuhyrZiMDT7goSNznu\n\tk3j1+QjFPrAwjo22tvhj3ARcpgQSPNyihXZXR4F5TBcZDyVcWwag4PBfIyOf7asQJVB/NevZv\n\t294b23iTQmw1MaodIZqeBwRZrqASy5Nae31zjpAwBsjDQ6DZJ05U9/PwJJei9g1OBmIPd5hzP\n\tTCg+ziFbIkr4wtFUdWHa5hJSDgE1zFPj36PjgIQNFunw37Z6pFg3C4pIA==","Subject":"[libcamera-devel] [PATCH v2 2/2] test: represent uninitialised\n\tvalues via ControlTypeNone","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Previously, not explicitly initialised values were represented by 0. This\nwas replaced by ControlTypeNone for better semantics.\n\nSigned-off-by: Christian Rauch \n---\n test/controls/control_info.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n--\n2.34.1","diff":"diff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp\nindex 2827473b..56b4101f 100644\n--- a/test/controls/control_info.cpp\n+++ b/test/controls/control_info.cpp\n@@ -26,8 +26,8 @@ protected:\n \t\t */\n \t\tControlInfo brightness;\n\n-\t\tif (brightness.min().get() != 0 ||\n-\t\t brightness.max().get() != 0) {\n+\t\tif (brightness.min().type() != ControlType::ControlTypeNone ||\n+\t\t brightness.max().type() != ControlType::ControlTypeNone) {\n \t\t\tcout << \"Invalid control range for Brightness\" << endl;\n \t\t\treturn TestFail;\n \t\t}\n","prefixes":["libcamera-devel","v2","2/2"]}