[{"id":24879,"web_url":"https://patchwork.libcamera.org/comment/24879/","msgid":"<20220901042100.GJ27075@pyrite.rasen.tech>","date":"2022-09-01T04:21:00","subject":"Re: [libcamera-devel] [PATCH v4 7/7] gstreamer: Provide colorimetry\n\t<> ColorSpace mappings","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Tue, Aug 30, 2022 at 01:17:25PM +0530, Umang Jain via libcamera-devel wrote:\n> From: Rishikesh Donadkar \n> \n> Provide colorimetry <=> libcamera::ColorSpace mappings via:\n> - GstVideoColorimetry colorimetry_from_colorspace(colorspace);\n> - ColorSpace colorspace_from_colorimetry(colorimetry);\n> \n> Read the colorimetry field from caps into the stream configuration.\n> After stream validation, the sensor supported colorimetry will\n> be retrieved and the caps will be updated accordingly.\n> \n> Colorimetry support for gstlibcamera currently undertakes only one\n> argument. Multiple colorimetry support shall be introduced in\n> subsequent commits.\n> \n> Signed-off-by: Rishikesh Donadkar \n> Signed-off-by: Umang Jain \n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Umang Jain \n\nReviewed-by: Paul Elder \n\n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 169 +++++++++++++++++++++++++++\n> 1 file changed, 169 insertions(+)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index 5a21a391..c7b44a8e 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -57,6 +57,152 @@ static struct {\n> \t/* \\todo NV42 is used in libcamera but is not mapped in GStreamer yet. */\n> };\n> \n> +static GstVideoColorimetry\n> +colorimetry_from_colorspace(const ColorSpace &colorSpace)\n> +{\n> +\tGstVideoColorimetry colorimetry;\n> +\n> +\tswitch (colorSpace.primaries) {\n> +\tcase ColorSpace::Primaries::Raw:\n> +\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_UNKNOWN;\n> +\t\tbreak;\n> +\tcase ColorSpace::Primaries::Smpte170m:\n> +\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_SMPTE170M;\n> +\t\tbreak;\n> +\tcase ColorSpace::Primaries::Rec709:\n> +\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_BT709;\n> +\t\tbreak;\n> +\tcase ColorSpace::Primaries::Rec2020:\n> +\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_BT2020;\n> +\t\tbreak;\n> +\t}\n> +\n> +\tswitch (colorSpace.transferFunction) {\n> +\tcase ColorSpace::TransferFunction::Linear:\n> +\t\tcolorimetry.transfer = GST_VIDEO_TRANSFER_GAMMA10;\n> +\t\tbreak;\n> +\tcase ColorSpace::TransferFunction::Srgb:\n> +\t\tcolorimetry.transfer = GST_VIDEO_TRANSFER_SRGB;\n> +\t\tbreak;\n> +\tcase ColorSpace::TransferFunction::Rec709:\n> +\t\tcolorimetry.transfer = GST_VIDEO_TRANSFER_BT709;\n> +\t\tbreak;\n> +\t}\n> +\n> +\tswitch (colorSpace.ycbcrEncoding) {\n> +\tcase ColorSpace::YcbcrEncoding::None:\n> +\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_RGB;\n> +\t\tbreak;\n> +\tcase ColorSpace::YcbcrEncoding::Rec601:\n> +\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT601;\n> +\t\tbreak;\n> +\tcase ColorSpace::YcbcrEncoding::Rec709:\n> +\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT709;\n> +\t\tbreak;\n> +\tcase ColorSpace::YcbcrEncoding::Rec2020:\n> +\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT2020;\n> +\t\tbreak;\n> +\t}\n> +\n> +\tswitch (colorSpace.range) {\n> +\tcase ColorSpace::Range::Full:\n> +\t\tcolorimetry.range = GST_VIDEO_COLOR_RANGE_0_255;\n> +\t\tbreak;\n> +\tcase ColorSpace::Range::Limited:\n> +\t\tcolorimetry.range = GST_VIDEO_COLOR_RANGE_16_235;\n> +\t\tbreak;\n> +\t}\n> +\n> +\treturn colorimetry;\n> +}\n> +\n> +static std::optional\n> +colorspace_from_colorimetry(const GstVideoColorimetry &colorimetry)\n> +{\n> +\tstd::optional colorspace;\n> +\n> +\tswitch (colorimetry.primaries) {\n> +\tcase GST_VIDEO_COLOR_PRIMARIES_UNKNOWN:\n> +\t\t/* Unknown primaries map to raw colorspace in gstreamer */\n> +\t\treturn ColorSpace::Raw;\n> +\tcase GST_VIDEO_COLOR_PRIMARIES_SMPTE170M:\n> +\t\tcolorspace->primaries = ColorSpace::Primaries::Smpte170m;\n> +\t\tbreak;\n> +\tcase GST_VIDEO_COLOR_PRIMARIES_BT709:\n> +\t\tcolorspace->primaries = ColorSpace::Primaries::Rec709;\n> +\t\tbreak;\n> +\tcase GST_VIDEO_COLOR_PRIMARIES_BT2020:\n> +\t\tcolorspace->primaries = ColorSpace::Primaries::Rec2020;\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tGST_WARNING(\"Colorimetry primaries %d not mapped in gstlibcamera\",\n> +\t\t\t colorimetry.primaries);\n> +\t\treturn std::nullopt;\n> +\t}\n> +\n> +\tswitch (colorimetry.transfer) {\n> +\t/* Transfer function mappings inspired from v4l2src plugin */\n> +\tcase GST_VIDEO_TRANSFER_GAMMA18:\n> +\tcase GST_VIDEO_TRANSFER_GAMMA20:\n> +\tcase GST_VIDEO_TRANSFER_GAMMA22:\n> +\tcase GST_VIDEO_TRANSFER_GAMMA28:\n> +\t\tGST_WARNING(\"GAMMA 18, 20, 22, 28 transfer functions not supported\");\n> +\t/* fallthrough */\n> +\tcase GST_VIDEO_TRANSFER_GAMMA10:\n> +\t\tcolorspace->transferFunction = ColorSpace::TransferFunction::Linear;\n> +\t\tbreak;\n> +\tcase GST_VIDEO_TRANSFER_SRGB:\n> +\t\tcolorspace->transferFunction = ColorSpace::TransferFunction::Srgb;\n> +\t\tbreak;\n> +\tcase GST_VIDEO_TRANSFER_BT601:\n> +\tcase GST_VIDEO_TRANSFER_BT2020_12:\n> +\tcase GST_VIDEO_TRANSFER_BT2020_10:\n> +\tcase GST_VIDEO_TRANSFER_BT709:\n> +\t\tcolorspace->transferFunction = ColorSpace::TransferFunction::Rec709;\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tGST_WARNING(\"Colorimetry transfer function %d not mapped in gstlibcamera\",\n> +\t\t\t colorimetry.transfer);\n> +\t\treturn std::nullopt;\n> +\t}\n> +\n> +\tswitch (colorimetry.matrix) {\n> +\tcase GST_VIDEO_COLOR_MATRIX_RGB:\n> +\t\tcolorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::None;\n> +\t\tbreak;\n> +\t/* FCC is about the same as BT601 with less digit */\n> +\tcase GST_VIDEO_COLOR_MATRIX_FCC:\n> +\tcase GST_VIDEO_COLOR_MATRIX_BT601:\n> +\t\tcolorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::Rec601;\n> +\t\tbreak;\n> +\tcase GST_VIDEO_COLOR_MATRIX_BT709:\n> +\t\tcolorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::Rec709;\n> +\t\tbreak;\n> +\tcase GST_VIDEO_COLOR_MATRIX_BT2020:\n> +\t\tcolorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::Rec2020;\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tGST_WARNING(\"Colorimetry matrix %d not mapped in gstlibcamera\",\n> +\t\t\t colorimetry.matrix);\n> +\t\treturn std::nullopt;\n> +\t}\n> +\n> +\tswitch (colorimetry.range) {\n> +\tcase GST_VIDEO_COLOR_RANGE_0_255:\n> +\t\tcolorspace->range = ColorSpace::Range::Full;\n> +\t\tbreak;\n> +\tcase GST_VIDEO_COLOR_RANGE_16_235:\n> +\t\tcolorspace->range = ColorSpace::Range::Limited;\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tGST_WARNING(\"Colorimetry range %d not mapped in gstlibcamera\",\n> +\t\t\t colorimetry.range);\n> +\t\treturn std::nullopt;\n> +\t}\n> +\n> +\treturn colorspace;\n> +}\n> +\n> static GstVideoFormat\n> pixel_format_to_gst_format(const PixelFormat &format)\n> {\n> @@ -151,6 +297,18 @@ gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg\n> \t\t\t \"width\", G_TYPE_INT, stream_cfg.size.width,\n> \t\t\t \"height\", G_TYPE_INT, stream_cfg.size.height,\n> \t\t\t nullptr);\n> +\n> +\tif (stream_cfg.colorSpace) {\n> +\t\tGstVideoColorimetry colorimetry = colorimetry_from_colorspace(stream_cfg.colorSpace.value());\n> +\t\tgchar *colorimetry_str = gst_video_colorimetry_to_string(&colorimetry);\n> +\n> +\t\tif (colorimetry_str)\n> +\t\t\tgst_structure_set(s, \"colorimetry\", G_TYPE_STRING, colorimetry_str, nullptr);\n> +\t\telse\n> +\t\t\tg_error(\"Got invalid colorimetry from ColorSpace: %s\",\n> +\t\t\t\tColorSpace::toString(stream_cfg.colorSpace).c_str());\n> +\t}\n> +\n> \tgst_caps_append_structure(caps, s);\n> \n> \treturn caps;\n> @@ -234,6 +392,17 @@ gst_libcamera_configure_stream_from_caps(StreamConfiguration &stream_cfg,\n> \tgst_structure_get_int(s, \"height\", &height);\n> \tstream_cfg.size.width = width;\n> \tstream_cfg.size.height = height;\n> +\n> +\t/* Configure colorimetry */\n> +\tif (gst_structure_has_field(s, \"colorimetry\")) {\n> +\t\tconst gchar *colorimetry_str = gst_structure_get_string(s, \"colorimetry\");\n> +\t\tGstVideoColorimetry colorimetry;\n> +\n> +\t\tif (!gst_video_colorimetry_from_string(&colorimetry, colorimetry_str))\n> +\t\t\tg_critical(\"Invalid colorimetry %s\", colorimetry_str);\n> +\n> +\t\tstream_cfg.colorSpace = colorspace_from_colorimetry(colorimetry);\n> +\t}\n> }\n> \n> #if !GST_CHECK_VERSION(1, 17, 1)\n> -- \n> 2.37.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94139C0DA4\n\tfor ;\n\tThu, 1 Sep 2022 04:21:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC91561FCC;\n\tThu, 1 Sep 2022 06:21:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C675261F9A\n\tfor ;\n\tThu, 1 Sep 2022 06:21:07 +0200 (CEST)","from pyrite.rasen.tech (unknown [50.228.9.220])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2AAEA481;\n\tThu, 1 Sep 2022 06:21:05 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662006069;\n\tbh=juachCXVZKKrK5rIApxFfy9bAPIPne9arzmhYS9tmhY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=pAXn3AvRg2nRTIMUiVJfICzOF0m4CSr1F6u/nynikmHfp7yQsKkBHX2YgvQzO1FT2\n\t4LnXvv70DjERE2H9ZQzw8khig4eI+flbphTuv1C0FpJ73gpS+nEu0rBjuUR/dCxqSZ\n\tDu1vcpDe9a4daqDAHsi2Mvm/u67PpUVrhQ9taE7YPEB4wZXHFd+JiihPECiUlewwEW\n\tnNFWkWSdh6pPYEYTELAZSEhZhAxVspsdUWgbb1Y+TaW4LJWpmaB4v7JUZqjUAuORRg\n\tFHf4/Ga5YrOVn7r1N3SHoafj4G91nIAoCXdRCqbsVl7KwTAVgsKLBn3mcoF7R507M9\n\tx6Xn8H5cVprxg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662006067;\n\tbh=juachCXVZKKrK5rIApxFfy9bAPIPne9arzmhYS9tmhY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VR+69uBx4kp5cShpl7UYncwczo6+8pKxGTPQCcbQn2wwwKv9EMHW/CIJUmm5twpmo\n\tjs8HvamNaj/w+xcX2izHHjy7Tyx695wDNmZ5xGyX2hHIyX69WPUlkYRsn3wF5CWGfT\n\tQO7mdZYksNT8Mv1Iw9JwKqThjytdATWTR798flJw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VR+69uBx\"; dkim-atps=neutral","Date":"Thu, 1 Sep 2022 00:21:00 -0400","To":"Umang Jain ","Message-ID":"<20220901042100.GJ27075@pyrite.rasen.tech>","References":"<20220830074725.1059643-1-umang.jain@ideasonboard.com>\n\t<20220830074725.1059643-8-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220830074725.1059643-8-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 7/7] gstreamer: Provide colorimetry\n\t<> ColorSpace mappings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"rishikeshdonadkar@gmail.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24883,"web_url":"https://patchwork.libcamera.org/comment/24883/","msgid":"<728d4753-642e-a04f-8a5f-9dae04972564@ideasonboard.com>","date":"2022-09-01T10:49:30","subject":"Re: [libcamera-devel] [PATCH v4 7/7] gstreamer: Provide colorimetry\n\t<> ColorSpace mappings","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi\n\nOn 8/30/22 1:17 PM, Umang Jain wrote:\n> From: Rishikesh Donadkar \n>\n> Provide colorimetry <=> libcamera::ColorSpace mappings via:\n> - GstVideoColorimetry colorimetry_from_colorspace(colorspace);\n> - ColorSpace colorspace_from_colorimetry(colorimetry);\n>\n> Read the colorimetry field from caps into the stream configuration.\n> After stream validation, the sensor supported colorimetry will\n> be retrieved and the caps will be updated accordingly.\n>\n> Colorimetry support for gstlibcamera currently undertakes only one\n> argument. Multiple colorimetry support shall be introduced in\n> subsequent commits.\n>\n> Signed-off-by: Rishikesh Donadkar \n> Signed-off-by: Umang Jain \n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Umang Jain \n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 169 +++++++++++++++++++++++++++\n> 1 file changed, 169 insertions(+)\n>\n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index 5a21a391..c7b44a8e 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -57,6 +57,152 @@ static struct {\n> \t/* \\todo NV42 is used in libcamera but is not mapped in GStreamer yet. */\n> };\n> \n> +static GstVideoColorimetry\n> +colorimetry_from_colorspace(const ColorSpace &colorSpace)\n> +{\n> +\tGstVideoColorimetry colorimetry;\n> +\n> +\tswitch (colorSpace.primaries) {\n> +\tcase ColorSpace::Primaries::Raw:\n> +\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_UNKNOWN;\n> +\t\tbreak;\n> +\tcase ColorSpace::Primaries::Smpte170m:\n> +\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_SMPTE170M;\n> +\t\tbreak;\n> +\tcase ColorSpace::Primaries::Rec709:\n> +\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_BT709;\n> +\t\tbreak;\n> +\tcase ColorSpace::Primaries::Rec2020:\n> +\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_BT2020;\n> +\t\tbreak;\n> +\t}\n> +\n> +\tswitch (colorSpace.transferFunction) {\n> +\tcase ColorSpace::TransferFunction::Linear:\n> +\t\tcolorimetry.transfer = GST_VIDEO_TRANSFER_GAMMA10;\n> +\t\tbreak;\n> +\tcase ColorSpace::TransferFunction::Srgb:\n> +\t\tcolorimetry.transfer = GST_VIDEO_TRANSFER_SRGB;\n> +\t\tbreak;\n> +\tcase ColorSpace::TransferFunction::Rec709:\n> +\t\tcolorimetry.transfer = GST_VIDEO_TRANSFER_BT709;\n> +\t\tbreak;\n> +\t}\n> +\n> +\tswitch (colorSpace.ycbcrEncoding) {\n> +\tcase ColorSpace::YcbcrEncoding::None:\n> +\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_RGB;\n> +\t\tbreak;\n> +\tcase ColorSpace::YcbcrEncoding::Rec601:\n> +\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT601;\n> +\t\tbreak;\n> +\tcase ColorSpace::YcbcrEncoding::Rec709:\n> +\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT709;\n> +\t\tbreak;\n> +\tcase ColorSpace::YcbcrEncoding::Rec2020:\n> +\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT2020;\n> +\t\tbreak;\n> +\t}\n> +\n> +\tswitch (colorSpace.range) {\n> +\tcase ColorSpace::Range::Full:\n> +\t\tcolorimetry.range = GST_VIDEO_COLOR_RANGE_0_255;\n> +\t\tbreak;\n> +\tcase ColorSpace::Range::Limited:\n> +\t\tcolorimetry.range = GST_VIDEO_COLOR_RANGE_16_235;\n> +\t\tbreak;\n> +\t}\n> +\n> +\treturn colorimetry;\n> +}\n> +\n> +static std::optional\n> +colorspace_from_colorimetry(const GstVideoColorimetry &colorimetry)\n> +{\n> +\tstd::optional colorspace;\n\nI started a rigourous testing on RPi today comparing cam's colorspace \nand gstreamer's colorspace mapping/adjustment/logs stuff and happen to \ncatch this last-min bug here.\n\nThe optional colorspace value needs to be assigned (or initialised with \na value here). Otherwise the return value from this function is always \nstd::nullopt (since we never assign a value hence the optional ptr is \nacting as non-containing value)...\n\nFor now, I have:\n\n     -       std::optional colorspace;\n     +       std::optional colorspace = ColorSpace::Raw;\n\nAny objections for this Laurent, Rishi ?\n> +\n> +\tswitch (colorimetry.primaries) {\n> +\tcase GST_VIDEO_COLOR_PRIMARIES_UNKNOWN:\n> +\t\t/* Unknown primaries map to raw colorspace in gstreamer */\n> +\t\treturn ColorSpace::Raw;\n> +\tcase GST_VIDEO_COLOR_PRIMARIES_SMPTE170M:\n> +\t\tcolorspace->primaries = ColorSpace::Primaries::Smpte170m;\n> +\t\tbreak;\n> +\tcase GST_VIDEO_COLOR_PRIMARIES_BT709:\n> +\t\tcolorspace->primaries = ColorSpace::Primaries::Rec709;\n> +\t\tbreak;\n> +\tcase GST_VIDEO_COLOR_PRIMARIES_BT2020:\n> +\t\tcolorspace->primaries = ColorSpace::Primaries::Rec2020;\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tGST_WARNING(\"Colorimetry primaries %d not mapped in gstlibcamera\",\n> +\t\t\t colorimetry.primaries);\n> +\t\treturn std::nullopt;\n> +\t}\n> +\n> +\tswitch (colorimetry.transfer) {\n> +\t/* Transfer function mappings inspired from v4l2src plugin */\n> +\tcase GST_VIDEO_TRANSFER_GAMMA18:\n> +\tcase GST_VIDEO_TRANSFER_GAMMA20:\n> +\tcase GST_VIDEO_TRANSFER_GAMMA22:\n> +\tcase GST_VIDEO_TRANSFER_GAMMA28:\n> +\t\tGST_WARNING(\"GAMMA 18, 20, 22, 28 transfer functions not supported\");\n> +\t/* fallthrough */\n> +\tcase GST_VIDEO_TRANSFER_GAMMA10:\n> +\t\tcolorspace->transferFunction = ColorSpace::TransferFunction::Linear;\n> +\t\tbreak;\n> +\tcase GST_VIDEO_TRANSFER_SRGB:\n> +\t\tcolorspace->transferFunction = ColorSpace::TransferFunction::Srgb;\n> +\t\tbreak;\n> +\tcase GST_VIDEO_TRANSFER_BT601:\n> +\tcase GST_VIDEO_TRANSFER_BT2020_12:\n> +\tcase GST_VIDEO_TRANSFER_BT2020_10:\n> +\tcase GST_VIDEO_TRANSFER_BT709:\n> +\t\tcolorspace->transferFunction = ColorSpace::TransferFunction::Rec709;\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tGST_WARNING(\"Colorimetry transfer function %d not mapped in gstlibcamera\",\n> +\t\t\t colorimetry.transfer);\n> +\t\treturn std::nullopt;\n> +\t}\n> +\n> +\tswitch (colorimetry.matrix) {\n> +\tcase GST_VIDEO_COLOR_MATRIX_RGB:\n> +\t\tcolorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::None;\n> +\t\tbreak;\n> +\t/* FCC is about the same as BT601 with less digit */\n> +\tcase GST_VIDEO_COLOR_MATRIX_FCC:\n> +\tcase GST_VIDEO_COLOR_MATRIX_BT601:\n> +\t\tcolorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::Rec601;\n> +\t\tbreak;\n> +\tcase GST_VIDEO_COLOR_MATRIX_BT709:\n> +\t\tcolorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::Rec709;\n> +\t\tbreak;\n> +\tcase GST_VIDEO_COLOR_MATRIX_BT2020:\n> +\t\tcolorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::Rec2020;\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tGST_WARNING(\"Colorimetry matrix %d not mapped in gstlibcamera\",\n> +\t\t\t colorimetry.matrix);\n> +\t\treturn std::nullopt;\n> +\t}\n> +\n> +\tswitch (colorimetry.range) {\n> +\tcase GST_VIDEO_COLOR_RANGE_0_255:\n> +\t\tcolorspace->range = ColorSpace::Range::Full;\n> +\t\tbreak;\n> +\tcase GST_VIDEO_COLOR_RANGE_16_235:\n> +\t\tcolorspace->range = ColorSpace::Range::Limited;\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tGST_WARNING(\"Colorimetry range %d not mapped in gstlibcamera\",\n> +\t\t\t colorimetry.range);\n> +\t\treturn std::nullopt;\n> +\t}\n> +\n> +\treturn colorspace;\n> +}\n> +\n> static GstVideoFormat\n> pixel_format_to_gst_format(const PixelFormat &format)\n> {\n> @@ -151,6 +297,18 @@ gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg\n> \t\t\t \"width\", G_TYPE_INT, stream_cfg.size.width,\n> \t\t\t \"height\", G_TYPE_INT, stream_cfg.size.height,\n> \t\t\t nullptr);\n> +\n> +\tif (stream_cfg.colorSpace) {\n> +\t\tGstVideoColorimetry colorimetry = colorimetry_from_colorspace(stream_cfg.colorSpace.value());\n> +\t\tgchar *colorimetry_str = gst_video_colorimetry_to_string(&colorimetry);\n> +\n> +\t\tif (colorimetry_str)\n> +\t\t\tgst_structure_set(s, \"colorimetry\", G_TYPE_STRING, colorimetry_str, nullptr);\n> +\t\telse\n> +\t\t\tg_error(\"Got invalid colorimetry from ColorSpace: %s\",\n> +\t\t\t\tColorSpace::toString(stream_cfg.colorSpace).c_str());\n> +\t}\n> +\n> \tgst_caps_append_structure(caps, s);\n> \n> \treturn caps;\n> @@ -234,6 +392,17 @@ gst_libcamera_configure_stream_from_caps(StreamConfiguration &stream_cfg,\n> \tgst_structure_get_int(s, \"height\", &height);\n> \tstream_cfg.size.width = width;\n> \tstream_cfg.size.height = height;\n> +\n> +\t/* Configure colorimetry */\n> +\tif (gst_structure_has_field(s, \"colorimetry\")) {\n> +\t\tconst gchar *colorimetry_str = gst_structure_get_string(s, \"colorimetry\");\n> +\t\tGstVideoColorimetry colorimetry;\n> +\n> +\t\tif (!gst_video_colorimetry_from_string(&colorimetry, colorimetry_str))\n> +\t\t\tg_critical(\"Invalid colorimetry %s\", colorimetry_str);\n> +\n> +\t\tstream_cfg.colorSpace = colorspace_from_colorimetry(colorimetry);\n> +\t}\n> }\n> \n> #if !GST_CHECK_VERSION(1, 17, 1)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77FA2C3272\n\tfor ;\n\tThu, 1 Sep 2022 10:49:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0C6661FCE;\n\tThu, 1 Sep 2022 12:49:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1427861FB9\n\tfor ;\n\tThu, 1 Sep 2022 12:49:37 +0200 (CEST)","from [IPV6:2401:4900:1f3f:1548:78ac:4a3:edc3:c28a] (unknown\n\t[IPv6:2401:4900:1f3f:1548:78ac:4a3:edc3:c28a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6DF46CD;\n\tThu, 1 Sep 2022 12:49:35 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662029378;\n\tbh=d02ZRKCrtAfouMWQhMl7MvMI2iEW7x3IbaM96f2D8jo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JM12LiZhoLPjjakeoA4JmDfNIqH17oWiAsZ0ECTUlyeR+TDmISX3pIrdtQNzpG4FI\n\tdMGuy6yeH6zuZ3oZ4p0Ldj+xQ96C2fRdlZRuWZ6ho1lNtQs4QBpH8SjvOUYXXAcpja\n\tvom1a3iyE8NImNDTsL8ICl/SoeGfRL/Wet34/LSwzGVL+9kDbf5iQL/w+gufMEJgVf\n\tEXulZLgC0GSq/MSnW4shExNYBTOnQaRQZYpWWcLffTVwRAjASD0lgaOD90bpIKq3+u\n\twnPNtCdUjqCVjDHeCUKIiXkEksgGtzWNHBcdtMOE3CZzBxA1giVj3ue9n1QIIVGNTc\n\tsrQdIzUMcm66A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662029376;\n\tbh=d02ZRKCrtAfouMWQhMl7MvMI2iEW7x3IbaM96f2D8jo=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=qylcSeZmkvH19gCk4euuCx5G71FzdN+Km5FTsg16HPC0Fwad8ZHFHnXHjjAMOb6Az\n\tsosdupcw7Lg9Rk+WryiYzDhHtCFIh8IbaTuoJ/+xkbmF51tXQGVjF1zTtSgeGkiVLI\n\t2/o7mJ411lQx8LyChTCbW2SH7vcLMCKakENEOA9c="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"qylcSeZm\"; dkim-atps=neutral","Message-ID":"<728d4753-642e-a04f-8a5f-9dae04972564@ideasonboard.com>","Date":"Thu, 1 Sep 2022 16:19:30 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.12.0","Content-Language":"en-US","To":"libcamera-devel@lists.libcamera.org","References":"<20220830074725.1059643-1-umang.jain@ideasonboard.com>\n\t<20220830074725.1059643-8-umang.jain@ideasonboard.com>","In-Reply-To":"<20220830074725.1059643-8-umang.jain@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v4 7/7] gstreamer: Provide colorimetry\n\t<> ColorSpace mappings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"rishikeshdonadkar@gmail.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24884,"web_url":"https://patchwork.libcamera.org/comment/24884/","msgid":"","date":"2022-09-01T10:58:21","subject":"Re: [libcamera-devel] [PATCH v4 7/7] gstreamer: Provide colorimetry\n\t<> ColorSpace mappings","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nOn Thu, Sep 01, 2022 at 04:19:30PM +0530, Umang Jain wrote:\n> On 8/30/22 1:17 PM, Umang Jain wrote:\n> > From: Rishikesh Donadkar \n> >\n> > Provide colorimetry <=> libcamera::ColorSpace mappings via:\n> > - GstVideoColorimetry colorimetry_from_colorspace(colorspace);\n> > - ColorSpace colorspace_from_colorimetry(colorimetry);\n> >\n> > Read the colorimetry field from caps into the stream configuration.\n> > After stream validation, the sensor supported colorimetry will\n> > be retrieved and the caps will be updated accordingly.\n> >\n> > Colorimetry support for gstlibcamera currently undertakes only one\n> > argument. Multiple colorimetry support shall be introduced in\n> > subsequent commits.\n> >\n> > Signed-off-by: Rishikesh Donadkar \n> > Signed-off-by: Umang Jain \n> > Reviewed-by: Laurent Pinchart \n> > Reviewed-by: Umang Jain \n> > ---\n> > src/gstreamer/gstlibcamera-utils.cpp | 169 +++++++++++++++++++++++++++\n> > 1 file changed, 169 insertions(+)\n> >\n> > diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> > index 5a21a391..c7b44a8e 100644\n> > --- a/src/gstreamer/gstlibcamera-utils.cpp\n> > +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> > @@ -57,6 +57,152 @@ static struct {\n> > \t/* \\todo NV42 is used in libcamera but is not mapped in GStreamer yet. */\n> > };\n> > \n> > +static GstVideoColorimetry\n> > +colorimetry_from_colorspace(const ColorSpace &colorSpace)\n> > +{\n> > +\tGstVideoColorimetry colorimetry;\n> > +\n> > +\tswitch (colorSpace.primaries) {\n> > +\tcase ColorSpace::Primaries::Raw:\n> > +\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_UNKNOWN;\n> > +\t\tbreak;\n> > +\tcase ColorSpace::Primaries::Smpte170m:\n> > +\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_SMPTE170M;\n> > +\t\tbreak;\n> > +\tcase ColorSpace::Primaries::Rec709:\n> > +\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_BT709;\n> > +\t\tbreak;\n> > +\tcase ColorSpace::Primaries::Rec2020:\n> > +\t\tcolorimetry.primaries = GST_VIDEO_COLOR_PRIMARIES_BT2020;\n> > +\t\tbreak;\n> > +\t}\n> > +\n> > +\tswitch (colorSpace.transferFunction) {\n> > +\tcase ColorSpace::TransferFunction::Linear:\n> > +\t\tcolorimetry.transfer = GST_VIDEO_TRANSFER_GAMMA10;\n> > +\t\tbreak;\n> > +\tcase ColorSpace::TransferFunction::Srgb:\n> > +\t\tcolorimetry.transfer = GST_VIDEO_TRANSFER_SRGB;\n> > +\t\tbreak;\n> > +\tcase ColorSpace::TransferFunction::Rec709:\n> > +\t\tcolorimetry.transfer = GST_VIDEO_TRANSFER_BT709;\n> > +\t\tbreak;\n> > +\t}\n> > +\n> > +\tswitch (colorSpace.ycbcrEncoding) {\n> > +\tcase ColorSpace::YcbcrEncoding::None:\n> > +\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_RGB;\n> > +\t\tbreak;\n> > +\tcase ColorSpace::YcbcrEncoding::Rec601:\n> > +\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT601;\n> > +\t\tbreak;\n> > +\tcase ColorSpace::YcbcrEncoding::Rec709:\n> > +\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT709;\n> > +\t\tbreak;\n> > +\tcase ColorSpace::YcbcrEncoding::Rec2020:\n> > +\t\tcolorimetry.matrix = GST_VIDEO_COLOR_MATRIX_BT2020;\n> > +\t\tbreak;\n> > +\t}\n> > +\n> > +\tswitch (colorSpace.range) {\n> > +\tcase ColorSpace::Range::Full:\n> > +\t\tcolorimetry.range = GST_VIDEO_COLOR_RANGE_0_255;\n> > +\t\tbreak;\n> > +\tcase ColorSpace::Range::Limited:\n> > +\t\tcolorimetry.range = GST_VIDEO_COLOR_RANGE_16_235;\n> > +\t\tbreak;\n> > +\t}\n> > +\n> > +\treturn colorimetry;\n> > +}\n> > +\n> > +static std::optional\n> > +colorspace_from_colorimetry(const GstVideoColorimetry &colorimetry)\n> > +{\n> > +\tstd::optional colorspace;\n> \n> I started a rigourous testing on RPi today comparing cam's colorspace \n> and gstreamer's colorspace mapping/adjustment/logs stuff and happen to \n> catch this last-min bug here.\n> \n> The optional colorspace value needs to be assigned (or initialised with \n> a value here). Otherwise the return value from this function is always \n> std::nullopt (since we never assign a value hence the optional ptr is \n> acting as non-containing value)...\n\nOops indeed.\n\n> For now, I have:\n> \n>     -       std::optional colorspace;\n>     +       std::optional colorspace = ColorSpace::Raw;\n> \n> Any objections for this Laurent, Rishi ?\n\nWorks for me.\n\n> > +\n> > +\tswitch (colorimetry.primaries) {\n> > +\tcase GST_VIDEO_COLOR_PRIMARIES_UNKNOWN:\n> > +\t\t/* Unknown primaries map to raw colorspace in gstreamer */\n> > +\t\treturn ColorSpace::Raw;\n> > +\tcase GST_VIDEO_COLOR_PRIMARIES_SMPTE170M:\n> > +\t\tcolorspace->primaries = ColorSpace::Primaries::Smpte170m;\n> > +\t\tbreak;\n> > +\tcase GST_VIDEO_COLOR_PRIMARIES_BT709:\n> > +\t\tcolorspace->primaries = ColorSpace::Primaries::Rec709;\n> > +\t\tbreak;\n> > +\tcase GST_VIDEO_COLOR_PRIMARIES_BT2020:\n> > +\t\tcolorspace->primaries = ColorSpace::Primaries::Rec2020;\n> > +\t\tbreak;\n> > +\tdefault:\n> > +\t\tGST_WARNING(\"Colorimetry primaries %d not mapped in gstlibcamera\",\n> > +\t\t\t colorimetry.primaries);\n> > +\t\treturn std::nullopt;\n> > +\t}\n> > +\n> > +\tswitch (colorimetry.transfer) {\n> > +\t/* Transfer function mappings inspired from v4l2src plugin */\n> > +\tcase GST_VIDEO_TRANSFER_GAMMA18:\n> > +\tcase GST_VIDEO_TRANSFER_GAMMA20:\n> > +\tcase GST_VIDEO_TRANSFER_GAMMA22:\n> > +\tcase GST_VIDEO_TRANSFER_GAMMA28:\n> > +\t\tGST_WARNING(\"GAMMA 18, 20, 22, 28 transfer functions not supported\");\n> > +\t/* fallthrough */\n> > +\tcase GST_VIDEO_TRANSFER_GAMMA10:\n> > +\t\tcolorspace->transferFunction = ColorSpace::TransferFunction::Linear;\n> > +\t\tbreak;\n> > +\tcase GST_VIDEO_TRANSFER_SRGB:\n> > +\t\tcolorspace->transferFunction = ColorSpace::TransferFunction::Srgb;\n> > +\t\tbreak;\n> > +\tcase GST_VIDEO_TRANSFER_BT601:\n> > +\tcase GST_VIDEO_TRANSFER_BT2020_12:\n> > +\tcase GST_VIDEO_TRANSFER_BT2020_10:\n> > +\tcase GST_VIDEO_TRANSFER_BT709:\n> > +\t\tcolorspace->transferFunction = ColorSpace::TransferFunction::Rec709;\n> > +\t\tbreak;\n> > +\tdefault:\n> > +\t\tGST_WARNING(\"Colorimetry transfer function %d not mapped in gstlibcamera\",\n> > +\t\t\t colorimetry.transfer);\n> > +\t\treturn std::nullopt;\n> > +\t}\n> > +\n> > +\tswitch (colorimetry.matrix) {\n> > +\tcase GST_VIDEO_COLOR_MATRIX_RGB:\n> > +\t\tcolorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::None;\n> > +\t\tbreak;\n> > +\t/* FCC is about the same as BT601 with less digit */\n> > +\tcase GST_VIDEO_COLOR_MATRIX_FCC:\n> > +\tcase GST_VIDEO_COLOR_MATRIX_BT601:\n> > +\t\tcolorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::Rec601;\n> > +\t\tbreak;\n> > +\tcase GST_VIDEO_COLOR_MATRIX_BT709:\n> > +\t\tcolorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::Rec709;\n> > +\t\tbreak;\n> > +\tcase GST_VIDEO_COLOR_MATRIX_BT2020:\n> > +\t\tcolorspace->ycbcrEncoding = ColorSpace::YcbcrEncoding::Rec2020;\n> > +\t\tbreak;\n> > +\tdefault:\n> > +\t\tGST_WARNING(\"Colorimetry matrix %d not mapped in gstlibcamera\",\n> > +\t\t\t colorimetry.matrix);\n> > +\t\treturn std::nullopt;\n> > +\t}\n> > +\n> > +\tswitch (colorimetry.range) {\n> > +\tcase GST_VIDEO_COLOR_RANGE_0_255:\n> > +\t\tcolorspace->range = ColorSpace::Range::Full;\n> > +\t\tbreak;\n> > +\tcase GST_VIDEO_COLOR_RANGE_16_235:\n> > +\t\tcolorspace->range = ColorSpace::Range::Limited;\n> > +\t\tbreak;\n> > +\tdefault:\n> > +\t\tGST_WARNING(\"Colorimetry range %d not mapped in gstlibcamera\",\n> > +\t\t\t colorimetry.range);\n> > +\t\treturn std::nullopt;\n> > +\t}\n> > +\n> > +\treturn colorspace;\n> > +}\n> > +\n> > static GstVideoFormat\n> > pixel_format_to_gst_format(const PixelFormat &format)\n> > {\n> > @@ -151,6 +297,18 @@ gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg\n> > \t\t\t \"width\", G_TYPE_INT, stream_cfg.size.width,\n> > \t\t\t \"height\", G_TYPE_INT, stream_cfg.size.height,\n> > \t\t\t nullptr);\n> > +\n> > +\tif (stream_cfg.colorSpace) {\n> > +\t\tGstVideoColorimetry colorimetry = colorimetry_from_colorspace(stream_cfg.colorSpace.value());\n> > +\t\tgchar *colorimetry_str = gst_video_colorimetry_to_string(&colorimetry);\n> > +\n> > +\t\tif (colorimetry_str)\n> > +\t\t\tgst_structure_set(s, \"colorimetry\", G_TYPE_STRING, colorimetry_str, nullptr);\n> > +\t\telse\n> > +\t\t\tg_error(\"Got invalid colorimetry from ColorSpace: %s\",\n> > +\t\t\t\tColorSpace::toString(stream_cfg.colorSpace).c_str());\n> > +\t}\n> > +\n> > \tgst_caps_append_structure(caps, s);\n> > \n> > \treturn caps;\n> > @@ -234,6 +392,17 @@ gst_libcamera_configure_stream_from_caps(StreamConfiguration &stream_cfg,\n> > \tgst_structure_get_int(s, \"height\", &height);\n> > \tstream_cfg.size.width = width;\n> > \tstream_cfg.size.height = height;\n> > +\n> > +\t/* Configure colorimetry */\n> > +\tif (gst_structure_has_field(s, \"colorimetry\")) {\n> > +\t\tconst gchar *colorimetry_str = gst_structure_get_string(s, \"colorimetry\");\n> > +\t\tGstVideoColorimetry colorimetry;\n> > +\n> > +\t\tif (!gst_video_colorimetry_from_string(&colorimetry, colorimetry_str))\n> > +\t\t\tg_critical(\"Invalid colorimetry %s\", colorimetry_str);\n> > +\n> > +\t\tstream_cfg.colorSpace = colorspace_from_colorimetry(colorimetry);\n> > +\t}\n> > }\n> > \n> > #if !GST_CHECK_VERSION(1, 17, 1)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96CB1C0DA4\n\tfor ;\n\tThu, 1 Sep 2022 10:58:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08F7E61FD1;\n\tThu, 1 Sep 2022 12:58:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8964561FB9\n\tfor ;\n\tThu, 1 Sep 2022 12:58:33 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BA76A6CD;\n\tThu, 1 Sep 2022 12:58:32 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662029915;\n\tbh=HCirHZ+7bBRArSwQbVM50/xE2xrUVWcwMOC9SnBHA2o=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=H/ulkpxbQlH9ZoFA/33SO+wY8PzEQQJF+U+4konlyejxObZnMBgVkbW+jT1kV/C19\n\tBaB+dXjNudq4LA4iDFpf2xAP1Xd4dzF2Oad5h/a+EQ/d+cEOeIDRvk6fGZ9uyzFSq6\n\t/FGJAH24ZiiJYZdTTh6rO3akX/dBu2T23CZYcO79RGQPAcou7hx7ZVoPJUqwKOHPR9\n\tqRxQ6CUeeeN+yxogtT+TVgMeBQt3Ek6Zl3U3RLPpvcG2a7H8CtLZCVubAs+LDh5+YW\n\t5G1ROt2wPm/2J2o5DWuO4nlJJ2lGNGeTJMTTsN5Hb6YjfpVmz1CHJVkdgYZEMWyp0y\n\tSmhZjoEQdDFVA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662029913;\n\tbh=HCirHZ+7bBRArSwQbVM50/xE2xrUVWcwMOC9SnBHA2o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bxqswSjG81HPMALl4XOOvtOY96QZ5cnIGF1wc3yNytmfkdTqZxjvkZAYhKlDBYYd7\n\tDZalmc62jmLcBn9icTJykDzCw3XAn8MviGM7rT9FavMzAAaK+hNOmhZdMgZ4lfyJYx\n\twPPZH7+IBK3nxUCKjpiA10f/g3fTJL4tHq1N4Epk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bxqswSjG\"; dkim-atps=neutral","Date":"Thu, 1 Sep 2022 13:58:21 +0300","To":"Umang Jain ","Message-ID":"","References":"<20220830074725.1059643-1-umang.jain@ideasonboard.com>\n\t<20220830074725.1059643-8-umang.jain@ideasonboard.com>\n\t<728d4753-642e-a04f-8a5f-9dae04972564@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<728d4753-642e-a04f-8a5f-9dae04972564@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 7/7] gstreamer: Provide colorimetry\n\t<> ColorSpace mappings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"rishikeshdonadkar@gmail.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]