[{"id":2316,"web_url":"https://patchwork.libcamera.org/comment/2316/","msgid":"<20190805115355.GQ29747@pendragon.ideasonboard.com>","date":"2019-08-05T11:53:55","subject":"Re: [libcamera-devel] [PATCH 5/5] android: hal: Add Camera3 HAL","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Aug 01, 2019 at 05:54:20PM +0200, Jacopo Mondi wrote:\n> Add Libcamera Android Camerav3 HAL implementation.\n\ns/Libcamera/libcamera/\ns/Camerav3/Camera HAL v3/\n\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera3_hal.cpp | 130 +++++\n> src/android/camera_hal_manager.cpp | 173 +++++++\n> src/android/camera_hal_manager.h | 56 ++\n> src/android/camera_module.cpp | 795 +++++++++++++++++++++++++++++\n> src/android/camera_module.h | 69 +++\n> src/android/camera_proxy.cpp | 181 +++++++\n> src/android/camera_proxy.h | 41 ++\n> src/android/meson.build | 8 +\n> src/android/tags | 424 +++++++++++++++\n\nCould you send a v2 without this file ? :-)\n\n> src/android/thread_rpc.cpp | 41 ++\n> src/android/thread_rpc.h | 56 ++\n> src/libcamera/meson.build | 22 +-\n> src/meson.build | 4 +\n> 13 files changed, 1995 insertions(+), 5 deletions(-)\n> create mode 100644 src/android/camera3_hal.cpp\n> create mode 100644 src/android/camera_hal_manager.cpp\n> create mode 100644 src/android/camera_hal_manager.h\n> create mode 100644 src/android/camera_module.cpp\n> create mode 100644 src/android/camera_module.h\n> create mode 100644 src/android/camera_proxy.cpp\n> create mode 100644 src/android/camera_proxy.h\n> create mode 100644 src/android/tags\n> create mode 100644 src/android/thread_rpc.cpp\n> create mode 100644 src/android/thread_rpc.h\n\n[snip]\n\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index a09b23d60022..9b6e4b769760 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -103,11 +103,23 @@ libcamera_deps = [\n> dependency('threads'),\n> ]\n> \n> -libcamera = shared_library('camera',\n> - libcamera_sources,\n> - install : true,\n> - include_directories : includes,\n> - dependencies : libcamera_deps)\n> +if get_option('android')\n> + libcamera_sources += android_hal_sources\n> + includes += android_includes\n> +\n> + libcamera = shared_library('camera',\n> + libcamera_sources,\n> + install : true,\n> + link_with : android_camera_metadata,\n> + include_directories : includes,\n> + dependencies : libcamera_deps)\n> +else\n> + libcamera = shared_library('camera',\n> + libcamera_sources,\n> + install : true,\n> + include_directories : includes,\n> + dependencies : libcamera_deps)\n> +endif\n\nWould it be possible to keep a single shared_library statement, with a\nvariable for link_with that is declared initially empty, and is updated\nwhen the android option is set ?\n\n> \n> libcamera_dep = declare_dependency(sources : [libcamera_api, libcamera_h],\n> include_directories : libcamera_includes,\n> diff --git a/src/meson.build b/src/meson.build\n> index 628e7a7f23f2..67ad20aab86b 100644\n> --- a/src/meson.build\n> +++ b/src/meson.build\n> @@ -1,3 +1,7 @@\n> +if get_option('android')\n> + subdir('android')\n> +endif\n> +\n> subdir('libcamera')\n> subdir('ipa')\n> subdir('cam')","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5ADC60E33\n\tfor ;\n\tMon, 5 Aug 2019 13:53:57 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A3F32F9;\n\tMon, 5 Aug 2019 13:53:57 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565006037;\n\tbh=7Ed1CdHeG05+hnKgccX+txSYL7Vx4ZlSXKCL8djQnag=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PENEBiR16NBUVQwvRhhYq1w9SdrGbjN+Mvk0sajNDAsmxH9y+ijneU9cZbcq6PaF7\n\ty8aL0zJGZhYxqlPc4SjsPPQz7cYC50YRF0pXvtB3W64xVzSVg/GXoQUIPX5qNTIqcv\n\t4Mzg9ALAuePPTT53/8dZc3r/3J6CLZ/xCtYF6Wg4=","Date":"Mon, 5 Aug 2019 14:53:55 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190805115355.GQ29747@pendragon.ideasonboard.com>","References":"<20190801155420.24694-1-jacopo@jmondi.org>\n\t<20190801155420.24694-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190801155420.24694-6-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 5/5] android: hal: Add Camera3 HAL","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 05 Aug 2019 11:53:57 -0000"}},{"id":2321,"web_url":"https://patchwork.libcamera.org/comment/2321/","msgid":"<20190806093424.4nzjmajd5s6amsmm@uno.localdomain>","date":"2019-08-06T09:34:24","subject":"Re: [libcamera-devel] [PATCH 5/5] android: hal: Add Camera3 HAL","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Aug 05, 2019 at 02:53:55PM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Thu, Aug 01, 2019 at 05:54:20PM +0200, Jacopo Mondi wrote:\n> > Add Libcamera Android Camerav3 HAL implementation.\n>\n> s/Libcamera/libcamera/\n> s/Camerav3/Camera HAL v3/\n>\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/android/camera3_hal.cpp | 130 +++++\n> > src/android/camera_hal_manager.cpp | 173 +++++++\n> > src/android/camera_hal_manager.h | 56 ++\n> > src/android/camera_module.cpp | 795 +++++++++++++++++++++++++++++\n> > src/android/camera_module.h | 69 +++\n> > src/android/camera_proxy.cpp | 181 +++++++\n> > src/android/camera_proxy.h | 41 ++\n> > src/android/meson.build | 8 +\n> > src/android/tags | 424 +++++++++++++++\n>\n> Could you send a v2 without this file ? :-)\n>\n\nJust wanted to save you all some CPU time to generate tags. I'm sorry\nyou don't appreciate that :)\n\nsorry about this, I added them by mistake, I'll drop..\n\n> > src/android/thread_rpc.cpp | 41 ++\n> > src/android/thread_rpc.h | 56 ++\n> > src/libcamera/meson.build | 22 +-\n> > src/meson.build | 4 +\n> > 13 files changed, 1995 insertions(+), 5 deletions(-)\n> > create mode 100644 src/android/camera3_hal.cpp\n> > create mode 100644 src/android/camera_hal_manager.cpp\n> > create mode 100644 src/android/camera_hal_manager.h\n> > create mode 100644 src/android/camera_module.cpp\n> > create mode 100644 src/android/camera_module.h\n> > create mode 100644 src/android/camera_proxy.cpp\n> > create mode 100644 src/android/camera_proxy.h\n> > create mode 100644 src/android/tags\n> > create mode 100644 src/android/thread_rpc.cpp\n> > create mode 100644 src/android/thread_rpc.h\n>\n> [snip]\n>\n> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > index a09b23d60022..9b6e4b769760 100644\n> > --- a/src/libcamera/meson.build\n> > +++ b/src/libcamera/meson.build\n> > @@ -103,11 +103,23 @@ libcamera_deps = [\n> > dependency('threads'),\n> > ]\n> >\n> > -libcamera = shared_library('camera',\n> > - libcamera_sources,\n> > - install : true,\n> > - include_directories : includes,\n> > - dependencies : libcamera_deps)\n> > +if get_option('android')\n> > + libcamera_sources += android_hal_sources\n> > + includes += android_includes\n> > +\n> > + libcamera = shared_library('camera',\n> > + libcamera_sources,\n> > + install : true,\n> > + link_with : android_camera_metadata,\n> > + include_directories : includes,\n> > + dependencies : libcamera_deps)\n> > +else\n> > + libcamera = shared_library('camera',\n> > + libcamera_sources,\n> > + install : true,\n> > + include_directories : includes,\n> > + dependencies : libcamera_deps)\n> > +endif\n>\n> Would it be possible to keep a single shared_library statement, with a\n> variable for link_with that is declared initially empty, and is updated\n> when the android option is set ?\n\nI'll look into improving this!\n\nThanks\n j\n>\n> >\n> > libcamera_dep = declare_dependency(sources : [libcamera_api, libcamera_h],\n> > include_directories : libcamera_includes,\n> > diff --git a/src/meson.build b/src/meson.build\n> > index 628e7a7f23f2..67ad20aab86b 100644\n> > --- a/src/meson.build\n> > +++ b/src/meson.build\n> > @@ -1,3 +1,7 @@\n> > +if get_option('android')\n> > + subdir('android')\n> > +endif\n> > +\n> > subdir('libcamera')\n> > subdir('ipa')\n> > subdir('cam')\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DB6C60E31\n\tfor ;\n\tTue, 6 Aug 2019 11:33:01 +0200 (CEST)","from uno.localdomain\n\t(host150-24-dynamic.51-79-r.retail.telecomitalia.it [79.51.24.150])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id C8D7B240012;\n\tTue, 6 Aug 2019 09:33:00 +0000 (UTC)"],"X-Originating-IP":"79.51.24.150","Date":"Tue, 6 Aug 2019 11:34:24 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190806093424.4nzjmajd5s6amsmm@uno.localdomain>","References":"<20190801155420.24694-1-jacopo@jmondi.org>\n\t<20190801155420.24694-6-jacopo@jmondi.org>\n\t<20190805115355.GQ29747@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"ozdrs7vewogkofwi\"","Content-Disposition":"inline","In-Reply-To":"<20190805115355.GQ29747@pendragon.ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 5/5] android: hal: Add Camera3 HAL","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 06 Aug 2019 09:33:09 -0000"}}]