[{"id":24825,"web_url":"https://patchwork.libcamera.org/comment/24825/","msgid":"","date":"2022-08-30T01:10:24","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Fix \\sa tags\n\tfor MediaDevice::link","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Marvin,\n\nThank you for the patch.\n\nOn Mon, Aug 29, 2022 at 03:59:50PM +0200, Marvin Schmidt via libcamera-devel wrote:\n> doxygen didn't create proper links to the overloads of\n> MediaDevice::link because the signatures didn't match due to an\n> additional 'const'\n> \n> While at it remove the unnecessary `MediaDevice::` and wrap the lines\n> \n> Fixes: b65feafe (\"libcamera: media_device: Add functions to get a MediaLink\")\n\nThe standard format for fixes tags is a 12 digits commit ID. I'll fix\nthis when applying.\n\n> Signed-off-by: Marvin Schmidt \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/media_device.cpp | 16 ++++++++++------\n> 1 file changed, 10 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index 7c94da9e..52c8e66e 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -352,8 +352,9 @@ MediaEntity *MediaDevice::getEntityByName(const std::string &name) const\n> * entity with name \\a sourceName, to the pad at index \\a sinkIdx of the\n> * sink entity with name \\a sinkName, if any.\n> *\n> - * \\sa MediaDevice::link(const MediaEntity *source, unsigned int sourceIdx, const MediaEntity *sink, unsigned int sinkIdx) const\n> - * \\sa MediaDevice::link(const MediaPad *source, const MediaPad *sink) const\n> + * \\sa link(const MediaEntity *source, unsigned int sourceIdx,\n> + * const MediaEntity *sink, unsigned int sinkIdx)\n> + * \\sa link(const MediaPad *source, const MediaPad *sink)\n> *\n> * \\return The link that connects the two pads, or nullptr if no such a link\n> * exists\n> @@ -381,8 +382,9 @@ MediaLink *MediaDevice::link(const std::string &sourceName, unsigned int sourceI\n> * entity \\a source, to the pad at index \\a sinkIdx of the sink entity \\a\n> * sink, if any.\n> *\n> - * \\sa MediaDevice::link(const std::string &sourceName, unsigned int sourceIdx, const std::string &sinkName, unsigned int sinkIdx) const\n> - * \\sa MediaDevice::link(const MediaPad *source, const MediaPad *sink) const\n> + * \\sa link(const std::string &sourceName, unsigned int sourceIdx,\n> + * const std::string &sinkName, unsigned int sinkIdx)\n> + * \\sa link(const MediaPad *source, const MediaPad *sink)\n> *\n> * \\return The link that connects the two pads, or nullptr if no such a link\n> * exists\n> @@ -404,8 +406,10 @@ MediaLink *MediaDevice::link(const MediaEntity *source, unsigned int sourceIdx,\n> * \\param[in] source The source pad\n> * \\param[in] sink The sink pad\n> *\n> - * \\sa MediaDevice::link(const std::string &sourceName, unsigned int sourceIdx, const std::string &sinkName, unsigned int sinkIdx) const\n> - * \\sa MediaDevice::link(const MediaEntity *source, unsigned int sourceIdx, const MediaEntity *sink, unsigned int sinkIdx) const\n> + * \\sa link(const std::string &sourceName, unsigned int sourceIdx,\n> + * const std::string &sinkName, unsigned int sinkIdx)\n> + * \\sa link(const MediaEntity *source, unsigned int sourceIdx,\n> + * const MediaEntity *sink, unsigned int sinkIdx)\n> *\n> * \\return The link that connects the two pads, or nullptr if no such a link\n> * exists","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7353EC3272\n\tfor ;\n\tTue, 30 Aug 2022 01:10:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A37AF61FC0;\n\tTue, 30 Aug 2022 03:10:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F9B061F9C\n\tfor ;\n\tTue, 30 Aug 2022 03:10:34 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C7043481;\n\tTue, 30 Aug 2022 03:10:33 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661821835;\n\tbh=/2QBy2lYdCt8iKK1WkKG6i+6x4ZySKN2YvWRpf/T3UE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Ed4uQdOltvjdpSRnkywNGKGJP9eGTGZZWsAzpWvSvtwljrRO/bL6gTYgsv6uuqm1j\n\twkZnHEAbb3awPRotumJwTu2qWvkP06Vv1e0bWsbC/iRLj0JmpEXFhBTacdYSnPUokI\n\tim0asuDb+cGCOu15iCc0ZpK+snVgt4oZAMQsiyvbFIsjYjR81qf5Tdg+fcHbOkemMB\n\trKdpDe/+zjLewxzXpCGiFGbX9cTwXROk7/JjWnnvFKsktj1zo8f2Watdd5Tn0SG5NP\n\tZyyj4nOPO1TC1F7kK4FPgXPyxny1MC6sGNQewThMr6bdl/vshw09JZSgCX1+F2jzzz\n\tgckEQszHzgM7w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661821834;\n\tbh=/2QBy2lYdCt8iKK1WkKG6i+6x4ZySKN2YvWRpf/T3UE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GE+zzGb2E7X5p8on3RlnZO3JmMMBxQAhJ3zuuEOSrZWyUKTUKmsd+tkz9vtw+Ym69\n\tTXU3d4SUSVPNEWdJ8I+ZxhjQdaNQ2iwmZsSF7kBp0VP6uO6cKpKZfUjjaBeef4igMM\n\tc4pxKwwYRnzDLyD+BcNvD3t2zYBC6ULTCFloofSA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GE+zzGb2\"; dkim-atps=neutral","Date":"Tue, 30 Aug 2022 04:10:24 +0300","To":"Marvin Schmidt ","Message-ID":"","References":"<20220829135950.1271098-1-marvin.schmidt1987@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220829135950.1271098-1-marvin.schmidt1987@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Fix \\sa tags\n\tfor MediaDevice::link","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24835,"web_url":"https://patchwork.libcamera.org/comment/24835/","msgid":"<736d73ef-662e-5721-1a05-16fb334bc0d2@ideasonboard.com>","date":"2022-08-30T10:37:27","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Fix \\sa tags\n\tfor MediaDevice::link","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello,\n\nOn 8/30/22 6:40 AM, Laurent Pinchart via libcamera-devel wrote:\n> Hi Marvin,\n>\n> Thank you for the patch.\n>\n> On Mon, Aug 29, 2022 at 03:59:50PM +0200, Marvin Schmidt via libcamera-devel wrote:\n>> doxygen didn't create proper links to the overloads of\n>> MediaDevice::link because the signatures didn't match due to an\n>> additional 'const'\n>>\n>> While at it remove the unnecessary `MediaDevice::` and wrap the lines\n>>\n>> Fixes: b65feafe (\"libcamera: media_device: Add functions to get a MediaLink\")\n> The standard format for fixes tags is a 12 digits commit ID. I'll fix\n> this when applying.\n>\n>> Signed-off-by: Marvin Schmidt \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n>\n>> ---\n>> src/libcamera/media_device.cpp | 16 ++++++++++------\n>> 1 file changed, 10 insertions(+), 6 deletions(-)\n>>\n>> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n>> index 7c94da9e..52c8e66e 100644\n>> --- a/src/libcamera/media_device.cpp\n>> +++ b/src/libcamera/media_device.cpp\n>> @@ -352,8 +352,9 @@ MediaEntity *MediaDevice::getEntityByName(const std::string &name) const\n>> * entity with name \\a sourceName, to the pad at index \\a sinkIdx of the\n>> * sink entity with name \\a sinkName, if any.\n>> *\n>> - * \\sa MediaDevice::link(const MediaEntity *source, unsigned int sourceIdx, const MediaEntity *sink, unsigned int sinkIdx) const\n>> - * \\sa MediaDevice::link(const MediaPad *source, const MediaPad *sink) const\n>> + * \\sa link(const MediaEntity *source, unsigned int sourceIdx,\n>> + * const MediaEntity *sink, unsigned int sinkIdx)\n>> + * \\sa link(const MediaPad *source, const MediaPad *sink)\n>> *\n>> * \\return The link that connects the two pads, or nullptr if no such a link\n>> * exists\n>> @@ -381,8 +382,9 @@ MediaLink *MediaDevice::link(const std::string &sourceName, unsigned int sourceI\n>> * entity \\a source, to the pad at index \\a sinkIdx of the sink entity \\a\n>> * sink, if any.\n>> *\n>> - * \\sa MediaDevice::link(const std::string &sourceName, unsigned int sourceIdx, const std::string &sinkName, unsigned int sinkIdx) const\n>> - * \\sa MediaDevice::link(const MediaPad *source, const MediaPad *sink) const\n>> + * \\sa link(const std::string &sourceName, unsigned int sourceIdx,\n>> + * const std::string &sinkName, unsigned int sinkIdx)\n>> + * \\sa link(const MediaPad *source, const MediaPad *sink)\n>> *\n>> * \\return The link that connects the two pads, or nullptr if no such a link\n>> * exists\n>> @@ -404,8 +406,10 @@ MediaLink *MediaDevice::link(const MediaEntity *source, unsigned int sourceIdx,\n>> * \\param[in] source The source pad\n>> * \\param[in] sink The sink pad\n>> *\n>> - * \\sa MediaDevice::link(const std::string &sourceName, unsigned int sourceIdx, const std::string &sinkName, unsigned int sinkIdx) const\n>> - * \\sa MediaDevice::link(const MediaEntity *source, unsigned int sourceIdx, const MediaEntity *sink, unsigned int sinkIdx) const\n>> + * \\sa link(const std::string &sourceName, unsigned int sourceIdx,\n>> + * const std::string &sinkName, unsigned int sinkIdx)\n>> + * \\sa link(const MediaEntity *source, unsigned int sourceIdx,\n>> + * const MediaEntity *sink, unsigned int sinkIdx)\n>> *\n>> * \\return The link that connects the two pads, or nullptr if no such a link\n>> * exists","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04620C3272\n\tfor ;\n\tTue, 30 Aug 2022 10:37:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD28561FBD;\n\tTue, 30 Aug 2022 12:37:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E947261F9C\n\tfor ;\n\tTue, 30 Aug 2022 12:37:33 +0200 (CEST)","from [IPV6:2401:4900:1f3f:1548:78ac:4a3:edc3:c28a] (unknown\n\t[IPv6:2401:4900:1f3f:1548:78ac:4a3:edc3:c28a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C563481;\n\tTue, 30 Aug 2022 12:37:31 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661855854;\n\tbh=sYuQvjhrxFSCVCcR1PVDfrp4d2aipUg6btoSCEokyso=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=o9DIixPqgJX2fVPUOJHyDnI8w0/DydLGiOZDRfR+nBF2/dXwewapvDUTgNssWNipX\n\tlU3gLyR2idNlZLAVX38EOF6kdpNfWkyOhrj1ZdvX/9ob7eZlbBX+wbrXcCk+gWFB5V\n\t5XwFmkwNOQjzw5yLuLNro83tz6hcetIS5ajZ5LSTN3gR4YJkIa+jgBi5O6mQh9n5O5\n\tDFyFjXNSXV2tCk6yWPPbL+xPIoWPrPWbXt9dq3eIPf1alSmSM/uiIyiIs7oifOAXKC\n\tlgJZ8by069HhI8PSLnDUgF+FbdgqTJogDHIU72BMqXMC9+dpoZbH/N/FBVxijDwSzA\n\tparQuEX/S22QQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661855853;\n\tbh=sYuQvjhrxFSCVCcR1PVDfrp4d2aipUg6btoSCEokyso=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=RA3PjmG71cYOjAs3ImpwMwx0aY2IlS+6jmFrUf+4srZ1fKynYB7i+/LXgt7lP3Rpw\n\txNlJK1MQtGFv5UnkRtrMzzdDY3ISA8LOPs9GBIekmOwPgpVebdg8k0HB/7WaxL4PJa\n\tUZKxgv8e07iDmPAegqF0ahFcrzx8JzXnyV/IjpUE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"RA3PjmG7\"; dkim-atps=neutral","Message-ID":"<736d73ef-662e-5721-1a05-16fb334bc0d2@ideasonboard.com>","Date":"Tue, 30 Aug 2022 16:07:27 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.12.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tMarvin Schmidt ","References":"<20220829135950.1271098-1-marvin.schmidt1987@gmail.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_device: Fix \\sa tags\n\tfor MediaDevice::link","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]