[{"id":24837,"web_url":"https://patchwork.libcamera.org/comment/24837/","msgid":"<8f29c32f-c1fa-2b83-4810-7cd54a132f20@ideasonboard.com>","date":"2022-08-30T10:51:32","subject":"Re: [libcamera-devel] [PATCH 1/3] pipeline: uvcvideo: Add color\n\tspace support","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank  you for the patch\n\nOn 8/29/22 3:34 PM, Laurent Pinchart via libcamera-devel wrote:\n> Add support for color space to the uvcvideo pipeline handler. UVC\n> devices have a fixed color space per format, so only the validate()\n\nAh good to know..\n> function needs to be extended to retrieve the color space from the\n> kernel. There is no need to pass the value back to the driver in\n> configure().\n\nMakes sense!\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 9cbf126aea57..2ae640a31f68 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -159,6 +159,11 @@ CameraConfiguration::Status UVCCameraConfiguration::validate()\n> \tcfg.stride = format.planes[0].bpl;\n> \tcfg.frameSize = format.planes[0].size;\n> \n> +\tif (cfg.colorSpace != format.colorSpace) {\n> +\t\tcfg.colorSpace = format.colorSpace;\n> +\t\tstatus = Adjusted;\n> +\t}\n> +\n> \treturn status;\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB122C3272\n\tfor ;\n\tTue, 30 Aug 2022 10:51:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F26D961FBD;\n\tTue, 30 Aug 2022 12:51:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A916961F9C\n\tfor ;\n\tTue, 30 Aug 2022 12:51:39 +0200 (CEST)","from [IPV6:2401:4900:1f3f:1548:78ac:4a3:edc3:c28a] (unknown\n\t[IPv6:2401:4900:1f3f:1548:78ac:4a3:edc3:c28a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6097481;\n\tTue, 30 Aug 2022 12:51:37 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661856701;\n\tbh=AmkUHIKuBXg0ROLgcEq6NPwwW5uX0BeO8yb8vJtGpEg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Y/iC5SNNkfSC1tN3vOyLI3cew7ivuFe1txu/S7DR9JF0PJajoo3fWB1GZNp1d6eRl\n\tT07YrmXYVprOtO5owKxO/s2M5yPJTQdbxsdKaYocdAkBMAH3SHjlGzRZxrzh5zxejm\n\t3SlnWD+4jzDJYjHx9paVINFTAU82g/5uLm8o43XgnFs8n2fo3YUT7/ZwB/IeXNdZs1\n\to5oNHqVlLUcflkwcViDWqbx1l2fzBk8V6RuI+PXWMZuvBRs4qIBzhts5dr1Xl6PFii\n\tKsDJEmu1EsgUtd/vQJJYWWtNrNvsWGGONCrSZXXPHxchXK1Al1uPJMkZHrIH19r/mK\n\tfDcxDeMIgPKNA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661856699;\n\tbh=AmkUHIKuBXg0ROLgcEq6NPwwW5uX0BeO8yb8vJtGpEg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=kqg4mZcaCpFbXzbAerxcgTJhJPhMNkgoir5/uxWrmIsgYSL+Vt/miil6vMz4cDg9O\n\tTFNHlvbZcrQV+YPAdid8htbarwLu4uM9uOXTC8gZkRdRjfsETc66nYA0zhg9AFgeXt\n\tDupvMcXOAh1XVznUqq2Td4diTL7N/Owl3mpGOSSo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kqg4mZca\"; dkim-atps=neutral","Message-ID":"<8f29c32f-c1fa-2b83-4810-7cd54a132f20@ideasonboard.com>","Date":"Tue, 30 Aug 2022 16:21:32 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.12.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220829100414.28404-1-laurent.pinchart@ideasonboard.com>\n\t<20220829100414.28404-2-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220829100414.28404-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 1/3] pipeline: uvcvideo: Add color\n\tspace support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]