{"id":17221,"url":"https://patchwork.libcamera.org/api/patches/17221/?format=json","web_url":"https://patchwork.libcamera.org/patch/17221/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220829100251.935217-1-umang.jain@ideasonboard.com>","date":"2022-08-29T10:02:51","name":"[libcamera-devel] gstreamer: Provide interlace-mode as fixated caps","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"2d16f6a36540481458e4db07f2c0f2f67069eb7d","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/17221/mbox/","series":[{"id":3444,"url":"https://patchwork.libcamera.org/api/series/3444/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3444","date":"2022-08-29T10:02:51","name":"[libcamera-devel] gstreamer: Provide interlace-mode as fixated caps","version":1,"mbox":"https://patchwork.libcamera.org/series/3444/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17221/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17221/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 338F6C3272\n\tfor ;\n\tMon, 29 Aug 2022 10:03:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8517861FC0;\n\tMon, 29 Aug 2022 12:03:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6390561FBB\n\tfor ;\n\tMon, 29 Aug 2022 12:03:03 +0200 (CEST)","from umang.jainideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3f:1548:78ac:4a3:edc3:c28a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 10FD78BD;\n\tMon, 29 Aug 2022 12:03:00 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661767384;\n\tbh=AUNPCG01eUfBBlFiGu317cUINwdnLmYHHGEJXiCiYCo=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=RPwwqhT4pGmQ5ETm7XZaeGlsJES3QWJu2yYT9RXFV1aaKvKujyM2nlIpFTYe9xYZo\n\tQAbtuHOoy2YCqFbfE38bPpn2NZA6GxdQ1U45HSDc9trqrSYuZk14uXAPdhQpmMJuu3\n\ttoULEYdPOHUp4ZhFOXoigdri6nO+j+Zzow1Eawz0SGTK0JniEk0Ob1xpnFlS3uykQo\n\tOvDH4pBcK/jwl5chmicuthdmCOusYi+G+c6ErCY/CXuAlJuek2NRKDOjo+An6wrKtr\n\tpNGTQCfPhmXOyoGy1PlE7WlsNGj+6pLtdHWSUju5X/nsfO1Ii4/vjJ7oLcQpJ5Lixn\n\tBwzihOS+9md+g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661767382;\n\tbh=AUNPCG01eUfBBlFiGu317cUINwdnLmYHHGEJXiCiYCo=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=C1ZyoGG55YWz715QsJR6t3O3zEj33LvRM7tUJT0UC0xH2eVae+MZ8SCb83FrbGxDD\n\tHSG3fx2+Is4fJA1H80oi4L9O5p8QhTLeWCUUi5YVdVGB/FH50PC5yPXvnKwzCw8/02\n\tILxLIPGQGDpeK93JJWV4+yXRbWG4ZTXMBbeaqIIE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"C1ZyoGG5\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 29 Aug 2022 15:32:51 +0530","Message-Id":"<20220829100251.935217-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.37.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] gstreamer: Provide interlace-mode as\n\tfixated caps","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"rishikeshdonadkar@gmail.com, vedantparanjape160201@gmail.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The 'interlace-mode' for libcamerasrc will always be 'progressive'.\nProvide it via fixated caps mechanism [1]\n\n[1] https://gstreamer.freedesktop.org/documentation/plugin-development/advanced/negotiation.html?gi-language=c#fixed-negotiation\n\nSigned-off-by: Umang Jain \n---\nRishi, Can you please check this patch as well? I think it will closely\nco-relate with the framerate being captured in caps, as fixate\nnegotitation mechanism.\n---\n src/gstreamer/gstlibcamerasrc.cpp | 26 ++++++++++++++++++++++++++\n 1 file changed, 26 insertions(+)","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 16d70fea..24a2e33e 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -800,11 +800,37 @@ gst_libcamera_src_release_pad(GstElement *element, GstPad *pad)\n \tgst_element_remove_pad(element, pad);\n }\n \n+static GstCaps *gst_libcamera_src_src_fixate([[maybe_unused]] GstBaseSrc *bsrc,\n+\t\t\t\t\t GstCaps *caps)\n+{\n+\tGstStructure *structure;\n+\tGstCaps *fixated_caps;\n+\n+\tfixated_caps = gst_caps_make_writable(caps);\n+\n+\tfor (guint i = 0; i < gst_caps_get_size(fixated_caps); ++i) {\n+\t\tstructure = gst_caps_get_structure(fixated_caps, i);\n+\t\tif (gst_structure_has_field(structure, \"interlace-mode\"))\n+\t\t\tgst_structure_fixate_field_string(structure, \"interlace-mode\",\n+\t\t\t\t\t\t\t \"progressive\");\n+\t\telse\n+\t\t\tgst_structure_set(structure, \"interlace-mode\", G_TYPE_STRING,\n+\t\t\t\t\t \"progressive\", NULL);\n+\t}\n+\n+\tfixated_caps = gst_caps_fixate(fixated_caps);\n+\n+\treturn fixated_caps;\n+}\n+\n static void\n gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n {\n \tGstElementClass *element_class = GST_ELEMENT_CLASS(klass);\n \tGObjectClass *object_class = G_OBJECT_CLASS(klass);\n+\tGstBaseSrcClass *gstbasesrc_class = (GstBaseSrcClass *)klass;\n+\n+\tgstbasesrc_class->fixate = gst_libcamera_src_src_fixate;\n \n \tobject_class->set_property = gst_libcamera_src_set_property;\n \tobject_class->get_property = gst_libcamera_src_get_property;\n","prefixes":["libcamera-devel"]}