{"id":17220,"url":"https://patchwork.libcamera.org/api/patches/17220/?format=json","web_url":"https://patchwork.libcamera.org/patch/17220/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220829084746.23405-1-laurent.pinchart@ideasonboard.com>","date":"2022-08-29T08:47:46","name":"[libcamera-devel] utils: rkisp1: gen-csc-table: Specify coefficients with full precision","commit_ref":"4baaecb4ff220d6decb959bef14d91385cbba1ad","pull_url":null,"state":"accepted","archived":false,"hash":"b14fd046fa97ef875581db5527cb02c410870a97","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17220/mbox/","series":[{"id":3443,"url":"https://patchwork.libcamera.org/api/series/3443/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3443","date":"2022-08-29T08:47:46","name":"[libcamera-devel] utils: rkisp1: gen-csc-table: Specify coefficients with full precision","version":1,"mbox":"https://patchwork.libcamera.org/series/3443/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17220/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17220/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D089BC0DA4\n\tfor ;\n\tMon, 29 Aug 2022 08:47:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4598161F9F;\n\tMon, 29 Aug 2022 10:47:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C36E61F9F\n\tfor ;\n\tMon, 29 Aug 2022 10:47:56 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0122E481;\n\tMon, 29 Aug 2022 10:47:55 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661762878;\n\tbh=STS+H1xnciYgViQtLfcVNyEJ6HkgR+BSr+0nb+i3Ojw=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=b7ixindNrgARnNyRq5UrdUlr9fzmEj/m02ZxF7c4HbqLVqMS85kCTxRAau0NGXiLx\n\tqV6xRM91HYI2IU7ZuY3fXqe5wDQ+aGIMIwprw4S6ACfvs11pDW0bzcRDGjYblUCDqj\n\tkxtqfv8YOmuby1jUf2B4B4XGwQSPAgWHGUa3ZD+/PLvlawp97bHsfM3UcYf7LWEM6L\n\t7HoHzBw4aEpKw5bim31ioIfSvW5QNXQwGrndQC+IEH0uA6hRw90d8SFuPVolAQN1U3\n\tL38BgJUp2KI2WmYyLpMaIAJhwPHlP+BzHqO5nUYfGEvYsU2hmF/bxrUUdRCSoPCyxi\n\tf2ZPaCDYMKQzw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661762876;\n\tbh=STS+H1xnciYgViQtLfcVNyEJ6HkgR+BSr+0nb+i3Ojw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Z3TFe/kQ8R/87e7lvbJkb4iUVor2C27levdHMO6IY8qr9+jqI0ztc2AmgP41EHDSY\n\tn5OVEhMSzRwWpgAzyr+TwVEdD3rCwRyZa2VFIXZ++K11kSmLIl4AMfTmvhLC0+foEr\n\tSla/raL8IS+tIV+3y8sTOefhc/TJ5sWQG+Di2v0s="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Z3TFe/kQ\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 29 Aug 2022 11:47:46 +0300","Message-Id":"<20220829084746.23405-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] utils: rkisp1: gen-csc-table: Specify\n\tcoefficients with full precision","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Rec01, Rec709, Rec2020 and SMTPE 240M standards specify the Cb and\nCr coefficients of the RGB to Y'CbCr conversion matrix using a quotient\nof two values. Use the exact same formulas instead of hardcoding the\ndivision results with a lower precision.\n\nSigned-off-by: Laurent Pinchart \n---\n utils/rkisp1/gen-csc-table.py | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)\n\n\nbase-commit: 3fad116f89e0d3497567043cbf6d8c49f1c102db","diff":"diff --git a/utils/rkisp1/gen-csc-table.py b/utils/rkisp1/gen-csc-table.py\nindex ca0187ec24c6..2fb702746421 100755\n--- a/utils/rkisp1/gen-csc-table.py\n+++ b/utils/rkisp1/gen-csc-table.py\n@@ -12,24 +12,24 @@ import sys\n \n encodings = {\n 'rec601': [\n- [ 0.2990, 0.5870, 0.1140 ],\n- [ -0.1687, -0.3313, 0.5 ],\n- [ 0.5, -0.4187, -0.0813 ]\n+ [ 0.299, 0.587, 0.114 ],\n+ [ -0.299 / 1.772, -0.587 / 1.772, 0.886 / 1.772 ],\n+ [ 0.701 / 1.402, -0.587 / 1.402, -0.114 / 1.402 ]\n ],\n 'rec709': [\n- [ 0.2126, 0.7152, 0.0722 ],\n- [ -0.1146, -0.3854, 0.5 ],\n- [ 0.5, -0.4542, -0.0458 ]\n+ [ 0.2126, 0.7152, 0.0722 ],\n+ [ -0.2126 / 1.8556, -0.7152 / 1.8556, 0.9278 / 1.8556 ],\n+ [ 0.7874 / 1.5748, -0.7152 / 1.5748, -0.0722 / 1.5748 ]\n ],\n 'rec2020': [\n- [ 0.2627, 0.6780, 0.0593 ],\n- [ -0.1396, -0.3604, 0.5 ],\n- [ 0.5, -0.4598, -0.0402 ]\n+ [ 0.2627, 0.6780, 0.0593 ],\n+ [ -0.2627 / 1.8814, -0.6780 / 1.8814, 0.9407 / 1.8814 ],\n+ [ 0.7373 / 1.4746, -0.6780 / 1.4746, -0.0593 / 1.4746 ],\n ],\n 'smpte240m': [\n- [ 0.2122, 0.7013, 0.0865 ],\n- [ -0.1161, -0.3839, 0.5 ],\n- [ 0.5, -0.4451, -0.0549 ]\n+ [ 0.2122, 0.7013, 0.0865 ],\n+ [ -0.2122 / 1.8270, -0.7013 / 1.8270, 0.9135 / 1.8270 ],\n+ [ 0.7878 / 1.5756, -0.7013 / 1.5756, -0.0865 / 1.5756 ],\n ],\n }\n \n","prefixes":["libcamera-devel"]}