[{"id":24747,"web_url":"https://patchwork.libcamera.org/comment/24747/","msgid":"","date":"2022-08-23T22:36:40","subject":"Re: [libcamera-devel] [PATCH] gstreamer: Add support for additional\n\tRGB formats","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn 8/24/22 12:08 AM, Laurent Pinchart via libcamera-devel wrote:\n> libcamerasrc only supports three RGB formats. Adding the other RGB\n> formats supported by libcamera is trivial, do so.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> I haven't tested this yet as I don't have a board hooked up that can\n> capture these formats. If someone can test it with an OV5640 sensor on\n> an i.MX8MP, that would be great, otherwise I'll get to it in the not too\n> distant future.\n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 14 +++++++++++++-\n> 1 file changed, 13 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index c97c0d438de2..5a21a391c698 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -19,9 +19,21 @@ static struct {\n> \t/* Compressed */\n> \t{ GST_VIDEO_FORMAT_ENCODED, formats::MJPEG },\n> \n> -\t/* RGB */\n> +\t/* RGB16 */\n> +\t{ GST_VIDEO_FORMAT_RGB16, formats::RGB565 },\n> +\n> +\t/* RGB24 */\n> \t{ GST_VIDEO_FORMAT_RGB, formats::BGR888 },\n> \t{ GST_VIDEO_FORMAT_BGR, formats::RGB888 },\n> +\n> +\t/* RGB32 */\n> +\t{ GST_VIDEO_FORMAT_BGRx, formats::XRGB8888 },\n> +\t{ GST_VIDEO_FORMAT_RGBx, formats::XBGR8888 },\n> +\t{ GST_VIDEO_FORMAT_xBGR, formats::RGBX8888 },\n> +\t{ GST_VIDEO_FORMAT_xRGB, formats::BGRX8888 },\n> +\t{ GST_VIDEO_FORMAT_BGRA, formats::ARGB8888 },\n> +\t{ GST_VIDEO_FORMAT_RGBA, formats::ABGR8888 },\n> +\t{ GST_VIDEO_FORMAT_ABGR, formats::RGBA8888 },\n\nI have individually cross referenced each entry with V4L2 pixel format \nand seems correct to me,\n\nReviewed-by: Umang Jain \n> \t{ GST_VIDEO_FORMAT_ARGB, formats::BGRA8888 },\n> \n> \t/* YUV Semiplanar */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56F4FC3272\n\tfor ;\n\tTue, 23 Aug 2022 22:36:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4AA7661FBD;\n\tWed, 24 Aug 2022 00:36:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90C6D61FA1\n\tfor ;\n\tWed, 24 Aug 2022 00:36:46 +0200 (CEST)","from [IPV6:2401:4900:1f3f:806e:6647:8e5c:f441:ca9a] (unknown\n\t[IPv6:2401:4900:1f3f:806e:6647:8e5c:f441:ca9a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 717E22B3;\n\tWed, 24 Aug 2022 00:36:45 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661294208;\n\tbh=zUXBlJ7rL/wVLQ1FWaKAkAPMxHuR7QrnyCZ4O6/7yaw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=02HiPNwPGmiaT2V5I/zGbEIk6xL88AY9aZpPP0shy2+pHmXbxwA85nndAMK/Ey4xT\n\tDBJeqS+MPPYe3BZ9B67nLNrrNwT5mNzmvHebz6s40blOBdyvamNgIZwmBUyHOs91R8\n\tPzeX12SVwq9Io6WHjjWt06xiDgNV6jGK85jSyG9rYkolgXQ2HbhetRboaWOExjYXNT\n\tQF8qpLJrZE7odA2WIbeRIvqAifBnqDu5Rp1CT/yiSHNA9uvCCDkptvo1S8v9jb2ZWT\n\t9dFNbB7AaIOTqRboC/Me0ITc3OxKeOA3k8v87is2EurmOI6Zpe29bCqr0r1phk97p9\n\tBxHxAvzcTK2BA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661294206;\n\tbh=zUXBlJ7rL/wVLQ1FWaKAkAPMxHuR7QrnyCZ4O6/7yaw=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=X3urxBUkFaY57xFUr6SW4iHekz1cKzwkomIR5V3TwAJw8uC4QNtrgyhiVmA5TmQxf\n\tT6yVfhzFVHym2J93cAb41Y91tuV4n8Far20N62MO7JfDpWWLxaVUguEibMzsdyL3pN\n\tn1e+Mz+y2cFdNiFaIppTCPdFznf89mCTW9C2wijc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"X3urxBUk\"; dkim-atps=neutral","Message-ID":"","Date":"Wed, 24 Aug 2022 04:06:40 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.12.0","Content-Language":"en-US","To":"libcamera-devel@lists.libcamera.org,\n\tLaurent Pinchart ","References":"<20220823183856.17944-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220823183856.17944-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] gstreamer: Add support for additional\n\tRGB formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24755,"web_url":"https://patchwork.libcamera.org/comment/24755/","msgid":"<166133273203.3322205.15800860725110981765@Monstersaurus>","date":"2022-08-24T09:18:52","subject":"Re: [libcamera-devel] [PATCH] gstreamer: Add support for additional\n\tRGB formats","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain via libcamera-devel (2022-08-23 23:36:40)\n> Hi Laurent,\n> \n> Thank you for the patch.\n> \n> On 8/24/22 12:08 AM, Laurent Pinchart via libcamera-devel wrote:\n> > libcamerasrc only supports three RGB formats. Adding the other RGB\n> > formats supported by libcamera is trivial, do so.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > I haven't tested this yet as I don't have a board hooked up that can\n> > capture these formats. If someone can test it with an OV5640 sensor on\n> > an i.MX8MP, that would be great, otherwise I'll get to it in the not too\n> > distant future.\n> > ---\n> > src/gstreamer/gstlibcamera-utils.cpp | 14 +++++++++++++-\n> > 1 file changed, 13 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> > index c97c0d438de2..5a21a391c698 100644\n> > --- a/src/gstreamer/gstlibcamera-utils.cpp\n> > +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> > @@ -19,9 +19,21 @@ static struct {\n> > /* Compressed */\n> > { GST_VIDEO_FORMAT_ENCODED, formats::MJPEG },\n> > \n> > - /* RGB */\n> > + /* RGB16 */\n> > + { GST_VIDEO_FORMAT_RGB16, formats::RGB565 },\n> > +\n> > + /* RGB24 */\n> > { GST_VIDEO_FORMAT_RGB, formats::BGR888 },\n> > { GST_VIDEO_FORMAT_BGR, formats::RGB888 },\n> > +\n> > + /* RGB32 */\n> > + { GST_VIDEO_FORMAT_BGRx, formats::XRGB8888 },\n> > + { GST_VIDEO_FORMAT_RGBx, formats::XBGR8888 },\n> > + { GST_VIDEO_FORMAT_xBGR, formats::RGBX8888 },\n> > + { GST_VIDEO_FORMAT_xRGB, formats::BGRX8888 },\n> > + { GST_VIDEO_FORMAT_BGRA, formats::ARGB8888 },\n> > + { GST_VIDEO_FORMAT_RGBA, formats::ABGR8888 },\n> > + { GST_VIDEO_FORMAT_ABGR, formats::RGBA8888 },\n> \n> I have individually cross referenced each entry with V4L2 pixel format \n> and seems correct to me,\n> \n> Reviewed-by: Umang Jain \n\nI'll be happy to see this patch in and support extended.\n\nWhat pixelformats do we support that are not supported by the gstreamer\nelement, or perhaps are not supported by gstreamer at all? Or are all\nformats covered with this?\n\nAll the above formats match my expectations with ordering.\n\nReviewed-by: Kieran Bingham \n\n--\nKieran\n\n\n\n> > { GST_VIDEO_FORMAT_ARGB, formats::BGRA8888 },\n> > \n> > /* YUV Semiplanar */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D88DAC3272\n\tfor ;\n\tWed, 24 Aug 2022 09:18:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 213C361FBE;\n\tWed, 24 Aug 2022 11:18:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9766F61FA2\n\tfor ;\n\tWed, 24 Aug 2022 11:18:54 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0C05B2B3;\n\tWed, 24 Aug 2022 11:18:54 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661332736;\n\tbh=Uru7upCzkEs2Xp567Se9/WGt0gh4DMhCzEhTWc1L6+8=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=vwdxgicCETFlzRvxfellGO+whplk2Gsb4Baiw8eQqUNieNFcreVWnEKv+bYxI0TSA\n\tsTSamsaVciPJsDrQMh7E2B0p/K5NHMypEpHVBoQK9HGjKcoZvbvBLkwPMqHmwO2XOT\n\tJZs33cRI0XRWpDpoJ8NVtQGj6O7gZAlnSNTn1w6OwaCRZO5iXp9a1a6/WkQeqYd92+\n\touC51lFr5rcNImRHV5XA/nvRfo+LcAEzVADtRA2foD01l4IfGEFMXccQBu1xBLRTkT\n\tW2GRW02jUp3DPBZoEj5p6AuEqGxJrxJ1wruwqB7ukBZf1PCkGB4Svgz1Ue6s8nAjB3\n\tP0npCThuLX++Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661332734;\n\tbh=Uru7upCzkEs2Xp567Se9/WGt0gh4DMhCzEhTWc1L6+8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=HzqwwYAP82OKt922+I7EtHa1ldFOMCWgYSyLlFp+SuEgPHfz2acuRVmGhvbxnv57w\n\tAYUER68G/9T3Nbe/duhyif06bjoaQeOLwqxe/+gO3iSaZtXjKK6WGvulm2qQcIAd8a\n\t58R/yj4JUtRqZUMxcNcrBaEDuhDktQttI/vpmQdw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HzqwwYAP\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220823183856.17944-1-laurent.pinchart@ideasonboard.com>\n\t","To":"Laurent Pinchart ,\n\tUmang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 24 Aug 2022 10:18:52 +0100","Message-ID":"<166133273203.3322205.15800860725110981765@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] gstreamer: Add support for additional\n\tRGB formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24756,"web_url":"https://patchwork.libcamera.org/comment/24756/","msgid":"","date":"2022-08-24T09:25:09","subject":"Re: [libcamera-devel] [PATCH] gstreamer: Add support for additional\n\tRGB formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Aug 24, 2022 at 10:18:52AM +0100, Kieran Bingham wrote:\n> Quoting Umang Jain via libcamera-devel (2022-08-23 23:36:40)\n> > Hi Laurent,\n> > \n> > Thank you for the patch.\n> > \n> > On 8/24/22 12:08 AM, Laurent Pinchart via libcamera-devel wrote:\n> > > libcamerasrc only supports three RGB formats. Adding the other RGB\n> > > formats supported by libcamera is trivial, do so.\n> > >\n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > I haven't tested this yet as I don't have a board hooked up that can\n> > > capture these formats. If someone can test it with an OV5640 sensor on\n> > > an i.MX8MP, that would be great, otherwise I'll get to it in the not too\n> > > distant future.\n> > > ---\n> > > src/gstreamer/gstlibcamera-utils.cpp | 14 +++++++++++++-\n> > > 1 file changed, 13 insertions(+), 1 deletion(-)\n> > >\n> > > diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> > > index c97c0d438de2..5a21a391c698 100644\n> > > --- a/src/gstreamer/gstlibcamera-utils.cpp\n> > > +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> > > @@ -19,9 +19,21 @@ static struct {\n> > > /* Compressed */\n> > > { GST_VIDEO_FORMAT_ENCODED, formats::MJPEG },\n> > > \n> > > - /* RGB */\n> > > + /* RGB16 */\n> > > + { GST_VIDEO_FORMAT_RGB16, formats::RGB565 },\n> > > +\n> > > + /* RGB24 */\n> > > { GST_VIDEO_FORMAT_RGB, formats::BGR888 },\n> > > { GST_VIDEO_FORMAT_BGR, formats::RGB888 },\n> > > +\n> > > + /* RGB32 */\n> > > + { GST_VIDEO_FORMAT_BGRx, formats::XRGB8888 },\n> > > + { GST_VIDEO_FORMAT_RGBx, formats::XBGR8888 },\n> > > + { GST_VIDEO_FORMAT_xBGR, formats::RGBX8888 },\n> > > + { GST_VIDEO_FORMAT_xRGB, formats::BGRX8888 },\n> > > + { GST_VIDEO_FORMAT_BGRA, formats::ARGB8888 },\n> > > + { GST_VIDEO_FORMAT_RGBA, formats::ABGR8888 },\n> > > + { GST_VIDEO_FORMAT_ABGR, formats::RGBA8888 },\n> > \n> > I have individually cross referenced each entry with V4L2 pixel format \n> > and seems correct to me,\n> > \n> > Reviewed-by: Umang Jain \n> \n> I'll be happy to see this patch in and support extended.\n> \n> What pixelformats do we support that are not supported by the gstreamer\n> element, or perhaps are not supported by gstreamer at all? Or are all\n> formats covered with this?\n\nThe above list covers all our RGB formats. I haven't checked the other\nones.\n\n> All the above formats match my expectations with ordering.\n> \n> Reviewed-by: Kieran Bingham \n> \n> > > { GST_VIDEO_FORMAT_ARGB, formats::BGRA8888 },\n> > > \n> > > /* YUV Semiplanar */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1BBC4C0DA4\n\tfor ;\n\tWed, 24 Aug 2022 09:25:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6EB9A61FBE;\n\tWed, 24 Aug 2022 11:25:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B69F61FA2\n\tfor ;\n\tWed, 24 Aug 2022 11:25:15 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A0992B3;\n\tWed, 24 Aug 2022 11:25:14 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661333116;\n\tbh=ui3tKF3PolWMoqf2whjax7c8pBEQf8n0zOZIzLk83bU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=gVm61SvS2a6EGe7lYYoOLXiiZe3JGmsFj+r4fjZnuaS0+Wlv3wyrS8C/1pG6q9zqJ\n\trJBguHIIu/gxdt+FAJzLe9pTF7IGn5Puo7UPRuJ81ttjNGXXoYJELDUiPBN15SNknw\n\tYkAinM/foR2xu1je/y5929YfaRZm5cLJOKRvALAwRXKBcmTiHEV52bq1yCELTcgPDG\n\t482//8t+joJj36MCl9CB6CRCOl8lBAB4vZ8B1Tf228xUUKhaaEjpzvjAiUEnV0TSHx\n\tusakycnRn6QsZn9MyvN0B1TEXPY0g4n1egQ4rl0/Tt51qN6RXfcp1ubsMsjEVNeHSq\n\t7CpVBMIEs89pg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661333114;\n\tbh=ui3tKF3PolWMoqf2whjax7c8pBEQf8n0zOZIzLk83bU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=E9MJ61WLvbxqqVbFrrGySfCU6Y9XJXPWi+Kl8hjzqCoz4sqZ7CfyXc22hC26TEUyr\n\tEP4DprOPfmpu9WxbB4CCIlLMmXyn5vO8B7HnIpIKjOHw2Sp5DSXLEHvyexEWAzoYyz\n\tzVZaEm30i1FvNQmsAV2UthKsU+JjPJVwwg10mPSo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"E9MJ61WL\"; dkim-atps=neutral","Date":"Wed, 24 Aug 2022 12:25:09 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220823183856.17944-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<166133273203.3322205.15800860725110981765@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<166133273203.3322205.15800860725110981765@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] gstreamer: Add support for additional\n\tRGB formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24760,"web_url":"https://patchwork.libcamera.org/comment/24760/","msgid":"<166133446126.3336190.13220073276765457286@Monstersaurus>","date":"2022-08-24T09:47:41","subject":"Re: [libcamera-devel] [PATCH] gstreamer: Add support for additional\n\tRGB formats","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2022-08-24 10:25:09)\n> On Wed, Aug 24, 2022 at 10:18:52AM +0100, Kieran Bingham wrote:\n> > Quoting Umang Jain via libcamera-devel (2022-08-23 23:36:40)\n> > > Hi Laurent,\n> > > \n> > > Thank you for the patch.\n> > > \n> > > On 8/24/22 12:08 AM, Laurent Pinchart via libcamera-devel wrote:\n> > > > libcamerasrc only supports three RGB formats. Adding the other RGB\n> > > > formats supported by libcamera is trivial, do so.\n> > > >\n> > > > Signed-off-by: Laurent Pinchart \n> > > > ---\n> > > > I haven't tested this yet as I don't have a board hooked up that can\n> > > > capture these formats. If someone can test it with an OV5640 sensor on\n> > > > an i.MX8MP, that would be great, otherwise I'll get to it in the not too\n> > > > distant future.\n> > > > ---\n> > > > src/gstreamer/gstlibcamera-utils.cpp | 14 +++++++++++++-\n> > > > 1 file changed, 13 insertions(+), 1 deletion(-)\n> > > >\n> > > > diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> > > > index c97c0d438de2..5a21a391c698 100644\n> > > > --- a/src/gstreamer/gstlibcamera-utils.cpp\n> > > > +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> > > > @@ -19,9 +19,21 @@ static struct {\n> > > > /* Compressed */\n> > > > { GST_VIDEO_FORMAT_ENCODED, formats::MJPEG },\n> > > > \n> > > > - /* RGB */\n> > > > + /* RGB16 */\n> > > > + { GST_VIDEO_FORMAT_RGB16, formats::RGB565 },\n> > > > +\n> > > > + /* RGB24 */\n> > > > { GST_VIDEO_FORMAT_RGB, formats::BGR888 },\n> > > > { GST_VIDEO_FORMAT_BGR, formats::RGB888 },\n> > > > +\n> > > > + /* RGB32 */\n> > > > + { GST_VIDEO_FORMAT_BGRx, formats::XRGB8888 },\n> > > > + { GST_VIDEO_FORMAT_RGBx, formats::XBGR8888 },\n> > > > + { GST_VIDEO_FORMAT_xBGR, formats::RGBX8888 },\n> > > > + { GST_VIDEO_FORMAT_xRGB, formats::BGRX8888 },\n> > > > + { GST_VIDEO_FORMAT_BGRA, formats::ARGB8888 },\n> > > > + { GST_VIDEO_FORMAT_RGBA, formats::ABGR8888 },\n> > > > + { GST_VIDEO_FORMAT_ABGR, formats::RGBA8888 },\n> > > \n> > > I have individually cross referenced each entry with V4L2 pixel format \n> > > and seems correct to me,\n> > > \n> > > Reviewed-by: Umang Jain \n> > \n> > I'll be happy to see this patch in and support extended.\n> > \n> > What pixelformats do we support that are not supported by the gstreamer\n> > element, or perhaps are not supported by gstreamer at all? Or are all\n> > formats covered with this?\n> \n> The above list covers all our RGB formats. I haven't checked the other\n> ones.\n\nIt looks like these are the unsupported formats. I haven't looked to see\nwhich are actually supported by Gstreamer, but if anyone wants to - this\nis the list to add:\n\n R8, R10, R12\n RGB565_BE\n AVUY8888, XVUY8888\n NV42\n YVU422, YUV444, YVU444\n\n All raw formats. (I expect gstreamer won't handle RAW?)\n\nKieran\n\n> \n> > All the above formats match my expectations with ordering.\n> > \n> > Reviewed-by: Kieran Bingham \n> > \n> > > > { GST_VIDEO_FORMAT_ARGB, formats::BGRA8888 },\n> > > > \n> > > > /* YUV Semiplanar */\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1881C3272\n\tfor ;\n\tWed, 24 Aug 2022 09:47:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 249EE61FBE;\n\tWed, 24 Aug 2022 11:47:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC49761FA2\n\tfor ;\n\tWed, 24 Aug 2022 11:47:43 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 564B62B3;\n\tWed, 24 Aug 2022 11:47:43 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661334465;\n\tbh=ARaz70diR/tHfGWR2TlUbN4wZtCA1F26dLZU8vc5Hjo=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=uwAX375F3HIHB/KalQnB4iVdU1X0O49htQsZnsBgGKS7K/j8fpQ8jHNwq4N2yFHYi\n\tA9LpAhUttlfd0n+LO9a5KQZsaCUXGHzCVLkivQkdBMdbjfUjTEwxomXXKJ+pX9EZ21\n\tZDJjSrNlGpxQ3OrEnAaTYovWM74xHeijahQ4Ht4iwqQLleuSvX6kUL4PaWYvXwraxA\n\tnJOf9sw08NKFtHDPyDs2EfYe7fiP/o/BuB2hi1aXfII7bIizJXYiifrAcswgVSNkdL\n\tZy9I0BZCD9JvQ0FuHY1EQvqjVhBZSkQlQt8pcQ+Y7FJbEh0OYoqeg3Y1aROvxvGmce\n\tshxLKZlQr3qtQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661334463;\n\tbh=ARaz70diR/tHfGWR2TlUbN4wZtCA1F26dLZU8vc5Hjo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=hnK2zaTlFfIF0LKinEpx1po8/34ZSPQlxJbuy2rFCEtyt3koZ34nNMFSLZVBHpRUL\n\tWzqJrWoMoUoCx4rbU0TC4Fm4cseIGY8sTmP2pjW/fARUJd/THwkvurikajCsESTBvJ\n\tXW6SfQ0kCk7eCx7RLu2HdOaBwbTrVk4v0xAcq/pE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hnK2zaTl\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220823183856.17944-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<166133273203.3322205.15800860725110981765@Monstersaurus>\n\t","To":"Laurent Pinchart ","Date":"Wed, 24 Aug 2022 10:47:41 +0100","Message-ID":"<166133446126.3336190.13220073276765457286@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] gstreamer: Add support for additional\n\tRGB formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24761,"web_url":"https://patchwork.libcamera.org/comment/24761/","msgid":"<91564272-fec5-6f9d-f8fc-44431c1d4737@oss.nxp.com>","date":"2022-08-24T11:08:53","subject":"Re: [libcamera-devel] [PATCH] gstreamer: Add support for additional\n\tRGB formats","submitter":{"id":107,"url":"https://patchwork.libcamera.org/api/people/107/","name":"Xavier Roumegue","email":"xavier.roumegue@oss.nxp.com"},"content":"On 8/23/22 20:38, Laurent Pinchart wrote:\n> libcamerasrc only supports three RGB formats. Adding the other RGB\n> formats supported by libcamera is trivial, do so.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> I haven't tested this yet as I don't have a board hooked up that can\n> capture these formats. If someone can test it with an OV5640 sensor on\n> an i.MX8MP, that would be great, otherwise I'll get to it in the not too\n> distant future.\n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 14 +++++++++++++-\n> 1 file changed, 13 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index c97c0d438de2..5a21a391c698 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -19,9 +19,21 @@ static struct {\n> \t/* Compressed */\n> \t{ GST_VIDEO_FORMAT_ENCODED, formats::MJPEG },\n> \n> -\t/* RGB */\n> +\t/* RGB16 */\n> +\t{ GST_VIDEO_FORMAT_RGB16, formats::RGB565 },\n> +\n> +\t/* RGB24 */\n> \t{ GST_VIDEO_FORMAT_RGB, formats::BGR888 },\n> \t{ GST_VIDEO_FORMAT_BGR, formats::RGB888 },\n> +\n> +\t/* RGB32 */\n> +\t{ GST_VIDEO_FORMAT_BGRx, formats::XRGB8888 },\n> +\t{ GST_VIDEO_FORMAT_RGBx, formats::XBGR8888 },\n> +\t{ GST_VIDEO_FORMAT_xBGR, formats::RGBX8888 },\n> +\t{ GST_VIDEO_FORMAT_xRGB, formats::BGRX8888 },\n> +\t{ GST_VIDEO_FORMAT_BGRA, formats::ARGB8888 },\n> +\t{ GST_VIDEO_FORMAT_RGBA, formats::ABGR8888 },\n> +\t{ GST_VIDEO_FORMAT_ABGR, formats::RGBA8888 },\n> \t{ GST_VIDEO_FORMAT_ARGB, formats::BGRA8888 },\n> \n> \t/* YUV Semiplanar */\nGST formats RGB16, RGB, BGR, BGRx, BGRA tested successfully on i.MX8MP \nplatform with ov5640 sensors so:\n\nTested-by: Xavier Roumegue ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50B1FC0DA4\n\tfor ;\n\tWed, 24 Aug 2022 11:08:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC40F61FBC;\n\tWed, 24 Aug 2022 13:08:58 +0200 (CEST)","from EUR05-VI1-obe.outbound.protection.outlook.com\n\t(mail-vi1eur05on2068.outbound.protection.outlook.com [40.107.21.68])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BDE260E26\n\tfor ;\n\tWed, 24 Aug 2022 13:08:57 +0200 (CEST)","from PAXPR04MB8703.eurprd04.prod.outlook.com\n\t(2603:10a6:102:21e::22)\n\tby AM0PR04MB6260.eurprd04.prod.outlook.com (2603:10a6:208:13a::16)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15;\n\tWed, 24 Aug 2022 11:08:55 +0000","from PAXPR04MB8703.eurprd04.prod.outlook.com\n\t([fe80::485:adba:7081:715a]) by\n\tPAXPR04MB8703.eurprd04.prod.outlook.com\n\t([fe80::485:adba:7081:715a%3]) with mapi id 15.20.5566.015;\n\tWed, 24 Aug 2022 11:08:55 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661339338;\n\tbh=hmF3q5dyYuFpjZOfHn0frI7L4BR977RCvJpzLiNLSQ8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=kuWp/n5ohbnBBn0W3sM6BnaAvMLMHoLgIOFOPa2Z120Rs7gXSesXn2xpLJXoyq1ez\n\tTXFzonZiUQ0KwMmn5d/MucVGHlwst5tI3VgY6V2DHANO4FREEueBADxPa6iMhsEtEh\n\tOETkDujNfTpTIZsQXNV6enyFTMIi+gjzCK6OyvATIuEebJHeX3Y0ichqfyp6V4MLU5\n\tIVSKFLpLBw3C96TRz12B984FDf0ort+FGLkYeh8ADbRG2h2xQb5uXC377Lt9IPNjcf\n\tshHtEOx971N0KDamQkZFZhCTQ2NvEutfLyrolk2OVlgEBXp1KZgoSPHWVTOIbUKSLm\n\ttEXFB8g6oQ3kw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;\n\ts=selector2-NXP1-onmicrosoft-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=dYzNGa5gzRpvsPGvY8q7GD8371/ekIqvr/xM/LriLp4=;\n\tb=IsQBiMbhM+h5t2D8skT/W6NhvF3kFOpDY4+5Dn1FU5EQk28N5quCys6CM4NOlnJCAXyjtU6eBoRFzE+p2tYWWs8IlsR8hj25NGe/hdkXqyQemQQ2d8pAZNsRefGoTEsyhMocccHr1z+rmHLykJvV230SkUVmCs+NyoucUk0pSZ8="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=NXP1.onmicrosoft.com\n\theader.i=@NXP1.onmicrosoft.com\n\theader.b=\"IsQBiMbh\"; dkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=oss.nxp.com;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=GynpJlA53axn6ixSAknr52EK3nCyCv7blECc+uykSL0wAAm+S+ZZSaKC36+BV0hFYYs6xynfgqz7Zqc7XxstBbWH8Rnvj2z4KCgS1MMN3t30usKZwGddomDgmB5GXOBK4IGjawv3U5OSt80CMWl3IVwR4kTvTY6hxsSCwC6niNuNCaVC13w2Qpe42kEWFjFqRbI3zM62wXEcI6Splmdf74dshWEzA7ZqWWzKSpwFcG6unmx5tGfT1KRjRsuVZTqkz7IRnAXRgYLGDfllT06WDptQ7jruOVR0vF+328jq2dMIKiJia8VTp7DPmW2htCgggm1OWORmRcx1vpKpUE+FdQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=dYzNGa5gzRpvsPGvY8q7GD8371/ekIqvr/xM/LriLp4=;\n\tb=Kwk4JScenhKEq/OAtYSHxkPrubUadKWihhhG9EbmS8lxSVvwXwtCLAUv9MRmJnQt4D4WHgNl8libBcDjRg/RuZJXXwh90iiOfG9r94ElegkCQPZMCvPAvblFW1hSMaEB0a+CVZVEmdQr9EZfwr2s+BMgjPP8kIkrA1+WmlRKbHstEoTGMzq9H7rqxbqq1Gz6xcnbhiJn7x6d6YYj05GdXblZZ317iSxoi1QPKOTs2FzWd1ItVM0WoJrRqj78hCqCrs3p8aMDraUvGZy5JFSICVdhKgIXaTDOQOVFYPpCEIPy7Zy3Rmi6SLEBZPya8X5KfEW2ovs04MuloPohsAE9rw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=oss.nxp.com;\n\tdmarc=pass action=none header.from=oss.nxp.com; \n\tdkim=pass header.d=oss.nxp.com; arc=none","Message-ID":"<91564272-fec5-6f9d-f8fc-44431c1d4737@oss.nxp.com>","Date":"Wed, 24 Aug 2022 13:08:53 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.12.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220823183856.17944-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220823183856.17944-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"PR0P264CA0106.FRAP264.PROD.OUTLOOK.COM\n\t(2603:10a6:100:19::22) To PAXPR04MB8703.eurprd04.prod.outlook.com\n\t(2603:10a6:102:21e::22)","MIME-Version":"1.0","X-MS-Exchange-MessageSentRepresentingType":"1","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"42eb85bd-41a9-4738-ad29-08da85c1089d","X-MS-TrafficTypeDiagnostic":"AM0PR04MB6260:EE_","X-MS-Exchange-SharedMailbox-RoutingAgent-Processed":"True","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;","X-Microsoft-Antispam-Message-Info":"mZ/dWm/jH1mhNgm/+T7U/jwnir3TJ67xQuo/XDuKTttHAeavcppqcziF1WZd8CNH6P/ezeLTW3dAmoBCXLE7WSlgu0Xpw6gbVzLKLNpqOp0YuupxPzeyM4Nvy5mUf0gOXpyQnGdh4L9iZlbZgi0iS0qWUVKm9q9v6O9KoadOnD6aX62tfSFIbYYuMzQFJ9vGwApu77wCwhEMFkynIZ3cfaj6BMMKFnp18ox+Zxpv2EsaS0DUhE5XaB5mVEPpLrsSclysjcTmKWC2xr1gAYZL8g7oQrDAjoRszl4+irZq1Mm63cbirOuy8DsZq3lSKoi5Nwrp6ofOBNOnWpuI3xpTiK9fyZnxtrSl/TQkNkOGylpUF1Fx5peygFr8cvYWCpivIqLqrjqaOcTCzfUWKfCjwVtIJ9L6/pDZull1kGen0ND638twIs/VyF8bqAereUaWa+pR69sZijfNtM456WI+hY3jfjnMeHy01DxkYY2s0BSvPxn4cptQjOstObXG5fE21dx5qNQ2qI1AaHwka5+MOMQEp2AzQntzm6Yu3arvOoANxHrHlzMC07VHdox2mv5mPtt8oYGE9TEP3wwSIp27TOoXOM7SFXa0q2/RJUiSFzcJ/FiCjurE0FtNYD5dZVRYu4YY9troXtaSGNdCZ8g/Nv+hDR2zVmkHioMdxK37Gv8KC8dEGmxjv8kQ5EUgAbhsoOLYbDyg31WRwtUxXBfqwh/bWTNBCZV9HKCstveoAGMM4pTktAjtmF7x30j5fOt/BadkW6tgLbmEKXaQhtht6B7ooPNR5XWP13VWmktumWM=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:PAXPR04MB8703.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230016)(4636009)(376002)(396003)(346002)(39860400002)(136003)(366004)(6486002)(86362001)(83380400001)(31696002)(8676002)(66556008)(8936002)(66946007)(66476007)(2616005)(5660300002)(4326008)(41300700001)(478600001)(186003)(316002)(52116002)(31686004)(53546011)(38100700002)(6506007)(6512007)(54906003)(2906002)(45980500001)(43740500002);\n\tDIR:OUT; SFP:1101; ","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?/dMb/ZUbe7eQKMt7yDgmqRdzA?=\n\t=?utf-8?q?UGmIxn+rUUBZq82E7I1oBfJuxLcjMtVuKdEjhkCV9fcwJ6IIHWOgJY8q?=\n\t=?utf-8?q?9bzbFn2kI3ji8onp650fvEMWrsM8QNKSmuqbegq7q/+cjmTcGn3hPAzq?=\n\t=?utf-8?q?F4Tw/9VuLVf6Sjl2RpaDZ44e/sC0V+CiivrKYCzFdnphEjOmYAj+hSZk?=\n\t=?utf-8?q?Wbv7oTkrFUEVvCwpDoI1j3I1TOn6tpLuNJ8onRTQHv9l1Vgrv8UTqbGO?=\n\t=?utf-8?q?v26XVNyclXZb/rO4vKmlRTOx+WL6Z7hi92WHQlrZdhYoC6RRIwo0EXp3?=\n\t=?utf-8?q?sbCRQbnh68V62DrhiyF4MtWA1hJXWpQ5yUjsso118409bYEOWwqFDYvu?=\n\t=?utf-8?q?Pds0pc3RtX1SYxJ0KAAHBNiGANGTRoYjZAmuciDxObUD13VQj8WE8cuB?=\n\t=?utf-8?q?HlIui/37fcSv3XV2rzZinlMcWPf3UtO/VuBCol6QPJcSRPYE9keOy9Gk?=\n\t=?utf-8?q?VTgJgomzmoixNsLghd+GRuTfUSIFfNiLGtx4nLmCBdIAKs2x09xujUG3?=\n\t=?utf-8?q?KXSOS8e7lN1E9pCYXYKf3wI7/I7ge0TA45oc0mwvBeP36KEWxY5dgTjc?=\n\t=?utf-8?q?Xht18fNOPC5PBST96hOzhGLAsvX+lA3Ci3vfKBvEgydWDDor4Aj7iyw1?=\n\t=?utf-8?q?RXcSh9hKZMNEp7cRlqShDv8ql4km/a01WOxsv63ulB5sYzck40YojF0c?=\n\t=?utf-8?q?3TK46VWgvozS7JC5kC1gjmJdO90zK5Lk3XaYt0RraglnMjSb+Wia5zqF?=\n\t=?utf-8?q?kVWZDptlbTGgFUCcxrr2UNe/m7Nzo9LMeqQc16mZB2z2KEMXbTBNfLoO?=\n\t=?utf-8?q?dSe4FQprK1G6mn2AH/M66K6Et8k2os8T6lP4G7EkycCPHXo+3Enp5D+H?=\n\t=?utf-8?q?7A8Dk3m+wBYOSvckLv2v6QIOvqsTL7uJgrCCXTmrfpp0pufdZj28AEjz?=\n\t=?utf-8?q?UE9AfhryaD3j0J1ruTjiL4NvY2XQvmO2ra9P3To8kQW++8AGrLeazcb7?=\n\t=?utf-8?q?YhEOwbkgGmuINdDZOUp0lx1NDGXMyDg1v1j+ucxICYG5WvZbS6riizOQ?=\n\t=?utf-8?q?mVE1O5utxwd37CbxwC/i4Qtu2v649Y1zrp3Kii4SEnd/k0IR1Hcu5laf?=\n\t=?utf-8?q?ufs3mD0Nor4gOe7JfRjeAxz78sSka+GlPv1sU1D0SgooNTodagAlLZ7V?=\n\t=?utf-8?q?95dWOHpaZ93yoiyXPhJLnmyIeqxO9TuYDI3CJYBgU1FPmjOD57i2JIwC?=\n\t=?utf-8?q?Jb7hj5zbmRaBKlkNsK7nsOHOOvWCTjX2zt35ftIuckdzKhYO74rHfxrA?=\n\t=?utf-8?q?kzfJwngrgzfXLiLCjF3aWomRYJw+bcmuBILq8W4mAReEmDsFWVM2Eqbr?=\n\t=?utf-8?q?ta9XWOwl32cAyK5DxQtKu/GqCQ9YNdMmFGjmEBwl99C1bl8ed6SiHXAd?=\n\t=?utf-8?q?xGmR+9V5Q4MQCtq7DTZEPVNTmxQdL/0jWvnADU60wWqzlWZPIZB5L9Df?=\n\t=?utf-8?q?071KHOSEnHnc0JdPzijSfyK/N36GU5TD1t6DAm2PjT2OTtZq9d3PbxOt?=\n\t=?utf-8?q?r8guEofWRes8c55hmfwNPOTSpGY/frh4b8TzEN+oOJ1Et7VAe5snL7L8?=\n\t=?utf-8?q?O5CAmDyvUVo0hzk0i5NTEFaQBAptkbKei6XveGARuXZBiEswI02feYS3?=\n\t=?utf-8?q?dO7wnB61KxEXvzCFPISwjdNsk5Xra3fEd7MeaVL68bCCeZpqfEdhrSmL?=\n\t=?utf-8?q?U01cRClgHQZTotR1jROXP8dtKh5HPrphM9s8w=3D=3D?=","X-OriginatorOrg":"oss.nxp.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"42eb85bd-41a9-4738-ad29-08da85c1089d","X-MS-Exchange-CrossTenant-AuthSource":"PAXPR04MB8703.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"24 Aug 2022 11:08:54.9516\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"QuXUuEArj+Nydtl6l0g4Dc24lt/De6E8JKrtHdXKKwpeLjlUsQHhWf0K15jGPJwY0PT/iNHYQO7+hBufjccseA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM0PR04MB6260","Subject":"Re: [libcamera-devel] [PATCH] gstreamer: Add support for additional\n\tRGB formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"\"Xavier Roumegue \\(OSS\\) via libcamera-devel\"\n\t","Reply-To":"\"Xavier Roumegue \\(OSS\\)\" ","Cc":"\"G.N. Zhou\" ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24762,"web_url":"https://patchwork.libcamera.org/comment/24762/","msgid":"<20220824174503.GA109174@pyrite.rasen.tech>","date":"2022-08-24T17:45:03","subject":"Re: [libcamera-devel] [PATCH] gstreamer: Add support for additional\n\tRGB formats","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Tue, Aug 23, 2022 at 09:38:56PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> libcamerasrc only supports three RGB formats. Adding the other RGB\n> formats supported by libcamera is trivial, do so.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> I haven't tested this yet as I don't have a board hooked up that can\n> capture these formats. If someone can test it with an OV5640 sensor on\n> an i.MX8MP, that would be great, otherwise I'll get to it in the not too\n> distant future.\n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 14 +++++++++++++-\n> 1 file changed, 13 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index c97c0d438de2..5a21a391c698 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -19,9 +19,21 @@ static struct {\n> \t/* Compressed */\n> \t{ GST_VIDEO_FORMAT_ENCODED, formats::MJPEG },\n> \n> -\t/* RGB */\n> +\t/* RGB16 */\n> +\t{ GST_VIDEO_FORMAT_RGB16, formats::RGB565 },\n> +\n> +\t/* RGB24 */\n> \t{ GST_VIDEO_FORMAT_RGB, formats::BGR888 },\n> \t{ GST_VIDEO_FORMAT_BGR, formats::RGB888 },\n> +\n> +\t/* RGB32 */\n> +\t{ GST_VIDEO_FORMAT_BGRx, formats::XRGB8888 },\n> +\t{ GST_VIDEO_FORMAT_RGBx, formats::XBGR8888 },\n> +\t{ GST_VIDEO_FORMAT_xBGR, formats::RGBX8888 },\n> +\t{ GST_VIDEO_FORMAT_xRGB, formats::BGRX8888 },\n> +\t{ GST_VIDEO_FORMAT_BGRA, formats::ARGB8888 },\n> +\t{ GST_VIDEO_FORMAT_RGBA, formats::ABGR8888 },\n> +\t{ GST_VIDEO_FORMAT_ABGR, formats::RGBA8888 },\n> \t{ GST_VIDEO_FORMAT_ARGB, formats::BGRA8888 },\n> \n> \t/* YUV Semiplanar */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 189B0C0DA4\n\tfor ;\n\tWed, 24 Aug 2022 17:45:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C58C61FC1;\n\tWed, 24 Aug 2022 19:45:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A871D60E25\n\tfor ;\n\tWed, 24 Aug 2022 19:45:09 +0200 (CEST)","from pyrite.rasen.tech (unknown [12.184.218.20])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F40B2B3;\n\tWed, 24 Aug 2022 19:45:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661363110;\n\tbh=Yr/5ODHAoNsH7Mnb+MTaaV4DP6qeREpTRgs/Ejn8JO0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=lRdG+EfwbR39Fl6bvg0/ZRvouF/R9+bA7kwA20vmxfzbMSyOmpMFjOd2I8gFI93gz\n\tNwwqaU/HQ3Ihba50u+NtVzCz6jy3dzhDKt4swuJ5DRPjuSjmVj9rW1fZzp3dX1Tfx9\n\tWPqbL/200D+pg2O9OkAspsjOJyjivoFVflxNhT0QUGrVOCD/L6uR7uniDptQCHL0Pp\n\trcWAcDLgxQmAPkxH688txb11Dtb0YilAvXcwFbLoXdxHqOQ6AQS9BN/3luLw8TOiyP\n\tucz3v5uKgEZrFno/+CQs3fBRgARdxLjee73IrDCr9PfJWV0jwFig/Ic+XPvLts+HHd\n\tvNnQQV1DvcGUw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661363109;\n\tbh=Yr/5ODHAoNsH7Mnb+MTaaV4DP6qeREpTRgs/Ejn8JO0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=V6wfeDDvem9b8keFZMDqajOLzCKnD06N8zNGdbDviVCq3HrlH9iOhU6rlqbyNVHH5\n\tEMV7zr5tXHI4uxc7X5Tb4tyakyhU41gk9ySFQJRv7GfqGhFbhKvEZtNgbMAKFbwXsS\n\tJkVKpCFpDjYSYTQJetp2Aod+f+WYbbbPiV7Sy3jw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"V6wfeDDv\"; dkim-atps=neutral","Date":"Wed, 24 Aug 2022 12:45:03 -0500","To":"Laurent Pinchart ","Message-ID":"<20220824174503.GA109174@pyrite.rasen.tech>","References":"<20220823183856.17944-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220823183856.17944-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] gstreamer: Add support for additional\n\tRGB formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]