[{"id":24750,"web_url":"https://patchwork.libcamera.org/comment/24750/","msgid":"<379e85c5-969d-ddb2-742a-f64340f6ee65@ideasonboard.com>","date":"2022-08-23T23:26:57","subject":"Re: [libcamera-devel] [PATCH 6/6] cam: Add color space support","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent\n\nThank you for the patch.\n\nOn 8/23/22 11:13 PM, Laurent Pinchart via libcamera-devel wrote:\n> Add support for color space to the StreamKeyValueParser, allowing\n> selection of a color space on the command line.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n\n> ---\n> src/cam/stream_options.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/src/cam/stream_options.cpp b/src/cam/stream_options.cpp\n> index a68135a9ed88..3a5625f5f267 100644\n> --- a/src/cam/stream_options.cpp\n> +++ b/src/cam/stream_options.cpp\n> @@ -8,6 +8,8 @@\n> \n> #include \n> \n> +#include \n> +\n> using namespace libcamera;\n> \n> StreamKeyValueParser::StreamKeyValueParser()\n> @@ -21,6 +23,8 @@ StreamKeyValueParser::StreamKeyValueParser()\n> \t\t ArgumentRequired);\n> \taddOption(\"pixelformat\", OptionString, \"Pixel format name\",\n> \t\t ArgumentRequired);\n> +\taddOption(\"colorspace\", OptionString, \"Color space\",\n> +\t\t ArgumentRequired);\n> }\n> \n> KeyValueParser::Options StreamKeyValueParser::parse(const char *arguments)\n> @@ -96,6 +100,9 @@ int StreamKeyValueParser::updateConfiguration(CameraConfiguration *config,\n> \n> \t\tif (opts.isSet(\"pixelformat\"))\n> \t\t\tcfg.pixelFormat = PixelFormat::fromString(opts[\"pixelformat\"].toString());\n> +\n> +\t\tif (opts.isSet(\"colorspace\"))\n> +\t\t\tcfg.colorSpace = ColorSpace::fromString(opts[\"colorspace\"].toString());\n> \t}\n> \n> \treturn 0;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2EE65C0DA4\n\tfor ;\n\tTue, 23 Aug 2022 23:27:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7473261FBD;\n\tWed, 24 Aug 2022 01:27:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BE0D61FA0\n\tfor ;\n\tWed, 24 Aug 2022 01:27:05 +0200 (CEST)","from [IPV6:2401:4900:1f3f:806e:6647:8e5c:f441:ca9a] (unknown\n\t[IPv6:2401:4900:1f3f:806e:6647:8e5c:f441:ca9a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D8202B3;\n\tWed, 24 Aug 2022 01:27:04 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661297226;\n\tbh=Y+v8X1yQLsFtL6TqnLz72hTbzyFxESnjRf07VNGJ0PY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=VPTd+aFZ9g4afI6ZT4sStKN/bQLTYyanzFn9v5k56VzWeGJviHklc/BTH83WICz+/\n\t4wY7zxFcJtwyNDAPXzDsw3SVaFqE47DJKAAijqrGnh6O7vnOe0eno2K4yWqjTSw9gJ\n\te8n4HSi682AYBLLZxD94Csl+h9Se52yqaDSixCBrko6CnAm7R9spr9ynDYd+yjTY+6\n\tzhhhRJwuJTgwER5hkvI4LTWuKrB9ozFAW5O+Q2IH6f7K+JeQzqnDWn2Xl1dDFVAe9F\n\tGQ8HFtUVKh7Rk2dHNATdX3cm2nzAkdTEv8JJJW5e/OQfoTWkvz5nYKxMFzTv4A/2r+\n\tiWiq6f9Y4GwKg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661297225;\n\tbh=Y+v8X1yQLsFtL6TqnLz72hTbzyFxESnjRf07VNGJ0PY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=NzUaXMF3KT3sXcDT86/slIdFMxzJNqHILRD2Pq5NOxqcrHQYDw9Q0pfZflJhlsGtr\n\tboZnKyP3wqKi57xh9LsV7znbanyzb971h4QCUjMFSj2EDgxxb9HJWDYLe2Xu8sdLxz\n\tY5PQDs3lwR4GFin6N6vkkEUxdMua+SRvLLrcweY0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NzUaXMF3\"; dkim-atps=neutral","Message-ID":"<379e85c5-969d-ddb2-742a-f64340f6ee65@ideasonboard.com>","Date":"Wed, 24 Aug 2022 04:56:57 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.12.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220823174314.14881-1-laurent.pinchart@ideasonboard.com>\n\t<20220823174314.14881-7-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220823174314.14881-7-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 6/6] cam: Add color space support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24780,"web_url":"https://patchwork.libcamera.org/comment/24780/","msgid":"<20220825200919.GR109174@pyrite.rasen.tech>","date":"2022-08-25T20:09:19","subject":"Re: [libcamera-devel] [PATCH 6/6] cam: Add color space support","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Tue, Aug 23, 2022 at 08:43:14PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Add support for color space to the StreamKeyValueParser, allowing\n> selection of a color space on the command line.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/cam/stream_options.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/cam/stream_options.cpp b/src/cam/stream_options.cpp\n> index a68135a9ed88..3a5625f5f267 100644\n> --- a/src/cam/stream_options.cpp\n> +++ b/src/cam/stream_options.cpp\n> @@ -8,6 +8,8 @@\n> \n> #include \n> \n> +#include \n> +\n> using namespace libcamera;\n> \n> StreamKeyValueParser::StreamKeyValueParser()\n> @@ -21,6 +23,8 @@ StreamKeyValueParser::StreamKeyValueParser()\n> \t\t ArgumentRequired);\n> \taddOption(\"pixelformat\", OptionString, \"Pixel format name\",\n> \t\t ArgumentRequired);\n> +\taddOption(\"colorspace\", OptionString, \"Color space\",\n> +\t\t ArgumentRequired);\n> }\n> \n> KeyValueParser::Options StreamKeyValueParser::parse(const char *arguments)\n> @@ -96,6 +100,9 @@ int StreamKeyValueParser::updateConfiguration(CameraConfiguration *config,\n> \n> \t\tif (opts.isSet(\"pixelformat\"))\n> \t\t\tcfg.pixelFormat = PixelFormat::fromString(opts[\"pixelformat\"].toString());\n> +\n> +\t\tif (opts.isSet(\"colorspace\"))\n> +\t\t\tcfg.colorSpace = ColorSpace::fromString(opts[\"colorspace\"].toString());\n> \t}\n> \n> \treturn 0;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47F56C3272\n\tfor ;\n\tThu, 25 Aug 2022 20:09:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1370061FBF;\n\tThu, 25 Aug 2022 22:09:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 385C961FA0\n\tfor ;\n\tThu, 25 Aug 2022 22:09:26 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2604:2d80:ad8a:9000:1bf9:855b:22de:3645])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3AEA12B3;\n\tThu, 25 Aug 2022 22:09:25 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661458167;\n\tbh=a1IARgul8EOXkuncZrmMbI5WgCb3lFF1iB4U3za9R9I=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=D0C5HfmqmdySHS3x+D1ATtty5jp4lBOSxrlK1CY4jyCG1fT2AeaWA8P8Ic0pyzZtt\n\tjp8JAsdlk9e6JSFgKfH+1wbgZvhi3APjnOtrtyOTzXM4cpV+w7zNuOJ5vTTOJV+qBF\n\tb+YmhjHgB/XOxLu1aSAqu+cwO//EG10FqZ2e2YlWt7izeNsn2ys1bK75ryXp7q0Rgc\n\thCltqe1syRdtYm5fuHJf4BenoByIKe9fBu2+PSDPCvyyotC+L7MfwDbIQiRIo1wijn\n\tOMkMWJ1gwfQH5n2lG4sDz0dOiCGFLuU0ypwTZqA36Mkm4c/Pxa7YMrTNG4PvMWx7r7\n\tf9z3Tt0oMyVaw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661458166;\n\tbh=a1IARgul8EOXkuncZrmMbI5WgCb3lFF1iB4U3za9R9I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ViXDpLN29hSDebhCVERQ3lwLIdEc9wcfafyFGB7e+TGjkWm03OxLt2UMD3mN2ovu9\n\tKwuzEND/yL+2sEjPLgp1OjRTsrthnicAB6AbFqoTeYd2Vtzsti9ketVvxsN+p4Qg9F\n\t2ObenKEvO3PrsOjkSNKlYf7Jl3eK2n/X8JIskT0Q="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ViXDpLN2\"; dkim-atps=neutral","Date":"Thu, 25 Aug 2022 15:09:19 -0500","To":"Laurent Pinchart ","Message-ID":"<20220825200919.GR109174@pyrite.rasen.tech>","References":"<20220823174314.14881-1-laurent.pinchart@ideasonboard.com>\n\t<20220823174314.14881-7-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220823174314.14881-7-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 6/6] cam: Add color space support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]