{"id":17190,"url":"https://patchwork.libcamera.org/api/patches/17190/?format=json","web_url":"https://patchwork.libcamera.org/patch/17190/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220823174314.14881-5-laurent.pinchart@ideasonboard.com>","date":"2022-08-23T17:43:12","name":"[libcamera-devel,4/6] test: Add a ColorSpace test","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"bda84e9311055327be0888e6f5053b804d8677a0","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17190/mbox/","series":[{"id":3432,"url":"https://patchwork.libcamera.org/api/series/3432/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3432","date":"2022-08-23T17:43:08","name":"libcamera: Add support for color spaces to rkisp1 pipeline handler","version":1,"mbox":"https://patchwork.libcamera.org/series/3432/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17190/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17190/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88EAFC327D\n\tfor ;\n\tTue, 23 Aug 2022 17:43:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C34A61FCE;\n\tTue, 23 Aug 2022 19:43:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B0B461FC9\n\tfor ;\n\tTue, 23 Aug 2022 19:43:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B566484\n\tfor ;\n\tTue, 23 Aug 2022 19:43:25 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661276608;\n\tbh=Q8xm+HRrwp36abDQNeAE8x0BCMzSovEjbAzWH2WvBO4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=aRaD+Vw+9M+3L2fASrmcGr5VMhTHsZmzY0uGpothbbezg4C6LOKMJg0uBxUXCh2h0\n\tJHJcpTF2fQbJ94XmALOfGK5K9YZrjNC1p6YgxXCzlwbm9twDZyUtVcVaXXQUX3PfFr\n\tzaz85Rd3offzUsN88Qh7tFa+hmNwrb2uUz+xp+i+7ZtASRekrvfKDlC6V6W74sRRuN\n\tRL1wcbWT07AS01eEhqtLy4sNVSwY6f/mxPp1W8HRHNY5kxok/OMxRn4vRII6cKzuMk\n\t9CLh72ILePnoAuo6ZRFCPBDEddkcKyabM5ctMyNBbNhMYhdhwENPqYrQM3w8JyDjva\n\t4lxTdKNy1TGqQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661276605;\n\tbh=Q8xm+HRrwp36abDQNeAE8x0BCMzSovEjbAzWH2WvBO4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=LTX2zNXsP1eUV95xfbmzZq1NAu5QENSJCbS7Jt/HqIHxRM1Oh4m3GGKZL2yeP2Lrs\n\tKj1OVIUm10OeJiLtJrZOsLVu4BmX6l2pvlml1XAHv2lKZLuJcoPApcSejKXTpQIUjH\n\tBHCHvQZ+OTdX6+qgS/3rCCW2ctY0h8QOepPURmCw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"LTX2zNXs\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 23 Aug 2022 20:43:12 +0300","Message-Id":"<20220823174314.14881-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220823174314.14881-1-laurent.pinchart@ideasonboard.com>","References":"<20220823174314.14881-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 4/6] test: Add a ColorSpace test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a test for the ColorSpace class that exercises the toString() and\nfromString() functions.\n\nSigned-off-by: Laurent Pinchart \n---\n test/color-space.cpp | 105 +++++++++++++++++++++++++++++++++++++++++++\n test/meson.build | 1 +\n 2 files changed, 106 insertions(+)\n create mode 100644 test/color-space.cpp","diff":"diff --git a/test/color-space.cpp b/test/color-space.cpp\nnew file mode 100644\nindex 000000000000..7d45b2179bca\n--- /dev/null\n+++ b/test/color-space.cpp\n@@ -0,0 +1,105 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2022, Laurent Pinchart \n+ *\n+ * libcamera ColorSpace test\n+ */\n+\n+#include \n+#include \n+\n+#include \n+\n+#include \"test.h\"\n+\n+using namespace libcamera;\n+using namespace std;\n+\n+class ColorSpaceTest : public Test\n+{\n+protected:\n+\tint run()\n+\t{\n+\t\tif (ColorSpace::toString(std::nullopt) != \"Unset\") {\n+\t\t\tstd::cerr << \"Conversion from nullopt to string failed\" << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tconst std::array, 10> colorSpaces = { {\n+\t\t\t{ ColorSpace::Raw, \"RAW\" },\n+\t\t\t{ ColorSpace::Srgb, \"sRGB\" },\n+\t\t\t{ ColorSpace::Sycc, \"sYCC\" },\n+\t\t\t{ ColorSpace::Smpte170m, \"SMPTE170M\" },\n+\t\t\t{ ColorSpace::Rec709, \"Rec709\" },\n+\t\t\t{ ColorSpace::Rec2020, \"Rec2020\" },\n+\t\t\t{\n+\t\t\t\tColorSpace{\n+\t\t\t\t\tColorSpace::Primaries::Raw,\n+\t\t\t\t\tColorSpace::TransferFunction::Linear,\n+\t\t\t\t\tColorSpace::YcbcrEncoding::None,\n+\t\t\t\t\tColorSpace::Range::Limited\n+\t\t\t\t},\n+\t\t\t\t\"RAW/Linear/None/Limited\"\n+\t\t\t}, {\n+\t\t\t\tColorSpace{\n+\t\t\t\t\tColorSpace::Primaries::Smpte170m,\n+\t\t\t\t\tColorSpace::TransferFunction::Srgb,\n+\t\t\t\t\tColorSpace::YcbcrEncoding::Rec601,\n+\t\t\t\t\tColorSpace::Range::Full\n+\t\t\t\t},\n+\t\t\t\t\"SMPTE170M/sRGB/Rec601/Full\"\n+\t\t\t}, {\n+\t\t\t\tColorSpace{\n+\t\t\t\t\tColorSpace::Primaries::Rec709,\n+\t\t\t\t\tColorSpace::TransferFunction::Rec709,\n+\t\t\t\t\tColorSpace::YcbcrEncoding::Rec709,\n+\t\t\t\t\tColorSpace::Range::Full\n+\t\t\t\t},\n+\t\t\t\t\"Rec709/Rec709/Rec709/Full\"\n+\t\t\t}, {\n+\t\t\t\tColorSpace{\n+\t\t\t\t\tColorSpace::Primaries::Rec2020,\n+\t\t\t\t\tColorSpace::TransferFunction::Linear,\n+\t\t\t\t\tColorSpace::YcbcrEncoding::Rec2020,\n+\t\t\t\t\tColorSpace::Range::Limited\n+\t\t\t\t},\n+\t\t\t\t\"Rec2020/Linear/Rec2020/Limited\"\n+\t\t\t},\n+\t\t} };\n+\n+\t\tfor (const auto &[colorSpace, name] : colorSpaces) {\n+\t\t\tif (colorSpace.toString() != name) {\n+\t\t\t\tstd::cerr\n+\t\t\t\t\t<< \"Conversion from ColorSpace to string failed: \"\n+\t\t\t\t\t<< \"expected \" << name\n+\t\t\t\t\t<< \", got \" << colorSpace.toString()\n+\t\t\t\t\t<< std::endl;\n+\t\t\t\treturn TestFail;\n+\t\t\t}\n+\n+\t\t\tif (ColorSpace::fromString(name) != colorSpace) {\n+\t\t\t\tstd::cerr\n+\t\t\t\t\t<< \"Conversion from string \"\n+\t\t\t\t\t<< name << \" to ColorSpace failed\"\n+\t\t\t\t\t<< std::endl;\n+\t\t\t\treturn TestFail;\n+\t\t\t}\n+\t\t}\n+\n+\t\tif (ColorSpace::fromString(\"Invalid\")) {\n+\t\t\tstd::cerr << \"Conversion from invalid name string to color space succeeded\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (ColorSpace::fromString(\"Rec709/Rec709/Rec710/Limited\")) {\n+\t\t\tstd::cerr << \"Conversion from invalid component string to color space succeeded\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\treturn TestPass;\n+\t}\n+};\n+\n+TEST_REGISTER(ColorSpaceTest)\ndiff --git a/test/meson.build b/test/meson.build\nindex d050bfa14cec..6cc778415dc8 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -26,6 +26,7 @@ subdir('v4l2_subdevice')\n subdir('v4l2_videodevice')\n \n public_tests = [\n+ ['color-space', 'color-space.cpp'],\n ['geometry', 'geometry.cpp'],\n ['public-api', 'public-api.cpp'],\n ['signal', 'signal.cpp'],\n","prefixes":["libcamera-devel","4/6"]}