[{"id":2352,"web_url":"https://patchwork.libcamera.org/comment/2352/","msgid":"<20190808220120.GI6055@pendragon.ideasonboard.com>","date":"2019-08-08T22:01:20","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: RKISP1\n\tconfigure isp output pad","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Helen,\n\nThank you for the patch, and sorry for the late reply.\n\nOn Tue, Jul 30, 2019 at 04:10:07PM -0300, Helen Koike wrote:\n> ISP output pad should be set to YUYV8_2X8 for non-bayer output format.\n> Bayer formats are not listed in RkISP1CameraConfiguration::validate(),\n> only non-bayer are listed, so we can set YUYV8_2X8 directly.\n> This need to be changed if we add support for bayer output with\n\ns/need/needs/\n\n> libcamera.\n> \n> Signed-off-by: Helen Koike <helen.koike@collabora.com>\n> \n> ---\n> \n> Hi,\n> \n> I'm re-sending this patch standalone as Laurent suggested.\n> \n> Thanks\n> Helen\n> ---\n>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 14 ++++++++++++++\n>  1 file changed, 14 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index efa9604..bc7cb3f 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -286,6 +286,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n>  \tif (ret < 0)\n>  \t\treturn ret;\n>  \n> +\tLOG(RkISP1, Debug) << \"Configuring ISP input pad with \" << format.toString();\n> +\n>  \tret = dphy_->getFormat(1, &format);\n>  \tif (ret < 0)\n>  \t\treturn ret;\n> @@ -294,6 +296,18 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n>  \tif (ret < 0)\n>  \t\treturn ret;\n>  \n> +\tLOG(RkISP1, Debug) << \"ISP input pad configured with \" << format.toString();\n> +\n> +\t/* YUYV8_2X8 is required in ISP pad 1 for non-bayer output */\n\ns/output/output./\n\nAccording to the code below, isn't this pad 2 ? I would write \"YUYV8_2X8\nis required on the ISP source path pad for YUV output.\".\n\nApart from that,\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nPlease let me know if you are fine with those small changes, I will then\nadd them when applying the patch.\n\nNiklas, I know you have a running environment for the Scarlet tablet,\nwould you be able to test this patch ?\n\n> +\tformat.mbus_code = MEDIA_BUS_FMT_YUYV8_2X8;\n> +\tLOG(RkISP1, Debug) << \"Configuring ISP output pad with \" << format.toString();\n> +\n> +\tret = isp_->setFormat(2, &format);\n> +\tif (ret < 0)\n> +\t\treturn ret;\n> +\n> +\tLOG(RkISP1, Debug) << \"ISP output pad configured with \" << format.toString();\n> +\n>  \tV4L2DeviceFormat outputFormat = {};\n>  \toutputFormat.fourcc = cfg.pixelFormat;\n>  \toutputFormat.size = cfg.size;","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD1D76161B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  9 Aug 2019 00:01:23 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1FD0DCC;\n\tFri,  9 Aug 2019 00:01:23 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565301683;\n\tbh=Jwec+FYNvKvshznzMaty0R3H9hOOfzYxQ78PAlg3QSs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HNX/5wyiZN2tebA/Ga4Odwj8cQG2PU/BbHKYDfrpLZmE+NW0A0UFXqrZyfJSL7fo5\n\tJZxad1u6pbDnr74MCG00bgsuI240uVxyOxVHKw9Y7FeNTPL+XU4egLUHw54tNAAQjw\n\tBdKALCJilqu0TDS0UFQAZn5e9HeBAfc2OUDWhQK0=","Date":"Fri, 9 Aug 2019 01:01:20 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Helen Koike <helen.koike@collabora.com>","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com","Message-ID":"<20190808220120.GI6055@pendragon.ideasonboard.com>","References":"<8ad5a0874203dacfd488fe6827e3feab14dc959c.1564513804.git.helen.koike@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<8ad5a0874203dacfd488fe6827e3feab14dc959c.1564513804.git.helen.koike@collabora.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: RKISP1\n\tconfigure isp output pad","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 08 Aug 2019 22:01:23 -0000"}},{"id":2353,"web_url":"https://patchwork.libcamera.org/comment/2353/","msgid":"<12e56dea-c9b8-df5a-5702-e78366819856@collabora.com>","date":"2019-08-09T01:31:58","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: RKISP1\n\tconfigure isp output pad","submitter":{"id":20,"url":"https://patchwork.libcamera.org/api/people/20/","name":"Helen Koike","email":"helen.koike@collabora.com"},"content":"Hi Laurent,\n\nOn 8/8/19 7:01 PM, Laurent Pinchart wrote:\n> Hi Helen,\n> \n> Thank you for the patch, and sorry for the late reply.\n\nno problem, thanks for reviewing.\n\n> \n> On Tue, Jul 30, 2019 at 04:10:07PM -0300, Helen Koike wrote:\n>> ISP output pad should be set to YUYV8_2X8 for non-bayer output format.\n>> Bayer formats are not listed in RkISP1CameraConfiguration::validate(),\n>> only non-bayer are listed, so we can set YUYV8_2X8 directly.\n>> This need to be changed if we add support for bayer output with\n> \n> s/need/needs/\n> \n>> libcamera.\n>>\n>> Signed-off-by: Helen Koike <helen.koike@collabora.com>\n>>\n>> ---\n>>\n>> Hi,\n>>\n>> I'm re-sending this patch standalone as Laurent suggested.\n>>\n>> Thanks\n>> Helen\n>> ---\n>>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 14 ++++++++++++++\n>>  1 file changed, 14 insertions(+)\n>>\n>> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> index efa9604..bc7cb3f 100644\n>> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> @@ -286,6 +286,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n>>  \tif (ret < 0)\n>>  \t\treturn ret;\n>>  \n>> +\tLOG(RkISP1, Debug) << \"Configuring ISP input pad with \" << format.toString();\n>> +\n>>  \tret = dphy_->getFormat(1, &format);\n>>  \tif (ret < 0)\n>>  \t\treturn ret;\n>> @@ -294,6 +296,18 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n>>  \tif (ret < 0)\n>>  \t\treturn ret;\n>>  \n>> +\tLOG(RkISP1, Debug) << \"ISP input pad configured with \" << format.toString();\n>> +\n>> +\t/* YUYV8_2X8 is required in ISP pad 1 for non-bayer output */\n> \n> s/output/output./\n> \n> According to the code below, isn't this pad 2 ? I would write \"YUYV8_2X8\n> is required on the ISP source path pad for YUV output.\".\n\nYes, it is pad 1, sorry about that\n\n> \n> Apart from that,\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> Please let me know if you are fine with those small changes, I will then\n> add them when applying the patch.\n\nYes, I'm fine with those changes, thanks!\n\nRegards,\nHelen\n\n> \n> Niklas, I know you have a running environment for the Scarlet tablet,\n> would you be able to test this patch ?\n> \n>> +\tformat.mbus_code = MEDIA_BUS_FMT_YUYV8_2X8;\n>> +\tLOG(RkISP1, Debug) << \"Configuring ISP output pad with \" << format.toString();\n>> +\n>> +\tret = isp_->setFormat(2, &format);\n>> +\tif (ret < 0)\n>> +\t\treturn ret;\n>> +\n>> +\tLOG(RkISP1, Debug) << \"ISP output pad configured with \" << format.toString();\n>> +\n>>  \tV4L2DeviceFormat outputFormat = {};\n>>  \toutputFormat.fourcc = cfg.pixelFormat;\n>>  \toutputFormat.size = cfg.size;\n>","headers":{"Return-Path":"<helen.koike@collabora.com>","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF04B61583\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  9 Aug 2019 03:32:10 +0200 (CEST)","from [IPv6:2804:431:c7f0:147a:f399:8d3e:aaa4:10a8] (unknown\n\t[IPv6:2804:431:c7f0:147a:f399:8d3e:aaa4:10a8])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: koike)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 7FD0D28B449;\n\tFri,  9 Aug 2019 02:32:07 +0100 (BST)"],"To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com","References":"<8ad5a0874203dacfd488fe6827e3feab14dc959c.1564513804.git.helen.koike@collabora.com>\n\t<20190808220120.GI6055@pendragon.ideasonboard.com>","From":"Helen Koike <helen.koike@collabora.com>","Openpgp":"preference=signencrypt","Autocrypt":"addr=helen.koike@collabora.com; keydata=\n\tmQINBFmOMD4BEADb2nC8Oeyvklh+ataw2u/3mrl+hIHL4WSWtii4VxCapl9+zILuxFDrxw1p\n\tXgF3cfx7g9taWBrmLE9VEPwJA6MxaVnQuDL3GXxTxO/gqnOFgT3jT+skAt6qMvoWnhgurMGH\n\twRaA3dO4cFrDlLsZIdDywTYcy7V2bou81ItR5Ed6c5UVX7uTTzeiD/tUi8oIf0XN4takyFuV\n\tRf09nOhi24bn9fFN5xWHJooFaFf/k2Y+5UTkofANUp8nn4jhBUrIr6glOtmE0VT4pZMMLT63\n\thyRB+/s7b1zkOofUGW5LxUg+wqJXZcOAvjocqSq3VVHcgyxdm+Nv0g9Hdqo8bQHC2KBK86VK\n\tvB+R7tfv7NxVhG1sTW3CQ4gZb0ZugIWS32Mnr+V+0pxci7QpV3jrtVp5W2GA5HlXkOyC6C7H\n\tAo7YhogtvFehnlUdG8NrkC3HhCTF8+nb08yGMVI4mMZ9v/KoIXKC6vT0Ykz434ed9Oc9pDow\n\tVUqaKi3ey96QczfE4NI029bmtCY4b5fucaB/aVqWYRH98Jh8oIQVwbt+pY7cL5PxS7dQ/Zuz\n\t6yheqDsUGLev1O3E4R8RZ8jPcfCermL0txvoXXIA56t4ZjuHVcWEe2ERhLHFGq5Zw7KC6u12\n\tkJoiZ6WDBYo4Dp+Gd7a81/WsA33Po0j3tk/8BWoiJCrjXzhtRwARAQABtCdIZWxlbiBLb2lr\n\tZSA8aGVsZW4ua29pa2VAY29sbGFib3JhLmNvbT6JAlQEEwEKAD4CGwEFCwkIBwMFFQoJCAsF\n\tFgIDAQACHgECF4AWIQSofQA6zrItXEgHWTzAfqwo9yFiXQUCXEz3bwUJBKaPRQAKCRDAfqwo\n\t9yFiXdUCD/4+WZr503hQ13KB4DijOW76ju8JDPp4p++qoPxtoAsld3yROoTI+VPWmt7ojHrr\n\tTZc7sTLxOFzaUC8HjGTb3r9ilIhIKf/M9KRLkpIJ+iLA+VoUbcSOMYWoVNfgLmbnqoezjPcy\n\tOHJwVw9dzEeYpvG6nkY6E4UktANySp27AniSXNuHOvYsOsXmUOqU1ScdsrQ9s732p/OGdTyw\n\t1yd3gUMLZvCKFOBVHILH59HCRJgpwUPiws8G4dGMs4GTRvHT2s2mDQdQ0HEvcM9rvCRVixuC\n\t5ZeOymZNi6lDIUIysgiZ+yzk6i5l/Ni6r7v20N3JppZvhPK6LqtaYceyAGyc3jjnOqoHT/qR\n\tkPjCwzmKiPtXjLw6HbRXtGgGtP5m3y8v6bfHH+66zd2vGCY0Z9EsqcnK4DCqRkLncFLPM2gn\n\t9cZcCmO4ZqXUhTyn1nHM494kd5NX1Op4HO+t9ErnpufkVjoMUeBwESdQwwwHT3rjUueGmCrn\n\tVJK69/qhA4La72VTxHutl+3Z0Xy20HWsZS8Gsam39f95/LtPLzbBwnOOi5ZoXnm97tF8HrAZ\n\t2h+kcRLMWw3BXy5q4gic+oFZMZP9oq1G9XTFld4FGgJ9ys8aGmhLM+uB1pFxb3XFtWQ2z4AJ\n\tiEp2VLl34quwfD6Gg4csiZe2KzvQHUe0w8SJ9LplrHPPprkCDQRZjjChARAAzISLQaHzaDOv\n\tZxcoCNBk/hUGo2/gsmBW4KSj73pkStZ+pm3Yv2CRtOD4jBlycXjzhwBV7/70ZMH70/Y25dJa\n\tCnJKl/Y76dPPn2LDWrG/4EkqUzoJkhRIYFUTpkPdaVYznqLgsho19j7HpEbAum8r3jemYBE1\n\tAIuVGg4bqY3UkvuHWLVRMuaHZNy55aYwnUvd46E64JH7O990mr6t/nu2a1aJ0BDdi8HZ0RMo\n\tEg76Avah+YR9fZrhDFmBQSL+mcCVWEbdiOzHmGYFoToqzM52wsNEpo2aStH9KLk8zrCXGx68\n\tohJyQoALX4sS03RIWh1jFjnlw2FCbEdj/HDX0+U0i9COtanm54arYXiBTnAnx0F7LW7pv7sb\n\t6tKMxsMLmprP/nWyV5AfFRi3jxs5tdwtDDk/ny8WH6KWeLR/zWDwpYgnXLBCdg8l97xUoPQO\n\t0VkKSa4JEXUZWZx9q6kICzFGsuqApqf9gIFJZwUmirsxH80Fe04Tv+IqIAW7/djYpOqGjSyk\n\toaEVNacwLLgZr+/j69/1ZwlbS8K+ChCtyBV4kEPzltSRZ4eU19v6sDND1JSTK9KSDtCcCcAt\n\tVGFlr4aE00AD/aOkHSylc93nPinBFO4AGhcs4WypZ3GGV6vGWCpJy9svfWsUDhSwI7GS/i/v\n\tUQ1+bswyYEY1Q3DjJqT7fXcAEQEAAYkEcgQYAQoAJgIbAhYhBKh9ADrOsi1cSAdZPMB+rCj3\n\tIWJdBQJcTPfVBQkEpo7hAkDBdCAEGQEKAB0WIQSomGMEg78Cd/pMshveCRfNeJ05lgUCWY4w\n\toQAKCRDeCRfNeJ05lp0gD/49i95kPKjpgjUbYeidjaWuINXMCA171KyaBAp+Jp2Qrun4sIJB\n\tZ6srMj6O/gC34AhZln2sXeQdxe88sNbg6HjlN+4AkhTd6DttjOfUwnamLDA7uw+YIapGgsgN\n\tlznjLnqOaQ9mtEwRbZMUOdyRf9osSuL14vHl4ia3bYNJ52WYre6gLMu4K+Ghd02og+ILgIio\n\tQ827h0spqIJYHrR3Ynnhxdlv5GPCobh+AKsQMdTIuCzR6JSCBk6GHkg33SiWScKMUzT8B/cn\n\typLfGnfV/LDZ9wS2TMzIlK/uv0Vd4C0OGDd/GCi5Gwu/Ot0aY7fzZo2CiRV+/nJBWPRRBTji\n\tbE4FG2rt7WSRLO/QmH2meIW4f0USDiHeNwznHkPei59vRdlMyQdsxrmgSRDuX9Y3UkERxbgd\n\tuscqC8Cpcy5kpF11EW91J8aGpcxASc+5Pa66/+7CrpBC2DnfcfACdMAje7yeMn9XlHrqXNlQ\n\tGaglEcnGN2qVqRcKgcjJX+ur8l56BVpBPFYQYkYkIdQAuhlPylxOvsMcqI6VoEWNt0iFF3dA\n\t//0MNb8fEqw5TlxDPOt6BDhDKowkxOGIA9LOcF4PkaR9Qkvwo2P4vA/8fhCnMqlSPom4xYdk\n\tEv8P554zDoL/XMHl+s7A0MjIJzT253ejZKlWeO68pAbNy/z7QRn2lFDnjwkQwH6sKPchYl2f\n\t0g//Yu3vDkqk8+mi2letP3XBl2hjv2eCZjTh34VvtgY5oeL2ROSJWNd18+7O6q3hECZ727EW\n\tgIb3LK9g4mKF6+Rch6Gwz1Y4fmC5554fd2Y2XbVzzz6AGUC6Y+ohNg7lTAVO4wu43+IyTB8u\n\tip5rX/JDGFv7Y1sl6tQJKAVIKAJE+Z3Ncqh3doQr9wWHl0UiQYKbSR9HpH1lmC1C3EEbTpwK\n\tfUIpZd1eQNyNJl1jHsZZIBYFsAfVNH/u6lB1TU+9bSOsV5SepdIb88d0fm3oZ4KzjhRHLFQF\n\tRwNUNn3ha6x4fbxYcwbvu5ZCiiX6yRTPoage/LUNkgQNX2PtPcur6CdxK6Pqm8EAI7PmYLfN\n\tNY3y01XhKNRvaVZoH2FugfUkhsBITglTIpI+n6YU06nDAcbeINFo67TSE0iL6Pek5a6gUQQC\n\t6w+hJCaMr8KYud0q3ccHyU3TlAPDe10En3GsVz7Y5Sa3ODGdbmkfjK8Af3ogGNBVmpV16Xl8\n\t4rETFv7POSUB2eMtbpmBopd+wKqHCwUEy3fx1zDbM9mp+pcDoL73rRZmlgmNfW/4o4qBzxRf\n\tFYTQLE69wAFU2IFce9PjtUAlBdC+6r3X24h3uD+EC37s/vWhxuKj2glaU9ONrVJ/SPvlqXOO\n\tWR1Zqw57vHMKimLdG3c24l8PkSw1usudgAA5OyO5Ag0EWY4wyQEQAMVp0U38Le7d80Mu6AT+\n\t1dMes87iKn30TdMuLvSg2uYqJ1T2riRBF7zU6u74HF6zps0rPQviBXOgoSuKa1hnS6OwFb9x\n\tyQPlk76LY96SUB5jPWJ3fO78ZGSwkVbJFuG9gpD/41n8Unn1hXgDb2gUaxD0oXv/723EmTYC\n\tvSo3z6Y8A2aBQNr+PyhQAPDazvVQ+P7vnZYq1oK0w+D7aIix/Bp4mo4VbgAeAeMxXWSZs8N5\n\tNQtXeTBgB7DqrfJP5wWwgCsROfeds6EoddcYgqhG0zVU9E54C8JcPOA0wKVs+9+gt2eyRNtx\n\t0UhFbah7qXuJGhWy/0CLXvVoCoS+7qpWz070TBAlPZrg9D0o2gOw01trQgoKAYBKKgJhxaX/\n\t4gzi+5Ccm33LYH9lAVTdzdorejuV1xWdsnNyc8OAPeoXBf9RIIWfQVmbhVXBp2DAPjV6/kIJ\n\tEml7MNJfEvqjV9zKsWF9AFlsqDWZDCyUdqR96ahTSD34pRwb6a9H99/GrjeowKaaL95DIVZT\n\tC6STvDNL6kpys4sOe2AMmQGv2MMcJB3aYLzH8f1sEQ9S0UMX7/6CifEG6JodG6Y/W/lLo1Vv\n\tDxeDA+u4Lgq6qxlksp8M78FjcmxFVlf4cpCi2ucbZxurhlBkjtZZ8MVAEde3hlqjcBl2Ah6Q\n\tD826FTxscOGlHEfNABEBAAGJAjwEGAEKACYCGwwWIQSofQA6zrItXEgHWTzAfqwo9yFiXQUC\n\tXEz31QUJBKaOuQAKCRDAfqwo9yFiXUvnEACBWe8wSnIvSX+9k4LxuLq6GQTOt+RNfliZQkCW\n\t5lT3KL1IJyzzOm4x+/slHRBl8bF7KEZyOPinXQXyJ/vgIdgSYxDqoZ7YZn3SvuNe4aT6kGwL\n\tEYYEV8Ecj4ets15FR2jSUNnVv5YHWtZ7bP/oUzr2LT54fjRcstYxgwzoj8AREtHQ4EJWAWCO\n\tZuEHTSm5clMFoi41CmG4DlJbzbo4YfilKYm69vwh50Y8WebcRN31jh0g8ufjOJnBldYYBLwN\n\tObymhlfy/HKBDIbyCGBuwYoAkoJ6LR/cqzl/FuhwhuDocCGlXyYaJOwXgHaCvVXI3PLQPxWZ\n\t+vPsD+TSVHc9m/YWrOiYDnZn6aO0Uk1Zv/m9+BBkWAwsreLJ/evn3SsJV1omNBTITG+uxXcf\n\tJkgmmesIAw8mpI6EeLmReUJLasz8QkzhZIC7t5rGlQI94GQG3Jg2dC+kpaGWOaT5G4FVMcBj\n\tiR1nXfMxENVYnM5ag7mBZyD/kru5W1Uj34L6AFaDMXFPwedSCpzzqUiHb0f+nYkfOodf5xy0\n\t46+3THy/NUS/ZZp/rI4F7Y77+MQPVg7vARfHHX1AxYUKfRVW5j88QUB70txn8Vgi1tDrOr4J\n\teD+xr0CvIGa5lKqgQacQtGkpOpJ8zY4ObSvpNubey/qYUE3DCXD0n2Xxk4muTvqlkFpOYA==","Message-ID":"<12e56dea-c9b8-df5a-5702-e78366819856@collabora.com>","Date":"Thu, 8 Aug 2019 22:31:58 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.2","MIME-Version":"1.0","In-Reply-To":"<20190808220120.GI6055@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: RKISP1\n\tconfigure isp output pad","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 09 Aug 2019 01:32:11 -0000"}},{"id":2369,"web_url":"https://patchwork.libcamera.org/comment/2369/","msgid":"<20190809192616.GF5007@pendragon.ideasonboard.com>","date":"2019-08-09T19:26:16","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: RKISP1\n\tconfigure isp output pad","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Helen,\n\nOn Thu, Aug 08, 2019 at 10:31:58PM -0300, Helen Koike wrote:\n> On 8/8/19 7:01 PM, Laurent Pinchart wrote:\n> > Hi Helen,\n> > \n> > Thank you for the patch, and sorry for the late reply.\n> \n> no problem, thanks for reviewing.\n> \n> > On Tue, Jul 30, 2019 at 04:10:07PM -0300, Helen Koike wrote:\n> >> ISP output pad should be set to YUYV8_2X8 for non-bayer output format.\n> >> Bayer formats are not listed in RkISP1CameraConfiguration::validate(),\n> >> only non-bayer are listed, so we can set YUYV8_2X8 directly.\n> >> This need to be changed if we add support for bayer output with\n> > \n> > s/need/needs/\n> > \n> >> libcamera.\n> >>\n> >> Signed-off-by: Helen Koike <helen.koike@collabora.com>\n> >>\n> >> ---\n> >>\n> >> Hi,\n> >>\n> >> I'm re-sending this patch standalone as Laurent suggested.\n> >>\n> >> Thanks\n> >> Helen\n> >> ---\n> >>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 14 ++++++++++++++\n> >>  1 file changed, 14 insertions(+)\n> >>\n> >> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> >> index efa9604..bc7cb3f 100644\n> >> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> >> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> >> @@ -286,6 +286,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> >>  \tif (ret < 0)\n> >>  \t\treturn ret;\n> >>  \n> >> +\tLOG(RkISP1, Debug) << \"Configuring ISP input pad with \" << format.toString();\n> >> +\n> >>  \tret = dphy_->getFormat(1, &format);\n> >>  \tif (ret < 0)\n> >>  \t\treturn ret;\n> >> @@ -294,6 +296,18 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> >>  \tif (ret < 0)\n> >>  \t\treturn ret;\n> >>  \n> >> +\tLOG(RkISP1, Debug) << \"ISP input pad configured with \" << format.toString();\n> >> +\n> >> +\t/* YUYV8_2X8 is required in ISP pad 1 for non-bayer output */\n> > \n> > s/output/output./\n> > \n> > According to the code below, isn't this pad 2 ? I would write \"YUYV8_2X8\n> > is required on the ISP source path pad for YUV output.\".\n> \n> Yes, it is pad 1, sorry about that\n\nDo you mean the comment is right and the code should be changed ?\n\n> > Apart from that,\n> > \n> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > \n> > Please let me know if you are fine with those small changes, I will then\n> > add them when applying the patch.\n> \n> Yes, I'm fine with those changes, thanks!\n> \n> > Niklas, I know you have a running environment for the Scarlet tablet,\n> > would you be able to test this patch ?\n> > \n> >> +\tformat.mbus_code = MEDIA_BUS_FMT_YUYV8_2X8;\n> >> +\tLOG(RkISP1, Debug) << \"Configuring ISP output pad with \" << format.toString();\n> >> +\n> >> +\tret = isp_->setFormat(2, &format);\n> >> +\tif (ret < 0)\n> >> +\t\treturn ret;\n> >> +\n> >> +\tLOG(RkISP1, Debug) << \"ISP output pad configured with \" << format.toString();\n> >> +\n> >>  \tV4L2DeviceFormat outputFormat = {};\n> >>  \toutputFormat.fourcc = cfg.pixelFormat;\n> >>  \toutputFormat.size = cfg.size;","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0E7460E2F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  9 Aug 2019 21:26:19 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 46C74CC;\n\tFri,  9 Aug 2019 21:26:19 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565378779;\n\tbh=sVrfem0wDBoY1tZbLBzrvxFdqMlsk/FAPY7dNwRvFD8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rhGHFdO2VpMDnnpdT5tmcjAsvLpfzIFZxiLiPAkZjH3tO9/anL1I0EGR+gYCxDhOH\n\tkckrP1Y6x/nuHLsWkYKmwBjN21LniAnDBL62pQ3Dxpv3EVuKRQApYyF61+Os+mJzVc\n\tRyCJcragI0M9cn+KKxZbghwLPhEK5DHHZ6MbK4q0=","Date":"Fri, 9 Aug 2019 22:26:16 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Helen Koike <helen.koike@collabora.com>","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com","Message-ID":"<20190809192616.GF5007@pendragon.ideasonboard.com>","References":"<8ad5a0874203dacfd488fe6827e3feab14dc959c.1564513804.git.helen.koike@collabora.com>\n\t<20190808220120.GI6055@pendragon.ideasonboard.com>\n\t<12e56dea-c9b8-df5a-5702-e78366819856@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<12e56dea-c9b8-df5a-5702-e78366819856@collabora.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: RKISP1\n\tconfigure isp output pad","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 09 Aug 2019 19:26:20 -0000"}},{"id":2370,"web_url":"https://patchwork.libcamera.org/comment/2370/","msgid":"<63c18f71-9e0c-72cd-94d3-27f4a046ae0f@collabora.com>","date":"2019-08-09T22:16:23","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: RKISP1\n\tconfigure isp output pad","submitter":{"id":20,"url":"https://patchwork.libcamera.org/api/people/20/","name":"Helen Koike","email":"helen.koike@collabora.com"},"content":"On 8/9/19 4:26 PM, Laurent Pinchart wrote:\n> Hi Helen,\n> \n> On Thu, Aug 08, 2019 at 10:31:58PM -0300, Helen Koike wrote:\n>> On 8/8/19 7:01 PM, Laurent Pinchart wrote:\n>>> Hi Helen,\n>>>\n>>> Thank you for the patch, and sorry for the late reply.\n>>\n>> no problem, thanks for reviewing.\n>>\n>>> On Tue, Jul 30, 2019 at 04:10:07PM -0300, Helen Koike wrote:\n>>>> ISP output pad should be set to YUYV8_2X8 for non-bayer output format.\n>>>> Bayer formats are not listed in RkISP1CameraConfiguration::validate(),\n>>>> only non-bayer are listed, so we can set YUYV8_2X8 directly.\n>>>> This need to be changed if we add support for bayer output with\n>>>\n>>> s/need/needs/\n>>>\n>>>> libcamera.\n>>>>\n>>>> Signed-off-by: Helen Koike <helen.koike@collabora.com>\n>>>>\n>>>> ---\n>>>>\n>>>> Hi,\n>>>>\n>>>> I'm re-sending this patch standalone as Laurent suggested.\n>>>>\n>>>> Thanks\n>>>> Helen\n>>>> ---\n>>>>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 14 ++++++++++++++\n>>>>  1 file changed, 14 insertions(+)\n>>>>\n>>>> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>>>> index efa9604..bc7cb3f 100644\n>>>> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>>>> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>>>> @@ -286,6 +286,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n>>>>  \tif (ret < 0)\n>>>>  \t\treturn ret;\n>>>>  \n>>>> +\tLOG(RkISP1, Debug) << \"Configuring ISP input pad with \" << format.toString();\n>>>> +\n>>>>  \tret = dphy_->getFormat(1, &format);\n>>>>  \tif (ret < 0)\n>>>>  \t\treturn ret;\n>>>> @@ -294,6 +296,18 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n>>>>  \tif (ret < 0)\n>>>>  \t\treturn ret;\n>>>>  \n>>>> +\tLOG(RkISP1, Debug) << \"ISP input pad configured with \" << format.toString();\n>>>> +\n>>>> +\t/* YUYV8_2X8 is required in ISP pad 1 for non-bayer output */\n>>>\n>>> s/output/output./\n>>>\n>>> According to the code below, isn't this pad 2 ? I would write \"YUYV8_2X8\n>>> is required on the ISP source path pad for YUV output.\".\n>>\n>> Yes, it is pad 1, sorry about that\n> \n> Do you mean the comment is right and the code should be changed ?\n\nOps, sorry again for this confusion, it is pad 2 (I don't know why I wrote pad 1),\nthe code is right, the comment should be changed.\n\nThanks\nHelen\n\n> \n>>> Apart from that,\n>>>\n>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>>>\n>>> Please let me know if you are fine with those small changes, I will then\n>>> add them when applying the patch.\n>>\n>> Yes, I'm fine with those changes, thanks!\n>>\n>>> Niklas, I know you have a running environment for the Scarlet tablet,\n>>> would you be able to test this patch ?\n>>>\n>>>> +\tformat.mbus_code = MEDIA_BUS_FMT_YUYV8_2X8;\n>>>> +\tLOG(RkISP1, Debug) << \"Configuring ISP output pad with \" << format.toString();\n>>>> +\n>>>> +\tret = isp_->setFormat(2, &format);\n>>>> +\tif (ret < 0)\n>>>> +\t\treturn ret;\n>>>> +\n>>>> +\tLOG(RkISP1, Debug) << \"ISP output pad configured with \" << format.toString();\n>>>> +\n>>>>  \tV4L2DeviceFormat outputFormat = {};\n>>>>  \toutputFormat.fourcc = cfg.pixelFormat;\n>>>>  \toutputFormat.size = cfg.size;\n>","headers":{"Return-Path":"<helen.koike@collabora.com>","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BDE460E2F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 10 Aug 2019 00:16:31 +0200 (CEST)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: koike) with ESMTPSA id 4142B28CEF2"],"To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com","References":"<8ad5a0874203dacfd488fe6827e3feab14dc959c.1564513804.git.helen.koike@collabora.com>\n\t<20190808220120.GI6055@pendragon.ideasonboard.com>\n\t<12e56dea-c9b8-df5a-5702-e78366819856@collabora.com>\n\t<20190809192616.GF5007@pendragon.ideasonboard.com>","From":"Helen Koike <helen.koike@collabora.com>","Openpgp":"preference=signencrypt","Autocrypt":"addr=helen.koike@collabora.com; keydata=\n\tmQINBFmOMD4BEADb2nC8Oeyvklh+ataw2u/3mrl+hIHL4WSWtii4VxCapl9+zILuxFDrxw1p\n\tXgF3cfx7g9taWBrmLE9VEPwJA6MxaVnQuDL3GXxTxO/gqnOFgT3jT+skAt6qMvoWnhgurMGH\n\twRaA3dO4cFrDlLsZIdDywTYcy7V2bou81ItR5Ed6c5UVX7uTTzeiD/tUi8oIf0XN4takyFuV\n\tRf09nOhi24bn9fFN5xWHJooFaFf/k2Y+5UTkofANUp8nn4jhBUrIr6glOtmE0VT4pZMMLT63\n\thyRB+/s7b1zkOofUGW5LxUg+wqJXZcOAvjocqSq3VVHcgyxdm+Nv0g9Hdqo8bQHC2KBK86VK\n\tvB+R7tfv7NxVhG1sTW3CQ4gZb0ZugIWS32Mnr+V+0pxci7QpV3jrtVp5W2GA5HlXkOyC6C7H\n\tAo7YhogtvFehnlUdG8NrkC3HhCTF8+nb08yGMVI4mMZ9v/KoIXKC6vT0Ykz434ed9Oc9pDow\n\tVUqaKi3ey96QczfE4NI029bmtCY4b5fucaB/aVqWYRH98Jh8oIQVwbt+pY7cL5PxS7dQ/Zuz\n\t6yheqDsUGLev1O3E4R8RZ8jPcfCermL0txvoXXIA56t4ZjuHVcWEe2ERhLHFGq5Zw7KC6u12\n\tkJoiZ6WDBYo4Dp+Gd7a81/WsA33Po0j3tk/8BWoiJCrjXzhtRwARAQABtCdIZWxlbiBLb2lr\n\tZSA8aGVsZW4ua29pa2VAY29sbGFib3JhLmNvbT6JAlQEEwEKAD4CGwEFCwkIBwMFFQoJCAsF\n\tFgIDAQACHgECF4AWIQSofQA6zrItXEgHWTzAfqwo9yFiXQUCXEz3bwUJBKaPRQAKCRDAfqwo\n\t9yFiXdUCD/4+WZr503hQ13KB4DijOW76ju8JDPp4p++qoPxtoAsld3yROoTI+VPWmt7ojHrr\n\tTZc7sTLxOFzaUC8HjGTb3r9ilIhIKf/M9KRLkpIJ+iLA+VoUbcSOMYWoVNfgLmbnqoezjPcy\n\tOHJwVw9dzEeYpvG6nkY6E4UktANySp27AniSXNuHOvYsOsXmUOqU1ScdsrQ9s732p/OGdTyw\n\t1yd3gUMLZvCKFOBVHILH59HCRJgpwUPiws8G4dGMs4GTRvHT2s2mDQdQ0HEvcM9rvCRVixuC\n\t5ZeOymZNi6lDIUIysgiZ+yzk6i5l/Ni6r7v20N3JppZvhPK6LqtaYceyAGyc3jjnOqoHT/qR\n\tkPjCwzmKiPtXjLw6HbRXtGgGtP5m3y8v6bfHH+66zd2vGCY0Z9EsqcnK4DCqRkLncFLPM2gn\n\t9cZcCmO4ZqXUhTyn1nHM494kd5NX1Op4HO+t9ErnpufkVjoMUeBwESdQwwwHT3rjUueGmCrn\n\tVJK69/qhA4La72VTxHutl+3Z0Xy20HWsZS8Gsam39f95/LtPLzbBwnOOi5ZoXnm97tF8HrAZ\n\t2h+kcRLMWw3BXy5q4gic+oFZMZP9oq1G9XTFld4FGgJ9ys8aGmhLM+uB1pFxb3XFtWQ2z4AJ\n\tiEp2VLl34quwfD6Gg4csiZe2KzvQHUe0w8SJ9LplrHPPprkCDQRZjjChARAAzISLQaHzaDOv\n\tZxcoCNBk/hUGo2/gsmBW4KSj73pkStZ+pm3Yv2CRtOD4jBlycXjzhwBV7/70ZMH70/Y25dJa\n\tCnJKl/Y76dPPn2LDWrG/4EkqUzoJkhRIYFUTpkPdaVYznqLgsho19j7HpEbAum8r3jemYBE1\n\tAIuVGg4bqY3UkvuHWLVRMuaHZNy55aYwnUvd46E64JH7O990mr6t/nu2a1aJ0BDdi8HZ0RMo\n\tEg76Avah+YR9fZrhDFmBQSL+mcCVWEbdiOzHmGYFoToqzM52wsNEpo2aStH9KLk8zrCXGx68\n\tohJyQoALX4sS03RIWh1jFjnlw2FCbEdj/HDX0+U0i9COtanm54arYXiBTnAnx0F7LW7pv7sb\n\t6tKMxsMLmprP/nWyV5AfFRi3jxs5tdwtDDk/ny8WH6KWeLR/zWDwpYgnXLBCdg8l97xUoPQO\n\t0VkKSa4JEXUZWZx9q6kICzFGsuqApqf9gIFJZwUmirsxH80Fe04Tv+IqIAW7/djYpOqGjSyk\n\toaEVNacwLLgZr+/j69/1ZwlbS8K+ChCtyBV4kEPzltSRZ4eU19v6sDND1JSTK9KSDtCcCcAt\n\tVGFlr4aE00AD/aOkHSylc93nPinBFO4AGhcs4WypZ3GGV6vGWCpJy9svfWsUDhSwI7GS/i/v\n\tUQ1+bswyYEY1Q3DjJqT7fXcAEQEAAYkEcgQYAQoAJgIbAhYhBKh9ADrOsi1cSAdZPMB+rCj3\n\tIWJdBQJcTPfVBQkEpo7hAkDBdCAEGQEKAB0WIQSomGMEg78Cd/pMshveCRfNeJ05lgUCWY4w\n\toQAKCRDeCRfNeJ05lp0gD/49i95kPKjpgjUbYeidjaWuINXMCA171KyaBAp+Jp2Qrun4sIJB\n\tZ6srMj6O/gC34AhZln2sXeQdxe88sNbg6HjlN+4AkhTd6DttjOfUwnamLDA7uw+YIapGgsgN\n\tlznjLnqOaQ9mtEwRbZMUOdyRf9osSuL14vHl4ia3bYNJ52WYre6gLMu4K+Ghd02og+ILgIio\n\tQ827h0spqIJYHrR3Ynnhxdlv5GPCobh+AKsQMdTIuCzR6JSCBk6GHkg33SiWScKMUzT8B/cn\n\typLfGnfV/LDZ9wS2TMzIlK/uv0Vd4C0OGDd/GCi5Gwu/Ot0aY7fzZo2CiRV+/nJBWPRRBTji\n\tbE4FG2rt7WSRLO/QmH2meIW4f0USDiHeNwznHkPei59vRdlMyQdsxrmgSRDuX9Y3UkERxbgd\n\tuscqC8Cpcy5kpF11EW91J8aGpcxASc+5Pa66/+7CrpBC2DnfcfACdMAje7yeMn9XlHrqXNlQ\n\tGaglEcnGN2qVqRcKgcjJX+ur8l56BVpBPFYQYkYkIdQAuhlPylxOvsMcqI6VoEWNt0iFF3dA\n\t//0MNb8fEqw5TlxDPOt6BDhDKowkxOGIA9LOcF4PkaR9Qkvwo2P4vA/8fhCnMqlSPom4xYdk\n\tEv8P554zDoL/XMHl+s7A0MjIJzT253ejZKlWeO68pAbNy/z7QRn2lFDnjwkQwH6sKPchYl2f\n\t0g//Yu3vDkqk8+mi2letP3XBl2hjv2eCZjTh34VvtgY5oeL2ROSJWNd18+7O6q3hECZ727EW\n\tgIb3LK9g4mKF6+Rch6Gwz1Y4fmC5554fd2Y2XbVzzz6AGUC6Y+ohNg7lTAVO4wu43+IyTB8u\n\tip5rX/JDGFv7Y1sl6tQJKAVIKAJE+Z3Ncqh3doQr9wWHl0UiQYKbSR9HpH1lmC1C3EEbTpwK\n\tfUIpZd1eQNyNJl1jHsZZIBYFsAfVNH/u6lB1TU+9bSOsV5SepdIb88d0fm3oZ4KzjhRHLFQF\n\tRwNUNn3ha6x4fbxYcwbvu5ZCiiX6yRTPoage/LUNkgQNX2PtPcur6CdxK6Pqm8EAI7PmYLfN\n\tNY3y01XhKNRvaVZoH2FugfUkhsBITglTIpI+n6YU06nDAcbeINFo67TSE0iL6Pek5a6gUQQC\n\t6w+hJCaMr8KYud0q3ccHyU3TlAPDe10En3GsVz7Y5Sa3ODGdbmkfjK8Af3ogGNBVmpV16Xl8\n\t4rETFv7POSUB2eMtbpmBopd+wKqHCwUEy3fx1zDbM9mp+pcDoL73rRZmlgmNfW/4o4qBzxRf\n\tFYTQLE69wAFU2IFce9PjtUAlBdC+6r3X24h3uD+EC37s/vWhxuKj2glaU9ONrVJ/SPvlqXOO\n\tWR1Zqw57vHMKimLdG3c24l8PkSw1usudgAA5OyO5Ag0EWY4wyQEQAMVp0U38Le7d80Mu6AT+\n\t1dMes87iKn30TdMuLvSg2uYqJ1T2riRBF7zU6u74HF6zps0rPQviBXOgoSuKa1hnS6OwFb9x\n\tyQPlk76LY96SUB5jPWJ3fO78ZGSwkVbJFuG9gpD/41n8Unn1hXgDb2gUaxD0oXv/723EmTYC\n\tvSo3z6Y8A2aBQNr+PyhQAPDazvVQ+P7vnZYq1oK0w+D7aIix/Bp4mo4VbgAeAeMxXWSZs8N5\n\tNQtXeTBgB7DqrfJP5wWwgCsROfeds6EoddcYgqhG0zVU9E54C8JcPOA0wKVs+9+gt2eyRNtx\n\t0UhFbah7qXuJGhWy/0CLXvVoCoS+7qpWz070TBAlPZrg9D0o2gOw01trQgoKAYBKKgJhxaX/\n\t4gzi+5Ccm33LYH9lAVTdzdorejuV1xWdsnNyc8OAPeoXBf9RIIWfQVmbhVXBp2DAPjV6/kIJ\n\tEml7MNJfEvqjV9zKsWF9AFlsqDWZDCyUdqR96ahTSD34pRwb6a9H99/GrjeowKaaL95DIVZT\n\tC6STvDNL6kpys4sOe2AMmQGv2MMcJB3aYLzH8f1sEQ9S0UMX7/6CifEG6JodG6Y/W/lLo1Vv\n\tDxeDA+u4Lgq6qxlksp8M78FjcmxFVlf4cpCi2ucbZxurhlBkjtZZ8MVAEde3hlqjcBl2Ah6Q\n\tD826FTxscOGlHEfNABEBAAGJAjwEGAEKACYCGwwWIQSofQA6zrItXEgHWTzAfqwo9yFiXQUC\n\tXEz31QUJBKaOuQAKCRDAfqwo9yFiXUvnEACBWe8wSnIvSX+9k4LxuLq6GQTOt+RNfliZQkCW\n\t5lT3KL1IJyzzOm4x+/slHRBl8bF7KEZyOPinXQXyJ/vgIdgSYxDqoZ7YZn3SvuNe4aT6kGwL\n\tEYYEV8Ecj4ets15FR2jSUNnVv5YHWtZ7bP/oUzr2LT54fjRcstYxgwzoj8AREtHQ4EJWAWCO\n\tZuEHTSm5clMFoi41CmG4DlJbzbo4YfilKYm69vwh50Y8WebcRN31jh0g8ufjOJnBldYYBLwN\n\tObymhlfy/HKBDIbyCGBuwYoAkoJ6LR/cqzl/FuhwhuDocCGlXyYaJOwXgHaCvVXI3PLQPxWZ\n\t+vPsD+TSVHc9m/YWrOiYDnZn6aO0Uk1Zv/m9+BBkWAwsreLJ/evn3SsJV1omNBTITG+uxXcf\n\tJkgmmesIAw8mpI6EeLmReUJLasz8QkzhZIC7t5rGlQI94GQG3Jg2dC+kpaGWOaT5G4FVMcBj\n\tiR1nXfMxENVYnM5ag7mBZyD/kru5W1Uj34L6AFaDMXFPwedSCpzzqUiHb0f+nYkfOodf5xy0\n\t46+3THy/NUS/ZZp/rI4F7Y77+MQPVg7vARfHHX1AxYUKfRVW5j88QUB70txn8Vgi1tDrOr4J\n\teD+xr0CvIGa5lKqgQacQtGkpOpJ8zY4ObSvpNubey/qYUE3DCXD0n2Xxk4muTvqlkFpOYA==","Message-ID":"<63c18f71-9e0c-72cd-94d3-27f4a046ae0f@collabora.com>","Date":"Fri, 9 Aug 2019 19:16:23 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.2","MIME-Version":"1.0","In-Reply-To":"<20190809192616.GF5007@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: RKISP1\n\tconfigure isp output pad","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 09 Aug 2019 22:16:32 -0000"}},{"id":2375,"web_url":"https://patchwork.libcamera.org/comment/2375/","msgid":"<20190810213431.GF4788@pendragon.ideasonboard.com>","date":"2019-08-10T21:34:31","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: RKISP1\n\tconfigure isp output pad","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Helen,\n\nOn Fri, Aug 09, 2019 at 07:16:23PM -0300, Helen Koike wrote:\n> On 8/9/19 4:26 PM, Laurent Pinchart wrote:\n> > On Thu, Aug 08, 2019 at 10:31:58PM -0300, Helen Koike wrote:\n> >> On 8/8/19 7:01 PM, Laurent Pinchart wrote:\n> >>> Hi Helen,\n> >>>\n> >>> Thank you for the patch, and sorry for the late reply.\n> >>\n> >> no problem, thanks for reviewing.\n> >>\n> >>> On Tue, Jul 30, 2019 at 04:10:07PM -0300, Helen Koike wrote:\n> >>>> ISP output pad should be set to YUYV8_2X8 for non-bayer output format.\n> >>>> Bayer formats are not listed in RkISP1CameraConfiguration::validate(),\n> >>>> only non-bayer are listed, so we can set YUYV8_2X8 directly.\n> >>>> This need to be changed if we add support for bayer output with\n> >>>\n> >>> s/need/needs/\n> >>>\n> >>>> libcamera.\n> >>>>\n> >>>> Signed-off-by: Helen Koike <helen.koike@collabora.com>\n> >>>>\n> >>>> ---\n> >>>>\n> >>>> Hi,\n> >>>>\n> >>>> I'm re-sending this patch standalone as Laurent suggested.\n> >>>>\n> >>>> Thanks\n> >>>> Helen\n> >>>> ---\n> >>>>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 14 ++++++++++++++\n> >>>>  1 file changed, 14 insertions(+)\n> >>>>\n> >>>> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> >>>> index efa9604..bc7cb3f 100644\n> >>>> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> >>>> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> >>>> @@ -286,6 +286,8 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> >>>>  \tif (ret < 0)\n> >>>>  \t\treturn ret;\n> >>>>  \n> >>>> +\tLOG(RkISP1, Debug) << \"Configuring ISP input pad with \" << format.toString();\n> >>>> +\n> >>>>  \tret = dphy_->getFormat(1, &format);\n> >>>>  \tif (ret < 0)\n> >>>>  \t\treturn ret;\n> >>>> @@ -294,6 +296,18 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> >>>>  \tif (ret < 0)\n> >>>>  \t\treturn ret;\n> >>>>  \n> >>>> +\tLOG(RkISP1, Debug) << \"ISP input pad configured with \" << format.toString();\n> >>>> +\n> >>>> +\t/* YUYV8_2X8 is required in ISP pad 1 for non-bayer output */\n> >>>\n> >>> s/output/output./\n> >>>\n> >>> According to the code below, isn't this pad 2 ? I would write \"YUYV8_2X8\n> >>> is required on the ISP source path pad for YUV output.\".\n> >>\n> >> Yes, it is pad 1, sorry about that\n> > \n> > Do you mean the comment is right and the code should be changed ?\n> \n> Ops, sorry again for this confusion, it is pad 2 (I don't know why I wrote pad 1),\n> the code is right, the comment should be changed.\n\nComment fixed and patch pushed. Thank you.\n\n> >>> Apart from that,\n> >>>\n> >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> >>>\n> >>> Please let me know if you are fine with those small changes, I will then\n> >>> add them when applying the patch.\n> >>\n> >> Yes, I'm fine with those changes, thanks!\n> >>\n> >>> Niklas, I know you have a running environment for the Scarlet tablet,\n> >>> would you be able to test this patch ?\n> >>>\n> >>>> +\tformat.mbus_code = MEDIA_BUS_FMT_YUYV8_2X8;\n> >>>> +\tLOG(RkISP1, Debug) << \"Configuring ISP output pad with \" << format.toString();\n> >>>> +\n> >>>> +\tret = isp_->setFormat(2, &format);\n> >>>> +\tif (ret < 0)\n> >>>> +\t\treturn ret;\n> >>>> +\n> >>>> +\tLOG(RkISP1, Debug) << \"ISP output pad configured with \" << format.toString();\n> >>>> +\n> >>>>  \tV4L2DeviceFormat outputFormat = {};\n> >>>>  \toutputFormat.fourcc = cfg.pixelFormat;\n> >>>>  \toutputFormat.size = cfg.size;","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 034BF60E38\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 10 Aug 2019 23:34:34 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C70F67;\n\tSat, 10 Aug 2019 23:34:34 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1565472874;\n\tbh=9lv9DOQO8gOi8O3Dsc4zL4xuvFiJ2fn4D5S1UCgyIlI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ke9rAfR9ypZFsmeAtKHnQ6EVf14XFzoSTF0oGdGzT3uhJrBMZTnmL7oVLiKeSM7DM\n\tEiBv+FFJgjUNzjaMGgqxN2PJUz2EEO00Dr93IouFkAhiUTL4DfJ1ZWQ+DSF8IxvOzJ\n\tGgSP8MgBCFZQe/Ga3QsJzTLO8SjKyoEUvL+xsAa8=","Date":"Sun, 11 Aug 2019 00:34:31 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Helen Koike <helen.koike@collabora.com>","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com","Message-ID":"<20190810213431.GF4788@pendragon.ideasonboard.com>","References":"<8ad5a0874203dacfd488fe6827e3feab14dc959c.1564513804.git.helen.koike@collabora.com>\n\t<20190808220120.GI6055@pendragon.ideasonboard.com>\n\t<12e56dea-c9b8-df5a-5702-e78366819856@collabora.com>\n\t<20190809192616.GF5007@pendragon.ideasonboard.com>\n\t<63c18f71-9e0c-72cd-94d3-27f4a046ae0f@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<63c18f71-9e0c-72cd-94d3-27f4a046ae0f@collabora.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: RKISP1\n\tconfigure isp output pad","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 10 Aug 2019 21:34:35 -0000"}}]