[{"id":24749,"web_url":"https://patchwork.libcamera.org/comment/24749/","msgid":"","date":"2022-08-23T23:21:34","subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: color_space: Reorder\n\tmembers in the same order as the header","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"hi Laurent,\nThank you for the patch\n\nOn 8/23/22 11:13 PM, Laurent Pinchart via libcamera-devel wrote:\n> Sort the members of the ColorSpace class in color_space.cpp to match the\n> color_space.h order. No functional change intended.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n> ---\n> src/libcamera/color_space.cpp | 168 +++++++++++++++++-----------------\n> 1 file changed, 84 insertions(+), 84 deletions(-)\n>\n> diff --git a/src/libcamera/color_space.cpp b/src/libcamera/color_space.cpp\n> index f0d6109ac4fb..1b2dd2404452 100644\n> --- a/src/libcamera/color_space.cpp\n> +++ b/src/libcamera/color_space.cpp\n> @@ -124,6 +124,90 @@ namespace libcamera {\n> * \\param[in] r The range of the pixel values in this color space\n> */\n> \n> +/**\n> + * \\brief A constant representing a raw color space (from a sensor)\n> + */\n> +const ColorSpace ColorSpace::Raw = {\n> +\tPrimaries::Raw,\n> +\tTransferFunction::Linear,\n> +\tYcbcrEncoding::None,\n> +\tRange::Full\n> +};\n> +\n> +/**\n> + * \\brief A constant representing the sRGB color space\n> + *\n> + * This is identical to the sYCC color space except that the Y'CbCr\n> + * range is limited rather than full.\n> + */\n> +const ColorSpace ColorSpace::Srgb = {\n> +\tPrimaries::Rec709,\n> +\tTransferFunction::Srgb,\n> +\tYcbcrEncoding::Rec601,\n> +\tRange::Limited\n> +};\n> +\n> +/**\n> + * \\brief A constant representing the sYCC color space, typically used for\n> + * encoding JPEG images\n> + */\n> +const ColorSpace ColorSpace::Sycc = {\n> +\tPrimaries::Rec709,\n> +\tTransferFunction::Srgb,\n> +\tYcbcrEncoding::Rec601,\n> +\tRange::Full\n> +};\n> +\n> +/**\n> + * \\brief A constant representing the SMPTE170M color space\n> + */\n> +const ColorSpace ColorSpace::Smpte170m = {\n> +\tPrimaries::Smpte170m,\n> +\tTransferFunction::Rec709,\n> +\tYcbcrEncoding::Rec601,\n> +\tRange::Limited\n> +};\n> +\n> +/**\n> + * \\brief A constant representing the Rec.709 color space\n> + */\n> +const ColorSpace ColorSpace::Rec709 = {\n> +\tPrimaries::Rec709,\n> +\tTransferFunction::Rec709,\n> +\tYcbcrEncoding::Rec709,\n> +\tRange::Limited\n> +};\n> +\n> +/**\n> + * \\brief A constant representing the Rec.2020 color space\n> + */\n> +const ColorSpace ColorSpace::Rec2020 = {\n> +\tPrimaries::Rec2020,\n> +\tTransferFunction::Rec709,\n> +\tYcbcrEncoding::Rec2020,\n> +\tRange::Limited\n> +};\n> +\n> +/**\n> + * \\var ColorSpace::primaries\n> + * \\brief The color primaries of this color space\n> + */\n> +\n> +/**\n> + * \\var ColorSpace::transferFunction\n> + * \\brief The transfer function used by this color space\n> + */\n> +\n> +/**\n> + * \\var ColorSpace::ycbcrEncoding\n> + * \\brief The Y'CbCr encoding used by this color space\n> + */\n> +\n> +/**\n> + * \\var ColorSpace::range\n> + * \\brief The pixel range used with by color space\n> + */\n> +\n> /**\n> * \\brief Assemble and return a readable string representation of the\n> * ColorSpace\n> @@ -219,90 +303,6 @@ std::string ColorSpace::toString(const std::optional &colorSpace)\n> \treturn colorSpace->toString();\n> }\n> \n> -/**\n> - * \\var ColorSpace::primaries\n> - * \\brief The color primaries of this color space\n> - */\n> -\n> -/**\n> - * \\var ColorSpace::transferFunction\n> - * \\brief The transfer function used by this color space\n> - */\n> -\n> -/**\n> - * \\var ColorSpace::ycbcrEncoding\n> - * \\brief The Y'CbCr encoding used by this color space\n> - */\n> -\n> -/**\n> - * \\var ColorSpace::range\n> - * \\brief The pixel range used with by color space\n> - */\n> -\n> -/**\n> - * \\brief A constant representing a raw color space (from a sensor)\n> - */\n> -const ColorSpace ColorSpace::Raw = {\n> -\tPrimaries::Raw,\n> -\tTransferFunction::Linear,\n> -\tYcbcrEncoding::None,\n> -\tRange::Full\n> -};\n> -\n> -/**\n> - * \\brief A constant representing the sRGB color space\n> - *\n> - * This is identical to the sYCC color space except that the Y'CbCr\n> - * range is limited rather than full.\n> - */\n> -const ColorSpace ColorSpace::Srgb = {\n> -\tPrimaries::Rec709,\n> -\tTransferFunction::Srgb,\n> -\tYcbcrEncoding::Rec601,\n> -\tRange::Limited\n> -};\n> -\n> -/**\n> - * \\brief A constant representing the sYCC color space, typically used for\n> - * encoding JPEG images\n> - */\n> -const ColorSpace ColorSpace::Sycc = {\n> -\tPrimaries::Rec709,\n> -\tTransferFunction::Srgb,\n> -\tYcbcrEncoding::Rec601,\n> -\tRange::Full\n> -};\n> -\n> -/**\n> - * \\brief A constant representing the SMPTE170M color space\n> - */\n> -const ColorSpace ColorSpace::Smpte170m = {\n> -\tPrimaries::Smpte170m,\n> -\tTransferFunction::Rec709,\n> -\tYcbcrEncoding::Rec601,\n> -\tRange::Limited\n> -};\n> -\n> -/**\n> - * \\brief A constant representing the Rec.709 color space\n> - */\n> -const ColorSpace ColorSpace::Rec709 = {\n> -\tPrimaries::Rec709,\n> -\tTransferFunction::Rec709,\n> -\tYcbcrEncoding::Rec709,\n> -\tRange::Limited\n> -};\n> -\n> -/**\n> - * \\brief A constant representing the Rec.2020 color space\n> - */\n> -const ColorSpace ColorSpace::Rec2020 = {\n> -\tPrimaries::Rec2020,\n> -\tTransferFunction::Rec709,\n> -\tYcbcrEncoding::Rec2020,\n> -\tRange::Limited\n> -};\n> -\n> /**\n> * \\brief Compare color spaces for equality\n> * \\return True if the two color spaces are identical, false otherwise","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4ECD8C3272\n\tfor ;\n\tTue, 23 Aug 2022 23:21:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9FB6A61FBD;\n\tWed, 24 Aug 2022 01:21:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97B8361FA0\n\tfor ;\n\tWed, 24 Aug 2022 01:21:41 +0200 (CEST)","from [IPV6:2401:4900:1f3f:806e:6647:8e5c:f441:ca9a] (unknown\n\t[IPv6:2401:4900:1f3f:806e:6647:8e5c:f441:ca9a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 611392B3;\n\tWed, 24 Aug 2022 01:21:40 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661296902;\n\tbh=2GE0YP2ukCZ6aeAoqBinR0vSMPF9ixwyiKeFYo7vplY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Gww1P0XByKbkM7/5FDnbxpPutcucKoiEAZIjQkVyVvfemGt+oMAx9DWiNnUaNkanU\n\t8a5lkmdzaLmb0icvjQFI3bnf5w9jszI7e+8RPOm36cTM50RjcYHBlegWisKzX5d20N\n\tF3p3pqSnq7Mfjf+UE6UfTa3DAaKqNEtCDaJbObV0qhN1dpmF8eds+bj6VqdS/U5g/8\n\tbCClKhbg7WqDQj+cfk1CyujY1llbvcNdCNYn7y6kfkdbRp5tGb70m+RBN6s7NC8P+d\n\tfI+xNrCUCV3ax2wRmM0XhCaY1iG1INj8IFPJuPR6eUgKnhyxD+BiRnAfUcIR/2Hqyr\n\tHwT8B3Iuk+dAw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661296901;\n\tbh=2GE0YP2ukCZ6aeAoqBinR0vSMPF9ixwyiKeFYo7vplY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=f6LTQX+V3Nv62QMCt6VGdAvwt8YvFsppbHkRlEGNfpmJAhT+dS5VA2+RiC+jyf38D\n\txAnsP4hODNk/C/L2Kq9WivxNUayS5fYZLy6Udm7A182efe4/7P6u6r8FNd/yBiqzxp\n\t6uyLBBoafoYw+R3HdLmXc/O0TuZN8VYtY3aVWhiY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"f6LTQX+V\"; dkim-atps=neutral","Message-ID":"","Date":"Wed, 24 Aug 2022 04:51:34 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.12.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220823174314.14881-1-laurent.pinchart@ideasonboard.com>\n\t<20220823174314.14881-3-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220823174314.14881-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: color_space: Reorder\n\tmembers in the same order as the header","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24776,"web_url":"https://patchwork.libcamera.org/comment/24776/","msgid":"<20220825185503.GN109174@pyrite.rasen.tech>","date":"2022-08-25T18:55:03","subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: color_space: Reorder\n\tmembers in the same order as the header","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Tue, Aug 23, 2022 at 08:43:10PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Sort the members of the ColorSpace class in color_space.cpp to match the\n> color_space.h order. No functional change intended.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/color_space.cpp | 168 +++++++++++++++++-----------------\n> 1 file changed, 84 insertions(+), 84 deletions(-)\n> \n> diff --git a/src/libcamera/color_space.cpp b/src/libcamera/color_space.cpp\n> index f0d6109ac4fb..1b2dd2404452 100644\n> --- a/src/libcamera/color_space.cpp\n> +++ b/src/libcamera/color_space.cpp\n> @@ -124,6 +124,90 @@ namespace libcamera {\n> * \\param[in] r The range of the pixel values in this color space\n> */\n> \n> +/**\n> + * \\brief A constant representing a raw color space (from a sensor)\n> + */\n> +const ColorSpace ColorSpace::Raw = {\n> +\tPrimaries::Raw,\n> +\tTransferFunction::Linear,\n> +\tYcbcrEncoding::None,\n> +\tRange::Full\n> +};\n> +\n> +/**\n> + * \\brief A constant representing the sRGB color space\n> + *\n> + * This is identical to the sYCC color space except that the Y'CbCr\n> + * range is limited rather than full.\n> + */\n> +const ColorSpace ColorSpace::Srgb = {\n> +\tPrimaries::Rec709,\n> +\tTransferFunction::Srgb,\n> +\tYcbcrEncoding::Rec601,\n> +\tRange::Limited\n> +};\n> +\n> +/**\n> + * \\brief A constant representing the sYCC color space, typically used for\n> + * encoding JPEG images\n> + */\n> +const ColorSpace ColorSpace::Sycc = {\n> +\tPrimaries::Rec709,\n> +\tTransferFunction::Srgb,\n> +\tYcbcrEncoding::Rec601,\n> +\tRange::Full\n> +};\n> +\n> +/**\n> + * \\brief A constant representing the SMPTE170M color space\n> + */\n> +const ColorSpace ColorSpace::Smpte170m = {\n> +\tPrimaries::Smpte170m,\n> +\tTransferFunction::Rec709,\n> +\tYcbcrEncoding::Rec601,\n> +\tRange::Limited\n> +};\n> +\n> +/**\n> + * \\brief A constant representing the Rec.709 color space\n> + */\n> +const ColorSpace ColorSpace::Rec709 = {\n> +\tPrimaries::Rec709,\n> +\tTransferFunction::Rec709,\n> +\tYcbcrEncoding::Rec709,\n> +\tRange::Limited\n> +};\n> +\n> +/**\n> + * \\brief A constant representing the Rec.2020 color space\n> + */\n> +const ColorSpace ColorSpace::Rec2020 = {\n> +\tPrimaries::Rec2020,\n> +\tTransferFunction::Rec709,\n> +\tYcbcrEncoding::Rec2020,\n> +\tRange::Limited\n> +};\n> +\n> +/**\n> + * \\var ColorSpace::primaries\n> + * \\brief The color primaries of this color space\n> + */\n> +\n> +/**\n> + * \\var ColorSpace::transferFunction\n> + * \\brief The transfer function used by this color space\n> + */\n> +\n> +/**\n> + * \\var ColorSpace::ycbcrEncoding\n> + * \\brief The Y'CbCr encoding used by this color space\n> + */\n> +\n> +/**\n> + * \\var ColorSpace::range\n> + * \\brief The pixel range used with by color space\n> + */\n> +\n> /**\n> * \\brief Assemble and return a readable string representation of the\n> * ColorSpace\n> @@ -219,90 +303,6 @@ std::string ColorSpace::toString(const std::optional &colorSpace)\n> \treturn colorSpace->toString();\n> }\n> \n> -/**\n> - * \\var ColorSpace::primaries\n> - * \\brief The color primaries of this color space\n> - */\n> -\n> -/**\n> - * \\var ColorSpace::transferFunction\n> - * \\brief The transfer function used by this color space\n> - */\n> -\n> -/**\n> - * \\var ColorSpace::ycbcrEncoding\n> - * \\brief The Y'CbCr encoding used by this color space\n> - */\n> -\n> -/**\n> - * \\var ColorSpace::range\n> - * \\brief The pixel range used with by color space\n> - */\n> -\n> -/**\n> - * \\brief A constant representing a raw color space (from a sensor)\n> - */\n> -const ColorSpace ColorSpace::Raw = {\n> -\tPrimaries::Raw,\n> -\tTransferFunction::Linear,\n> -\tYcbcrEncoding::None,\n> -\tRange::Full\n> -};\n> -\n> -/**\n> - * \\brief A constant representing the sRGB color space\n> - *\n> - * This is identical to the sYCC color space except that the Y'CbCr\n> - * range is limited rather than full.\n> - */\n> -const ColorSpace ColorSpace::Srgb = {\n> -\tPrimaries::Rec709,\n> -\tTransferFunction::Srgb,\n> -\tYcbcrEncoding::Rec601,\n> -\tRange::Limited\n> -};\n> -\n> -/**\n> - * \\brief A constant representing the sYCC color space, typically used for\n> - * encoding JPEG images\n> - */\n> -const ColorSpace ColorSpace::Sycc = {\n> -\tPrimaries::Rec709,\n> -\tTransferFunction::Srgb,\n> -\tYcbcrEncoding::Rec601,\n> -\tRange::Full\n> -};\n> -\n> -/**\n> - * \\brief A constant representing the SMPTE170M color space\n> - */\n> -const ColorSpace ColorSpace::Smpte170m = {\n> -\tPrimaries::Smpte170m,\n> -\tTransferFunction::Rec709,\n> -\tYcbcrEncoding::Rec601,\n> -\tRange::Limited\n> -};\n> -\n> -/**\n> - * \\brief A constant representing the Rec.709 color space\n> - */\n> -const ColorSpace ColorSpace::Rec709 = {\n> -\tPrimaries::Rec709,\n> -\tTransferFunction::Rec709,\n> -\tYcbcrEncoding::Rec709,\n> -\tRange::Limited\n> -};\n> -\n> -/**\n> - * \\brief A constant representing the Rec.2020 color space\n> - */\n> -const ColorSpace ColorSpace::Rec2020 = {\n> -\tPrimaries::Rec2020,\n> -\tTransferFunction::Rec709,\n> -\tYcbcrEncoding::Rec2020,\n> -\tRange::Limited\n> -};\n> -\n> /**\n> * \\brief Compare color spaces for equality\n> * \\return True if the two color spaces are identical, false otherwise","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 585DDC3272\n\tfor ;\n\tThu, 25 Aug 2022 18:55:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7FCF361FBF;\n\tThu, 25 Aug 2022 20:55:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1867C61FA0\n\tfor ;\n\tThu, 25 Aug 2022 20:55:10 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2604:2d80:ad8a:9000:1bf9:855b:22de:3645])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E43CB2B3;\n\tThu, 25 Aug 2022 20:55:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661453711;\n\tbh=7GSgry4pPcuq8x+DWaAB1U56EYeziZXXvF779TBt3CQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Vgxj/2mnilE/YenkkVBYYqyhT4TavrEx+OSl1D29cmhAMNp1QSSxdo5nR9a9uqpRr\n\tCfFsotErgxW4ovnPaOwmtVhQKKqXql6IbtMpIF5O2FTYj4VdjqtRQGo/to28OP35Dn\n\tHSvDy7vJOgFOE4R9fROGwjPIOR/qsNwwIpCovCMWUhZOlDzfmrFfR1+n7BJCGnuyXU\n\t7MQNlLfTXYCGEgZvtS+jIwGzRzI+KAZUI537SS2AuPJHRWJAIjJzqUwZ9xFKIY62Oy\n\tguboC3uf/P6hyBxhY9EG3W6NJKtWCM96yIW4ZFJewSYrQhKpo+2zpLsmHUfDl9FANF\n\tJl9vLw5Txxk9Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661453709;\n\tbh=7GSgry4pPcuq8x+DWaAB1U56EYeziZXXvF779TBt3CQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HXAts89ENL9df++Vs9h60A1IItTncpDhetAwwsuDSW0DUIOB4LRUMZ2x7HrZ8GwRf\n\tEaUH1Hxdlz3ZLansGyxSmyKoU8KpwGUBFS7AkmROHJ/nsASZw+m4W4NHNYzLUWUSxy\n\tRC77Q7L+aDyMfO3p7H6QUiWijjNCRRu9WSKz/4/I="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HXAts89E\"; dkim-atps=neutral","Date":"Thu, 25 Aug 2022 13:55:03 -0500","To":"Laurent Pinchart ","Message-ID":"<20220825185503.GN109174@pyrite.rasen.tech>","References":"<20220823174314.14881-1-laurent.pinchart@ideasonboard.com>\n\t<20220823174314.14881-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220823174314.14881-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/6] libcamera: color_space: Reorder\n\tmembers in the same order as the header","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]