[{"id":24715,"web_url":"https://patchwork.libcamera.org/comment/24715/","msgid":"","date":"2022-08-19T11:23:25","subject":"Re: [libcamera-devel] [PATCH v4 1/6] py: meson: Use\n\tlibcamera_private dependency","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Fri, Aug 19, 2022 at 02:16:10PM +0300, Tomi Valkeinen wrote:\n> We define -DLIBCAMERA_BASE_PRIVATE to get access to libcamera private\n> headers, but the correct way to do this is to have a meson dependency to\n> libcamera_private.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/libcamera/meson.build | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index 04578bac..99c2a8c0 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -60,7 +60,7 @@ pycamera_sources += custom_target('py_gen_formats',\n> command : [gen_py_formats, '-o', '@OUTPUT@', '@INPUT@'])\n> \n> pycamera_deps = [\n> - libcamera_public,\n> + libcamera_private,\n> py3_dep,\n> pybind11_dep,\n> ]\n> @@ -69,7 +69,6 @@ pycamera_args = [\n> '-fvisibility=hidden',\n> '-Wno-shadow',\n> '-DPYBIND11_USE_SMART_HOLDER_AS_DEFAULT',\n> - '-DLIBCAMERA_BASE_PRIVATE',\n> ]\n> \n> destdir = get_option('libdir') / ('python' + py3_dep.version()) / 'site-packages' / 'libcamera'","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F10BAC3272\n\tfor ;\n\tFri, 19 Aug 2022 11:23:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6EF7261FBD;\n\tFri, 19 Aug 2022 13:23:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA90861FA4\n\tfor ;\n\tFri, 19 Aug 2022 13:23:29 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E7BAE3F1;\n\tFri, 19 Aug 2022 13:23:28 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660908211;\n\tbh=HyNN8tPSTWIZN5sEinR02rnlTqEuX9yzbsO+RhDRYFc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=T/cj1WfK2slOAi8hMnCKfNk5tgqKwyB2Z9SJjt6ntnyfTGai0+pieKQyM5uKdQoxp\n\tSyHJC3XR0xVcfufquwRQPtkQI7XEj5d1TDZ/0tJMFBddyohG/g5jOVBMlqht3JF39W\n\tdpLuCqpqziZXFUeK0F0kaznrByumOwhe6n8L0Wc70Pzf7A+fTfKH9BB9rdJpT19kxm\n\tLRa4bqAsHBLlf6/cXHb9MS55Abv2oXWr/EvNlrF+jFOSGFNttw5DrSjpxBQZPk+tVp\n\t17uTiDfkYljUlEjzfphfYBl7APRCcyhm22I81ZbdgjXhkbFyREPUVOD4fpx7t+vQN0\n\tkUd01jQAcKISA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660908209;\n\tbh=HyNN8tPSTWIZN5sEinR02rnlTqEuX9yzbsO+RhDRYFc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=imbzetE0webhX19Gmd4bzAZmepeQb5bZPECptNqYJ2OAss/GHfGmV3ivdVoZUoKNI\n\tKkU2Z6gwPR43OzqoZo3WAJ3eHpPtTZVIzBzMiPDWaYMf5rh2Su0mmRhPaIaiH0uewA\n\tbwlpSeRYGQ1/J9icrLMYBMxTa2TwmX6dOoU7x/5c="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"imbzetE0\"; dkim-atps=neutral","Date":"Fri, 19 Aug 2022 14:23:25 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220819111615.39814-1-tomi.valkeinen@ideasonboard.com>\n\t<20220819111615.39814-2-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220819111615.39814-2-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 1/6] py: meson: Use\n\tlibcamera_private dependency","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]