[{"id":24697,"web_url":"https://patchwork.libcamera.org/comment/24697/","msgid":"","date":"2022-08-19T00:55:04","subject":"Re: [libcamera-devel] [PATCH v2 6/7] [TEST] ipa: vimc: Add\n\tIPAOperationCode to init() parameter list","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Thu, Aug 18, 2022 at 03:49:21PM +0900, Paul Elder via libcamera-devel wrote:\n> For the purpose of testing serializing/deserializing enums in function\n> parameters, add IPAOperationCode to the parameter list of init().\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> No changes in v2\n> ---\n> include/libcamera/ipa/vimc.mojom | 2 +-\n> src/ipa/vimc/vimc.cpp | 6 ++++--\n> src/libcamera/pipeline/vimc/vimc.cpp | 2 +-\n> test/ipa/ipa_interface_test.cpp | 2 +-\n> 4 files changed, 7 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/vimc.mojom b/include/libcamera/ipa/vimc.mojom\n> index 718b9674..16149787 100644\n> --- a/include/libcamera/ipa/vimc.mojom\n> +++ b/include/libcamera/ipa/vimc.mojom\n> @@ -18,7 +18,7 @@ enum IPAOperationCode {\n> };\n> \n> interface IPAVimcInterface {\n> -\tinit(libcamera.IPASettings settings) => (int32 ret);\n> +\tinit(libcamera.IPASettings settings, IPAOperationCode code) => (int32 ret);\n> \n> \tconfigure(libcamera.IPACameraSensorInfo sensorInfo,\n> \t\t map streamConfig,\n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index 85afb279..6bf39a1c 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -31,7 +31,7 @@ public:\n> \tIPAVimc();\n> \t~IPAVimc();\n> \n> -\tint init(const IPASettings &settings) override;\n> +\tint init(const IPASettings &settings, const ipa::vimc::IPAOperationCode &code) override;\n\nShould we do for enums the same thing we do for integers, and pass by\nvalue instead of const reference ?\n\nReviewed-by: Laurent Pinchart \n\n> \n> \tint start() override;\n> \tvoid stop() override;\n> @@ -66,7 +66,7 @@ IPAVimc::~IPAVimc()\n> \t\t::close(fd_);\n> }\n> \n> -int IPAVimc::init(const IPASettings &settings)\n> +int IPAVimc::init(const IPASettings &settings, const ipa::vimc::IPAOperationCode &code)\n> {\n> \ttrace(ipa::vimc::IPAOperationInit);\n> \n> @@ -74,6 +74,8 @@ int IPAVimc::init(const IPASettings &settings)\n> \t\t<< \"initializing vimc IPA with configuration file \"\n> \t\t<< settings.configurationFile;\n> \n> +\tLOG(IPAVimc, Debug) << \"Got opcode \" << code;\n> +\n> \tFile conf(settings.configurationFile);\n> \tif (!conf.open(File::OpenModeFlag::ReadOnly)) {\n> \t\tLOG(IPAVimc, Error) << \"Failed to open configuration file\";\n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 153cf849..983bd514 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -471,7 +471,7 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n> \tdata->ipa_->paramsBufferReady.connect(data.get(), &VimcCameraData::paramsBufferReady);\n> \n> \tstd::string conf = data->ipa_->configurationFile(\"vimc.conf\");\n> -\tdata->ipa_->init(IPASettings{ conf, data->sensor_->model() });\n> +\tdata->ipa_->init(IPASettings{ conf, data->sensor_->model() }, ipa::vimc::IPAOperationInit);\n> \n> \t/* Create and register the camera. */\n> \tstd::set streams{ &data->stream_ };\n> diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\n> index 3c0df843..b9fa15cd 100644\n> --- a/test/ipa/ipa_interface_test.cpp\n> +++ b/test/ipa/ipa_interface_test.cpp\n> @@ -106,7 +106,7 @@ protected:\n> \n> \t\t/* Test initialization of IPA module. */\n> \t\tstd::string conf = ipa_->configurationFile(\"vimc.conf\");\n> -\t\tint ret = ipa_->init(IPASettings{ conf, \"vimc\" });\n> +\t\tint ret = ipa_->init(IPASettings{ conf, \"vimc\" }, ipa::vimc::IPAOperationInit);\n> \t\tif (ret < 0) {\n> \t\t\tcerr << \"IPA interface init() failed\" << endl;\n> \t\t\treturn TestFail;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11D1CC3272\n\tfor ;\n\tFri, 19 Aug 2022 00:55:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AFC661FC0;\n\tFri, 19 Aug 2022 02:55:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C752561FA8\n\tfor ;\n\tFri, 19 Aug 2022 02:55:07 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3568A8B;\n\tFri, 19 Aug 2022 02:55:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660870509;\n\tbh=L0uR+yYKccHuJ68wmHmbXZ0d/+IHL+/yyQusZM8dg/M=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vCeQEQ+2x+3JT/VXOkIeKnERwZaM9CzBEhAq/IA/EC33siBJbWT7b0/FLWE089Ufu\n\tuWs1uPQRqxLHQlLtgfj/cediyNJPIJYd9GidzToiWuzL2gln3qu9WnaTPje6+Chun4\n\tsUbDb7EW0cAq20JIY7StceWmK7j3PQyRaLd2HlaB2OP/XSgpPYR3cmtXARU0BitsYW\n\tZG9VkH9MLNzw2hNZ/zGBvUmKRibualtqr4BxmiVmM85hh9c7oH/I7RvN+GLoltI89/\n\tmZWd/C5YlUwoQYk8JToI952mtC3z8r9xV9Qx0uia1Ke9CTjnMAqr/tYkHWyaWVbIBp\n\tM2tIpZQDpF4mw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660870507;\n\tbh=L0uR+yYKccHuJ68wmHmbXZ0d/+IHL+/yyQusZM8dg/M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IzPPr98YDEKRm5X/Yqif7B31wAXuOIu871imkRnC/5+W4tGI+c5hXA9noenTBNpob\n\t/flBJ/XEVaUXJRT09pk043OuFzVprCZhF4NLLHgkm6f+v66BDJZdbGXVNXUgZU24pJ\n\t16hoF3En+tpDDhXSsKbiBEY0fF3J2XHdzbh6zmGs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IzPPr98Y\"; dkim-atps=neutral","Date":"Fri, 19 Aug 2022 03:55:04 +0300","To":"Paul Elder ","Message-ID":"","References":"<20220818064923.2573060-1-paul.elder@ideasonboard.com>\n\t<20220818064923.2573060-7-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220818064923.2573060-7-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 6/7] [TEST] ipa: vimc: Add\n\tIPAOperationCode to init() parameter list","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24711,"web_url":"https://patchwork.libcamera.org/comment/24711/","msgid":"<20220819074456.GC34241@pyrite.rasen.tech>","date":"2022-08-19T07:44:56","subject":"Re: [libcamera-devel] [PATCH v2 6/7] [TEST] ipa: vimc: Add\n\tIPAOperationCode to init() parameter list","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Fri, Aug 19, 2022 at 03:55:04AM +0300, Laurent Pinchart wrote:\n> Hi Paul,\n> \n> Thank you for the patch.\n> \n> On Thu, Aug 18, 2022 at 03:49:21PM +0900, Paul Elder via libcamera-devel wrote:\n> > For the purpose of testing serializing/deserializing enums in function\n> > parameters, add IPAOperationCode to the parameter list of init().\n> > \n> > Signed-off-by: Paul Elder \n> > \n> > ---\n> > No changes in v2\n> > ---\n> > include/libcamera/ipa/vimc.mojom | 2 +-\n> > src/ipa/vimc/vimc.cpp | 6 ++++--\n> > src/libcamera/pipeline/vimc/vimc.cpp | 2 +-\n> > test/ipa/ipa_interface_test.cpp | 2 +-\n> > 4 files changed, 7 insertions(+), 5 deletions(-)\n> > \n> > diff --git a/include/libcamera/ipa/vimc.mojom b/include/libcamera/ipa/vimc.mojom\n> > index 718b9674..16149787 100644\n> > --- a/include/libcamera/ipa/vimc.mojom\n> > +++ b/include/libcamera/ipa/vimc.mojom\n> > @@ -18,7 +18,7 @@ enum IPAOperationCode {\n> > };\n> > \n> > interface IPAVimcInterface {\n> > -\tinit(libcamera.IPASettings settings) => (int32 ret);\n> > +\tinit(libcamera.IPASettings settings, IPAOperationCode code) => (int32 ret);\n> > \n> > \tconfigure(libcamera.IPACameraSensorInfo sensorInfo,\n> > \t\t map streamConfig,\n> > diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> > index 85afb279..6bf39a1c 100644\n> > --- a/src/ipa/vimc/vimc.cpp\n> > +++ b/src/ipa/vimc/vimc.cpp\n> > @@ -31,7 +31,7 @@ public:\n> > \tIPAVimc();\n> > \t~IPAVimc();\n> > \n> > -\tint init(const IPASettings &settings) override;\n> > +\tint init(const IPASettings &settings, const ipa::vimc::IPAOperationCode &code) override;\n> \n> Should we do for enums the same thing we do for integers, and pass by\n> value instead of const reference ?\n\nHm, tbh I think we should. I guess I have to fix that too then :/\n\n> \n> Reviewed-by: Laurent Pinchart \n\nThat means that... this is approved for merging...? I wasn't sure how we\nfelt about modifying the vimc IPA interface in such dummy-test ways\n\n\nPaul\n\n> \n> > \n> > \tint start() override;\n> > \tvoid stop() override;\n> > @@ -66,7 +66,7 @@ IPAVimc::~IPAVimc()\n> > \t\t::close(fd_);\n> > }\n> > \n> > -int IPAVimc::init(const IPASettings &settings)\n> > +int IPAVimc::init(const IPASettings &settings, const ipa::vimc::IPAOperationCode &code)\n> > {\n> > \ttrace(ipa::vimc::IPAOperationInit);\n> > \n> > @@ -74,6 +74,8 @@ int IPAVimc::init(const IPASettings &settings)\n> > \t\t<< \"initializing vimc IPA with configuration file \"\n> > \t\t<< settings.configurationFile;\n> > \n> > +\tLOG(IPAVimc, Debug) << \"Got opcode \" << code;\n> > +\n> > \tFile conf(settings.configurationFile);\n> > \tif (!conf.open(File::OpenModeFlag::ReadOnly)) {\n> > \t\tLOG(IPAVimc, Error) << \"Failed to open configuration file\";\n> > diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> > index 153cf849..983bd514 100644\n> > --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> > +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> > @@ -471,7 +471,7 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n> > \tdata->ipa_->paramsBufferReady.connect(data.get(), &VimcCameraData::paramsBufferReady);\n> > \n> > \tstd::string conf = data->ipa_->configurationFile(\"vimc.conf\");\n> > -\tdata->ipa_->init(IPASettings{ conf, data->sensor_->model() });\n> > +\tdata->ipa_->init(IPASettings{ conf, data->sensor_->model() }, ipa::vimc::IPAOperationInit);\n> > \n> > \t/* Create and register the camera. */\n> > \tstd::set streams{ &data->stream_ };\n> > diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\n> > index 3c0df843..b9fa15cd 100644\n> > --- a/test/ipa/ipa_interface_test.cpp\n> > +++ b/test/ipa/ipa_interface_test.cpp\n> > @@ -106,7 +106,7 @@ protected:\n> > \n> > \t\t/* Test initialization of IPA module. */\n> > \t\tstd::string conf = ipa_->configurationFile(\"vimc.conf\");\n> > -\t\tint ret = ipa_->init(IPASettings{ conf, \"vimc\" });\n> > +\t\tint ret = ipa_->init(IPASettings{ conf, \"vimc\" }, ipa::vimc::IPAOperationInit);\n> > \t\tif (ret < 0) {\n> > \t\t\tcerr << \"IPA interface init() failed\" << endl;\n> > \t\t\treturn TestFail;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 960E2BE173\n\tfor ;\n\tFri, 19 Aug 2022 07:45:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0444A61FC0;\n\tFri, 19 Aug 2022 09:45:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8546861FA3\n\tfor ;\n\tFri, 19 Aug 2022 09:45:04 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF7623F1;\n\tFri, 19 Aug 2022 09:45:02 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660895106;\n\tbh=bUrkD4mQQXtrkmDxvPFFGoKW3vjxQv1qo5jpW6IgT1Y=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=d/PKieIs98RA/kMCkJwXQjGEJhoFQ7LHnDHmj3SeT3W81zLKwMAOrePBnK8a5YMc6\n\ttYyaKSCZqHPuxNtNgsw2q1MzBrc4EH1R9Kje4DMMKc1D3DNHDL1oHtyaag5MAyt28/\n\tZT1EflujKkuO0FwGnMkfeugLb+dPRIkjOeaM097yUvUDp1hCNBU9KKnVqqcqj+epAW\n\tIprbxuVruKUDTnEQuyLxnUp0ZcuZfEsvGgns4fc/g2wuUHnBACFoQzheudcv3k+LlX\n\t46o6E6p2a/EYa/iyxeirHz99rQLY11vjzAx193BdhYKU+xh9gvEgCiTCThPClYIl5l\n\tVk37TAsV5tOTw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660895104;\n\tbh=bUrkD4mQQXtrkmDxvPFFGoKW3vjxQv1qo5jpW6IgT1Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fCjfuGT5K9f+DFWmj8AvkcXBCepfrmutcL2ygDUtQLVVY0GsSSd3Esw4Dp6yh48JB\n\t4RAQFyG8UHSzDefJNv1E2KG8v4RjMSe0aJTdB6SKVEZK9eDiLmuIHe7ik9CctTdCYi\n\tJ5Zmb5NsFuzGi/hVXKJy0RPVXT/S4BL349J4/jVA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fCjfuGT5\"; dkim-atps=neutral","Date":"Fri, 19 Aug 2022 16:44:56 +0900","To":"Laurent Pinchart ","Message-ID":"<20220819074456.GC34241@pyrite.rasen.tech>","References":"<20220818064923.2573060-1-paul.elder@ideasonboard.com>\n\t<20220818064923.2573060-7-paul.elder@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 6/7] [TEST] ipa: vimc: Add\n\tIPAOperationCode to init() parameter list","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24713,"web_url":"https://patchwork.libcamera.org/comment/24713/","msgid":"","date":"2022-08-19T08:13:52","subject":"Re: [libcamera-devel] [PATCH v2 6/7] [TEST] ipa: vimc: Add\n\tIPAOperationCode to init() parameter list","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nOn Fri, Aug 19, 2022 at 04:44:56PM +0900, paul.elder@ideasonboard.com wrote:\n> On Fri, Aug 19, 2022 at 03:55:04AM +0300, Laurent Pinchart wrote:\n> > On Thu, Aug 18, 2022 at 03:49:21PM +0900, Paul Elder via libcamera-devel wrote:\n> > > For the purpose of testing serializing/deserializing enums in function\n> > > parameters, add IPAOperationCode to the parameter list of init().\n> > > \n> > > Signed-off-by: Paul Elder \n> > > \n> > > ---\n> > > No changes in v2\n> > > ---\n> > > include/libcamera/ipa/vimc.mojom | 2 +-\n> > > src/ipa/vimc/vimc.cpp | 6 ++++--\n> > > src/libcamera/pipeline/vimc/vimc.cpp | 2 +-\n> > > test/ipa/ipa_interface_test.cpp | 2 +-\n> > > 4 files changed, 7 insertions(+), 5 deletions(-)\n> > > \n> > > diff --git a/include/libcamera/ipa/vimc.mojom b/include/libcamera/ipa/vimc.mojom\n> > > index 718b9674..16149787 100644\n> > > --- a/include/libcamera/ipa/vimc.mojom\n> > > +++ b/include/libcamera/ipa/vimc.mojom\n> > > @@ -18,7 +18,7 @@ enum IPAOperationCode {\n> > > };\n> > > \n> > > interface IPAVimcInterface {\n> > > -\tinit(libcamera.IPASettings settings) => (int32 ret);\n> > > +\tinit(libcamera.IPASettings settings, IPAOperationCode code) => (int32 ret);\n> > > \n> > > \tconfigure(libcamera.IPACameraSensorInfo sensorInfo,\n> > > \t\t map streamConfig,\n> > > diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> > > index 85afb279..6bf39a1c 100644\n> > > --- a/src/ipa/vimc/vimc.cpp\n> > > +++ b/src/ipa/vimc/vimc.cpp\n> > > @@ -31,7 +31,7 @@ public:\n> > > \tIPAVimc();\n> > > \t~IPAVimc();\n> > > \n> > > -\tint init(const IPASettings &settings) override;\n> > > +\tint init(const IPASettings &settings, const ipa::vimc::IPAOperationCode &code) override;\n> > \n> > Should we do for enums the same thing we do for integers, and pass by\n> > value instead of const reference ?\n> \n> Hm, tbh I think we should. I guess I have to fix that too then :/\n> \n> > Reviewed-by: Laurent Pinchart \n> \n> That means that... this is approved for merging...? I wasn't sure how we\n> felt about modifying the vimc IPA interface in such dummy-test ways\n\nI'm fine with that, the vimc API is meant for this purpose. I expect\nwe'll refactor it later to make it look less \"dummy\", but we'll keep an\nanum and a Flags somewhere in any case for the purpose of testing. For\nnow, this is fine.\n\n> > > \tint start() override;\n> > > \tvoid stop() override;\n> > > @@ -66,7 +66,7 @@ IPAVimc::~IPAVimc()\n> > > \t\t::close(fd_);\n> > > }\n> > > \n> > > -int IPAVimc::init(const IPASettings &settings)\n> > > +int IPAVimc::init(const IPASettings &settings, const ipa::vimc::IPAOperationCode &code)\n> > > {\n> > > \ttrace(ipa::vimc::IPAOperationInit);\n> > > \n> > > @@ -74,6 +74,8 @@ int IPAVimc::init(const IPASettings &settings)\n> > > \t\t<< \"initializing vimc IPA with configuration file \"\n> > > \t\t<< settings.configurationFile;\n> > > \n> > > +\tLOG(IPAVimc, Debug) << \"Got opcode \" << code;\n> > > +\n> > > \tFile conf(settings.configurationFile);\n> > > \tif (!conf.open(File::OpenModeFlag::ReadOnly)) {\n> > > \t\tLOG(IPAVimc, Error) << \"Failed to open configuration file\";\n> > > diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> > > index 153cf849..983bd514 100644\n> > > --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> > > +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> > > @@ -471,7 +471,7 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n> > > \tdata->ipa_->paramsBufferReady.connect(data.get(), &VimcCameraData::paramsBufferReady);\n> > > \n> > > \tstd::string conf = data->ipa_->configurationFile(\"vimc.conf\");\n> > > -\tdata->ipa_->init(IPASettings{ conf, data->sensor_->model() });\n> > > +\tdata->ipa_->init(IPASettings{ conf, data->sensor_->model() }, ipa::vimc::IPAOperationInit);\n> > > \n> > > \t/* Create and register the camera. */\n> > > \tstd::set streams{ &data->stream_ };\n> > > diff --git a/test/ipa/ipa_interface_test.cpp b/test/ipa/ipa_interface_test.cpp\n> > > index 3c0df843..b9fa15cd 100644\n> > > --- a/test/ipa/ipa_interface_test.cpp\n> > > +++ b/test/ipa/ipa_interface_test.cpp\n> > > @@ -106,7 +106,7 @@ protected:\n> > > \n> > > \t\t/* Test initialization of IPA module. */\n> > > \t\tstd::string conf = ipa_->configurationFile(\"vimc.conf\");\n> > > -\t\tint ret = ipa_->init(IPASettings{ conf, \"vimc\" });\n> > > +\t\tint ret = ipa_->init(IPASettings{ conf, \"vimc\" }, ipa::vimc::IPAOperationInit);\n> > > \t\tif (ret < 0) {\n> > > \t\t\tcerr << \"IPA interface init() failed\" << endl;\n> > > \t\t\treturn TestFail;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12A78BE173\n\tfor ;\n\tFri, 19 Aug 2022 08:14:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 613E161FC0;\n\tFri, 19 Aug 2022 10:13:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A93461FA3\n\tfor ;\n\tFri, 19 Aug 2022 10:13:57 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0C7559D;\n\tFri, 19 Aug 2022 10:13:56 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660896839;\n\tbh=wxXILJQSPooMY8qH2nugYdAdwcFoMeUye/0VF5+0mqE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=EN5aCx4b2GEYuY3gfTnhWpMQthzzCwCcqsUOkjmPrWVLSHhf0YutPrqpmdhIFzzYo\n\txlplMtHFzDL8E7CU2yicDF8CX/GTQZBaadIBzIex7LskhkIapdN1dR4yazFeEp6FP5\n\tjUrgqerIWibNa5Jo2ThFJXmmA0wKsKw4cy5YsqBOLji7dJ3/8BhWtNrII7Qupl8LcK\n\toAXeg/C3UEdcgrPlpy8g6DBESpkFTWqdn2qnGZWo8y+Erw5fXBOFw2bN4DGHIKlNzB\n\tVFBvfqDQuMdcgztsxgFqbSxGEJ6FP8J1qUAkfdnJUciTVkuukyX5loEH7gCQFsKdHU\n\tadtsnRL/LWwsQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660896837;\n\tbh=wxXILJQSPooMY8qH2nugYdAdwcFoMeUye/0VF5+0mqE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=K7sXdZds1n8+vT/kNiBGw4Gu8HVdGSo+5MaJCKCUTSG8A5woKWbX0oBmeys8B13Rl\n\tVg3sCpT4J34i7i4rlL3ylzEHH1FC8UvC0JxOJXhjmXzffbXol56ZlzjSkthkdEXwAw\n\tQtTluyZCr3+s/8AMPs+kYEfxKoGRWQpkYKYiV1D4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"K7sXdZds\"; dkim-atps=neutral","Date":"Fri, 19 Aug 2022 11:13:52 +0300","To":"paul.elder@ideasonboard.com","Message-ID":"","References":"<20220818064923.2573060-1-paul.elder@ideasonboard.com>\n\t<20220818064923.2573060-7-paul.elder@ideasonboard.com>\n\t\n\t<20220819074456.GC34241@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220819074456.GC34241@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH v2 6/7] [TEST] ipa: vimc: Add\n\tIPAOperationCode to init() parameter list","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]