[{"id":24615,"web_url":"https://patchwork.libcamera.org/comment/24615/","msgid":"","date":"2022-08-16T19:27:12","subject":"Re: [libcamera-devel] [PATCH v2 3/3] libcamera: pipeline: remove\n\tunused assignment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Christian,\n\nThank you for the patch.\n\nOn Tue, Aug 16, 2022 at 08:38:26PM +0200, Christian Rauch via libcamera-devel wrote:\n> The variable 'ret' is assigned but not read until after the next assignment.\n> \n> Signed-off-by: Christian Rauch \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 93287332..03bbe6b4 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -688,7 +688,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \t\t/* \\todo Turn this into a hard failure. */\n> \t\tLOG(RkISP1, Warning) << \"Camera sensor information not available\";\n> \t\tsensorInfo = {};\n> -\t\tret = 0;\n> \t}\n> \n> \tstd::map entityControls;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA3E0BE173\n\tfor ;\n\tTue, 16 Aug 2022 19:27:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E83461FC0;\n\tTue, 16 Aug 2022 21:27:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60B2C61FA9\n\tfor ;\n\tTue, 16 Aug 2022 21:27:27 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E958825B;\n\tTue, 16 Aug 2022 21:27:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660678048;\n\tbh=36aIbCb0z6vtmlKc56Zd+5+wJPbQtW7CroNySNeI+lM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=u1zDBmqJKrhxPVgpdnJZGmcg0eQa9ohAroS/n62CKgriU8/3XONEudcAYDIoIWcXX\n\t2GqZnUSfIbn6bi7nv0vbzH3S9v7Rt6DGsSCaX8iN+Lnp/FMhOYAzlChDbwbrbzLWa3\n\toq5oYhcrVGs1NtY63UB8l6amv5n4zvtZbNIpubYw2rvimmDLHogd87pNdyjxYa8F21\n\tLlM6elDOp6JIBDZcbwenS944wKW4TyrUp9CVyzgrS4fBcw5Utahv3UGGKpR3oZ5iV9\n\tk6Wz1FfjhjtDRjtEvoSNCTmIufl4PoXFo01B4yDFfzdyHsP+HtAP1rxqHQ9PhxJJSc\n\ttc1hkkHdTCPmg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660678047;\n\tbh=36aIbCb0z6vtmlKc56Zd+5+wJPbQtW7CroNySNeI+lM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tCKIv/MjuLXjkOoPcLzFA0fG1miuNsacyx0Q3sBQ8lyzkfWhPNhfapNIBGYz8URfW\n\tYGer7phvGJpSVXM6tRH6c0nLMP4PPtmTHM2nyiB4XqYnHZCw5oJu/H6U+2u2EXbAKp\n\tqh31EGA3TRvaO19AQ+Ocn123BLZvQ2rzTSkdDGOY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tCKIv/Mj\"; dkim-atps=neutral","Date":"Tue, 16 Aug 2022 22:27:12 +0300","To":"Christian Rauch ","Message-ID":"","References":"<20220816183826.102989-1-Rauch.Christian@gmx.de>\n\t<20220816183826.102989-3-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220816183826.102989-3-Rauch.Christian@gmx.de>","Subject":"Re: [libcamera-devel] [PATCH v2 3/3] libcamera: pipeline: remove\n\tunused assignment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]