[{"id":2297,"web_url":"https://patchwork.libcamera.org/comment/2297/","msgid":"<4c11d515-ee94-5cea-b389-837d01a84bba@ideasonboard.com>","date":"2019-07-19T11:43:46","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix\n\targument name mismatch","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 17/07/2019 08:11, Laurent Pinchart wrote:\n> Fix an argument name mismatch between method declaration and\n> definition.\n> \n> Reported-by: Paul Elder \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index c27fe75577f5..827906d5cd2e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -122,7 +122,7 @@ public:\n> \tBufferPool *exportBuffers();\n> \tvoid freeBuffers();\n> \n> -\tint start(std::vector> *buffer);\n> +\tint start(std::vector> *buffers);\n> \tint stop();\n> \n> \tstatic int mediaBusToFormat(unsigned int code);\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2940260E3B\n\tfor ;\n\tFri, 19 Jul 2019 13:43:49 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8CB2C55F;\n\tFri, 19 Jul 2019 13:43:48 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1563536628;\n\tbh=A/Er83bvE4y2i4Lg8/ycilKEc+zalllpGJrcLP+8OJk=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=oeXzHWSsMFaznO9beY5Me+v9Lf94Quo+ScK/3qPyUEHBr6WUWn9Bh7wV8BjFQ42oH\n\tq3nQAH7DMFvVwfgb/T07UshcMs4eLuQevLWiXHtX3NTJP3/D2ghCEh37JxeQfAhZrS\n\tSP2JhemWNHHr8wdGDNdZk4Db60lxyQx/bI121vj0=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190717071128.6192-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<4c11d515-ee94-5cea-b389-837d01a84bba@ideasonboard.com>","Date":"Fri, 19 Jul 2019 12:43:46 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.2","MIME-Version":"1.0","In-Reply-To":"<20190717071128.6192-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix\n\targument name mismatch","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 19 Jul 2019 11:43:49 -0000"}},{"id":2300,"web_url":"https://patchwork.libcamera.org/comment/2300/","msgid":"<20190720130801.GD1679@wyvern>","date":"2019-07-20T13:08:01","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix\n\targument name mismatch","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-07-17 10:11:28 +0300, Laurent Pinchart wrote:\n> Fix an argument name mismatch between method declaration and\n> definition.\n> \n> Reported-by: Paul Elder \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index c27fe75577f5..827906d5cd2e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -122,7 +122,7 @@ public:\n> \tBufferPool *exportBuffers();\n> \tvoid freeBuffers();\n> \n> -\tint start(std::vector> *buffer);\n> +\tint start(std::vector> *buffers);\n> \tint stop();\n> \n> \tstatic int mediaBusToFormat(unsigned int code);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-pf1-x442.google.com (mail-pf1-x442.google.com\n\t[IPv6:2607:f8b0:4864:20::442])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 42ED560C00\n\tfor ;\n\tSat, 20 Jul 2019 15:08:10 +0200 (CEST)","by mail-pf1-x442.google.com with SMTP id b13so15354073pfo.1\n\tfor ;\n\tSat, 20 Jul 2019 06:08:10 -0700 (PDT)","from localhost (M106185144154.v4.enabler.ne.jp. [106.185.144.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tk25sm25949485pgt.53.2019.07.20.06.08.03\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tSat, 20 Jul 2019 06:08:04 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=vbp14iDvsF5EhwEuOhweHpWaJFrTqXCGWL5SkfurZSc=;\n\tb=C03pU8xlX6TDQgDCZfQQ0OXdDMaboqrIEBgKzWMZlsdaBBmzwP0EmNeXCeI1UbLGOP\n\tQrVCI28kwwu5p06Yr4N3Zf/vjo0ODHiity3HLd2alnBdfAhJlhVFbgfg2gTHtyaE9zMy\n\t7FmmieN886ylquzeEl5cX0bI3yIJ7Ia2Sm/7wOGAEqhBKs5Q01DzPiuddB9rJ9w7hR9g\n\tvbv3sHFJJ8pDgGS5wszPznacCWe+jwsi0mwF+ylndRrHY0Ds1a7c59YyA0XMH8C1qxl/\n\ttWKBJPSeUQd3CIMXDAI7DHUBaNAczsAlfydzwTgJydkR+6AIwdVTrg0NAEaZKr5KM3Xp\n\t2KNw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=vbp14iDvsF5EhwEuOhweHpWaJFrTqXCGWL5SkfurZSc=;\n\tb=NpuiRUVVvLsO6innsKct3FSKkA0ig9jbwmkW54lmQZ1GY57qcPkxNfgVEQPofYgvkH\n\tVNtny8CPSAhBDSEgO9WHnc0bFVwgK8BWxB5keADToz23y6h111Htw313fPlMfj480xuz\n\tOhFGzdqJJJtUj68UrEYWP3ey1C26Bjd5p6ySeeMVwsqYQoWeEes92WKiFf8lRm+8ISkt\n\toYgzuh2YMaUzZlO4KPjPKqfW5dt87w8sM21hmiY/kL476xLAERnd1v3mu8cbhIeUDX/k\n\tchJ+Ayclx0CN0wg900B38s7cbVQwTR/AoHDVFC2cnm4r88uGxA4QwF1w0LOXB/PLdOcc\n\t4Ggw==","X-Gm-Message-State":"APjAAAXMg9eunjnXmJd8rJzu/p5xa7jXE2mTauhZlNSipc0r7LekYcNy\n\t1nQZ5OxdlXiEuW/cpGJj3Is=","X-Google-Smtp-Source":"APXvYqw67ud4s27yjJ3mzV80+g617zrLnmKiqpvIj9rY4/0cYrO8jZ8fdvz6gmEQ57ci/hK37pKW0g==","X-Received":"by 2002:a17:90a:ca0f:: with SMTP id\n\tx15mr19231192pjt.82.1563628084810; \n\tSat, 20 Jul 2019 06:08:04 -0700 (PDT)","Date":"Sat, 20 Jul 2019 22:08:01 +0900","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190720130801.GD1679@wyvern>","References":"<20190717071128.6192-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190717071128.6192-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Fix\n\targument name mismatch","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 20 Jul 2019 13:08:10 -0000"}}]