[{"id":24613,"web_url":"https://patchwork.libcamera.org/comment/24613/","msgid":"","date":"2022-08-16T19:25:08","subject":"Re: [libcamera-devel] [PATCH v2 1/3] libcamera: remove unused\n\theaders","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Christian,\n\nThank you for the patch.\n\nOn Tue, Aug 16, 2022 at 08:38:24PM +0200, Christian Rauch via libcamera-devel wrote:\n> These headers are not used as reported by clangd.\n> \n> Signed-off-by: Christian Rauch \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 1 -\n> test/serialization/ipa_data_serializer_test.cpp | 4 ----\n> 2 files changed, 5 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 69c73f8c..8d731435 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -49,7 +49,6 @@\n> #include \"geq_status.h\"\n> #include \"lux_status.h\"\n> #include \"metadata.h\"\n> -#include \"noise_status.h\"\n> #include \"sharpen_algorithm.h\"\n> #include \"sharpen_status.h\"\n> \n> diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp\n> index d2050a86..377ecdb0 100644\n> --- a/test/serialization/ipa_data_serializer_test.cpp\n> +++ b/test/serialization/ipa_data_serializer_test.cpp\n> @@ -20,11 +20,7 @@\n> #include \n> #include \n> \n> -#include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/ipa_data_serializer.h\"\n> -#include \"libcamera/internal/ipa_manager.h\"\n> -#include \"libcamera/internal/ipa_module.h\"\n> -#include \"libcamera/internal/pipeline_handler.h\"\n> \n> #include \"serialization_test.h\"\n> #include \"test.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4156C3272\n\tfor ;\n\tTue, 16 Aug 2022 19:25:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0479761FBC;\n\tTue, 16 Aug 2022 21:25:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AA9A61FA9\n\tfor ;\n\tTue, 16 Aug 2022 21:25:23 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 999B625B;\n\tTue, 16 Aug 2022 21:25:22 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660677925;\n\tbh=OSAaKEwE1AxGU5sXezmIF8Fg/nVf3+msegsOZ4Y9osU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=nlbvdQ17ysQejULtqux06xsbo1L+zAw0Mb9u7lYrFxm16gCprKosvOu+hOE64I75a\n\tawu37IgjFq1dz6BZGDABFEtPwY8XCjKnKDZXoKD75gxgWRQ2ZB1vnMb4n2IlLf+Eny\n\tcfJTV9YRuLq+kHD1Ym4qB56dx88Z76kbNWKHm0Kza94SRxioExchGYUDR1bmSxSlvT\n\t58YgykqAP2jYLYPdBQs25S4ubRTIfazHIw64488t/DMbcJlpX+RXLtl+cDn8V9btyt\n\t4KS4nw0VnUdHTOBpAWtT4CrzkYdoB1F4Lfo1kP9fnkmKcZ2DLJsW83Cgzy1yzJmYCX\n\t3MQoIs0qW7VUQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660677922;\n\tbh=OSAaKEwE1AxGU5sXezmIF8Fg/nVf3+msegsOZ4Y9osU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Oi7rma5UFsL3VfI9HDSI6H5w0K6CjLWEUDE6peOgRUA98ONVjUux+J4U41AfSTjmY\n\tOW1qt9KuPYBhGyqKmsBebwSCeysUlM1opwEG1aPjkpmYrpNq9+JaL26SuMVNoxZDlW\n\tjHu33594+CyU1760ckXGYxnjTvLxVIF517I1Yevs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Oi7rma5U\"; dkim-atps=neutral","Date":"Tue, 16 Aug 2022 22:25:08 +0300","To":"Christian Rauch ","Message-ID":"","References":"<20220816183826.102989-1-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220816183826.102989-1-Rauch.Christian@gmx.de>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] libcamera: remove unused\n\theaders","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]